Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display add button in header for TWL when no items #597

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

kintsoogi
Copy link
Contributor

@kintsoogi kintsoogi commented Nov 27, 2023

Describe what your pull request addresses

Test Instructions

  • Either navigate to a reference where there are no TWL items or delete all current TWL items (make sure you are on QA)
    • Verify that add button shows in header when there are no TWL items
    • Add tsv item to TWL and verify that TWL shows
  • Do the same for either TN or TQ. Verify that delete button in header does not show when there are no items

- Display add button in header for TWL when no items
- Do not display delete button if no items in tsv resource card
@kintsoogi kintsoogi self-assigned this Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f39feac) 50.59% compared to head (acd6bcf) 51.72%.

Files Patch % Lines
src/components/ResourceCard.js 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #597      +/-   ##
===========================================
+ Coverage    50.59%   51.72%   +1.12%     
===========================================
  Files           43       43              
  Lines         1338     1336       -2     
===========================================
+ Hits           677      691      +14     
+ Misses         661      645      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kintsoogi kintsoogi merged commit 868a6c3 into develop Nov 27, 2023
10 checks passed
@kintsoogi kintsoogi deleted the kintsoogi-585-twlNoAddButton branch November 27, 2023 20:48
PhotoNomad0 added a commit that referenced this pull request Dec 6, 2023
* Replace hard coded card names in merge dialog to resource titles

* Replace BranchMergerContext with state in app context

* Update single-scripture-rcl version for #546 (#558)

* Update issue templates

* Add button to TSV Resource Cards to Add another TSV resource

* Moved add button in TWL to actions column in table

* Feature 559 / support front matter (#561)

* added front to demo

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* add error message handling

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

* update dependencies

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Save to DCS on TSV Add & Navigate to new TSV Row (#571)

* Changes to save new TSV row to DCS on add

* Changes to navigate to newly created tsv row

* Only generate Tsv data if resource is tsv

* Change const, clarify ternary, update scrip-tsv version

* feature 524 / added alignment reset and multi-select. (#576)

* added alignment reset and multi-select.

* update dependencies

* update dependencies

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Update version of scripture-tsv to 0.2.1 (#584)

* Fix for 500 errors (#583)

Updated versions of gitea-react-toolkit and single-scripture-rcl

Co-authored-by: PhotoNomad0 <[email protected]>

* Feature kintsoogi 484 delete tsv (#587)

* Add delete tsv functionality and pure setItemIndex

* Small fix for newQuote

* update dependencies

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* upgrades translation-helps-rcl to 3.5.13

* Display add button in header for TWL when no items (#597)

- Display add button in header for TWL when no items
- Do not display delete button if no items in tsv resource card

* Updated version of scripture-resources-rcl

Fixes problem where empty last tsv item in book throws errors

* fixes build error while building with node >= 18

__This is a temporary fix__

Any machine building with node >= 18 runs into this issue:
unfoldingWord/translation-helps-rcl#121

I've modified the build scripts to use the set-env.sh scripts
to determine what the NODE_OPTIONS should be when building.

* Bump version to 2.2.0

* qaFail 602 / Save button is enabled when edit box is clicked (#608)

update single-scripture-rcl

* Bugfix 570 / Fix highlighting errors with right quote in Greek Word (#604)

fixes for highlighting right quotes in original languages

---------

Co-authored-by: kintsoogi <[email protected]>
Co-authored-by: Kintsoogi <[email protected]>
Co-authored-by: elsylambert <[email protected]>
Co-authored-by: PhotoNomad0 <[email protected]>
Co-authored-by: Noah Harvey <[email protected]>
Co-authored-by: Noah Harvey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants