Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge/v0.23.5 to main #4078

Merged
merged 27 commits into from
Feb 15, 2024
Merged

Merge/v0.23.5 to main #4078

merged 27 commits into from
Feb 15, 2024

Conversation

findtopher
Copy link
Member

What changes are proposed in this pull request?

Merge release branch to main

nebulae and others added 16 commits January 26, 2024 14:42
* sidebar fix

* filling out test

* fix index

* add edge case

* rm log
* modal pcd slices fixes

* e2e test

* stray comment
* fix string casting bug

* fix dynamic groups options rendering bug

* fix stray aggregations firing bug

* fix imavid store key bug

* initialize dynamic group view mode to default after switching back to unordered mode

* fix modal sidebar pom

* upgrade deps

* fix sidebar

* rm broken assertion

---------

Co-authored-by: Benjamin Kane <[email protected]>
* include coinciding filters in sidebar search

* string search updates
Add target view utilities to operators
@findtopher findtopher changed the base branch from develop to main February 12, 2024 18:21
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 156 lines in your changes are missing coverage. Please review.

Comparison is base (328eb76) 15.98% compared to head (9e2bb15) 15.99%.

Files Patch % Lines
.../core/src/components/Filters/StringFilter/state.ts 0.00% 45 Missing ⚠️
...src/components/Filters/StringFilter/useOnSelect.ts 0.00% 20 Missing ⚠️
.../src/components/Modal/Group/DynamicGroup/index.tsx 0.00% 14 Missing ⚠️
app/packages/state/src/hooks/useCreateLooker.ts 0.00% 14 Missing ⚠️
app/packages/state/src/recoil/view.ts 0.00% 11 Missing ⚠️
app/packages/state/src/recoil/sidebar.ts 78.72% 10 Missing ⚠️
app/packages/state/src/recoil/aggregations.ts 0.00% 8 Missing ⚠️
...src/components/Filters/StringFilter/Checkboxes.tsx 0.00% 6 Missing ⚠️
...ackages/looker-3d/src/action-bar/SliceSelector.tsx 0.00% 5 Missing ⚠️
...p/packages/core/src/components/Actions/Options.tsx 0.00% 4 Missing ⚠️
... and 10 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4078   +/-   ##
=======================================
  Coverage   15.98%   15.99%           
=======================================
  Files         732      732           
  Lines       81966    82062   +96     
  Branches     1101     1110    +9     
=======================================
+ Hits        13100    13123   +23     
- Misses      68866    68939   +73     
Flag Coverage Δ
app 15.99% <19.17%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@findtopher findtopher requested a review from a team February 12, 2024 18:48
@findtopher findtopher merged commit 28f268d into main Feb 15, 2024
14 of 15 checks passed
@findtopher findtopher deleted the merge/v0.23.5-to-main branch February 15, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants