chore: Update notifications engine to 7a06976 #3384

kzap · 2024-02-20T06:46:46Z

What

Updates in this latest version argoproj/notifications-engine@7a06976 of notifications-engine:

feat: Update aws-sdk-go-v2 for EKS Pod Identities notifications-engine#259
SQS:
- feat(awssqs): Support sending messages to SQS FIFO queues notifications-engine#261
GitHub:
- feat(github): Support GitHub transient environment deployment type notifications-engine#260
- github: reuse existing deployment when sending new notification notifications-engine#235
Slack:
- Add slack param to disable link unfurling notifications-engine#242
Opsgenie:
- feat(opsgenie): Add support for setting priority in Opsgenie notification notifications-engine#267
- feat(opsgenie): Add support for setting alias in Opsgenie notification notifications-engine#268
Telegram:
- Add option for Telegram to use a thread id when posting notification notifications-engine#265

Updating notifications documentation generator to replace some argocd- prefixed strings.
Adding documentation for contributors on how to update notifications-engine like in this PR.

Checklist

Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
I've signed my commits with DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My builds are green. Try syncing with master if they are not.
My organization is added to USERS.md.

…074eeed6145085160e2fec63 Updating and fetch latest notifications-engine dependencies Signed-off-by: Andre Marcelo-Tanner <[email protected]>

…4.1-0.20240219110818-7a069766e954 Signed-off-by: Andre Marcelo-Tanner <[email protected]>

- Update go.mod: github.com/go-telegram-bot-api/telegram-bot-api/v5 => github.com/OvyFlash/telegram-bot-api/v5 v5.0.0-20240108230938-63e5c59035bf - Ref: argoproj/notifications-engine#265 - Could also be done via go replace --edit - go mod tidy also ran Signed-off-by: Andre Marcelo-Tanner <[email protected]>

Signed-off-by: Andre Marcelo-Tanner <[email protected]>

…nd also replace secret with argocd-notifications-secret Signed-off-by: Andre Marcelo-Tanner <[email protected]>

codecov · 2024-02-20T06:55:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8405f2e) 81.83% compared to head (abc378b) 83.00%.
Report is 19 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3384      +/-   ##
==========================================
+ Coverage   81.83%   83.00%   +1.16%     
==========================================
  Files         135      135              
  Lines       20688    16873    -3815     
==========================================
- Hits        16931    14005    -2926     
+ Misses       2883     1996     -887     
+ Partials      874      872       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-02-20T06:55:19Z

Go Published Test Results

2 130 tests 2 130 ✅ 2m 50s ⏱️
118 suites 0 💤
1 files 0 ❌

Results for commit abc378b.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-20T07:19:05Z

E2E Tests Published Test Results

4 files 4 suites 3h 40m 53s ⏱️
107 tests 97 ✅ 6 💤 4 ❌
440 runs 404 ✅ 24 💤 12 ❌

For more details on these failures, see this check.

Results for commit abc378b.

♻️ This comment has been updated with latest results.

kzap · 2024-02-21T02:22:34Z

go.mod

@@ -202,6 +202,7 @@ require (

 replace (
 	github.com/go-check/check => github.com/go-check/check v0.0.0-20180628173108-788fd7840127
+	github.com/go-telegram-bot-api/telegram-bot-api/v5 => github.com/OvyFlash/telegram-bot-api/v5 v5.0.0-20240108230938-63e5c59035bf


replaced in the notifications engine in this PR: argoproj/notifications-engine#265

kzap · 2024-02-21T02:23:00Z

go.mod

@@ -4,7 +4,7 @@ go 1.20

 require (
 	github.com/antonmedv/expr v1.15.5
-	github.com/argoproj/notifications-engine v0.4.1-0.20231213155711-c02dc5fdb5e1
+	github.com/argoproj/notifications-engine v0.4.1-0.20240219110818-7a069766e954


Updating to argoproj/notifications-engine@7a06976

kzap · 2024-02-21T02:23:22Z

hack/gen-docs/main.go

+		if e := strReplaceDocFiles("argocd-notifications-cm", "argo-rollouts-notification-configmap", files); e != nil {
+			log.Fatal(e)
+		}
+		if e := strReplaceDocFiles("argocd-notifications-secret", "argo-rollouts-notification-secret", files); e != nil {
+			log.Fatal(e)
+		}


lets replace these strings with the argo-rollouts- equivalent.

They recently got renamed to a argocd- prefixed string in docs: use real cm name instead of placeholder notifications-engine#264

Signed-off-by: Andre Marcelo-Tanner <[email protected]>

sonarcloud · 2024-02-21T04:35:45Z

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

kzap · 2024-02-22T00:12:04Z

docs/generated/notification-services/alertmanager.md

-  name: <config-map-name>
+  name: argo-rollouts-notification-configmap


generated by running make docs

These were recently renamed upstream to a argocd specific name :/

docs: use real cm name instead of placeholder notifications-engine#264

zachaller

Thanks for the contribution!

kzap and others added 6 commits February 20, 2024 01:20

Run: go get github.com/argoproj/notifications-engine@7a069766e95476e1…

6e0eb10

…074eeed6145085160e2fec63 Updating and fetch latest notifications-engine dependencies Signed-off-by: Andre Marcelo-Tanner <[email protected]>

Run: go get github.com/argoproj/notifications-engine/pkg/services@v0.…

82fffbe

…4.1-0.20240219110818-7a069766e954 Signed-off-by: Andre Marcelo-Tanner <[email protected]>

Add strReplaceDocFiles to update strings from default docs

a18325b

Signed-off-by: Andre Marcelo-Tanner <[email protected]>

Run: make docs

d00bbd1

Signed-off-by: Andre Marcelo-Tanner <[email protected]>

replace <config-map-name> with argo-rollouts-notification-configmap a…

2aed45e

…nd also replace secret with argocd-notifications-secret Signed-off-by: Andre Marcelo-Tanner <[email protected]>

kzap commented Feb 21, 2024

View reviewed changes

kzap added 2 commits February 20, 2024 23:23

add Ada company to USERS.md

f2e8477

Signed-off-by: Andre Marcelo-Tanner <[email protected]>

chore: update contributing docs with notifications engine section

abc378b

Signed-off-by: Andre Marcelo-Tanner <[email protected]>

kzap marked this pull request as ready for review February 21, 2024 04:35

kzap changed the title ~~chore: Update notifications engine 7a06976~~ chore: Update notifications engine to 7a06976 Feb 21, 2024

This was referenced Feb 21, 2024

Argo rollouts notifications does not work with telegram #3057

Open

Update Notification services docs #1680

Open

kostis-codefresh requested a review from zachaller February 21, 2024 09:05

kzap commented Feb 22, 2024

View reviewed changes

zachaller added this to the v1.7 milestone Feb 27, 2024

zachaller approved these changes Feb 27, 2024

View reviewed changes

zachaller merged commit d06cc34 into argoproj:master Feb 27, 2024
31 checks passed

gazidizdaroglu mentioned this pull request Apr 26, 2024

chore: update notifications-engine to f4856710 argoproj/argo-cd#17971

Merged

14 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Update notifications engine to 7a06976 #3384

chore: Update notifications engine to 7a06976 #3384

kzap commented Feb 20, 2024 •

edited

Loading

codecov bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited

Loading

kzap Feb 21, 2024

kzap Feb 21, 2024

kzap Feb 21, 2024 •

edited

Loading

sonarcloud bot commented Feb 21, 2024

kzap Feb 22, 2024 •

edited

Loading

zachaller left a comment

		name: <config-map-name>
		name: argo-rollouts-notification-configmap

chore: Update notifications engine to 7a06976 #3384

chore: Update notifications engine to 7a06976 #3384

Conversation

kzap commented Feb 20, 2024 • edited Loading

What

Checklist

codecov bot commented Feb 20, 2024 • edited Loading

Codecov Report

github-actions bot commented Feb 20, 2024 • edited Loading

Go Published Test Results

github-actions bot commented Feb 20, 2024 • edited Loading

E2E Tests Published Test Results

kzap Feb 21, 2024

Choose a reason for hiding this comment

kzap Feb 21, 2024

Choose a reason for hiding this comment

kzap Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

sonarcloud bot commented Feb 21, 2024

Quality Gate passed

kzap Feb 22, 2024 • edited Loading

Choose a reason for hiding this comment

zachaller left a comment

Choose a reason for hiding this comment

kzap commented Feb 20, 2024 •

edited

Loading

codecov bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited

Loading

github-actions bot commented Feb 20, 2024 •

edited

Loading

kzap Feb 21, 2024 •

edited

Loading

kzap Feb 22, 2024 •

edited

Loading