fix(behavior_velocity_planner): sort unique_lane_ids for merge_from_private_area

[tkimura4]

Signed-off-by: tomoya.kimura [email protected]

Description

Sort unique_lane_ids in getLaneletsOnPath for merge_from_private_area bacause this module is assumed that
unique_lane_ids are in order
https://github.com/autowarefoundation/autoware.universe/blob/main/planning/behavior_velocity_planner/src/scene_module/intersection/manager.cpp#L118-L124

( Before the change, the stop point of merge_from_private_area was wrong. )

Before the change

After the change

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[kosuke55]

LGTM

[codecov]

Codecov Report

Merging #1323 (cdcbea6) into main (db01212) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main   #1323      +/-   ##
========================================
- Coverage   9.51%   9.46%   -0.06%     
========================================
  Files       1096    1096              
  Lines      76148   76557     +409     
  Branches   16991   17297     +306     
========================================
  Hits        7244    7244              
- Misses     62292   62653     +361     
- Partials    6612    6660      +48     

Flag	Coverage Δ		*Carryforward flag
differential	4.94% <0.00%> (?)
total	9.49% <0.00%> (ø)		Carriedforward from 628606c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...vior_velocity_planner/include/utilization/util.hpp	3.57% <0.00%> (-0.28%)	⬇️
...ity_planner/src/scene_module/crosswalk/manager.cpp	0.00% <0.00%> (ø)
...behavior_velocity_planner/src/utilization/util.cpp	21.90% <0.00%> (-2.41%)	⬇️
...elocity_planner/src/scene_module/run_out/debug.cpp	0.00% <0.00%> (ø)
...ocity_planner/src/scene_module/crosswalk/debug.cpp	0.00% <0.00%> (ø)
...ocity_planner/src/scene_module/stop_line/debug.cpp	0.00% <0.00%> (ø)
...city_planner/src/scene_module/blind_spot/debug.cpp	0.00% <0.00%> (ø)
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db01212...cdcbea6. Read the comment docs.

[kosuke55]

Could you please modify the following as well?
https://github.com/autowarefoundation/autoware.universe/blob/main/planning/behavior_velocity_planner/include/utilization/util.hpp#L305-L337
https://github.com/autowarefoundation/autoware.universe/blob/main/planning/behavior_velocity_planner/src/scene_module/crosswalk/manager.cpp#L30-L56

[tkimura4]

@kosuke55
I fixed.
4eddeac

[taikitanaka3]

LGTM