fix: remove warning for compile error

[wep21]

Signed-off-by: wep21 [email protected]

Related Issue(required)

Description(required)

Note: This compile error occurs only in my environment, so I create this PR as a draft.
There are 3 errors below.
/usr/include/pcl-1.10/pcl/octree/octree_key.h:155:9: error: ISO C++ prohibits anonymous structs [-Werror=pedantic]
/opt/ros/galactic/include/rcutils/logging_macros.h:72:18: error: ‘filter_limit_negative’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
/opt/ros/galactic/include/rcutils/logging_macros.h:72:18: error: ‘keep_organized’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Read commit-guidelines
• Assign PR to reviewer

If you are adding new package following items are required:

• Documentation with description of the package is available
• A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR / build-and-test-pr: Required to pass before the merge.
• Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
• Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

[kenji-miyake]

Why did you remove -Wpedantic?

[wep21]

/usr/include/pcl-1.10/pcl/octree/octree_key.h:155:9: error: ISO C++ prohibits anonymous structs [-Werror=pedantic]
This causes the error above. I don't have any idea why -Wno-gnu-anonymous-struct doesn't work...

[kenji-miyake]

I see. Hmm... 🤔

[kenji-miyake]

@wep21 Could you write the error log in the description? 🙏

[wep21]

@kenji-miyake I added the errors in the description. Please check it out.

[ajay1606]

@wep21 @kenji-miyake

Hello, While building the main branch from the Autoware architecture proposal, I also encountered the following errors that were mentioned here a few days ago. Anyhow after a few workarounds able to overcome those errors; Please check this out if it's helpful for you also. Now am able to run the Main branch successfully.

Ubuntu: 20.04
ROS2: galactic
Autoware Version: main branch ( https://github.com/tier4/AutowareArchitectureProposal.proj)

/usr/include/pcl-1.10/pcl/octree/octree_key.h:155:9: error: ISO C++ prohibits anonymous structs [-Werror=pedantic]
/opt/ros/galactic/include/rcutils/logging_macros.h:72:18: error: ‘filter_limit_negative’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
/opt/ros/galactic/include/rcutils/logging_macros.h:72:18: error: ‘keep_organized’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

1. Include "SYSTEM" in the include directory in CMakeLists as below; (/pointcloud_preprocessor/CMakeLists.txt)

include_directories(
  include
)
include_directories(SYSTEM
  ${Boost_INCLUDE_DIRS}
  ${PCL_INCLUDE_DIRS}
  ${EIGEN3_INCLUDE_DIRS}
  ${OpenCV_INCLUDE_DIRS}
  ${GRID_MAP_INCLUDE_DIR}
)

2. While building workspace add (-DCMAKE_CXX_FLAGS="-w")
   colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_FLAGS="-w"

Regards,
Ajay