Allocate starting resource IDs for Cameo #1

huningxin · 2013-04-26T07:38:45Z

Cameo uses Chromium resource framework (grit/grd). To make sure Cameo resource IDs are unique cross Chromium components, it is required to add new starting resource IDs.

Since Cameo is a project built on Chromium, allocate starting IDs from 31000.

Cameo uses Chromium resource framework (grit/grd). To make sure Cameo resource IDs are unique cross Chromium components, it is required to add new starting resource IDs. Since Cameo is a project built on Chromium, allocate starting IDs from 31000.

huningxin · 2013-04-26T07:39:54Z

@darktears , please review this pull request. It is for pull request for cameo launcher based on content API (crosswalk-project/crosswalk#2). Thanks in advance.

huningxin · 2013-04-26T08:52:44Z

Chromium reserves the resource ID from 31000 for project built on Chromium. If Chromium doesn't break this, Cameo resource ID will be kept unique then.

Allocate starting resource IDs for Cameo

Bug fixing for aura root window host

> RenderWidgetHostImpl's resize_ack_pending_ should set to true only when > RenderWidget::Resize(...) is expected to send ack. But resize_ack_pending_ > could be false positive or false negative. It caused crbug.com/246154 and > this CL fixes the both false cases by setting resize_ack_pending_ correctly. > > > Example false positive: > Let's say RenderWidget::Resize(...) is called twice by > RenderWidgetHostImpl::WasResized(), with the following arguments. > > crosswalk-project#1 new_size : 100x100 physical_backing_size : 0x0 > crosswalk-project#2 new_size : 100x100 physical_backing_size : 200x200 > > Then it doesn't send ack for the both cases because crosswalk-project#1 has an empty > physical_backing_size and crosswalk-project#2 doesn't change new_size from the previous call. > However, RenderWidgetHostImpl::WasResized() sets resize_ack_pending_ true crosswalk-project#2, > because current_size_ is updated only when we have ack back, so current_size_ > wasn't updated for crosswalk-project#1 and RenderWidget can think the current_size_ is about to > change to 100x100 at crosswalk-project#2. > > > Example false negative: > Again, consider this sequence of arguments: > > crosswalk-project#1 new_size : 100x100 > crosswalk-project#2 new_size : 0x0 > crosswalk-project#3 new_size : 100x100 > > RenderWidget sends acks at crosswalk-project#1 and crosswalk-project#3. Then RenderWidget's current_size_ is > not updated at crosswalk-project#2 so RenderWidget thinks current_size_ is not changed for > crosswalk-project#3, thus does not expect ack. > > BUG=246154 > > Review URL: https://chromiumcodereview.appspot.com/18413004 [email protected] Review URL: https://codereview.chromium.org/19241002 git-svn-id: svn://svn.chromium.org/chrome/branches/1547/src@211655 0039d316-1c4b-4281-b951-d872f2087c98

What triggered it is that in this test case the remote port of the shared worker gets created in the renderer process temporarily. This is because the MP only gets sent after initial execution of the worker's JS is done, but the message channel (which is composed of two message ports) is created before that during JS execution. So when the browser receives the postMessage IPC, it actually sends it back to the same renderer process because the worker's remote port is temporarily in the renderer. The message is then queued up. Later on, when the shared worker starts, the worker process takes ownership of its message port, which comes with the queued message that contains a MP. The newly created MP doesn't receive any messages because it's erroneously set in a queued state. That happened because of bug crosswalk-project#1: when the queued message above was sent from the renderer to the worker process, it went through MessagePortService::PostMessageTo. That was calling "sent_ports[i]->queue_messages = true;" to cover for bug crosswalk-project#2. But the browser shouldn't be setting this flag. It should only be set by the child process (per the first paragraph). Bug crosswalk-project#2 was that when the child process gave its queued messages to the browser, it did not tell the message ports that were contained in them that they should send their queued messages to the browser. This means that we would potentially silently drop some messages that are sent to a port. The solution is to fix bug crosswalk-project#2 and take out the other bug that was covering it. The test is from Marja's change in https://codereview.chromium.org/23710066/ BUG=293432 [email protected] Review URL: https://codereview.chromium.org/23583050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224135 0039d316-1c4b-4281-b951-d872f2087c98

…PNG with regexp filtering/highlighting. Joi: this commit consists of 2 logical parts. Part #1 is refactoring of checkdeps.py into a base class in builddeps.py and a subclass in the new trimmed down checkdeps.py. Part #2 is adding graphdeps.py, which derives from the same base class and does its own thing. There are also trivial accompanying changes to rules.py. This tool was very useful to me during a recent development for understanding inter-module dependencies and finding good places for new sources. BUG=292397 Review URL: https://codereview.chromium.org/24018004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226295 0039d316-1c4b-4281-b951-d872f2087c98

This fails on ASAN tests: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%282%29/builds/18341/steps/content_unittests/logs/stdio ==23976==ERROR: AddressSanitizer: heap-use-after-free on address 0x60b00002ae68 at pc 0x2281510 bp 0x7fff24edac90 sp 0x7fff24edac88 READ of size 8 at 0x60b00002ae68 thread T0 #0 0x228150f in content::WebRTCIdentityStoreBackend::FindIdentity(GURL const&, std::string const&, std::string const&, base::Callback<void (int, std::string const&, std::string const&)> const&) content/browser/media/webrtc_identity_store_backend.cc:225 #1 0x228340f in content::WebRTCIdentityStoreBackend::OnLoaded(scoped_ptr<std::map<content::WebRTCIdentityStoreBackend::IdentityKey, content::WebRTCIdentityStoreBackend::Identity, std::less<content::WebRTCIdentityStoreBackend::IdentityKey>, std::allocator<std::pair<content::WebRTCIdentityStoreBackend::IdentityKey const, content::WebRTCIdentityStoreBackend::Identity> > >, base::DefaultDeleter<std::map<content::WebRTCIdentityStoreBackend::IdentityKey, content::WebRTCIdentityStoreBackend::Identity, std::less<content::WebRTCIdentityStoreBackend::IdentityKey>, std::allocator<std::pair<content::WebRTCIdentityStoreBackend::IdentityKey const, content::WebRTCIdentityStoreBackend::Identity> > > > >) content/browser/media/webrtc_identity_store_backend.cc:353 #2 0x2289f53 in Run base/bind_internal.h:190 .... > Clears the expired identities from the WebRTC identity cache. > We now check the creation time of an identity before returning for WebRTCIdentityStoreBackend::FindIdentity and remove the expired identity from the in-memory cache. > The expired identities are also removed from the on-disk database before it's loaded to the in-memory cache. > The identities have 30-day expiration time by default for now. > > BUG=304398 > > Review URL: https://codereview.chromium.org/26082002 [email protected] Review URL: https://codereview.chromium.org/26567009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227776 0039d316-1c4b-4281-b951-d872f2087c98

Suppose that TopSites contain only "http://www.google.com/a", GetGeneralizedCanonicalURL() would allow us to find it using "http://www.google.com/a/b" as the search key. Our previous prefix match routine (renamed to GetSpecializedCanonicalURL()) works the other way: it allows to find "http://www.google.com/a" using "http://www.google.com/" as the search key. There are several ways to implement GetGeneralizedCanonicalURL(): 1. Go through successive prefixes, and look in TopSites. E.g., "http://www.google.com/a/b/c/d" forms the queries http://www.google.com/a/b/c/d http://www.google.com/a/b/c http://www.google.com/a/b http://www.google.com/a http://www.google.com 2. Go through stored URL TopSites and seek prefixes of input URL. 3. Similar to 2, but applying binary search, using GetSpecializedCanonicalURL() to bound calls. Method #1 can lead to O(n^2) behaviour depending on input URL size. Method #3 probably introduces unnecessary complexity. That's why we chose method #2. An optimization is that we "bracket" the range of TopSites URLs that share the same scheme+path+port as the input URL, then performs a search in reversed-direction. Some refactoring are also done for TopSitesCache(): - Added helper routine GetURLFromIterator(). - Added helper inner class CanonicalURLQuery() to factor repetative code from querying |top_sitse_|. BUG=304954 Review URL: https://codereview.chromium.org/26032002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228084 0039d316-1c4b-4281-b951-d872f2087c98

Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x4b4c49 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:52 #1 0x8a286e3 in base::Value::CreateStringValue(std::string const&) base/values.cc:109 #2 0x3eba5d2 in ProfileSyncServicePreferenceTest_ModelAssociationCloudAddsOldAndNewMigratedData_Test::TestBody() chrome/browser/sync/profile_sync_service_preference_unittest.cc:531 #3 0x7f130f7 in testing::Test::Run() testing/gtest/src/gtest.cc:2067 and so on. These showed up on the try runs of your change too, please pay attention to this. Also, consider rewriting this code to use a RAII pattern, then it's impossible to forget what this change adds, and the tests won't leak when they fail. BUG=299290 [email protected] Review URL: https://codereview.chromium.org/30633002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229592 0039d316-1c4b-4281-b951-d872f2087c98

…ek if necessary Works-around Android MediaCodec's requirement that a new video MediaCodec always first be fed with I-frame data by re-introducing a (short-term, for this work-around only) "browser seek" that is coordinated with regular seeks, but hidden as much as possible from Blink and web apps. Updates and adds related MediaSourcePlayerTests. Also adds a preroll test to verify http://crbug.com/309122 case #1. A more robust fix approach is tracked by http://crbug.com/304234. BUG=298502, 309122 [email protected],[email protected],[email protected] TEST=Original and alternate repro steps in Bug 298502 no longer crash due to surface change, though other crashes sometimes occur on original repro steps (bugs 306314 and 302867). All MediaSourcePlayerTests pass on Android. Review URL: https://codereview.chromium.org/26595003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231425 0039d316-1c4b-4281-b951-d872f2087c98

…of the summa..." > Use TOP crosswalk-project#1 language from CLD2 instead of the summary language > > The summary language and the top language are different, and the top language should be used for Translate. Originally, Chromium adopts the top language of CLD1, and summary language of CLD2. This CL fixes to use the top language even in the case of CLD2. > > BUG=320362 > TEST=manual > > Review URL: https://codereview.chromium.org/75483009 [email protected] Review URL: https://codereview.chromium.org/83793018 git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@237228 0039d316-1c4b-4281-b951-d872f2087c98

1. Enable icu_use_data_file_flag on CrOS 2. Doing #1 led to a crash because GetStringUTF8 (that relies on ICU to determine whether the current UI language is RTL) is called before InitializeICU is called. Instead of using GetStringUTF8, get the string directly from the resource bundle because there's no need to adjust the string for the RTL locale in this particular case. Note to perf-sheriff : The size of chrome binary will be 10M smaller because the ICU data is now in a separate file (icudtl.dat) whose size is about 10M. BUG=72633 TEST=ui_base_unittests Review URL: https://codereview.chromium.org/135963010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248325 0039d316-1c4b-4281-b951-d872f2087c98

…hromium.org/135963010/) Reason for revert: This is breaking the Chrome OS bots on the waterfall: http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28x86%29&number=19593 http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28amd64%29&number=13965 From discussion on chromium-dev: Looking at /var/log/messages for one of the failing tests, Chrome is exiting with SIGABRT over and over, and ui.LATEST has the following over and over: [0201/085858:FATAL:content_main_runner.cc(735)] Check failed: base::i18n::InitializeICU(). Original issue's description: > Enable icu_use_data_file_flag on CrOS > > 1. Enable icu_use_data_file_flag on CrOS > > 2. Doing #1 led to a crash because GetStringUTF8 (that relies on ICU to determine whether the current UI language is RTL) is called before InitializeICU is called. Instead of using GetStringUTF8, get the string directly from the resource bundle because there's no need to adjust the string for the RTL locale in this particular case. > > Note to perf-sheriff : The size of chrome binary will be 10M smaller because the ICU data is now in a separate file (icudtl.dat) whose size is about 10M. > > BUG=72633 > TEST=ui_base_unittests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248325 [email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=72633 Review URL: https://codereview.chromium.org/151163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248374 0039d316-1c4b-4281-b951-d872f2087c98

…AD, in Views Adds a new dialog, DownloadFeedbackDialogView, to ask people whether they want to participate in the upload program. Currently only hooked up to UNCOMMON_DOWNLOAD. Still TODO: - need to add dialog to DANGEROUS_HOST as well - need to add new histogram for dialog once DANGEROUS_HOST is in place -------------- How to test [Win & CrOS only]: 1. Visit http://testsafebrowsing.appspot.com/, click on crosswalk-project#5, then click discard, then click any choice in the dialog 2. If you repeat #1, you shouldn't see the dialog again unless you delete the preferences file in the User Data directory 3. If you do #1 in two separate windows, only one of them should trigger the dialog BUG=312533 [email protected] Review URL: https://codereview.chromium.org/147593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249796 0039d316-1c4b-4281-b951-d872f2087c98

> Split out InputMethodMenuManager from InputMethodManager. > > Rename input_method_property to input_method_menu_item, and move to ash/ime. > > BUG=342336, 343044 > > Review URL: https://codereview.chromium.org/150203015 I'm reverting as test appears to be consistently failing: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/39558/steps/ash_unittests/logs/TestUninitializedGet InputMethodMenuManagerTest.TestUninitializedGet (run #1): [ RUN ] InputMethodMenuManagerTest.TestUninitializedGet [WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test couldn't detect the number of threads. ../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure Death test: InputMethodMenuManager::Get() Result: failed to die. Error msg: [ DEATH ] [ FAILED ] InputMethodMenuManagerTest.TestUninitializedGet (4 ms) InputMethodMenuManagerTest.TestUninitializedGet (run #2): [ RUN ] InputMethodMenuManagerTest.TestUninitializedGet [WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test couldn't detect the number of threads. ../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure Death test: InputMethodMenuManager::Get() Result: failed to die. Error msg: [ DEATH ] [ FAILED ] InputMethodMenuManagerTest.TestUninitializedGet (2 ms) InputMethodMenuManagerTest.TestUninitializedGet (run #3): [ RUN ] InputMethodMenuManagerTest.TestUninitializedGet [WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test couldn't detect the number of threads. ../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure Death test: InputMethodMenuManager::Get() Result: failed to die. Error msg: [ DEATH ] [ FAILED ] InputMethodMenuManagerTest.TestUninitializedGet (2 ms) InputMethodMenuManagerTest.TestUninitializedGet (run #4): [ RUN ] InputMethodMenuManagerTest.TestUninitializedGet [WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test couldn't detect the number of threads. ../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure Death test: InputMethodMenuManager::Get() Result: failed to die. Error msg: [ DEATH ] [ FAILED ] InputMethodMenuManagerTest.TestUninitializedGet (1 ms) [email protected] Review URL: https://codereview.chromium.org/165453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251194 0039d316-1c4b-4281-b951-d872f2087c98

> Add wallpaper api tests > > This CL add the following tests: > 1. test chrome.setWallpaper can set ChromeOS wallpaper from jpg or png formatted arraybuffer. > 2. test chrome.setWallpaper can set ChromeOS wallpaper from a valid url that point to a jpg or png image. > 3. test an invalide URL wont set wallpaper > 4. test a new wallpaper request will cancel previous unfinished request > > > BUG=176183 > > Review URL: https://codereview.chromium.org/153093010 AFAICT this failed as soon as you landed it. Here's output from one of the bots: ExtensionApiTest.Wallpaper (run #1): [ RUN ] ExtensionApiTest.Wallpaper [21364:21364:0213/150838:1514562885:ERROR:audio_manager_pulse.cc(248)] Failed to connect to the context. Error: Connection refused Xlib: extension "RANDR" missing on display ":9". [7:7:0213/150839:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: renderer. [21409:21409:0213/230839:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: gpu-process. [15:15:0213/150840:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: renderer. [24:24:0213/150840:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: utility. Corrupt JPEG data: premature end of data segment [21364:21364:0213/150841:1516721525:INFO:CONSOLE(0)] "[SUCCESS] setJpgWallpaperFromAppLocalFile", source: chrome-extension://neonnameailmmllmeicdbcndfninlogd/_generated_background_page.html (0) [31:31:0213/150841:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: utility. [21364:21364:0213/150841:1516803158:INFO:CONSOLE(0)] "[SUCCESS] setPngWallpaperFromAppLocalFile", source: chrome-extension://neonnameailmmllmeicdbcndfninlogd/_generated_background_page.html (0) [38:38:0213/150841:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: utility. Corrupt JPEG data: premature end of data segment [21364:21364:0213/150841:1517187827:INFO:CONSOLE(0)] "[SUCCESS] setJpgWallpaperFromURL", source: chrome-extension://neonnameailmmllmeicdbcndfninlogd/_generated_background_page.html (0) [45:45:0213/150841:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: utility. [21364:21364:0213/150841:1517523379:INFO:CONSOLE(0)] "[SUCCESS] setPngWallpaperFromURL", source: chrome-extension://neonnameailmmllmeicdbcndfninlogd/_generated_background_page.html (0) [21364:21446:0213/150841:1517544840:WARNING:embedded_test_server.cc(231)] Request not handled. Returning 404: /extensions/api_test/wallpaper/test1.jpg [52:52:0213/150841:WARNING:sandbox_linux.cc(55)] Activated seccomp-bpf sandbox for process type: utility. /usr/include/c++/4.6/debug/vector:320:error: attempt to subscript container with out-of-bounds index 0, but container only holds 0 elements. Objects involved in the operation: sequence "this" @ 0x0x7ffffdb6a470 { } at: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%282%29/builds/10341/steps/browser_tests/logs/Wallpaper [email protected] Review URL: https://codereview.chromium.org/167243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251366 0039d316-1c4b-4281-b951-d872f2087c98

…painting. (https://codereview.chromium.org/164183012/) Reason for revert: Breaks compositor_unittests on ChromeOS. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/39630 LayerWithRealCompositorTest.Delegate (run #1): [ RUN ] LayerWithRealCompositorTest.Delegate ../../ui/compositor/layer_unittest.cc:527: Failure Value of: l1->bounds().size() Actual: 8-byte object \u003C90-01 00-00 90-01 00-00> Expected: delegate.paint_size() Which is: 8-byte object \u003C00-00 00-00 00-00 00-00> ... LayerWithRealCompositorTest.NoScaleCanvas (run #1): [ RUN ] LayerWithRealCompositorTest.NoScaleCanvas ../../ui/compositor/layer_unittest.cc:1311: Failure Value of: l1_delegate.paint_size().ToString() Actual: "0x0" Expected: "280x360" [ FAILED ] LayerWithRealCompositorTest.NoScaleCanvas (112 ms) ... I can repro the failures on my dev box and revert this CL fixes the problem. Original issue's description: > Remove --enable-per-tile-painting and --ui-enable-per-tile-painting. > > The ui flag is always true on ChromeOS and off elsewhere. The other is > never on and we're not planning to turn it on. > > R=piman > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251538 [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/168423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251553 0039d316-1c4b-4281-b951-d872f2087c98

This CL: - Refactors FrameCaptionButton so that it inherits from views::CustomButton instead of views::ImageButton. This is needed because part #2 switches the button to be painted as a background + icon background: none, hovered or pressed icon: active or inactive - Sets the images for the FrameCaptionButton to use in HeaderPainter. Part #2 introduces browser only window control assets. This CL is a step towards making ash not know about browser resources. - Renames |FrameCaptionButton::animation_| to |FrameCaptionButton::swap_images_animation_| in preparation for disambiguating |FrameCaptionButton::swap_images_animation_| from |CustomButton::hover_animation_|. BUG=297187 TEST=None Review URL: https://codereview.chromium.org/142323011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252703 0039d316-1c4b-4281-b951-d872f2087c98

Experimental revert. It seems that PPAPINaClGLibcTest.URLLoader1 is failing more often than it used to after sometime around this change. This is the only change that seems plausible, especially given the error message at the beginning of the test: PPAPINaClGLibcTest.URLLoader1 (run #1): [ RUN ] PPAPINaClGLibcTest.URLLoader1 [2776:2884:0224/095958:3880400:WARNING:chrome_browser_main_win.cc(321)] Command line too long for RegisterApplicationRestart [3500:3312:0224/100000:ERROR:singleton_hwnd.cc(43)] Cannot create windows on non-UI thread! HTTP server started on 127.0.0.1:51814... sending server_data: {"host": "127.0.0.1", "port": 51814} (36 bytes) ... garykac will send out more details about our investigation of this issue. Crossing my fingers. > Update shell_aura.cc to get aura::Window for dispatcher. > > This change is related to CL: https://codereview.chromium.org/172743002 where > RootWindow was renamed to WindowEventDispatcher. > > This fixes the Ozone build which uses shell_aura.cc > > [email protected] > NOTRY=true > > Review URL: https://codereview.chromium.org/177713003 [email protected] Review URL: https://codereview.chromium.org/178553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252976 0039d316-1c4b-4281-b951-d872f2087c98

…e loops. (https://codereview.chromium.org/182143002/) Reason for revert: win debug interactive_ui_tests: BookmarkBarViewTest12.CloseWithModalDialog (run #1): [ RUN ] BookmarkBarViewTest12.CloseWithModalDialog [3940:2156:0226/224958:2493504:FATAL:desktop_dispatcher_client.cc(33)] Check failed: !quit_closure_.is_null(). Original issue's description: > Use the default dispatcher where possible for nested message loops. > > Notable changes: > * Add QuitNestedMessageLoop() to client::DispatcherClient, which can be used to > terminate a nested loop started by RunWithDispatcher(). > * FirstRunDialog and SimpleMessageBoxViews are no longer > MessagePumpDispatchers. The default dispatcher is used instead, and > QuitNestedMessageLoop() is called to terminate the loop instead of returning > POST_DISPATCH_QUIT_LOOP from the Dispatch() override. > > BUG=none > [email protected] > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253723 [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=none Review URL: https://codereview.chromium.org/182753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253744 0039d316-1c4b-4281-b951-d872f2087c98

…ttps://codereview.chromium.org/180513002/) Reason for revert: Possible cause of build breakage: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/40180 http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/40180/steps/message_center_unittests/logs/LeftPositioningWithLeftTaskbar MessagePopupCollectionTest.LeftPositioningWithLeftTaskbar (run #1): [ RUN ] MessagePopupCollectionTest.LeftPositioningWithLeftTaskbar Xlib: extension "RANDR" missing on display ":9". ../../ui/message_center/views/message_popup_collection_unittest.cc:341: Failure Expected: (r1.x()) \u003C (GetWorkArea().CenterPoint().x()), actual: 433 vs 400 [ FAILED ] MessagePopupCollectionTest.LeftPositioningWithLeftTaskbar (430 ms) Original issue's description: > Converts MessagePopupCollection into a long-lived object. > > This improves the behavior since there were several scenarios where > observer methods would cause re-entrancy into the destructor of > MessagePopupCollection. Since it observes MessageCenter, it knows when > it should show popups and when it shouldn't. > > This CL is based on dewittj's crrev.com/114553002 with a fix > for some tests in linux-aura and win because of screen_aura. > > BUG=327363 > [email protected], [email protected] > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254101 [email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=327363 Review URL: https://codereview.chromium.org/183883006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254145 0039d316-1c4b-4281-b951-d872f2087c98

…org/140583003/) Reason for revert: Appears to have caused a memory leak. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%282%29/builds/23519/steps/content_unittests/logs/AvailableService Indirect leak of 176 byte(s) in 1 object(s) allocated from: #0 0x49c001 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54 #1 0xf42228 in content::PowerProfilerServiceTest::ServiceStartTest() content/browser/power_profiler/power_profiler_service_unittest.cc:85 #2 0xf4212d in content::PowerProfilerServiceTest_AvailableService_Test::TestBody() content/browser/power_profiler/power_profiler_service_unittest.cc:138 #3 0x2d3587a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #4 0x2d3587a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #5 0x2d379ca in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #6 0x2d38793 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #7 0x2d4984a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #8 0x2d48e30 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #9 0x2d48e30 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #10 0x2cc09cc in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #11 0x2cc09cc in base::TestSuite::Run() base/test/test_suite.cc:213 #12 0x2cb4041 in Run base/callback.h:401 #13 0x2cb4041 in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #14 0x195d8ce in main content/test/run_all_unittests.cc:14 #15 0x7f515353d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > This CL implemented part of chrome power profiler, including the service, data provider and observer base. > > BUG=337138 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254116 [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=337138 Review URL: https://codereview.chromium.org/184583004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254146 0039d316-1c4b-4281-b951-d872f2087c98

This caused a memory leak. It appears |suggestions| was mismanaged? http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%283%29/builds/13714/steps/unit_tests/logs/OfflinePageDontProceed Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x4b1711 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54 #1 0x61e7518 in LocalizedError::GetStrings(int, std::string const&, GURL const&, bool, bool, std::string const&, std::string const&, scoped_ptr\u003CLocalizedError::ErrorPageParams, base::DefaultDeleter\u003CLocalizedError::ErrorPageParams> >, base::DictionaryValue*) chrome/common/localized_error.cc:686 #2 0x111d82c0 in chromeos::OfflineLoadPage::GetHTMLContents() chrome/browser/chromeos/offline/offline_load_page.cc:98 #3 0xfb6f1fd in content::InterstitialPageImpl::Show() content/browser/frame_host/interstitial_page_impl.cc:248 #4 0x13fc43e in chromeos::OfflineLoadPageTest::ShowInterstitial(char const*) chrome/browser/chromeos/offline/offline_load_page_unittest.cc:71 #5 0x13fc870 in chromeos::OfflineLoadPageTest_OfflinePageDontProceed_Test::TestBody() chrome/browser/chromeos/offline/offline_load_page_unittest.cc:128 #6 0x800bf1a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #7 0x800bf1a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #8 0x800e349 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #9 0x800f0c3 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #10 0x801fd1a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #11 0x801f320 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #12 0x801f320 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #13 0x129f3154 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #14 0x129f3154 in base::TestSuite::Run() base/test/test_suite.cc:213 #15 0x129ea3b7 in Run base/callback.h:401 #16 0x129ea3b7 in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #17 0x820ee6d in main chrome/test/base/run_all_unittests.cc:13 #18 0x7f1d7d44d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 > Switch to using the new Link Doctor API. > > The new API allows Link Doctor results to be integrated into Chrome's > own error pages. > > BUG=64832 > [email protected], [email protected], [email protected], [email protected] > > Review URL: https://codereview.chromium.org/137623011 [email protected] Review URL: https://codereview.chromium.org/185003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254241 0039d316-1c4b-4281-b951-d872f2087c98

This made the Asan bot unhappy http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASan%2BLSan%20Tests%20%282%29&number=396 P2PSocketHostTest.TestInvalidTurnChannelMessages (run #1): [ RUN ] P2PSocketHostTest.TestInvalidTurnChannelMessages ================================================================= ==13684==ERROR: AddressSanitizer: global-buffer-overflow on address 0x00000cc54404 at pc 0x278fe5c bp 0x7fff34be4350 sp 0x7fff34be4348 READ of size 1 at 0x00000cc54404 thread T0 #0 0x278fe5b in IsRtpPacket content/browser/renderer_host/p2p/socket_host.cc:54 #1 0x278fe5b in content::packet_processing_helpers::GetRtpPacketStartPositionAndLength(char*, int, int*, int*) content/browser/renderer_host/p2p/socket_host.cc:304 #2 0x1f5a542 in content::P2PSocketHostTest_TestInvalidTurnChannelMessages_Test::TestBody() content/browser/renderer_host/p2p/socket_host_unittest.cc:208 #3 0x2c38e7a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #4 0x2c38e7a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #5 0x2c3afca in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #6 0x2c3bd93 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #7 0x2c4ce4a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #8 0x2c4c430 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #9 0x2c4c430 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #10 0x2bcad1c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #11 0x2bcad1c in base::TestSuite::Run() base/test/test_suite.cc:213 #12 0x2bbebbb in Run base/callback.h:401 #13 0x2bbebbb in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #14 0x198401e in main content/test/run_all_unittests.cc:14 #15 0x7f28c9fa576c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 #16 0x4b322c in _start (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x4b322c) 0x00000cc54404 is located 60 bytes to the left of global variable 'kRtpMsgWith2ByteExtnHeader' from '../../content/browser/renderer_host/p2p/socket_host_unittest.cc' (0xcc54440) of size 20 0x00000cc54404 is located 0 bytes to the right of global variable 'kTurnChannelMsgWithZeroLength' from '../../content/browser/renderer_host/p2p/socket_host_unittest.cc' (0xcc54400) of size 4 SUMMARY: AddressSanitizer: global-buffer-overflow content/browser/renderer_host/p2p/socket_host.cc:54 IsRtpPacket Shadow bytes around the buggy address: 0x000081982830: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x000081982840: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x000081982850: 00 00 f9 f9 f9 f9 f9 f9 00 00 f9 f9 f9 f9 f9 f9 0x000081982860: 00 00 04 f9 f9 f9 f9 f9 00 00 04 f9 f9 f9 f9 f9 0x000081982870: 00 00 00 04 f9 f9 f9 f9 00 f9 f9 f9 f9 f9 f9 f9 =>0x000081982880:[04]f9 f9 f9 f9 f9 f9 f9 00 00 04 f9 f9 f9 f9 f9 0x000081982890: 00 00 00 f9 f9 f9 f9 f9 00 00 00 00 00 04 f9 f9 0x0000819828a0: f9 f9 f9 f9 00 00 00 00 00 00 00 f9 f9 f9 f9 f9 0x0000819828b0: 00 00 f9 f9 f9 f9 f9 f9 00 00 00 f9 f9 f9 f9 f9 0x0000819828c0: 03 f9 f9 f9 f9 f9 f9 f9 00 00 05 f9 f9 f9 f9 f9 0x0000819828d0: 04 f9 f9 f9 f9 f9 f9 f9 00 00 00 00 00 00 00 00 > This CL adds methods to manipulate RTP header extension, particularly > AbsoulteSendTime extension. If there is matching extension ID present > in RTP packet, we will update with the current time. > > [email protected], [email protected], [email protected] > > BUG= > > Review URL: https://codereview.chromium.org/159353002 [email protected] Review URL: https://codereview.chromium.org/197933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256584 0039d316-1c4b-4281-b951-d872f2087c98

The linux asan bot went red ResourceDispatcherHostTest.DownloadToFile (run #1): [ RUN ] ResourceDispatcherHostTest.DownloadToFile [ OK ] ResourceDispatcherHostTest.DownloadToFile (212 ms) [----------] 1 test from ResourceDispatcherHostTest (212 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (213 ms total) [ PASSED ] 1 test. YOU HAVE 5 DISABLED TESTS ================================================================= ==9125==ERROR: LeakSanitizer: detected memory leaks Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x49be81 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54 #1 0x23ce695 in content::ResourceDispatcherHostImpl::BeginRequest(int, ResourceHostMsg_Request const&, IPC::Message*, int) content/browser/loader/resource_dispatcher_host_impl.cc:1045 #2 0x23cba80 in OnRequestResource content/browser/loader/resource_dispatcher_host_impl.cc:879 #3 0x23cba80 in Dispatch\u003Ccontent::ResourceDispatcherHostImpl, content::ResourceDispatcherHostImpl, int, const ResourceHostMsg_Request &> content/common/resource_messages.h:305 #4 0x23cba80 in content::ResourceDispatcherHostImpl::OnMessageReceived(IPC::Message const&, content::ResourceMessageFilter*, bool*) content/browser/loader/resource_dispatcher_host_impl.cc:841 #5 0xe04954 in content::ResourceDispatcherHostTest_DownloadToFile_Test::TestBody() content/browser/loader/resource_dispatcher_host_unittest.cc:2840 #6 0x2c10c9a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #7 0x2c10c9a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #8 0x2c12dea in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #9 0x2c13bb3 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #10 0x2c24c6a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #11 0x2c24250 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #12 0x2c24250 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #13 0x2b9ed2c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #14 0x2b9ed2c in base::TestSuite::Run() base/test/test_suite.cc:213 #15 0x2b92bcb in Run base/callback.h:401 #16 0x2b92bcb in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #17 0x199a83e in main content/test/run_all_unittests.cc:14 #18 0x7f6e898bf76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 SUMMARY: AddressSanitizer: 16 byte(s) leaked in 1 allocation(s). http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/409 > Fix various issues in RedirectToFileResourceHandler. > > - Handle errors in creating temporary files. > - Cancel on write failure instead of resuming. This used to work, but got > lost in some refactoring in r142108. > - Fix the OnResponseCompleted resume logic to account for partial writes. > - Don't lose write errors which occur after OnResponseCompleted is received. > - WeakPtrFactory goes after other members. > - OnWillStart was never forwarded to downstream handlers. > - Make sure the file is closed before deleting it. > > Also add a lot of machinery so we can better unit test this stack. > > BUG=316634,347663 > TEST=ResourceDispatcherHostTest.DownloadToFile > ResourceDispatcherHostTest.RegisterDownloadedTempFile > ResourceLoaderTest.RedirectToFile* > TemporaryFileStreamTest.Basic > > Review URL: https://codereview.chromium.org/82273002 [email protected] Review URL: https://codereview.chromium.org/196533013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256704 0039d316-1c4b-4281-b951-d872f2087c98

Turned the chromeos lsan bot red: Indirect leak of 48 byte(s) in 1 object(s) allocated from: #0 0x480201 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54 #1 0x49e263 in ui::AXTreeSerializer\u003Cviews::View*>::SerializeChangedNodes(views::View*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:372 #2 0x49b75a in ui::AXTreeSerializer\u003Cviews::View*>::SerializeChanges(views::View*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:329 #3 0x49992d in views::AXTreeSourceViewsTest_SimpleSerialization_Test::TestBody() ui/views/accessibility/ax_tree_source_views_unittest.cc:75 #4 0xb859ba in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #5 0xb859ba in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #6 0xb874c9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #7 0xb88243 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #8 0xb98e9a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #9 0xb984a0 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #10 0xb984a0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #11 0xb51664 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #12 0xb51664 in base::TestSuite::Run() base/test/test_suite.cc:213 #13 0xb47d1d in Run base/callback.h:401 #14 0xb47d1d in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #15 0x80bdba in main ui/views/run_all_unittests.cc:46 #16 0x7f0caf06376c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%2BLSan%20Tests%20%281%29/builds/222/steps/views_unittests/logs/SimpleSerialization > Reland r256396 Add views implementation for AXTreeSource. > > BUG=318758 > [email protected] > > Review URL: https://codereview.chromium.org/196603003 [email protected] Review URL: https://codereview.chromium.org/196953009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256745 0039d316-1c4b-4281-b951-d872f2087c98

Parameter "sampleRate" is not required for loadAudioResource(). There is FIXME in AudioBus.cpp in blink FIXME: the sampleRate parameter is ignored. It should be removed from the API. It will be consist of 3 steps. 1. Removing "sampleRate" in chrome which is called by blink. (included deprecated method) https://codereview.chromium.org/195043002/ 2. Removing "sampleRate" in blink. https://codereview.chromium.org/194753005/ 3. Removing deprecated method from #1 BUG=351284 Review URL: https://codereview.chromium.org/195043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256800 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#1} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}

Previously, any time the webview plugin needed to schedule animation, it dirtied layout in the containing frame. This was because it used to be the case that LayoutEmbeddedObject would run the webview plugin's lifecycle as part of layout. However, this is not right, for two reasons: 1. A lifecycle update for later phases may be needed for the plugin due to changes in the parent, even if layout is not dirty. This can lead to not running the webview lifecyle in some cases. https://codereview.chromium.org/1708923002 fixed this by always running the lifecycle of the webview plugin when the parent does. 2. Animation is scheduled for two reasons: lifecyle update, and actual animations, such as issuing resize events to script. It is valid to queue up async script events during a lifecycle update. (In one case in the referenced bug, FrameView:: sendResizeEventIfNeeded does this when it notices that layout changed the size of the frame). This CL fixes cases such as that, and builds up on the one fixing issue crosswalk-project#1, by scheduling animation of the parent frame but not dirtying layout. BUG=590856 Review URL: https://codereview.chromium.org/1774653002 Cr-Commit-Position: refs/heads/master@{#379694} (cherry picked from commit 78ea22a) Review URL: https://codereview.chromium.org/1777563003 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#137} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}

…set crosswalk-project#1 id:1 of https://codereview.chromium.org/1782563002/ ) Reason for revert: Merged incorrectly. Will revert for now and remerge. Original issue's description: > Takeover MT initiated animations from the compositor > > This is a followup CL to https://crrev.com/1734063003/. It finishes a > MT initiated animation running on the compositor, on the MT. > > BUG=581875 > > Review URL: https://codereview.chromium.org/1770443002 > > Cr-Commit-Position: refs/heads/master@{#379868} > (cherry picked from commit d0eaee2) TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581875 Review URL: https://codereview.chromium.org/1778223002 Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#166} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}

…heets is true. (patchset crosswalk-project#1 id:1 of https://codereview.chromium.org/1827043003/ ) Reason for revert: Build failed. The branch was before we renamed the getters from property to getProperty. Original issue's description: > Disable subsequence caching when didLayoutWithPendingStylesheets is true. > > BUG=593758 > > Review URL: https://codereview.chromium.org/1823353003 > > Cr-Commit-Position: refs/heads/master@{#382791} > (cherry picked from commit 27c2539) > > Committed: https://chromium.googlesource.com/chromium/src/+/91283f70477be7d059454b89fb7839dbd465130d [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=593758 Review URL: https://codereview.chromium.org/1833003002 Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#382} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}

…rosswalk-project#1 id:1 of https://codereview.chromium.org/1828703006/ ) Reason for revert: Doesn't compile on m50 branch Original issue's description: > Android: fix memory regression on svelte device > > Virtualized GL contexts were being disabled for > some non-full screen video due to the attribute > |alpha| used for context creation requests made in > RenderWidget/RenderThreadImp was true. > > This CL check the surface type (on/off) to disable > virtualized GL only for onscreen surfaces whose > format doesn't match the default. > > BUG=594083, 591100 > > Review URL: https://codereview.chromium.org/1818303002 > > Cr-Commit-Position: refs/heads/master@{#383179} > (cherry picked from commit 5c3c0ed) > > NOTRY=true > NOPRESUBMIT=true [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594083, 591100 Review URL: https://codereview.chromium.org/1840583002 Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#394} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}

Repro steps: 1.) Turn on "Don't keep activities" 2.) Navigate to a test form site: https://www.cs.tut.fi/~jkorpela/forms/testing.html 3.) Submit POST form 4.) Refresh 5.) Hit the home button (causing the activity to be destroyed per crosswalk-project#1 It crashes in the destruction path as the fragment manager has been destroyed. Add a safety check to prevent the crash. BUG=598196 Review URL: https://codereview.chromium.org/1836053002 Cr-Commit-Position: refs/heads/master@{#383574} Review URL: https://codereview.chromium.org/1837073002 . Cr-Commit-Position: refs/branch-heads/2661@{#409} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}

…walk-project#1 id:1 of https://codereview.chromium.org/1836093003/ ) Reason for revert: Didn't build on M50. Original issue's description: > Remove secondary player from Media Sessions > > When we switch Android media players, for cast, we no longer want audio > focus changes associated with old player to take effect. To handle this > remove the old player from the Media Sessions. > > The new player is responsible for adding itself to the Media Sessions if > it needs to. The remote player doesn't need to, and, after stopping casting > the local player will do so when the user presses play. > > BUG=595373 > > Review URL: https://codereview.chromium.org/1823983002 > > Cr-Commit-Position: refs/heads/master@{#382613} > (cherry picked from commit 4bee90c) > > Committed: https://chromium.googlesource.com/chromium/src/+/3ad63a558b2fbe889d02eeffe2f664955bfc9f07 [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595373 Review URL: https://codereview.chromium.org/1842763003 Cr-Commit-Position: refs/branch-heads/2661@{#421} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}

@obj

… URLs. (patchset #1 id:1 of https://codereview.chromium.org/2111633002/ ) Reason for revert: Sigh, test failed to compile on builder: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20beta/builds/3447/steps/compile/logs/stdio FAILED: obj/content/browser/frame_host/content_browsertests.navigation_controller_impl_browsertest.obj ninja -t msvc -e environment.x86 -- "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\content\browser\frame_host\content_browsertests.navigation_controller_impl_browsertest.obj.rsp /c ..\..\content\browser\frame_host\navigation_controller_impl_browsertest.cc /Foobj\content\browser\frame_host\content_browsertests.navigation_controller_impl_browsertest.obj /Fdobj\content\content_browsertests.cc.pdb c:\b\build\slave\win_beta\build\src\content\browser\frame_host\navigation_controller_impl_browsertest.cc(749): error C2664: 'bool content::ExecuteScript(const content::ToRenderFrameHost &,const std::string &)': cannot convert argument 1 from 'content::FrameTreeNode *' to 'const content::ToRenderFrameHost &' Original issue's description: > Avoid incorrect NC_AUTO_SUBFRAME renderer kills for non-web URLs. > > There are several corner cases with in-page navigations where non-web > URLs (e.g., about:blank, file) may look cross-origin. This was > leading to renderer kills when a subframe went back/forward. > > A followup CL will account for these cases more accurately, but since > this is just second line of defense against URL spoofs, we can loosen > it to only check web URLs for the time being to avoid the kills. > > BUG=613732 > TEST=See bug comment 10 for repro steps. > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2054013003 > Cr-Commit-Position: refs/heads/master@{#399228} > (cherry picked from commit 37988b9) > > Committed: https://chromium.googlesource.com/chromium/src/+/38453aec59e45d2685bb327f3a9033554489e4e8 [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=613732 Review-Url: https://codereview.chromium.org/2110183003 Cr-Commit-Position: refs/branch-heads/2743@{#532} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}

…c at shutdown (patchset #1 id:1 of https://codereview.chromium.org/2125623002/ ) Reason for revert: I am landing the original fix and will then add a minor change directly after. The new change (https://codereview.chromium.org/2126603002/) will ensure that all tests runs as expected. Original issue's description: > Revert of Prevents crash in media::AudioInputController::OnData in Mac at shutdown (patchset #3 id:40001 of https://codereview.chromium.org/2110133002/ ) > > Reason for revert: > Causes some WebRTC content_browsertests to fail on Mac https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/56577 > > 17 tests failed: > WebRtcAudioDebugRecordingsBrowserTest.CallWithAudioDebugRecordings (../../content/browser/media/webrtc/webrtc_audio_debug_recordings_browsertest.cc:98) > WebRtcAudioDebugRecordingsBrowserTest.CallWithAudioDebugRecordingsEnabledThenDisabled (../../content/browser/media/webrtc/webrtc_audio_debug_recordings_browsertest.cc:164) > WebRtcBrowserTest.CallAndVerifyVideoMutingWorks (../../content/browser/media/webrtc/webrtc_browsertest.cc:318) > WebRtcBrowserTest.CallWithDataAndMedia (../../content/browser/media/webrtc/webrtc_browsertest.cc:225) > WebRtcBrowserTest.CallWithSctpDataAndMedia (../../content/browser/media/webrtc/webrtc_browsertest.cc:237) > WebRtcBrowserTest.CanSetupAudioAndVideoCall (../../content/browser/media/webrtc/webrtc_browsertest.cc:113) > WebRtcBrowserTest.CanSetupAudioAndVideoCallWithoutMsidAndBundle (../../content/browser/media/webrtc/webrtc_browsertest.cc:178) > WebRtcBrowserTest.CanSetupCallAndSendDtmf (../../content/browser/media/webrtc/webrtc_browsertest.cc:126) > WebRtcBrowserTest.CanSetupLegacyCall (../../content/browser/media/webrtc/webrtc_browsertest.cc:201) > WebRtcBrowserTest.EnsureLocalVideoMuteDoesntMuteAudio (../../content/browser/media/webrtc/webrtc_browsertest.cc:301) > WebRtcBrowserTest.EnsureRemoteVideoMuteDoesntMuteAudio (../../content/browser/media/webrtc/webrtc_browsertest.cc:307) > WebRtcBrowserTest.EstablishAudioVideoCallAndEnsureAudioIsPlaying (../../content/browser/media/webrtc/webrtc_browsertest.cc:271) > WebRtcBrowserTest.EstablishAudioVideoCallAndVerifyLocalMutingWorks (../../content/browser/media/webrtc/webrtc_browsertest.cc:295) > WebRtcBrowserTest.EstablishAudioVideoCallAndVerifyRemoteMutingWorks (../../content/browser/media/webrtc/webrtc_browsertest.cc:289) > WebRtcBrowserTest.EstablishAudioVideoCallAndVerifyUnmutingWorks (../../content/browser/media/webrtc/webrtc_browsertest.cc:313) > WebRtcBrowserTest.NegotiateOfferWithBLine (../../content/browser/media/webrtc/webrtc_browsertest.cc:197) > WebRtcBrowserTest.NoCrashWhenConnectChromiumSinkToRemoteTrack (../../content/browser/media/webrtc/webrtc_browsertest.cc:169) > > Original issue's description: > > Prevents crash in media::AudioInputController::OnData in Mac at shutdown > > > > BUG=623703 > > > > Committed: https://crrev.com/46d57073d145e2af834ae93aad15cc3a138a6cc4 > > Cr-Commit-Position: refs/heads/master@{#403664} > > [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=623703 > > Committed: https://crrev.com/a52511fc4d907663193d7ba18928e7edd0890ce2 > Cr-Commit-Position: refs/heads/master@{#403783} [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623703 Review-Url: https://codereview.chromium.org/2123103002 Cr-Commit-Position: refs/heads/master@{#403863} (cherry picked from commit 2b4dde9) Review URL: https://codereview.chromium.org/2152793002 . Cr-Commit-Position: refs/branch-heads/2743@{#623} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}

…ated messages (patchset #1 id:1 of https://codereview.chromium.org/2213123002/ ) Reason for revert: Broke compile Original issue's description: > [Extensions] Ensure ordering of extension [un]loaded, activated messages > > We send three messages to the renderer in order to maintain extension > lifetime and active state: extension loaded, extension unloaded, and > extension activated. The loaded message is sent when a) an extension is > loaded and b) initially when the render process starts. Unloaded > messages are sent when an extension is unloaded to any running process. > Activated messages are sent to a renderer when a render view > corresponding to an extension is created. > > Unfortunately, the existent render processes are not always initialized. > We have code to queue up messages until the render process is properly > initialized, which ensures that at least the loaded message with all > currently-loaded extensions is sent first, followed by queued messages > in FIFO. However, this breaks in the following scenario: > - Renderer created, not fully initialized (channel not created) > - Render view created, activate extension 'A' message sent. Since the > process is not initialized, this message is queued. > - Extension unloaded. Extension 'A' unloaded message is also queued. > - Renderer initialized. We initialize the renderer with all loaded > extensions, however, Extension 'A' is no longer loaded, so is > (rightly) included in the list. > - Extension renderer receives messages for loaded extensions, activate > extension 'A', unload extension 'A'. Since extension 'A' was never > loaded, the queued messages break assumptions (and cause a crash). > > Fix this by passing all loaded, unloaded, and activated messages through > a common source that keeps track of initialized render processes, and > will not send messages until the process is initialized, as well as > cleaning up unnecessary messages (such as activating extensions that > have since been unloaded). > > Also add a regression test. > > BUG=528026 > > Review-Url: https://codereview.chromium.org/2162983002 > Cr-Commit-Position: refs/heads/master@{#407796} > (cherry picked from commit 5e510e8) > > Committed: https://chromium.googlesource.com/chromium/src/+/1719b2ac728c8745554ca458188af7f6d20b3d0f TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=528026 Review-Url: https://codereview.chromium.org/2211213002 Cr-Commit-Position: refs/branch-heads/2785@{#506} Cr-Branched-From: 6862397-refs/heads/master@{#403382}

…r (patchset #1 id:1 of https://codereview.chromium.org/2237253002/ ) Reason for revert: Fails to compile Original issue's description: > Separate data use reporting logic in ExternalDataUseObserver > > ExternalDataUseReporter class is created with the data use reporting > logic. ExternalDataUseReporter is created in IO thread and moved to UI > thread. It is owned by ExternalDataUseObserver. > > BUG=570884 > > Review-Url: https://codereview.chromium.org/2145863002 > Cr-Commit-Position: refs/heads/master@{#406041} > (cherry picked from commit 7ef8efb) > > Committed: https://chromium.googlesource.com/chromium/src/+/420db8b477d2ab04c5899b56ddf140c8f85435da [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570884 Review-Url: https://codereview.chromium.org/2242463003 Cr-Commit-Position: refs/branch-heads/2785@{#572} Cr-Branched-From: 6862397-refs/heads/master@{#403382}

…tps://codereview.chromium.org/2252283002/ ) Reason for revert: Wrong resolve Original issue's description: > arc: Fix crash on Arc window close. > > BUG=638261 > BUG=b/30817552 > TEST=Manually on device. No more crashes are observed. > > NOTRY=true > NOPRESUBMIT=true > [email protected] > > Review-Url: https://codereview.chromium.org/2251493002 > Cr-Commit-Position: refs/heads/master@{#412390} > (cherry picked from commit 323b4a4) TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=638261 Review-Url: https://codereview.chromium.org/2251313002 Cr-Commit-Position: refs/branch-heads/2785@{#652} Cr-Branched-From: 6862397-refs/heads/master@{#403382}

…rence (patchset #1 id:1 of https://codereview.chromium.org/2241533002/ ) Reason for revert: Experiment out. Reverting. See bug for reasoning. Original issue's description: > android: Switch CleanupReference to PhantomReference > > Again. This time due to correctness. Want to experiment on beta to see > how big the impact is. Quoting from the comment in the CL: > > NOTE Using PhantonReference instead of WeakReference is required for correctness. > WeakReferences are enqueued before finalizers are called, and finalizers can > resurrect the referent object. PhantomReference does delay clean up more compared > to WeakReference. > > BUG=618807 > > Committed: https://crrev.com/630d88124d2e5a3fda6b9fd25d06eaa1af403fca > Cr-Commit-Position: refs/heads/master@{#411417} [email protected],[email protected] BUG=618807 Review-Url: https://codereview.chromium.org/2255253002 Cr-Commit-Position: refs/heads/master@{#412871} (cherry picked from commit 74e50f4) Review URL: https://codereview.chromium.org/2257893003 . Cr-Commit-Position: refs/branch-heads/2785@{#663} Cr-Branched-From: 6862397-refs/heads/master@{#403382}

…://codereview.chromium.org/2257923002/ ) Reason for revert: Wrong resolve Original issue's description: > arc: Handle non-launchable apps. > > There are Android apps that can be started indirectly and which > don't have launchable flag. We had no support such apps in Chrome > and that caused incorrect behavior in shelf. Fix is to register > such apps on creation with special flag that prevents them to > appear in launcher app list and to be pinned in shelf. > > BUG=635536 > BUG=b/30508435 > TEST=Manually on device. Icon of an app (app info) appears on the > shelf and cannot be pinned. No app info icon in app list. > TEST=Extended unit_test > [email protected] > NOTRY=true > NOPRESUBMIT=true > > Review-Url: https://codereview.chromium.org/2210143003 > Cr-Commit-Position: refs/heads/master@{#411120} > (cherry picked from commit 25bc165) TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635536 Review-Url: https://codereview.chromium.org/2259033002 Cr-Commit-Position: refs/branch-heads/2785@{#666} Cr-Branched-From: 6862397-refs/heads/master@{#403382}

…rvice. (patchset #1 id:1 of https://codereview.chromium.org/2248353002/ ) Reason for revert: Compilation problem: ../../chrome/browser/chromeos/arc/arc_auth_service.cc:244:34: error: no member named 'stopped' in 'arc::ArcBridgeService' Original issue's description: > Migrate ArcUserDataService into ArcAuthService. > > There are race problems around data removing. > One of the cause is that state management is done in > ArcAuthService and ArcUserDataService separately. > > This CL migrates ArcUserDataService into ArcAuthService > so that we can remove the data when necessary. > > BUG=633258, 636218 > TEST=Ran manually. > - "Enable -> ARC boot wait -> Disable" triggers data removal after > ARC stop. > - "Enable -> Disable before ARC boot" triggers immediate data > removal. > - "Enable -> ARC boot wait -> Kill ARC instance" does not trigger > data removal. > [email protected], [email protected] > [email protected], [email protected], [email protected] > > Review-Url: https://codereview.chromium.org/2209173002 > Cr-Commit-Position: refs/heads/master@{#411923} > (cherry picked from commit 6d95ad3) > > Committed: https://chromium.googlesource.com/chromium/src/+/d7ca35a59c7bd8c7ddd78d7682458e48e6b4e934 [email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=633258, 636218 Review-Url: https://codereview.chromium.org/2255673004 Cr-Commit-Position: refs/branch-heads/2785@{#671} Cr-Branched-From: 6862397-refs/heads/master@{#403382}

…tps://codereview.chromium.org/2251973003/ ) Reason for revert: wrong resolve Original issue's description: > arc: Fix crash on Arc window close. > > BUG=638261 > BUG=b/30817552 > TEST=Manually on device. No more crashes are observed. > > NOTRY=true > NOPRESUBMIT=true > [email protected] > > Review-Url: https://codereview.chromium.org/2251493002 > Cr-Commit-Position: refs/heads/master@{#412390} > (cherry picked from commit 323b4a4) TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=638261 Review-Url: https://codereview.chromium.org/2255383004 Cr-Commit-Position: refs/branch-heads/2785@{#672} Cr-Branched-From: 6862397-refs/heads/master@{#403382}

https://codereview.chromium.org/2265173003/ ) Reason for revert: Bad merge. Original issue's description: > arc: bluetooth: Add Gatt server mojo API > > This patch adds the mojo definition for Gatt Server API > > BUG=629210 > TEST=Build > > Review-Url: https://codereview.chromium.org/2104023002 > Cr-Commit-Position: refs/heads/master@{#407546} > (cherry picked from commit 9c5baa3) TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=629210 Review-Url: https://codereview.chromium.org/2263363003 Cr-Commit-Position: refs/branch-heads/2785@{#711} Cr-Branched-From: 6862397-refs/heads/master@{#403382}

…chromium.org/2280173002/ ) Reason for revert: breaks build (bad merge) Original issue's description: > conflicts resolved > > BUG= > > Committed: https://chromium.googlesource.com/chromium/src/+/63dd2d9cfe0f30d08fbd6db291b62b8aa5041b5b TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2281143003 Cr-Commit-Position: refs/branch-heads/2785@{#764} Cr-Branched-From: 6862397-refs/heads/master@{#403382}

…://codereview.chromium.org/2107893004/ ) Reason for revert: Breaks icons on deb packages Original issue's description: > Support relocatable RPM packages > > BUG=31519 > > Committed: https://crrev.com/c5e796b04c2dffb9bb2023ec6985d5c3457b6e99 > Cr-Commit-Position: refs/heads/master@{#402666} [email protected] BUG=642953 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2299093002 Review-Url: https://codereview.chromium.org/2299273002 Cr-Original-Commit-Position: refs/heads/master@{#415840} Cr-Commit-Position: refs/branch-heads/2785@{#806} Cr-Branched-From: 6862397-refs/heads/master@{#403382}

…ce (patchset #1 id:1 of https://codereview.chromium.org/2313213002/ ) Reason for revert: Syntax error Original issue's description: > arc: Fix thread unsafe behavior of ArcDownloadsWatcherService > > ArcBridgeService is not thread-safe. > WeakPtr should be defererenced only on the thread to which the > factory belongs. > > BUG=643059 > > Review-Url: https://codereview.chromium.org/2304523002 > Cr-Commit-Position: refs/heads/master@{#416194} > (cherry picked from commit 3c74f1c) > > Committed: https://chromium.googlesource.com/chromium/src/+/8c306683e2476a091d8fd0b94c87a9ecefff87bd TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=643059 Review-Url: https://codereview.chromium.org/2315013003 Cr-Commit-Position: refs/branch-heads/2785@{#841} Cr-Branched-From: 6862397-refs/heads/master@{#403382}

…id:1 of https://codereview.chromium.org/2079423002/ ) Reason for revert: This causes crashes during browser startup. Original issue's description: > Remove calls to MessageLoop::current() in ios. > > Why? > The fact that there's a MessageLoop on the thread is an > unnecessary implementation detail. When browser threads > are migrated to base/task_scheduler, tasks will no longer > have access to a MessageLoop. > > These changes were generated manually. > > BUG=616447 > [email protected] > > Committed: https://crrev.com/c5c127abb5f0d8ba0dd34cfbd6233bbf9209f0f2 > Cr-Commit-Position: refs/heads/master@{#401027} [email protected] BUG=616447 Review-Url: https://codereview.chromium.org/2326053002 Cr-Commit-Position: refs/heads/master@{#417583} (cherry picked from commit dce5618) Review URL: https://codereview.chromium.org/2329533002 . Cr-Commit-Position: refs/branch-heads/2785@{#864} Cr-Branched-From: 6862397-refs/heads/master@{#403382}

id:1 of https://codereview.chromium.org/2334143003/ ) Reason for revert: This manual merge is broken. It is missing the attribute EGL_DMA_BUF_PLANE?_FD_EXT. Original issue's description: > ozone: Sort U and V plane when creating an image. > > Manual merge of crrev.com/2295943002 to M53. > > By EGL_EXT_image_dma_buf_import spec, if there is a YUV multi-planar > format, the plane 1 and 2 should always be U and V. > > Intel mesa currently doesn't follow the spec and does the swap on its > own. > > BUG=646136, 646137, b/31164247 > TEST=External video on samus. > NOTRY=true > NOPRESUBMIT=true > > Review-Url: https://codereview.chromium.org/2295943002 > Cr-Commit-Position: refs/heads/master@{#418082} [email protected] NOTRY=true NOPRESUBMIT=true # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=646136, 646137, b/31164247 Review-Url: https://codereview.chromium.org/2341083002 Cr-Commit-Position: refs/branch-heads/2785@{#898} Cr-Branched-From: 6862397-refs/heads/master@{#403382}

…d:1 of https://codereview.chromium.org/2365833003/ ) Reason for revert: After further discussion, decided against taking this in 53 Original issue's description: > Re-enable rate limiting for Windows Crashpad > > Chrome can get itself into crash loops that cause massive numbers of > uploads. We'd like to have UMA to see what we're dropping, but for > the time being, mitigate by re-instituting the Mac-style 1/hr upload > limit. > > BUG=crashpad:23, 647464 > > Review-Url: https://codereview.chromium.org/2332103002 > Cr-Commit-Position: refs/heads/master@{#418063} > (cherry picked from commit d922b3c) > > Committed: https://chromium.googlesource.com/chromium/src/+/c1490fd145eda148dd788e554426aa7cb7fde5b2 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=crashpad:23, 647464 Review-Url: https://codereview.chromium.org/2367723003 Cr-Commit-Position: refs/branch-heads/2785@{#920} Cr-Branched-From: 6862397-refs/heads/master@{#403382}

…#1 id:1 of https://codereview.chromium.org/2347453002/ ) Reason for revert: This broke YouTube, Hangout, and camera app on many ChromeOS devices. The video was black. See http://crbug.com/648528 Original issue's description: > Add NV12 buffer scanout support from exo to ozone. > > Let exo import NV12 scanout buffers and use them to composite. > > BUG=647015, 646148, b/31159410, b/29625228 > NOTRY=true > NOPRESUBMIT=true > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2296433002 > Cr-Commit-Position: refs/heads/master@{#418096} > (cherry picked from commit 1e8cdd4) [email protected] NOTRY=true NOPRESUBMIT=true BUG=647015, 646148, b/31159410, b/29625228 Review-Url: https://codereview.chromium.org/2360323004 Cr-Commit-Position: refs/branch-heads/2840@{#499} Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}

…FETCH_CRL_FROM_NET if adding a crl polic… (patchset #1 id:1 of https://codereview.chromium.org/2370983002/ ) Reason for revert: Broke build due to calling function renamed on trunk. BUG=650407,645629 Original issue's description: > Hack for AIA fetching on Mac Sierra: On >=10.12, always do FETCH_CRL_FROM_NET if adding a crl policy. > > BUG=645629 > > Review-Url: https://codereview.chromium.org/2368453002 > Cr-Commit-Position: refs/heads/master@{#420482} > (cherry picked from commit 97a93ce) > > Committed: https://chromium.googlesource.com/chromium/src/+/229aed5b182860fad333aa574bf49e6434702b89 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=645629 Review-Url: https://codereview.chromium.org/2373653003 Cr-Commit-Position: refs/branch-heads/2840@{#536} Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}

id:1 of https://codereview.chromium.org/2380513002/ ) Reason for revert: BUILD.gn change missing from this merge, causing breakage on the Beta builders https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/precise64%20beta/builds/4150 ERROR at //testing/test.gni:271:5: Source file not found. executable(target_name) { ^------------------------ The target: //third_party/WebKit/Source/web:webkit_unit_tests has a source file: //third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp Original issue's description: > Revert r403630 which broke parsing on some sites. > > HTMLTreeBuilderSimulator needs to line up with HTML parsing. r403630 > tried to bring them closer together, but this regressed some existing > sites. This should be relanded but it needs to make the parser and > simulator more reliably consistent. > > BUG=542803,639541 > > Review-Url: https://codereview.chromium.org/2366203006 > Cr-Commit-Position: refs/heads/master@{#421177} > (cherry picked from commit 6a45441) > > Committed: https://chromium.googlesource.com/chromium/src/+/5b2166eee42a2936e0653929afb2595d614288fb [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=542803,639541 Review-Url: https://codereview.chromium.org/2382523002 Cr-Commit-Position: refs/branch-heads/2840@{#567} Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}

… items. (patchset #1 id:1 of https://codereview.chromium.org/2380943006/ ) Reason for revert: Broke compile on M54. Original issue's description: > Notify the renderer if a history navigation has no subframe items. > > In this case, the renderer does not need to consult the browser > process if subframes are created during the navigation. Since there > are no history items for it, the renderer can just load the default > URL. > > BUG=638088, 639842 > TEST=Restore chrome://settings after disabling MD settings mode. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2316003002 > Cr-Commit-Position: refs/heads/master@{#420486} > (cherry picked from commit 45b3bba) > > Committed: https://chromium.googlesource.com/chromium/src/+/2c38c57dd850f83ba7d1a6713a0552175200efd1 [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=638088, 639842 Review-Url: https://codereview.chromium.org/2384833002 Cr-Commit-Position: refs/branch-heads/2840@{#606} Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}

…ttps://codereview.chromium.org/2411903003/ ) Reason for revert: Does not compile: ../../chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:857: error: method updateHerbIntent in class ChromeLauncherActivity cannot be applied to given types; ChromeLauncherActivity.updateHerbIntent(ChromeTabbedActivity.this, ^ required: Context,Intent found: ChromeTabbedActivity,Intent,Uri reason: actual and formal argument lists differ in length Original issue's description: > Fix tab redirect to apps in Herb mode. > > BUG=653254 > > Review-Url: https://codereview.chromium.org/2398833002 > Cr-Commit-Position: refs/heads/master@{#423355} > > Support native app redirects to herb. > > If in Herb mode, use the same intent handling logic as Chrome, > which more aggressively intents out to external applications > than a normal CCT. > > BUG=653254 > > Review-Url: https://codereview.chromium.org/2412613002 > Cr-Commit-Position: refs/heads/master@{#424483} > Committed: https://chromium.googlesource.com/chromium/src/+/1005c8597f728173c822bdc1d8a01609f8cbd02c [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653254 Review-Url: https://codereview.chromium.org/2419483002 Cr-Commit-Position: refs/branch-heads/2840@{#729} Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}

…ttps://codereview.chromium.org/2419483002/ ) Reason for revert: Reland. Issue fixed by https://codereview.chromium.org/2408233003/ Original issue's description: > Revert of Fix tab redirect to apps in Herb mode. (patchset #1 id:1 of https://codereview.chromium.org/2411903003/ ) > > Reason for revert: > Does not compile: > > ../../chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java:857: error: method updateHerbIntent in class ChromeLauncherActivity cannot be applied to given types; > ChromeLauncherActivity.updateHerbIntent(ChromeTabbedActivity.this, > ^ > required: Context,Intent > found: ChromeTabbedActivity,Intent,Uri > reason: actual and formal argument lists differ in length > > Original issue's description: > > Fix tab redirect to apps in Herb mode. > > > > BUG=653254 > > > > Review-Url: https://codereview.chromium.org/2398833002 > > Cr-Commit-Position: refs/heads/master@{#423355} > > > > Support native app redirects to herb. > > > > If in Herb mode, use the same intent handling logic as Chrome, > > which more aggressively intents out to external applications > > than a normal CCT. > > > > BUG=653254 > > > > Review-Url: https://codereview.chromium.org/2412613002 > > Cr-Commit-Position: refs/heads/master@{#424483} > > Committed: https://chromium.googlesource.com/chromium/src/+/1005c8597f728173c822bdc1d8a01609f8cbd02c > > [email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=653254 [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653254 Review-Url: https://codereview.chromium.org/2404163005 Cr-Commit-Position: refs/branch-heads/2840@{#730} Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}

[email protected] Change-Id: I68f20700013b59a429ab17d0675e9f94a5532259 Reviewed-on: https://chromium-review.googlesource.com/646294 Reviewed-by: [email protected] <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#1} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

kenchris pushed a commit that referenced this pull request Apr 26, 2013

Merge pull request #1 from huningxin/master

d7749ff

Allocate starting resource IDs for Cameo

kenchris merged commit d7749ff into crosswalk-project:master Apr 26, 2013

huningxin added a commit that referenced this pull request Jul 17, 2013

Merge pull request #1 from hmin/aura

b4c2fa2

Bug fixing for aura root window host

fujunwei pushed a commit to fujunwei/chromium-crosswalk that referenced this pull request Jun 28, 2016

Incrementing VERSION to 50.0.2661.1

b497429

Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#1} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allocate starting resource IDs for Cameo #1

Allocate starting resource IDs for Cameo #1

huningxin commented Apr 26, 2013

huningxin commented Apr 26, 2013

huningxin commented Apr 26, 2013

Allocate starting resource IDs for Cameo #1

Allocate starting resource IDs for Cameo #1

Conversation

huningxin commented Apr 26, 2013

huningxin commented Apr 26, 2013

huningxin commented Apr 26, 2013