Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Add "messages" to generate resource id for string. #4

Merged
merged 1 commit into from
May 20, 2013
Merged

Add "messages" to generate resource id for string. #4

merged 1 commit into from
May 20, 2013

Conversation

junmin-zhu
Copy link
Contributor

This patch should work together with the patch "javascript dialog support" of cameo repo.

@junmin-zhu
Copy link
Contributor Author

@darktears , @kenchris , @huningxin, @hmin , would you help to review the patch? thanks.

kenchris pushed a commit that referenced this pull request May 20, 2013
Merge pull request #4 from junmin-zhu/jsdialog
c3e6fe7 
Add "messages" to generate resource id for string.
@kenchris kenchris merged commit c3e6fe7 into crosswalk-project:lkgr May 20, 2013
@wang16 wang16 mentioned this pull request May 31, 2013
Merged
halton pushed a commit that referenced this pull request Nov 6, 2013
InstantExtended: Send search URLs to renderers.
2309e91 
                                                                                
Previously, navigations initiated by an instant renderer were bounced to
the browser to be rebucketed into an instant or non-instant renderer.
But navigations from non-instant renderers to instant URLs (i.e.
privileged search page URLs) were not rebucketed, because the renderer
had no knowledge of which URLs were instant URLs, and it would be too
expensive to bounce ALL URLs. As a result, non-instant pages like
google.com/setprefs could not redirect to instant pages like
google.com/search.
                                                                        
This change has InstantService tell renderers about URLs associated with
the default search engine, and uses this knowledge to bounce
renderer-initiated navigations to likely instant URLs from non-instant
processes back into the browser for rebucketing. So now link clicks from
non-instant pages to instant pages will put the destination pages into
an instant process. Unfortunately, though, redirects are still broken.
For example,
                                                                                
0. User clicks "Set preferences" button on an instant page.
1. Instant renderer bounces google.com/setprefs to the browser.
2. Browser says google.com/setprefs is not an instant URL,
   and assigns it to a non-instant renderer.
3. After rebucketing to the non-instant renderer, google.com/setprefs
   is marked as a browser initiated request(!)
4. /setprefs redirects to /search, which _is_ an instant URL, but
   because /setprefs is marked as browser initiated the non-instant
   renderer does not get a chance to bounce it back to the browser.
                                                                                
I tried working around this by giving redirects a chance to bounce back
to the browser in step #4, but this broke the signin process model in a
scary way that I don't fully understand. It seems like the right fix
here is going to need to EITHER follow the redirect chain in step #2
when determining if an URL is an instant URL, OR somehow flag the
bounced redirect request for further inspection in step #3.

This change also includes a small side benefit. Since renderers now know
about instant URLs, we can suppress a flash of a baked-in error page in
the event of an error while loading the InstantExtended new tab page.

TEST=manual,unit,browsertest
BUG=271088,223754

Review URL: https://codereview.chromium.org/23455047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226103 0039d316-1c4b-4281-b951-d872f2087c98
huningxin referenced this pull request in huningxin/chromium-croswalk Mar 4, 2014
Revert 251164 "Split out InputMethodMenuManager from InputMethod..."
7440626 
> Split out InputMethodMenuManager from InputMethodManager.
> 
> Rename input_method_property to input_method_menu_item, and move to ash/ime.
> 
> BUG=342336, 343044
> 
> Review URL: https://codereview.chromium.org/150203015

I'm reverting as test appears to be consistently failing:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/39558/steps/ash_unittests/logs/TestUninitializedGet

InputMethodMenuManagerTest.TestUninitializedGet (run #1):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (4 ms)

InputMethodMenuManagerTest.TestUninitializedGet (run #2):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (2 ms)

InputMethodMenuManagerTest.TestUninitializedGet (run #3):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (2 ms)

InputMethodMenuManagerTest.TestUninitializedGet (run #4):
[ RUN      ] InputMethodMenuManagerTest.TestUninitializedGet

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:825:: Death
tests use fork(), which is unsafe particularly in a threaded
context. For this test, Google Test couldn't detect the number of
threads.
../../ash/ime/input_method_menu_manager_unittest.cc:16: Failure
Death test: InputMethodMenuManager::Get()
    Result: failed to die.
 Error msg:
[  DEATH   ] 
[  FAILED  ] InputMethodMenuManagerTest.TestUninitializedGet (1 ms)

[email protected]

Review URL: https://codereview.chromium.org/165453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251194 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Mar 26, 2014
Enable icu_use_data_file_flag on Android
b4934e5 
0. Roll icu to r249466 to copy Android-specific icudtl.dat
1. Turn it in build/common.gypi by default except for android webview build. Move it inside L2 var dict and pull it up to the top level var dict to make 'Google Chrome' build on Android happy. 
2. Add an entry for icudtl.dat to chrome/chrome_android_paks.gypi so that
it's copied to assets directory for Chrome and related targets. 
3. Extract icudtl.dat from the asset and copy to DIR_ANDROID_APP_DATA and make it world-readable so that child processes (sandboxed with uid) can read it. 
4. Add icudtl.dat to MANDATORY_PAKS list in various Android build targets 

Google Chrome has #4 but in a separate CL ( https://chrome-internal-review.googlesource.com/#/c/155554/ ). That CL will land before this CL. 

[email protected]
BUG=72633
TEST=base_unittests:*Convers*, net_unittests:*IDN*, browser tests on all platforms.

Review URL: https://codereview.chromium.org/156333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253938 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Mar 26, 2014
Revert 253938 "Enable icu_use_data_file_flag on Android"
2afcfa6 
May have caused crashes on Android layout test bots.

> Enable icu_use_data_file_flag on Android
> 
> 0. Roll icu to r249466 to copy Android-specific icudtl.dat
> 1. Turn it in build/common.gypi by default except for android webview build. Move it inside L2 var dict and pull it up to the top level var dict to make 'Google Chrome' build on Android happy. 
> 2. Add an entry for icudtl.dat to chrome/chrome_android_paks.gypi so that
> it's copied to assets directory for Chrome and related targets. 
> 3. Extract icudtl.dat from the asset and copy to DIR_ANDROID_APP_DATA and make it world-readable so that child processes (sandboxed with uid) can read it. 
> 4. Add icudtl.dat to MANDATORY_PAKS list in various Android build targets 
> 
> Google Chrome has #4 but in a separate CL ( https://chrome-internal-review.googlesource.com/#/c/155554/ ). That CL will land before this CL. 
> 
> [email protected]
> BUG=72633
> TEST=base_unittests:*Convers*, net_unittests:*IDN*, browser tests on all platforms.
> 
> Review URL: https://codereview.chromium.org/156333002

[email protected]

Review URL: https://codereview.chromium.org/183863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254020 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Mar 26, 2014
Revert of Chrome power profiler service (https://codereview.chromium.…
05e70d3 
…org/140583003/)

Reason for revert:
Appears to have caused a memory leak.

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%282%29/builds/23519/steps/content_unittests/logs/AvailableService

Indirect leak of 176 byte(s) in 1 object(s) allocated from:
    #0 0x49c001 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54
    #1 0xf42228 in content::PowerProfilerServiceTest::ServiceStartTest() content/browser/power_profiler/power_profiler_service_unittest.cc:85
    #2 0xf4212d in content::PowerProfilerServiceTest_AvailableService_Test::TestBody() content/browser/power_profiler/power_profiler_service_unittest.cc:138
    #3 0x2d3587a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
    #4 0x2d3587a in testing::Test::Run() testing/gtest/src/gtest.cc:2061
    #5 0x2d379ca in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #6 0x2d38793 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #7 0x2d4984a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    #8 0x2d48e30 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    #9 0x2d48e30 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #10 0x2cc09cc in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #11 0x2cc09cc in base::TestSuite::Run() base/test/test_suite.cc:213
    #12 0x2cb4041 in Run base/callback.h:401
    #13 0x2cb4041 in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494
    #14 0x195d8ce in main content/test/run_all_unittests.cc:14
    #15 0x7f515353d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226


Original issue's description:
> This CL implemented part of chrome power profiler, including the service, data provider and observer base.
> 
> BUG=337138
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254116

[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=337138

Review URL: https://codereview.chromium.org/184583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254146 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Mar 26, 2014
Revert 254207 "Switch to using the new Link Doctor API."
f49aef8 
This caused a memory leak. It appears |suggestions| was mismanaged?

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%283%29/builds/13714/steps/unit_tests/logs/OfflinePageDontProceed

Direct leak of 40 byte(s) in 1 object(s) allocated from:
    #0 0x4b1711 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54
    #1 0x61e7518 in LocalizedError::GetStrings(int, std::string const&, GURL const&, bool, bool, std::string const&, std::string const&, scoped_ptr\u003CLocalizedError::ErrorPageParams, base::DefaultDeleter\u003CLocalizedError::ErrorPageParams> >, base::DictionaryValue*) chrome/common/localized_error.cc:686
    #2 0x111d82c0 in chromeos::OfflineLoadPage::GetHTMLContents() chrome/browser/chromeos/offline/offline_load_page.cc:98
    #3 0xfb6f1fd in content::InterstitialPageImpl::Show() content/browser/frame_host/interstitial_page_impl.cc:248
    #4 0x13fc43e in chromeos::OfflineLoadPageTest::ShowInterstitial(char const*) chrome/browser/chromeos/offline/offline_load_page_unittest.cc:71
    #5 0x13fc870 in chromeos::OfflineLoadPageTest_OfflinePageDontProceed_Test::TestBody() chrome/browser/chromeos/offline/offline_load_page_unittest.cc:128
    #6 0x800bf1a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
    #7 0x800bf1a in testing::Test::Run() testing/gtest/src/gtest.cc:2061
    #8 0x800e349 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #9 0x800f0c3 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #10 0x801fd1a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    #11 0x801f320 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    #12 0x801f320 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #13 0x129f3154 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #14 0x129f3154 in base::TestSuite::Run() base/test/test_suite.cc:213
    #15 0x129ea3b7 in Run base/callback.h:401
    #16 0x129ea3b7 in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494
    #17 0x820ee6d in main chrome/test/base/run_all_unittests.cc:13
    #18 0x7f1d7d44d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

> Switch to using the new Link Doctor API.
> 
> The new API allows Link Doctor results to be integrated into Chrome's
> own error pages.
> 
> BUG=64832
> [email protected], [email protected], [email protected], [email protected]
> 
> Review URL: https://codereview.chromium.org/137623011

[email protected]

Review URL: https://codereview.chromium.org/185003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254241 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Mar 26, 2014
Enable icu_use_data_file_flag on Android
c8e8781 
0. Roll icu to r249466 to copy Android-specific icudtl.dat
1. Turn it in build/common.gypi by default except for android webview build. Move it inside L2 var dict and pull it up to the top level var dict to make 'Google Chrome' build on Android happy. 
2. Add an entry for icudtl.dat to chrome/chrome_android_paks.gypi so that
it's copied to assets directory for Chrome and related targets. 
3. Extract icudtl.dat from the asset and copy to DIR_ANDROID_APP_DATA and make it world-readable so that child processes (sandboxed with uid) can read it. 
4. Add icudtl.dat to MANDATORY_PAKS list in various Android build targets 

Google Chrome has #4 but in a separate CL ( https://chrome-internal-review.googlesource.com/#/c/155554/ ). That CL will land before this CL. 

This also depends on a Blink change https://codereview.chromium.org/183013006/ 

[email protected]
BUG=72633
TEST=base_unittests:*Convers*, net_unittests:*IDN*, browser tests on all platforms.
TEST=On Android, 1. Layout tests 
2. build/android/test_runner.py gtest -s webkit_unit_tests 
--gtest_filter=WebFrameTest.SelectRange*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253938

Review URL: https://codereview.chromium.org/156333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255762 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Mar 26, 2014
Revert 256580 "This CL adds methods to manipulate RTP header ext..."
2ebbe12 
This made the Asan bot unhappy

http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASan%2BLSan%20Tests%20%282%29&number=396


P2PSocketHostTest.TestInvalidTurnChannelMessages (run #1):
[ RUN      ] P2PSocketHostTest.TestInvalidTurnChannelMessages
=================================================================
==13684==ERROR: AddressSanitizer: global-buffer-overflow on address 0x00000cc54404 at pc 0x278fe5c bp 0x7fff34be4350 sp 0x7fff34be4348
READ of size 1 at 0x00000cc54404 thread T0
    #0 0x278fe5b in IsRtpPacket content/browser/renderer_host/p2p/socket_host.cc:54
    #1 0x278fe5b in content::packet_processing_helpers::GetRtpPacketStartPositionAndLength(char*, int, int*, int*) content/browser/renderer_host/p2p/socket_host.cc:304
    #2 0x1f5a542 in content::P2PSocketHostTest_TestInvalidTurnChannelMessages_Test::TestBody() content/browser/renderer_host/p2p/socket_host_unittest.cc:208
    #3 0x2c38e7a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
    #4 0x2c38e7a in testing::Test::Run() testing/gtest/src/gtest.cc:2061
    #5 0x2c3afca in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #6 0x2c3bd93 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #7 0x2c4ce4a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    #8 0x2c4c430 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    #9 0x2c4c430 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #10 0x2bcad1c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #11 0x2bcad1c in base::TestSuite::Run() base/test/test_suite.cc:213
    #12 0x2bbebbb in Run base/callback.h:401
    #13 0x2bbebbb in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494
    #14 0x198401e in main content/test/run_all_unittests.cc:14
    #15 0x7f28c9fa576c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226
    #16 0x4b322c in _start (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x4b322c)

0x00000cc54404 is located 60 bytes to the left of global variable 'kRtpMsgWith2ByteExtnHeader' from '../../content/browser/renderer_host/p2p/socket_host_unittest.cc' (0xcc54440) of size 20
0x00000cc54404 is located 0 bytes to the right of global variable 'kTurnChannelMsgWithZeroLength' from '../../content/browser/renderer_host/p2p/socket_host_unittest.cc' (0xcc54400) of size 4
SUMMARY: AddressSanitizer: global-buffer-overflow content/browser/renderer_host/p2p/socket_host.cc:54 IsRtpPacket
Shadow bytes around the buggy address:
  0x000081982830: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x000081982840: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x000081982850: 00 00 f9 f9 f9 f9 f9 f9 00 00 f9 f9 f9 f9 f9 f9
  0x000081982860: 00 00 04 f9 f9 f9 f9 f9 00 00 04 f9 f9 f9 f9 f9
  0x000081982870: 00 00 00 04 f9 f9 f9 f9 00 f9 f9 f9 f9 f9 f9 f9
=>0x000081982880:[04]f9 f9 f9 f9 f9 f9 f9 00 00 04 f9 f9 f9 f9 f9
  0x000081982890: 00 00 00 f9 f9 f9 f9 f9 00 00 00 00 00 04 f9 f9
  0x0000819828a0: f9 f9 f9 f9 00 00 00 00 00 00 00 f9 f9 f9 f9 f9
  0x0000819828b0: 00 00 f9 f9 f9 f9 f9 f9 00 00 00 f9 f9 f9 f9 f9
  0x0000819828c0: 03 f9 f9 f9 f9 f9 f9 f9 00 00 05 f9 f9 f9 f9 f9
  0x0000819828d0: 04 f9 f9 f9 f9 f9 f9 f9 00 00 00 00 00 00 00 00


> This CL adds methods to manipulate RTP header extension, particularly
> AbsoulteSendTime extension. If there is matching extension ID present
> in RTP packet, we will update with the current time.
> 
> [email protected], [email protected], [email protected]
> 
> BUG=
> 
> Review URL: https://codereview.chromium.org/159353002

[email protected]

Review URL: https://codereview.chromium.org/197933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256584 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Mar 26, 2014
Revert 256688 "Fix various issues in RedirectToFileResourceHandler."
1a8b5cf 
The linux asan bot went red

ResourceDispatcherHostTest.DownloadToFile (run #1):
[ RUN      ] ResourceDispatcherHostTest.DownloadToFile
[       OK ] ResourceDispatcherHostTest.DownloadToFile (212 ms)
[----------] 1 test from ResourceDispatcherHostTest (212 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (213 ms total)
[  PASSED  ] 1 test.

  YOU HAVE 5 DISABLED TESTS


=================================================================
==9125==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x49be81 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54
    #1 0x23ce695 in content::ResourceDispatcherHostImpl::BeginRequest(int, ResourceHostMsg_Request const&, IPC::Message*, int) content/browser/loader/resource_dispatcher_host_impl.cc:1045
    #2 0x23cba80 in OnRequestResource content/browser/loader/resource_dispatcher_host_impl.cc:879
    #3 0x23cba80 in Dispatch\u003Ccontent::ResourceDispatcherHostImpl, content::ResourceDispatcherHostImpl, int, const ResourceHostMsg_Request &> content/common/resource_messages.h:305
    #4 0x23cba80 in content::ResourceDispatcherHostImpl::OnMessageReceived(IPC::Message const&, content::ResourceMessageFilter*, bool*) content/browser/loader/resource_dispatcher_host_impl.cc:841
    #5 0xe04954 in content::ResourceDispatcherHostTest_DownloadToFile_Test::TestBody() content/browser/loader/resource_dispatcher_host_unittest.cc:2840
    #6 0x2c10c9a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
    #7 0x2c10c9a in testing::Test::Run() testing/gtest/src/gtest.cc:2061
    #8 0x2c12dea in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #9 0x2c13bb3 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #10 0x2c24c6a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    #11 0x2c24250 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    #12 0x2c24250 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #13 0x2b9ed2c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #14 0x2b9ed2c in base::TestSuite::Run() base/test/test_suite.cc:213
    #15 0x2b92bcb in Run base/callback.h:401
    #16 0x2b92bcb in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494
    #17 0x199a83e in main content/test/run_all_unittests.cc:14
    #18 0x7f6e898bf76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

SUMMARY: AddressSanitizer: 16 byte(s) leaked in 1 allocation(s).


http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/409



> Fix various issues in RedirectToFileResourceHandler.
> 
> - Handle errors in creating temporary files.
> - Cancel on write failure instead of resuming. This used to work, but got
>   lost in some refactoring in r142108.
> - Fix the OnResponseCompleted resume logic to account for partial writes.
> - Don't lose write errors which occur after OnResponseCompleted is received.
> - WeakPtrFactory goes after other members.
> - OnWillStart was never forwarded to downstream handlers.
> - Make sure the file is closed before deleting it.
> 
> Also add a lot of machinery so we can better unit test this stack.
> 
> BUG=316634,347663
> TEST=ResourceDispatcherHostTest.DownloadToFile
>      ResourceDispatcherHostTest.RegisterDownloadedTempFile
>      ResourceLoaderTest.RedirectToFile*
>      TemporaryFileStreamTest.Basic
> 
> Review URL: https://codereview.chromium.org/82273002

[email protected]

Review URL: https://codereview.chromium.org/196533013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256704 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Mar 26, 2014
Revert 256563 "Reland r256396 Add views implementation for AXTre..."
3af95c1 
Turned the chromeos lsan bot red:

Indirect leak of 48 byte(s) in 1 object(s) allocated from:
    #0 0x480201 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54
    #1 0x49e263 in ui::AXTreeSerializer\u003Cviews::View*>::SerializeChangedNodes(views::View*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:372
    #2 0x49b75a in ui::AXTreeSerializer\u003Cviews::View*>::SerializeChanges(views::View*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:329
    #3 0x49992d in views::AXTreeSourceViewsTest_SimpleSerialization_Test::TestBody() ui/views/accessibility/ax_tree_source_views_unittest.cc:75
    #4 0xb859ba in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
    #5 0xb859ba in testing::Test::Run() testing/gtest/src/gtest.cc:2061
    #6 0xb874c9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #7 0xb88243 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #8 0xb98e9a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    #9 0xb984a0 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    #10 0xb984a0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #11 0xb51664 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #12 0xb51664 in base::TestSuite::Run() base/test/test_suite.cc:213
    #13 0xb47d1d in Run base/callback.h:401
    #14 0xb47d1d in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494
    #15 0x80bdba in main ui/views/run_all_unittests.cc:46
    #16 0x7f0caf06376c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%2BLSan%20Tests%20%281%29/builds/222/steps/views_unittests/logs/SimpleSerialization

> Reland r256396 Add views implementation for AXTreeSource.
> 
> BUG=318758
> [email protected]
> 
> Review URL: https://codereview.chromium.org/196603003

[email protected]

Review URL: https://codereview.chromium.org/196953009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256745 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Mar 26, 2014
Move clients of BrowserContextKeyedService to use KeyedService (#4)
540380f 
This change covers:
- //components
- Roughly half of the remaining clients in //chrome

BUG=351704
TBR=jochen

Review URL: https://codereview.chromium.org/198193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257067 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Mar 26, 2014
Revert of Componentize (Mutable)ProfileOAuth2TokenService. (https://c…
21b082d 
…odereview.chromium.org/201163002/)

Reason for revert:
GetUsageAndQuota fails consistently after this CL: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29

(view as text)
SyncFileSystemApiTest.GetUsageAndQuota (run #1):
[ RUN      ] SyncFileSystemApiTest.GetUsageAndQuota
[2716:1648:0319/155948:INFO:CONSOLE(0)] "[FAIL] undefined: API Test Error in undefined
Actual: 0
Expected: 123456
Error
    at Object.\u003Canonymous> (extensions::test:208:18)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at Object.handleRequest (extensions::binding:55:27)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at Object.\u003Canonymous> (extensions::binding:318:32)
    at Object.testStep (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:17:17)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at safeCallbackApply (extensions::sendRequest:21:15)
    at handleResponse (extensions::sendRequest:76:7)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0)
[2716:1648:0319/155948:INFO:CONSOLE(0)] "Error in response to syncFileSystem.getUsageAndQuota: chrome.test.failure
    at Object.callback (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:10:27)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0)
c:\b\build\slave\cr-win-rel\build\src\chrome\browser\extensions\api\sync_file_system\sync_file_system_apitest.cc(147): error: Value of: RunExtensionTest("sync_file_system/get_usage_and_quota")
  Actual: false
Expected: true
Failed 1 of 1 tests
[  FAILED  ] SyncFileSystemApiTest.GetUsageAndQuota, where TypeParam =  and GetParam() =  (1266 ms)

SyncFileSystemApiTest.GetUsageAndQuota (run #2):
[ RUN      ] SyncFileSystemApiTest.GetUsageAndQuota
[4080:2344:0319/161628:INFO:CONSOLE(0)] "[FAIL] undefined: API Test Error in undefined
Actual: 0
Expected: 123456
Error
    at Object.\u003Canonymous> (extensions::test:208:18)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at Object.handleRequest (extensions::binding:55:27)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at Object.\u003Canonymous> (extensions::binding:318:32)
    at Object.testStep (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:17:17)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at safeCallbackApply (extensions::sendRequest:21:15)
    at handleResponse (extensions::sendRequest:76:7)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0)
[4080:2344:0319/161628:INFO:CONSOLE(0)] "Error in response to syncFileSystem.getUsageAndQuota: chrome.test.failure
    at Object.callback (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:10:27)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0)
c:\b\build\slave\cr-win-rel\build\src\chrome\browser\extensions\api\sync_file_system\sync_file_system_apitest.cc(147): error: Value of: RunExtensionTest("sync_file_system/get_usage_and_quota")
  Actual: false
Expected: true
Failed 1 of 1 tests
[4080:2344:0319/161628:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.allow_outdated
[4080:2344:0319/161628:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.always_authorize
[  FAILED  ] SyncFileSystemApiTest.GetUsageAndQuota, where TypeParam =  and GetParam() =  (1422 ms)

SyncFileSystemApiTest.GetUsageAndQuota (run #3):
[ RUN      ] SyncFileSystemApiTest.GetUsageAndQuota
[3040:2588:0319/161647:INFO:CONSOLE(0)] "[FAIL] undefined: API Test Error in undefined
Actual: 0
Expected: 123456
Error
    at Object.\u003Canonymous> (extensions::test:208:18)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at Object.handleRequest (extensions::binding:55:27)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at Object.\u003Canonymous> (extensions::binding:318:32)
    at Object.testStep (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:17:17)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at safeCallbackApply (extensions::sendRequest:21:15)
    at handleResponse (extensions::sendRequest:76:7)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0)
[3040:2588:0319/161647:INFO:CONSOLE(0)] "Error in response to syncFileSystem.getUsageAndQuota: chrome.test.failure
    at Object.callback (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:10:27)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0)
c:\b\build\slave\cr-win-rel\build\src\chrome\browser\extensions\api\sync_file_system\sync_file_system_apitest.cc(147): error: Value of: RunExtensionTest("sync_file_system/get_usage_and_quota")
  Actual: false
Expected: true
Failed 1 of 1 tests
[  FAILED  ] SyncFileSystemApiTest.GetUsageAndQuota, where TypeParam =  and GetParam() =  (1156 ms)

SyncFileSystemApiTest.GetUsageAndQuota (run #4):
[ RUN      ] SyncFileSystemApiTest.GetUsageAndQuota
[1028:2272:0319/161650:INFO:CONSOLE(0)] "[FAIL] undefined: API Test Error in undefined
Actual: 0
Expected: 123456
Error
    at Object.\u003Canonymous> (extensions::test:208:18)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at Object.handleRequest (extensions::binding:55:27)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at Object.\u003Canonymous> (extensions::binding:318:32)
    at Object.testStep (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:17:17)
    at Function.target.(anonymous function) (extensions::SafeBuiltins:19:14)
    at safeCallbackApply (extensions::sendRequest:21:15)
    at handleResponse (extensions::sendRequest:76:7)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0)
[1028:2272:0319/161650:INFO:CONSOLE(0)] "Error in response to syncFileSystem.getUsageAndQuota: chrome.test.failure
    at Object.callback (chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/test.js:10:27)", source: chrome-extension://himokjngfaoiegefgnbfbecjaemjbool/_generated_background_page.html (0)
c:\b\build\slave\cr-win-rel\build\src\chrome\browser\extensions\api\sync_file_system\sync_file_system_apitest.cc(147): error: Value of: RunExtensionTest("sync_file_system/get_usage_and_quota")
  Actual: false
Expected: true
Failed 1 of 1 tests
[  FAILED  ] SyncFileSystemApiTest.GetUsageAndQuota, where TypeParam =  and GetParam() =  (1297 ms)

Original issue's description:
> Componentize (Mutable)ProfileOAuth2TokenService.
> 
> This CL componentizes the following:
> - ProfileOAuth2TokenService (obsolete references to Profile removed)
> - MutableProfileOAuth2TokenService (no changes required)
> - SigninErrorController (no changes required)
> 
> BUG=334156,333993,334217
> TBR=jochen
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258039

[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=334156,333993,334217

Review URL: https://codereview.chromium.org/205703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258160 0039d316-1c4b-4281-b951-d872f2087c98
huningxin referenced this pull request in huningxin/chromium-croswalk May 4, 2014
Revert 263352 "Introduce RenderFrameProxyHost object and use it ..."
c9b4bff 
Leaks: Linux LSan:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/1508

E.g.:
Indirect leak of 1544 byte(s) in 1 object(s) allocated from:
    #0 0x4fc78b in operator new(unsigned long) /usr/local/google/home/thakis/src/chrome/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x232ebeb in allocate /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/ext/new_allocator.h:92
    #2 0x232ebeb in _M_allocate /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_vector.h:150
    #3 0x232ebeb in _M_allocate_and_copy<std::move_iterator<__gnu_cxx::_Hashtable_node<std::pair<const std::basic_string<char>, content::SiteInstance *> > **> > /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_vector.h:1052
    #4 0x232ebeb in reserve /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/vector.tcc:74
    crosswalk-project#5 0x232ebeb in _M_initialize_buckets /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/backward/hashtable.h:577
    crosswalk-project#6 0x232ebeb in __gnu_cxx::hashtable<std::pair<std::string const, content::SiteInstance*>, std::string, __gnu_cxx::hash<std::string>, std::_Select1st<std::pair<std::string const, content::SiteInstance*> >, std::equal_to<std::string>, std::allocator<content::SiteInstance*> >::hashtable(unsigned long, __gnu_cxx::hash<std::string> const&, std::equal_to<std::string> const&, std::allocator<std::pair<std::string const, content::SiteInstance*> > const&) /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/backward/hashtable.h:334
    crosswalk-project#7 0x232cb58 in RefCounted /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/ext/hash_map:126
    crosswalk-project#8 0x232cb58 in content::BrowsingInstance::BrowsingInstance(content::BrowserContext*) content/browser/browsing_instance.cc:18
    crosswalk-project#9 0x28d4131 in content::SiteInstance::Create(content::BrowserContext*) content/browser/site_instance_impl.cc:220
    crosswalk-project#10 0x2db9c92 in CreateTestWebContents content/public/test/test_renderer_host.cc:138
    crosswalk-project#11 0x2db9c92 in content::RenderViewHostTestHarness::SetUp() content/public/test/test_renderer_host.cc:182
    crosswalk-project#12 0xda5e2d in content::RenderFrameHostManagerTest::SetUp() content/browser/frame_host/render_frame_host_manager_unittest.cc:204
    crosswalk-project#13 0x2eea0f2 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2045
    crosswalk-project#14 0x2eea0f2 in testing::Test::Run() testing/gtest/src/gtest.cc:2057
    crosswalk-project#15 0x2eec3a9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    crosswalk-project#16 0x2eed183 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    crosswalk-project#17 0x2efe463 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    crosswalk-project#18 0x2efda30 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    crosswalk-project#19 0x2efda30 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    crosswalk-project#20 0x2e7712c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    crosswalk-project#21 0x2e7712c in base::TestSuite::Run() base/test/test_suite.cc:213
    crosswalk-project#22 0x2e6aebd in Run base/callback.h:401
    crosswalk-project#23 0x2e6aebd in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback<int ()> const&, int) base/test/launcher/unit_test_launcher.cc:494
    crosswalk-project#24 0x1bfec66 in main content/test/run_all_unittests.cc:14
    crosswalk-project#25 0x7f853fc5876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226

> Introduce RenderFrameProxyHost object and use it in RFHM.
> 
> This is the first CL in a series to create RenderFrameProxy(Host) infrastructure. Before the Blink codebase is ready to transform local and remote frames, the proxy objects will keep internally the existing RF/RFH in swapped out state. This CL creates the browser side proxy object and wraps the swapped out RFH.
> 
> BUG=357747
> 
> Review URL: https://codereview.chromium.org/217163007

[email protected]

Review URL: https://codereview.chromium.org/236003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263367 0039d316-1c4b-4281-b951-d872f2087c98
darktears pushed a commit that referenced this pull request May 12, 2014
Revert of Ensure that modal dialogs from subframes can be cleaned up …
257c32d 
…correctly. (https://codereview.chromium.org/255543009/)

Reason for revert:
Causes leaks:

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2046/steps/browser_tests/logs/SadTabCancelsSubframeDialogs

Direct leak of 48 byte(s) in 1 object(s) allocated from:
    #0 0x56973b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x52464ce in IPC::SyncMessage::GenerateReply(IPC::Message const*) ipc/ipc_sync_message.cc:99
    #2 0x9f6ec47 in Tuple4 ipc/ipc_message_utils.h:877
    #3 0x9f6ec47 in bool FrameHostMsg_RunJavaScriptMessage::DispatchDelayReply\u003Ccontent::RenderFrameHostImpl, void (content::RenderFrameHostImpl::*)(std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, GURL const&, content::JavaScriptMessageType, IPC::Message*)>(IPC::Message const*, content::RenderFrameHostImpl*, void (content::RenderFrameHostImpl::*)(std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, GURL const&, content::JavaScriptMessageType, IPC::Message*)) content/common/frame_messages.h:545
    #4 0x9f6b9d3 in content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const&) content/browser/frame_host/render_frame_host_impl.cc:287
    #5 0xa1185d9 in content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_process_host_impl.cc:1346
    #6 0x5239eec in IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) ipc/ipc_channel_proxy.cc:269
    #7 0x3256fbf in Run base/callback.h:401
    #8 0x3256fbf in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:450
    #9 0x3258e35 in DeferOrRunPendingTask base/message_loop/message_loop.cc:462
    #10 0x3258e35 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:576
    #11 0x32fab87 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_glib.cc:270
    #12 0x3290314 in base::RunLoop::Run() base/run_loop.cc:49
    #13 0xc55c305 in content::RunThisRunLoop(base::RunLoop*) content/public/test/test_utils.cc:103
    #14 0xc55e252 in operator-> content/public/test/test_utils.cc:165
    #15 0xc55e252 in content::WindowedNotificationObserver::Wait() content/public/test/test_utils.cc:225
    #16 0x31af7c1 in ui_test_utils::WaitForAppModalDialog() chrome/test/base/ui_test_utils.cc:342
    #17 0x19c1ed8 in BrowserTest_SadTabCancelsSubframeDialogs_Test::RunTestOnMainThread() chrome/browser/ui/browser_browsertest.cc:585
    #18 0x31996b8 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:419


Original issue's description:
> Ensure that modal dialogs from subframes can be cleaned up correctly.
> 
> BUG=366510
> TEST=See bug comment 7 for repro steps.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266638

[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=366510

Review URL: https://codereview.chromium.org/257863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266669 0039d316-1c4b-4281-b951-d872f2087c98
darktears pushed a commit that referenced this pull request May 12, 2014
Revert of Linux Aura: get tooltip background color from theme (https:…
6daa739 
…//codereview.chromium.org/258713002/)

Reason for revert:
views_unittest TooltipController test failures
views_unittests views_unittests 4 disabled 10 flaky failed 10 ( 9 secs )
stdio
Capture
CloseOnCaptureLost
DontShowEmptyTooltips
EnableOrDisableTooltips
HideOnExit
ReshowOnClickAfterEnterExit
TooltipHidesOnKeyPressAndStaysHiddenUntilChange
TooltipHidesOnTimeoutAndStaysHiddenUntilChange
TooltipsInMultipleViews
ViewTooltip


TooltipControllerTest.ViewTooltip (run #2):
[ RUN      ] TooltipControllerTest.ViewTooltip
Xlib:  extension "RANDR" missing on display ":9".
Received signal 11 SEGV_MAPERR 000000000000
#0 0x000000a88e4e base::debug::StackTrace::StackTrace()
#1 0x000000a89068 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f9474270cb0 \u003Cunknown>
#3 0x000000736b83 views::NativeWidgetAura::Activate()
#4 0x000000737508 views::NativeWidgetAura::ShowWithWindowState()
#5 0x000000738acb views::Widget::Show()
#6 0x00000052cb09 views::corewm::test::(anonymous namespace)::CreateWidget()
#7 0x00000052d397 views::corewm::test::TooltipControllerTest::SetUp()
#8 0x00000065a16a testing::Test::Run()

Original issue's description:
> Linux Aura: get tooltip background color from theme
> 
> the border color can still conflict with the theme (e.g., no visible border if the tooltip bg is dark), but fixing that is a lot harder because the border, window roundedness, and shadow are all one tiled set of images (see shadow.cc).
> 
> BUG=348194
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266974

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=348194

Review URL: https://codereview.chromium.org/263533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266992 0039d316-1c4b-4281-b951-d872f2087c98
darktears pushed a commit that referenced this pull request May 12, 2014
Revert of Move DefaultActivationClient to wm/core (https://codereview…
7c44a3a 
….chromium.org/250113002/)

Reason for revert:
views_unittest TooltipController test failures
views_unittests views_unittests 4 disabled 10 flaky failed 10 ( 9 secs )
stdio
Capture
CloseOnCaptureLost
DontShowEmptyTooltips
EnableOrDisableTooltips
HideOnExit
ReshowOnClickAfterEnterExit
TooltipHidesOnKeyPressAndStaysHiddenUntilChange
TooltipHidesOnTimeoutAndStaysHiddenUntilChange
TooltipsInMultipleViews
ViewTooltip


TooltipControllerTest.ViewTooltip (run #2):
[ RUN      ] TooltipControllerTest.ViewTooltip
Xlib:  extension "RANDR" missing on display ":9".
Received signal 11 SEGV_MAPERR 000000000000
#0 0x000000a88e4e base::debug::StackTrace::StackTrace()
#1 0x000000a89068 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f9474270cb0 \u003Cunknown>
#3 0x000000736b83 views::NativeWidgetAura::Activate()
#4 0x000000737508 views::NativeWidgetAura::ShowWithWindowState()
#5 0x000000738acb views::Widget::Show()
#6 0x00000052cb09 views::corewm::test::(anonymous namespace)::CreateWidget()
#7 0x00000052d397 views::corewm::test::TooltipControllerTest::SetUp()
#8 0x00000065a16a testing::Test::Run().

Original issue's description:
> Move DefaultActivationClient to wm/core
> 
> Several tests are using AuraTestHelper and were relying on it to set up the DefaultActivationClient, so I had to have them instantiate the DAC directly after calling SetUp() on the helper. I also had to make the DAC delete itself after the root window it's bound to is destroyed.
> 
> [email protected]
> http://crbug.com/308710
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266616
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266975

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/261553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267001 0039d316-1c4b-4281-b951-d872f2087c98
darktears pushed a commit that referenced this pull request May 12, 2014
Revert 267850 "ServiceWorker: Create sequenced task runner for d..."
7b47eec 
unit_tests failing a DCHECK, e.g.:

out/Debug/unit_tests --gtest_filter='*BrowsingData*.*'

[32145:32145:0502/110725:1563688322251:FATAL:ref_counted.cc(32)] Check failed: !in_dtor_.
#0 0x7f45e6b227de base::debug::StackTrace::StackTrace()
#1 0x7f45e6bb0a85 logging::LogMessage::~LogMessage()
#2 0x7f45e6bcc063 base::subtle::RefCountedThreadSafeBase::AddRef()
#3 0x7f45da6ad895 base::RefCountedThreadSafe<>::AddRef()
#4 0x7f45daec3be2 scoped_refptr<>::scoped_refptr()
#5 0x7f45daf0048b content::ServiceWorkerStorage::ServiceWorkerStorage()
#6 0x7f45daea61e8 content::ServiceWorkerContextCore::ServiceWorkerContextCore()
...

> ServiceWorker: Create sequenced task runner for database
>
>
> BUG=369464
> TEST=pass all existing tests (no behavioral change)
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/265743012

[email protected]

Review URL: https://codereview.chromium.org/262973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267870 0039d316-1c4b-4281-b951-d872f2087c98
darktears pushed a commit that referenced this pull request Jun 30, 2014
Revert 278043 "Re-enable PDFExtensionTest.BasicPlugin"
4095d9e 
This test fails consistently on Linux Tests (dbg) (1)

[ RUN      ] PDFExtensionTest.BasicPlugin
...
[1023:1023:0618/142028:INFO:CONSOLE(0)] "[SUCCESS] testPageSize", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html?http://127.0.0.1:42118/pdf/test.pdf (0)
[17:17:0618/142028:WARNING:resource_message_handler.cc(49)] 'Post' message handler failed to complete successfully.
[17:17:0618/142028:ERROR:pepper_uma_host.cc(106)] Host or histogram name is not allowed to use the UMA API.
[17:17:0618/142028:WARNING:resource_message_handler.cc(49)] 'Post' message handler failed to complete successfully.
memory allocation bug: object at 0x7f5a852272c0 has never been allocated
BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7f9e4351c8b5 base::debug::StackTrace::StackTrace()
#1 0x00000462f8f2 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f9e2fb2f4a0 \u003Cunknown>
#3 0x7f9e2fbe1a43 __poll
#4 0x7f9e30917ff6 \u003Cunknown>
#5 0x7f9e30918124 g_main_context_iteration
#6 0x7f9e434e49e5 base::MessagePumpGlib::Run()
<truncated, full output is in gzipped JSON output at end of step>
#31 0x7f9e34f05dc7 content::RunNamedProcessTypeMain()
#32 0x7f9e34f074df content::ContentMainRunnerImpl::Run()
#33 0x7f9e34f0528b content::ContentMain()
...

> Re-enable PDFExtensionTest.BasicPlugin
> 
> This test was disabled because it was failing. A few changes have been made:
> -The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption.
> -testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091.
> -The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory).
> 
> BUG=303491
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273819
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274186
> 
> Review URL: https://codereview.chromium.org/290803007

[email protected]

Review URL: https://codereview.chromium.org/346693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278191 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Aug 11, 2014
Revert of Add VideoFrameRecorder for use recording test frame sequenc…
d0fe478 
…es. (https://codereview.chromium.org/339073002/)

Reason for revert:
Brand new test fails in ASAN:

Direct leak of 112 byte(s) in 1 object(s) allocated from:
#0 0x462ccb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
#1 0x7ee8f9 in CreateNextFrame remoting/host/video_frame_recorder_unittest.cc:96
#2 0x7ee8f9 in remoting::VideoFrameRecorderTest::CreateTestFrames() remoting/host/video_frame_recorder_unittest.cc:112
#3 0x7f1184 in remoting::VideoFrameRecorderTest_EncodeButDontRecord_Test::TestBody() remoting/host/video_frame_recorder_unittest.cc:269
#4 0xb3bf38 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2045
#5 0xb3bf38 in testing::Test::Run() testing/gtest/src/gtest.cc:2061
#6 0xb3e1c9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
#7 0xb3ef56 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
#8 0xb5206a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
#9 0xb516a0 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
#10 0xb516a0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
#11 0xab66bc in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
#12 0xab66bc in base::TestSuite::Run() base/test/test_suite.cc:227
#13 0xaada32 in Run base/callback.h:401
#14 0xaada32 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498
#15 0xaad3ad in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553
#16 0x4e8067 in main chrome/test/base/run_all_remoting_unittests.cc:31
#17 0x7f1f660df76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226


Original issue's description:
> Add VideoFrameRecorder for use recording test frame sequences.
> 
> This will be used to record representative frame sequences for performance evaluation of the new VP9 encoder.
> 
> BUG=260879
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279795

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=260879

Review URL: https://codereview.chromium.org/350903003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279805 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Aug 11, 2014
Revert of Adding WaitForIncomingMethodCall for InterfacePtr (https://…
81b786c 
…codereview.chromium.org/341193006/)

Reason for revert:
ASan build failed with mojo in the callstack, and the implicated call ReadAllAvailableMessages was introduced in this CL.

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/4229/steps/browser_tests/logs/stdio

==32447==ERROR: AddressSanitizer: heap-use-after-free on address 0x611000024ae8 at pc 0x64ea589 bp 0x7fffc974d810 sp 0x7fffc974d808
READ of size 1 at 0x611000024ae8 thread T0 (browser_tests)
#0 0x64ea588 in mojo::internal::Connector::ReadAllAvailableMessages() mojo/public/cpp/bindings/lib/connector.cc:165
#1 0xe30a3ee in Run base/callback.h:441
#2 0xe30a3ee in mojo::common::HandleWatcher::State::OnHandleReady(int) mojo/common/handle_watcher.cc:278
#3 0x38890c8 in Run base/callback.h:441
#4 0x38890c8 in MakeItSo base/bind_internal.h:871


Original issue's description:
> Adding WaitForIncomingMethodCall for InterfacePtr
> 
> BUG=386485
> [email protected]
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280069

[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=386485

Review URL: https://codereview.chromium.org/341993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280077 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Aug 11, 2014
Revert 280400 "Creation of a new and improved object for the cac..."
ccf2515 
Seems to have introduced leaks:
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/3527/steps/net_unittests/logs/stdio

For example:

Direct leak of 112 byte(s) in 1 object(s) allocated from:
#0 0x5166cb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
#1 0x16ce6be in MockDiskCache::CreateEntry(std::string const&, disk_cache::Entry**, base::Callback<void (int)> const&) net/http/mock_http_cache.cc:408
#2 0x37654a7 in DoCreate net/http/disk_based_cert_cache.cc:187
#3 0x37654a7 in net::DiskBasedCertCache::WriteWorker::DoLoop(int) net/http/disk_based_cert_cache.cc:158
#4 0x3768f23 in Start net/http/disk_based_cert_cache.cc:125
#5 0x3768f23 in net::DiskBasedCertCache::Set(CERTCertificateStr*, base::Callback<void (std::string const&)> const&) net/http/disk_based_cert_cache.cc:533
#6 0x10d0ffa in net::DiskBasedCertCache_SyncSet_Test::TestBody() net/http/disk_based_cert_cache_unittest.cc:231
#7 0x33ce728 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2045
#8 0x33ce728 in testing::Test::Run() testing/gtest/src/gtest.cc:2061
#9 0x33d0f09 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
#10 0x33d1c96 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
#11 0x33e4daa in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
#12 0x33e43e0 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
#13 0x33e43e0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
#14 0x40a6d1c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
#15 0x40a6d1c in base::TestSuite::Run() base/test/test_suite.cc:227
#16 0x409b4e2 in Run base/callback.h:401
#17 0x409b4e2 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498
#18 0x409ae5d in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553
#19 0x2b986cc in main net/test/run_all_unittests.cc:64
#20 0x7fc4683a976c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226


> Creation of a new and improved object for the caching of certificate objects on disk.
> 
> Review URL: https://codereview.chromium.org/329733002

[email protected]

Review URL: https://codereview.chromium.org/349533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280492 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Aug 11, 2014
Revert 281304 "Pass an instance of FaviconClient to FaviconService."
6a2848c 
Broke the Linux ASan LSan Test(2) bot

Direct leak of 16 byte(s) in 1 object(s) allocated from:
    #0 0x5ac35b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
    #1 0x1df3a96 in (anonymous namespace)::BuildFaviconService(content::BrowserContext*) chrome/browser/favicon/favicon_handler_unittest.cc:1408
    #2 0xf2c3cc0 in BrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) components/keyed_service/content/browser_context_keyed_service_factory.cc:88
    #3 0x549067a in FaviconServiceFactory::GetForProfile(Profile*, Profile::ServiceAccessType) chrome/browser/favicon/favicon_service_factory.cc:25
    #4 0x1df00f4 in (anonymous namespace)::FaviconHandlerTest_UnableToDownloadFavicon_Test::TestBody() chrome/browser/favicon/favicon_handler_unittest.cc:1432
    #5 0x6cc96f8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
    #6 0x6cc96f8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061
    #7 0x6ccbed9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #8 0x6cccc66 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #9 0x6cdfd7a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    #10 0x6cdf3b0 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    #11 0x6cdf3b0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #12 0x1021320c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #13 0x1021320c in base::TestSuite::Run() base/test/test_suite.cc:227
    #14 0x1020a9d2 in Run base/callback.h:401
    #15 0x1020a9d2 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498
    #16 0x1020a34d in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:553
    #17 0x6df1bee in main chrome/test/base/run_all_unittests.cc:15
    #18 0x7f93160dc76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226


> Pass an instance of FaviconClient to FaviconService.
> 
> This is an intermediary CL where the FaviconClient is not used by the FaviconService.
> Subsequent CLs will start using the FaviconClient in the FaviconService to abstract usage of chrome/ code.
> 
> BUG=377505
> 
> Review URL: https://codereview.chromium.org/302433010

[email protected]

Review URL: https://codereview.chromium.org/370663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281309 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Aug 11, 2014
Revert 281292 "Tests added for user-listing on sign-in screen."
9474e3f 
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2108

=================================================================
==16633==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 544 byte(s) in 2 object(s) allocated from:
    #0 0x5cd9bb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
    #1 0x104eb1b7 in chromeos::User::CreateRegularUser(std::string const&) chrome/browser/chromeos/login/users/user.cc:169
    #2 0x767d3e3 in chromeos::FakeUserManager::AddUser(std::string const&) chrome/browser/chromeos/login/users/fake_user_manager.cc:37
    #3 0x5129ae7 in chromeos::SigninPrepareUserListTest::SetUp() chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc:56
    #4 0x76070b1 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045


> Tests added for user-listing on sign-in screen.
> 
> BUG=353936
> 
> Review URL: https://codereview.chromium.org/369833002

[email protected]

Review URL: https://codereview.chromium.org/370583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281340 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Aug 11, 2014
Revert of Fix Windows logoff race. (https://codereview.chromium.org/3…
db248c5 
…49263004/)

Reason for revert:
Suspected as cause of browser_tests failures on Mac10.7 Tests:

http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%283%29/builds/28572

ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #1):
[ RUN      ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession
[10963:519:0708/084058:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession()
../../chrome/browser/profiles/profile_browsertest.cc:365: Failure
Value of: "SessionEnded"
Expected: GetExitTypePreferenceFromDisk(profile)
Which is: "Crashed"
[  FAILED  ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam =  and GetParam() =  (780 ms)

ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #2):
[ RUN      ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession
[12926:519:0708/084834:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession()
../../chrome/browser/profiles/profile_browsertest.cc:365: Failure
Value of: "SessionEnded"
Expected: GetExitTypePreferenceFromDisk(profile)
Which is: "Crashed"
[  FAILED  ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam =  and GetParam() =  (639 ms)

ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #3):
[ RUN      ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession
[12935:519:0708/084836:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession()
../../chrome/browser/profiles/profile_browsertest.cc:365: Failure
Value of: "SessionEnded"
Expected: GetExitTypePreferenceFromDisk(profile)
Which is: "Crashed"
[  FAILED  ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam =  and GetParam() =  (551 ms)

ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession (run #4):
[ RUN      ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession
[12937:519:0708/084837:ERROR:browser_process_impl.cc(495)] Not implemented reached in virtual void BrowserProcessImpl::EndSession()
../../chrome/browser/profiles/profile_browsertest.cc:365: Failure
Value of: "SessionEnded"
Expected: GetExitTypePreferenceFromDisk(profile)
Which is: "Crashed"
[  FAILED  ] ProfileBrowserTest.WritesProfilesSynchronouslyOnEndSession, where TypeParam =  and GetParam() =  (560 ms)

Original issue's description:
> Fix Windows logoff race by posting a sentinel task to each taskrunner used to save state, and blocking on the completion of all sentinels.
> De-flake and re-enable ProfileBrowserTests, by not running the tasks queued to initialize Bookmarks. This caused test failures when the delayed initialization managed to run.
> This depends on https://codereview.chromium.org/370323002/, which fixes a BookmarkStorage lifetime issue, and https://codereview.chromium.org/375683002/ which annotates a remaining leak.
> 
> [email protected], [email protected]
> 
> [email protected], gab=chromium.org, [email protected]
> BUG=386126, 141141, 141517, 142787, 140882, 165760, 163713, 391508
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281746

TBR=siggi
BUG=392186
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/378863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281766 0039d316-1c4b-4281-b951-d872f2087c98
rakuco pushed a commit that referenced this pull request Aug 11, 2014
Revert of Fixed use-after-free in LoadCallback in bookmark_storage.cc (…
047a44d 
…https://codereview.chromium.org/373153002/)

Reason for revert:
Causing memory leaks:

Indirect leak of 328 byte(s) in 1 object(s) allocated from:
    #0 0x515feb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55
    #1 0xc334cfb in BookmarkModel::CreatePermanentNode(BookmarkNode::Type) components/bookmarks/browser/bookmark_model.cc:910
    #2 0xc326772 in BookmarkModel::CreateLoadDetails(std::string const&) components/bookmarks/browser/bookmark_model.cc:1006
    #3 0xc326553 in BookmarkModel::Load(PrefService*, std::string const&, base::FilePath const&, scoped_refptr\u003Cbase::SequencedTaskRunner> const&, scoped_refptr\u003Cbase::SequencedTaskRunner> const&) components/bookmarks/browser/bookmark_model.cc:151
    #4 0x232a4d7 in BookmarkModelFactory::BuildServiceInstanceFor(content::BrowserContext*) const chrome/browser/bookmarks/bookmark_model_factory.cc:65
    #5 0xc0bc85f in BrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) components/keyed_service/content/browser_context_keyed_service_factory.cc:91
    #6 0x260de89 in ProfileImpl::DoFinalInit() chrome/browser/profiles/profile_impl.cc:657
    #7 0x260beb5 in ProfileImpl::OnPrefsLoaded(bool) chrome/browser/profiles/profile_impl.cc:881
    #8 0x260ae3e in ProfileImpl::ProfileImpl(base::FilePath const&, Profile::Delegate*, Profile::CreateMode, base::SequencedTaskRunner*) chrome/browser/profiles/profile_impl.cc:492
    #9 0x2608ddb in Profile::CreateProfile(base::FilePath const&, Profile::Delegate*, Profile::CreateMode) chrome/browser/profiles/profile_impl.cc:297
    #10 0x18de165 in ProfileBrowserTest::CreateProfile(base::FilePath const&, Profile::Delegate*, Profile::CreateMode) chrome/browser/profiles/profile_browsertest.cc:106
    #11 0x18df8f8 in ProfileBrowserTest_CreateOldProfileSynchronous_Test::RunTestOnMainThread() chrome/browser/profiles/profile_browsertest.cc:153
    #12 0x33f5434 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:427
    #13 0x2e6ca18 in Run base/callback.h:401
    #14 0x2e6ca18 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1548
    #15 0x2e69666 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:975
    #16 0x59381d7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:694
    #17 0x5c8f207 in Run base/callback.h:401
    #18 0x5c8f207 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45
    #19 0x59342e0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:594
    #20 0x5e8a153 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106
    #21 0xf0228a0 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22
    #22 0xef6cbc4 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:763
    #23 0xef69d3f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19
    #24 0xcf5b57f in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:253
    #25 0x33f2563 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:210
    #26 0x3e81941 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
    #27 0x3e81941 in testing::Test::Run() testing/gtest/src/gtest.cc:2057
    #28 0x3e83cd9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #29 0x3e84a66 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #30 0x3e97b7a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    #31 0x3e971b0 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    #32 0x3e971b0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #33 0x359557c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #34 0x359557c in base::TestSuite::Run() base/test/test_suite.cc:227



Original issue's description:
> Fixed use-after-free in LoadCallback in bookmark_storage.cc
> 
> BookmarkStorage isn't ref counted anymore since
> https://codereview.chromium.org/370323002, and the LoadCallback() task
> now gets a WeakPtr to the owning BookmarkStorage. However, it gets a
> raw pointer to the BookmarkLoadDetails object, which is still owned
> by BookmarkStorage and may have been destroyed when the background
> task runs.
> 
> This happened on iOS tests after a recent merge.
> 
> [email protected]
> BUG=165760
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281830

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=165760

Review URL: https://codereview.chromium.org/379643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281843 0039d316-1c4b-4281-b951-d872f2087c98
darktears pushed a commit that referenced this pull request Sep 30, 2014
@madsager
Revert of EventSender: Added checks for missing arguments (patchset #4 …
f70f5fb 
…id:60001 of https://codereview.chromium.org/584203003/)

Reason for revert:
This makes the fast/events/hit-test-counts.html layout test fail. Reverting for now.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fevents%2Fhit-test-counts.html&testType=layout-tests

Original issue's description:
> Added checks for missing arguments in event_sender.cc. Also simplified the uses of x & y in EventSender::GestureEvent.
>
> BUG=415970
>
> Committed: https://crrev.com/302907463636d2ddfe25c5381bd1f2b64016d1c6
> Cr-Commit-Position: refs/heads/master@{#296256}

[email protected],[email protected],[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=415970

Review URL: https://codereview.chromium.org/600733002

Cr-Commit-Position: refs/heads/master@{#296357}
darktears pushed a commit that referenced this pull request Sep 30, 2014
Revert of PPAPI: Never re-enter JavaScript for PostMessage. (patchset #4
50c6f1a 
 id:60001 of https://codereview.chromium.org/589213003/)

Reason for revert:
May be crashing Chrome:
https://code.google.com/p/chromium/issues/detail?id=417511

Original issue's description:
> PPAPI: Never re-enter JavaScript for PostMessage.
>
> Blocking renderer->plugin messages can be interrupted by any message
> from the plugin->renderer (even async ones). So while handline a blocking
> message, such as HandleInputEvent or HandleBlockingMessage, it's currently
> possible to re-enter JavaScript. This patch makes that impossible by
> queueing up Plugin->Renderer messages sent via PPB_Messaging::PostMessage
> while any renderer->plugin sync message is on the stack.
>
> BUG=384528
>
> Committed: https://crrev.com/f73075c99b5ba30e8d62dc5f13fdfb210d0fc506
> Cr-Commit-Position: refs/heads/master@{#296311}

[email protected],[email protected]
NOTREECHECKS=true
NOTRY=true
BUG=384528

Review URL: https://codereview.chromium.org/601923003

Cr-Commit-Position: refs/heads/master@{#296571}
darktears pushed a commit that referenced this pull request Oct 6, 2014
Disable the scoped handle verifier (and close hook) for M-39
c8d8751 
To be merged on 2171.

BUG=418816
[email protected]
[email protected]

Review URL: https://codereview.chromium.org/616713002

Cr-Commit-Position: refs/heads/master@{#297319}
(cherry picked from commit 20d9928)

Review URL: https://codereview.chromium.org/618543002

Cr-Commit-Position: refs/branch-heads/2171@{#4}
Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco pushed a commit that referenced this pull request Oct 13, 2014
Incrementing VERSION to 39.0.2171.19
4d02448 
Cr-Commit-Position: refs/branch-heads/2171_13@{#4}
Cr-Branched-From: 89f3116-refs/branch-heads/2171@{#63}
Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
@pozdnyakov pozdnyakov mentioned this pull request Jan 14, 2015
Merged
rakuco pushed a commit that referenced this pull request Jan 26, 2015
Incrementing VERSION to 41.0.2272.4
1b9b4a9 
Cr-Commit-Position: refs/branch-heads/2272@{#4}
Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco pushed a commit that referenced this pull request Mar 2, 2015
@mrdewitt
Revert of HID-detection screen moved to screenContext. (patchset #7 i…
2ad7324 
…d:120001 of https://codereview.chromium.org/898453002/)

Reason for revert:
I believe this is causing interactive_ui_tests failures:

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29

LoginUITest.OobeCatchException
LoginUITest.OobeNoExceptions

LoginUITest.OobeCatchException (run #4):
[ RUN      ] LoginUITest.OobeCatchException
[1:1:0211/103529:ERROR:memory_mapped_file.cc(42)] Couldn't open /tmp/run_tha_testo_ZzaC/out/Debug/chrome_200_percent.pak
[1:1:0211/103529:ERROR:data_pack.cc(78)] Failed to mmap datapack
[31306:31306:0211/103529:INFO:audio_manager_pulse.cc(258)] Failed to connect to the context.  Error: Connection refused
[31306:31306:0211/103529:ERROR:memory_mapped_file.cc(42)] Couldn't open /tmp/run_tha_testo_ZzaC/out/Debug/chrome_200_percent.pak
[31306:31306:0211/103529:ERROR:data_pack.cc(78)] Failed to mmap datapack
Xlib:  extension "RANDR" missing on display ":9".
[31306:31306:0211/103529:WARNING:child_account_service.cc(322)] User instance wasn't found while setting child account flag.
[31306:31306:0211/103529:WARNING:data_reduction_proxy_settings.cc(366)] SPDY proxy OFF at startup
[31306:31306:0211/103529:ERROR:hid_detection_screen_handler.cc(35)] HIDDetectionScreenHandler::HIDDetectionScreenHandler
[31306:31306:0211/103529:ERROR:hid_detection_screen_handler.cc(79)] HIDDetectionScreenHandler::CheckIsScreenRequired 0x325bf0183920
[31306:31324:0211/103529:WARNING:freezer_cgroup_process_manager.cc(58)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
../../chrome/browser/chromeos/login/test/js_checker.cc:62: Failure
Value of: GetBool(expression)
  Actual: false
Expected: true
cr.ErrorStore.getInstance().length == 0
../../chrome/browser/chromeos/login/test/js_checker.cc:62: Failure
Value of: GetBool(expression)
  Actual: false
Expected: true
cr.ErrorStore.getInstance().length == 1
../../chrome/browser/chromeos/login/test/js_checker.cc:62: Failure
Value of: GetBool(expression)
  Actual: false
Expected: true
cr.ErrorStore.getInstance().length == 2
[7:8:0211/103533:WARNING:channel.cc(547)] Failed to send message to ack remove remote endpoint (local ID 1, remote ID 1)
[7:8:0211/103533:WARNING:channel.cc(547)] Failed to send message to ack remove remote endpoint (local ID 2147483648, remote ID 2)
[  FAILED  ] LoginUITest.OobeCatchException, where TypeParam =  and GetParam() =  (4704 ms)

Original issue's description:
> HID-detection screen moved to screenContext.
>
> BUG=433797
>
> Committed: https://crrev.com/cc4feaa0828ee6d58c6a3eecf67e9d6bf72588a7
> Cr-Commit-Position: refs/heads/master@{#315788}

[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=433797

Review URL: https://codereview.chromium.org/915133002

Cr-Commit-Position: refs/heads/master@{#315804}
rakuco pushed a commit that referenced this pull request Mar 2, 2015
@jbauman2
Revert of Use Surfaces on Windows, Linux, and Mac OS (try #4) (patchset
684903a 
#6 id:100001 of https://codereview.chromium.org/869233008/)

Reason for revert:
Possibly caused issues on Win WebGL debug:
http://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/26853
BUG=457685

Original issue's description:
> Use Surfaces on Windows, Linux, and Mac OS (try #4)
>
> Surfaces should be feature-complete, so try enabling them on Windows, Linux, and Mac OS. They're still disabled on Chrome OS because they rely on single-threaded browser compositing, and on Android because they haven't been implemented there yet.
>
> BUG=334090
> [email protected]
>
> Committed: https://crrev.com/951a985779ceb581576c8b3c0f83223ea3689dd0
> Cr-Commit-Position: refs/heads/master@{#315682}

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=334090

Review URL: https://codereview.chromium.org/917913002

Cr-Commit-Position: refs/heads/master@{#315831}
rakuco pushed a commit that referenced this pull request Mar 2, 2015
@quisquous
Revert of cc: Make PaintedScrollbarLayer not use ContentsScalingLayer…
8e7bf27 
… (patchset #4 id:60001 of https://codereview.chromium.org/913133004/)

Reason for revert:
Causes DCHECKs in layout tests.

Original issue's description:
> cc: Make PaintedScrollbarLayer not use ContentsScalingLayer
>
> ContentsScalingLayer depends on the main thread running calculate draw
> properties and updating contents scale and content bounds.  In order to
> switch to using property trees (which don't currently calculate these
> values), PaintedScrollbarLayer needs to calculate contents scale
> internally.
>
> This also moves towards removing ContentsScalingLayer (currently also
> used by TiledLayer and HeadsUpDisplayLayer), which once it's gone will
> allow contents scale and content bounds to removed entirely from Layer
> and LayerImpl.
>
> Committed: https://crrev.com/a499bbb66f29815ae0cef3eaa62ee2b3d3526d04
> Cr-Commit-Position: refs/heads/master@{#316088}

[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/913393004

Cr-Commit-Position: refs/heads/master@{#316089}
rakuco pushed a commit that referenced this pull request Mar 2, 2015
Revert of Fix for Incomplete context menu is shown on pdf files and r…
f3d747c 
…eload,back,forward options are missing (patchset #4 id:60001 of https://codereview.chromium.org/913663002/)

Reason for revert:
This caused http://code.google.com/p/chromium/issues/detail?id=458927 . There is a followup CL: https://codereview.chromium.org/931073002/ which almost does a revert of this anyway. So I'm reverting here just to be safe and make sure this doesn't make its way to a branch.

Original issue's description:
> Fix for incomplete context menu in pdf page.
>
> when we are viewing the PDF in a MimeHandlerViewGuest then we should
> use its embedder WebContents.
> Changes done to use the embedder WebContents if we have guest view.
>
> BUG=449919
>
> Committed: https://crrev.com/0c6616522ca22a77e444c4b4f57b3b71baf30cdb
> Cr-Commit-Position: refs/heads/master@{#316187}

[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=449919

Review URL: https://codereview.chromium.org/935863002

Cr-Commit-Position: refs/heads/master@{#316714}
rakuco pushed a commit that referenced this pull request Mar 2, 2015
@dtsengchromium
Reland #4: Ensure WebView notifies desktop automation on creation, de…
47cb3b3 
…struction, and change

Previous attempts:
https://codereview.chromium.org/880063002
https://codereview.chromium.org/895623003/
https://codereview.chromium.org/890013006/
https://codereview.chromium.org/907973004/

This latest attempt removes the logic that reloads ChromeVox at the beginning of a test.

Locally, under extremely heavy load, tests progressively ran slowe. The same copy of a test ran 1 second slower than a previous copy. Ultimately, this led to a timeout.

With the above change, this no longer occurs and hopefully fixes the flakeyness.

Change is located in chromevox_e2e_test_base.js.

[email protected]

Review URL: https://codereview.chromium.org/940763002

Cr-Commit-Position: refs/heads/master@{#316950}
rakuco pushed a commit that referenced this pull request Mar 2, 2015
@dtsengchromium
Revert of Reland #4: Ensure WebView notifies desktop automation on cr…
f8476d3 
…eation, (patchset #1 id:1 of https://codereview.chromium.org/940763002/)

Reason for revert:
Still flakes on bots.

Original issue's description:
> Reland #4: Ensure WebView notifies desktop automation on creation, destruction, and change
>
> Previous attempts:
> https://codereview.chromium.org/880063002
> https://codereview.chromium.org/895623003/
> https://codereview.chromium.org/890013006/
> https://codereview.chromium.org/907973004/
>
> This latest attempt removes the logic that reloads ChromeVox at the beginning of a test.
>
> Locally, under extremely heavy load, tests progressively ran slowe. The same copy of a test ran 1 second slower than a previous copy. Ultimately, this led to a timeout.
>
> With the above change, this no longer occurs and hopefully fixes the flakeyness.
>
> Change is located in chromevox_e2e_test_base.js.
>
> [email protected]
>
> Committed: https://crrev.com/47cb3b3798d325f3083565a05a2dcdaee117c296
> Cr-Commit-Position: refs/heads/master@{#316950}

[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/939853003

Cr-Commit-Position: refs/heads/master@{#316971}
rakuco pushed a commit that referenced this pull request Mar 2, 2015
@rdcronin
Revert of Handle RenderProcessHostImpl::SetBackgrounded on Windows (p…
126d77b 
…atchset #4 id:60001 of https://codereview.chromium.org/926663002/)

Reason for revert:
This patch set re-enabled ChromeRenderProcessHostTest.Backgrounding, which is now failing on XP bots.

Example logs:
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/35740/steps/browser_tests%20on%20Windows-XP-SP3/logs/ChromeRenderProcessHostTest.Backgrounding
https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/35740/steps/browser_tests%20on%20Windows-XP-SP3/logs/ChromeRenderProcessHostTest.Backgrounding

Original issue's description:
> Handle RenderProcessHostImpl::SetBackgrounded on Windows
>
> This was disabled on Windows because:
>
>  - http://crrev.com/274071 made it such that it was asynchronous via the renderer (as only
> the process itself can set itself in background mode on Windows).
>
>  - And then this was removed for Windows as part of issue 381820 as true background mode on
> Windows was achieved by having the renderer itself change its process priority (which
> doesn't work as the unbackgrounding request can be stuck behind other priority tasks
> running in background mode).
>
> Also, the test for this was disabled in between (see issue 394368) -- the asynchronicity
> introduced in r274071 probably causing the flakes.
>
> Overall there is no need to have the renderer enter PROCESS_MODE_BACKGROUND_BEGIN itself,
> IDLE_PRIORITY_CLASS should be sufficient as its the same as far as CPU priority is
> concerned and IO is irrelevant in the renderers.
>
> Thus we can get background mode for hidden renderers without running into issue 381820.
>
> Experiment with IDLE_PRIORITY_CLASS/BELOW_NORMAL_PRIORITY_CLASS vs the status quo.
>
> Watching the relevant perf bots (tab_switching.top_10 -> MPArch.RWH_TabSwitchPaintDuration)
> and UMA metrics MPArch.RWH_TabSwitchPaintDuration which shouldn't regress.
> And others (e.g., SessionRestore related) which will hopefully improve.
>
> Enable the experiment by default in the absence of Finch to get perf waterfall coverage.
>
> The experiment will be called "BackgroundRendererProcesses" and have 4 groups:
>  ["Disallow", "AllowBelowNormalFromBrowser",
>   "AllowIdleFromBrowser", "AllowBackgroundModeFromRenderer"]
>
> It will be a per-session (rather than per-profile) experiment, randomly assigning a user
> to a group every new Chrome session.
>
> BUG=394368, 458594
>
> Committed: https://crrev.com/aaf738a2cce69ce952386b48e3bc252bd307ef43
> Cr-Commit-Position: refs/heads/master@{#317042}

[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=394368, 458594

Review URL: https://codereview.chromium.org/940993002

Cr-Commit-Position: refs/heads/master@{#317070}
rakuco pushed a commit that referenced this pull request Mar 2, 2015
Revert of Make sure MessagePortService is used in a thread safe manne…
60583ad 
…r. (patchset #4 id:80001 of https://codereview.chromium.org/937503003/)

Reason for revert:
This CL is suspected to cause the Win7 test (dbg) failures.

Original issue's description:
> Added DCHECKs to all public methods of MessagePortService to make sure it is used in a thread safe manner.
>
> BUG=459115
>
> Committed: https://crrev.com/c2d9552dde5a7dd05dc63e744c71f497f0120306
> Cr-Commit-Position: refs/heads/master@{#317178}

[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459115

Review URL: https://codereview.chromium.org/942583005

Cr-Commit-Position: refs/heads/master@{#317299}
rakuco pushed a commit that referenced this pull request Mar 2, 2015
Revert of Revert of Make sure MessagePortService is used in a thread …
721247d 
…safe manner. (patchset #1 id:1 of https://codereview.chromium.org/942583005/)

Reason for revert:
This does not seem to cause the problem.

Original issue's description:
> Revert of Make sure MessagePortService is used in a thread safe manner. (patchset #4 id:80001 of https://codereview.chromium.org/937503003/)
>
> Reason for revert:
> This CL is suspected to cause the Win7 test (dbg) failures.
>
> Original issue's description:
> > Added DCHECKs to all public methods of MessagePortService to make sure it is used in a thread safe manner.
> >
> > BUG=459115
> >
> > Committed: https://crrev.com/c2d9552dde5a7dd05dc63e744c71f497f0120306
> > Cr-Commit-Position: refs/heads/master@{#317178}
>
> [email protected],[email protected]
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=459115
>
> Committed: https://crrev.com/60583adc54a6b043dc0b812f10869801eb0da0b4
> Cr-Commit-Position: refs/heads/master@{#317299}

[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459115

Review URL: https://codereview.chromium.org/947483002

Cr-Commit-Position: refs/heads/master@{#317312}
rakuco pushed a commit that referenced this pull request Mar 2, 2015
Incrementing VERSION to 42.0.2311.4
f3d6206 
Cr-Commit-Position: refs/branch-heads/2311@{#4}
Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
darktears pushed a commit that referenced this pull request Mar 25, 2015
Revert of Move Extension ScriptContext creation into ScriptContextSet…
77b0411 
…. (patchset #4 id:60001 of https://codereview.chromium.org/995283004/)

Reason for revert:
Memory failure in ScriptContextTest.GinRunnerLifetime.

Original issue's description:
> Move Extension ScriptContext creation into ScriptContextSet.
>
> Previously extensions::Dispatcher was responsible for creating ScriptContexts
> then Adding them to its ScriptContextSet. Now, ScriptContextSet creates them
> itself. This prepares the Extension system for later changing to lazily or
> asynchronously creating ScriptContexts.
>
> BUG=466373
> [email protected]
>
> Committed: https://crrev.com/75605c7fca774b95984ba67f70ba86bb5750c0f6
> Cr-Commit-Position: refs/heads/master@{#320602}
>
> Committed: https://crrev.com/52f4caf6d01302ebf42136b42fa77d1c67d93ae9
> Cr-Commit-Position: refs/heads/master@{#320770}

[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=466373

Review URL: https://codereview.chromium.org/1013823003

Cr-Commit-Position: refs/heads/master@{#320794}
darktears pushed a commit that referenced this pull request Mar 25, 2015
@tapted
Revert of Enable toolkit_views=1 by default on Mac (patchset #4 id:21…
c3bdb1c 
…0001 of https://codereview.chromium.org/984513002/)

Reason for revert:
Failing on GN build :(.

Link: http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/5288

E.g. display_change_listener_aura.cc:38:43:error: member access into incomplete type 'NSView'

Original issue's description:
> Enable toolkit_views=1 by default on Mac
>
> As announced on chromium-dev: http://goo.gl/NqrmLk (and after
> discussions with chrome-eng-review).
>
> This CL shouldn't change any user-visible UI, just change the way Chrome
> is built on Mac. Soon, we will explore running ui/app_list/views/ on Mac
> rather than the (outdated) ui/app_list/cocoa/.
>
> A ~0.43% sizes regression on Mac is expected with this CL (~652kB
> uncompressed). Full details in a doc: http://goo.gl/oHucmf
>
> With this change, toolkit-views test cases in interactive_ui_tests will
> start running on bots. views_unittests will be added to the Mac bots in
> a follow-up.
>
> BUG=363529
>
> Committed: https://crrev.com/c11ec57849fd579c7a5559413488c018ea532311
> Cr-Commit-Position: refs/heads/master@{#321075}

[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=363529

Review URL: https://codereview.chromium.org/1011363002

Cr-Commit-Position: refs/heads/master@{#321079}
darktears pushed a commit that referenced this pull request Mar 25, 2015
@Steelskin
Revert of Added EventSender.setTouchPointRadius() for layoutTests (pa…
74b2e39 
…tchset #4 id:60001 of https://codereview.chromium.org/990183003/)

Reason for revert:
Layout tests failures, see crbug/468704

Original issue's description:
> Added EventSender.setTouchPointRadius() for layoutTests
>
> A link to the Blink patch (layoutTests) https://codereview.chromium.org/990193002/
>
> BUG=
>
> Committed: https://crrev.com/97a6dbc41736e484f1b5ad544f68f8d34013179b
> Cr-Commit-Position: refs/heads/master@{#321167}

[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=468704

Review URL: https://codereview.chromium.org/1011383006

Cr-Commit-Position: refs/heads/master@{#321335}
darktears pushed a commit that referenced this pull request Mar 25, 2015
@lucasgadani
Revert of Add RoutingIDIssuer to help track routing id issues. (patch…
052af41 
…set #4 id:60001 of https://codereview.chromium.org/999193003/)

Reason for revert:
We've already collected enough data to triage this bug.

Original issue's description:
> This is a re-land of https://codereview.chromium.org/643733002.
>
> This CL adds a RoutingIDIssuer that verifies that the routing IDs are being sent to the correct process.
>
> BUG=464633
> [email protected]
>
> Committed: https://crrev.com/5ae65efdfd51de794fb544195fad271dd90ff0b1
> Cr-Commit-Position: refs/heads/master@{#320207}

[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464633

Review URL: https://codereview.chromium.org/1019913002

Cr-Commit-Position: refs/heads/master@{#321380}
darktears pushed a commit that referenced this pull request Mar 25, 2015
@pavelfeldman
Revert of Python readability review for dbeam@. (patchset #4 id:28000…
1372da2 
…1 of https://codereview.chromium.org/476453002/)

Reason for revert:
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Full&number=22183

Original issue's description:
> Python readability review for dbeam@.
>
> [email protected]
>
> Committed: https://crrev.com/c5503ce046fdad8c76129c0061f0d6011c2fe92b
> Cr-Commit-Position: refs/heads/master@{#321693}

[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1023253003

Cr-Commit-Position: refs/heads/master@{#321701}
darktears pushed a commit that referenced this pull request Mar 25, 2015
@tkent-google
Revert of Add DCHECKS() for current thread in ChildProcessLauncher (p…
dd53cf7 
…atchset #4 id:60001 of https://codereview.chromium.org/1002853003/)

Reason for revert:
Broke linux_blink_rel try bots.

http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53723/steps/webkit_tests%20%28with%20patch%29/logs/stdio
> [20222:20222:0322/165944:1212144529:FATAL:child_process_launcher.cc(508)] Check failed: ::content::BrowserThread::CurrentlyOn(client_thread_id_). Must be called on Chrome_UIThread; actually called on CrBrowserMain.

Original issue's description:
> Add DCHECKS() for current thread in ChildProcessLauncher
>
> And rename some functions to indicate when they don't run
> on the default (client) thread.
>
> This avoids misuse and makes it more obvious what threads we are on
> given that this involves multiple threads (launcher thread, and
> different client threads for renderers and other children - former
> calls from UI thread, the latter from IO thread -
> plus there are some Android quirks).
>
> BUG=469248
>
> Committed: https://crrev.com/8efc3b5a5e7b24ffeed0e5576a725b77868eb9ab
> Cr-Commit-Position: refs/heads/master@{#321648}

[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=469248

Review URL: https://codereview.chromium.org/1025923002

Cr-Commit-Position: refs/heads/master@{#321723}
darktears pushed a commit that referenced this pull request Mar 25, 2015
@a1ph
Revert of ServiceWorker: Support includeUncontrolled option in client…
dec2cd6 
…s.matchAll() (1/2, chromium) (patchset #4 id:120001 of https://codereview.chromium.org/1007133002/)

Reason for revert:
Broke http/tests/serviceworker/chromium/clients-openwindow.html
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/45800

Original issue's description:
> ServiceWorker: Support includeUncontrolled option in clients.matchAll() (1/2, chromium)
>
> * Add SWContextCore::GetProviderHostByClientID() method
> * Add SWContextCore::GetProviderHostIterator() which takes predicate
> * Make ServiceWorkerVersion::OnGetClients return uncontrolled host when specified
> * Make ServiceWorkerVersion::On{PostMessage,Focus} work for uncontrolled hosts
>   (i.e. now ServiceWorker can have clients that are not controlled by it)
>
> Spec links:
> https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#serviceworker-client-query-options-dictionary
> https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#clients-getall
>
> 1/2: THIS PATCH
> 2/2: blink patch (layout tests will be added here)
>
> BUG=460415
> TEST=ServiceWorkerContextTest.GetProviderHostIterator
> TEST=layout tests will be added later
>
> Committed: https://crrev.com/04848e8f57c823b674b0a3e03047e281fae44bfd
> Cr-Commit-Position: refs/heads/master@{#321722}

[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460415

Review URL: https://codereview.chromium.org/1024383003

Cr-Commit-Position: refs/heads/master@{#321749}
rakuco pushed a commit that referenced this pull request Jun 8, 2015
Fix the System Profile to not load extensions. It could otherwise be …
a515307 
…forced to by GPO.

A few releases ago I introduced a System Profile to back the User Manager (https://codereview.chromium.org/847733005). This profile, however, is causing some problems. I'm trying to reduce those by making clearer the contract of what it's for: A profile that doesn't take a browser window, has no extensions, writes little to disk, etc.

This certainly addresses issue #4 raised within the bug, and address the other issues as well (I can't repro them). This CL generally hardens Chrome for the System Profile in a lot of the same ways we do the Guest Profile.

BUG=482176
[email protected]

Review URL: https://codereview.chromium.org/1129293002

Cr-Commit-Position: refs/heads/master@{#331276}
(cherry picked from commit 7831f57)

Review URL: https://codereview.chromium.org/1157273006

Cr-Commit-Position: refs/branch-heads/2403@{#116}
Cr-Branched-From: f54b809-refs/heads/master@{#330231}
PeterWangIntel pushed a commit to PeterWangIntel/chromium-crosswalk that referenced this pull request Dec 21, 2015
Merge pull request crosswalk-project#4 from PeterWangIntel/geo
44d7fd3 
To disable Web Geolocations&Geofencing
smishenk pushed a commit to smishenk/chromium-crosswalk that referenced this pull request Apr 29, 2016
@galmacky
Fix possible out-of-range access in setComposingText().
441969f 
The previous code assumed that BaseInputConnection.setComposingText replaces
the current "selection" with the given text, but what it does actually is to
replace the "composing span" if any. This CL adds the consistency to it.

BUG=578762
TEST=build/android/test_runner.py instrumentation --test-apk=ContentShellTest \
  --isolate-file-path content/content_shell_test_apk.isolate --release -vv -f \
  'ImeTest#test*WithDifferentCursorPositions'

Review URL: https://codereview.chromium.org/1594323003

Cr-Commit-Position: refs/heads/master@{#370067}
(cherry picked from commit f4d0e6b)

Review URL: https://codereview.chromium.org/1605623003 .

Cr-Commit-Position: refs/branch-heads/2623@{crosswalk-project#4}
Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
fujunwei pushed a commit to fujunwei/chromium-crosswalk that referenced this pull request May 27, 2016
Fix compile issue, missing override.
4d8599e 
[email protected]
BUG=none

Review URL: https://codereview.chromium.org/1444963003

Cr-Commit-Position: refs/heads/master@{#359783}
(cherry picked from commit f20a5c5)

Review URL: https://codereview.chromium.org/1447913002 .

Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#4}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
fujunwei pushed a commit to fujunwei/chromium-crosswalk that referenced this pull request Jun 28, 2016
Check if asyncparams is null for document mode UI initialization
6eff6f8 
The if statement checks for the tabtobereparented to be null
without checking the params itself.

BUG=590637

Review URL: https://codereview.chromium.org/1746933002

(cherry picked from commit 12b7f87)

Cr-Original-Commit-Position: refs/heads/master@{#378249}
Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#4}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
fujunwei pushed a commit to fujunwei/chromium-crosswalk that referenced this pull request Jun 28, 2016
@mikewest
Revert of Evict non-secure cookies less agressively. (patchset crossw…
4da5cad 
…alk-project#4 id:60001 of https://codereview.chromium.org/1705753002/ )

Reason for revert:
Let's see if the automagical reversion thingie will work on a ~2 week old patch.

```
I updated the eviction algorithm with our initial pass at a merger between leave-secure-cookies-along and cookie-priorities, and neglected to ensure that that new algorithm was safely locked up behind the "strict secure cookies" experiment. That patch is in M50.

I think the right thing to do is to revert https://codereview.chromium.org/1705753002 on the M50 branch so that we retain the status quo behavior for beta. That means that we're going to have to wait a bit longer to start ratcheting down on cookies, which is unfortunate, but the safe choice this late in the game.
```

BUG=591720

Original issue's description:
> Evict non-secure cookies less agressively.
>
> The current implementation of strict-secure cookies wipes all non-secure
> cookies when an origin exceeds ~180. This is a bit agressive, and has
> real impact on users.
>
> This patch softens that to remove only the number of non-secure cookies
> necessary to get under the ~150 cap. If a user has 150 secure cookies,
> we'll still wipe all non-secure cookies, but that seems less likely to
> impact users than the current behavior.
>
> The patch is a bit more complicated than I expected due to interactions
> with the Chrome-only "priority" feature we shipped back in 2013. In
> short, we execute priority-driven removal of non-secure cookies first,
> and only touch secure cookies if necessary.
>
> BUG=581588
> [email protected], [email protected]
>
> Committed: https://crrev.com/162d27135f2ee44ae01341de055d1b827a930767
> Cr-Commit-Position: refs/heads/master@{#376204}

[email protected],[email protected]
BUG=581588

Review URL: https://codereview.chromium.org/1762693002

Cr-Commit-Position: refs/heads/master@{#379030}
(cherry picked from commit 8773435)

Review URL: https://codereview.chromium.org/1770183003 .

Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#122}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
imreotto pushed a commit to tenta-browser/chromium-crosswalk that referenced this pull request Nov 2, 2017
@krockot
Mojo: Fix nested SyncHandleWatcher Wait
c856f71 
We defer event callback list modification until the outermost Wait()
unwinds, but we need to ensure that the internal WaitSet has events
removed immediately within UnregisterEvent if the event has no more
valid callbacks registered.

This allows callers to make the assumption that exclusively registered
events are not referenced beyond a call to UnregisterEvent, which is an
assumption made by production code.

Adds tests for SyncHandleRegistry event watching too.

BUG=761097
[email protected]

(cherry picked from commit 018ebce)

Change-Id: Ibbf6eee335879bba6b732637944338f046bf37cb
Reviewed-on: https://chromium-review.googlesource.com/646491
Reviewed-by: Yuzhu Shen <[email protected]>
Commit-Queue: Ken Rockot <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#499116}
Reviewed-on: https://chromium-review.googlesource.com/647335
Reviewed-by: Ken Rockot <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#4}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junmin-zhu @kenchris