WIP : to get comments #6

riju · 2013-06-11T12:29:31Z

gyp changes needed to make it compile for efl

xingnan · 2013-06-11T12:29:53Z

Trybot Dashboard

PATCH
[content_linux] Building...
[content_win] Building...
[content_android] Building...

BUG=279573 [email protected] TEST=manually (see the repro steps in the bug comment crosswalk-project#6) Review URL: https://chromiumcodereview.appspot.com/23490003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219940 0039d316-1c4b-4281-b951-d872f2087c98

- A user hovers the minimize button with the mouse then taps the snap left / snap right button - When the MaximizeBubbleFrameState computed by GetMaximizeBubbleFrameState() changes while the maximize button help bubble is visible due to the work area bounds changing (See comment crosswalk-project#6 in bug) BUG=342867 TEST=FrameMaximizeButtonTest.MaximizeBubbleMouseHoverAndTouch Review URL: https://codereview.chromium.org/160493004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251206 0039d316-1c4b-4281-b951-d872f2087c98

@obj

> Fixes crashes wrt to the maximize button when: > - A user hovers the minimize button with the mouse then taps the snap left / snap right button > - When the MaximizeBubbleFrameState computed by GetMaximizeBubbleFrameState() changes while the maximize button help bubble is visible due to the work area bounds changing (See comment crosswalk-project#6 in bug) > > BUG=342867 > TEST=FrameMaximizeButtonTest.MaximizeBubbleMouseHoverAndTouch > > Review URL: https://codereview.chromium.org/160493004 Reverting as broke compile on windows: [2431/3743] CXX obj\chrome\browser\extensions\api\cast_channel\browser_extensions.cast_auth_util_nss.obj FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\ash\wm\caption_buttons\ash.maximize_bubble_controller.obj.rsp /c ..\..\ash\wm\caption_buttons\maximize_bubble_controller.cc /Foobj\ash\wm\caption_buttons\ash.maximize_bubble_controller.obj /Fdobj\ash\ash.cc.pdb c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73) :error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' : method with override specifier 'override' did not override any base class methods FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\ash\wm\ash.custom_frame_view_ash.obj.rsp /c ..\..\ash\wm\custom_frame_view_ash.cc /Foobj\ash\wm\ash.custom_frame_view_ash.obj /Fdobj\ash\ash.cc.pdb c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73) :error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' : method with override specifier 'override' did not override any base class methods FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\ash\wm\caption_buttons\ash.frame_caption_button_container_view.obj.rsp /c ..\..\ash\wm\caption_buttons\frame_caption_button_container_view.cc /Foobj\ash\wm\caption_buttons\ash.frame_caption_button_container_view.obj /Fdobj\ash\ash.cc.pdb c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73) :error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' : method with override specifier 'override' did not override any base class methods FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\ash\wm\caption_buttons\ash.maximize_bubble_controller_bubble.obj.rsp /c ..\..\ash\wm\caption_buttons\maximize_bubble_controller_bubble.cc /Foobj\ash\wm\caption_buttons\ash.maximize_bubble_controller_bubble.obj /Fdobj\ash\ash.cc.pdb c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73) :error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' : method with override specifier 'override' did not override any base class methods FAILED: ninja -t msvc -e environment.x64 -- C:\b\build\goma\gomacc.exe "C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\ash\wm\caption_buttons\ash.frame_maximize_button.obj.rsp /c ..\..\ash\wm\caption_buttons\frame_maximize_button.cc /Foobj\ash\wm\caption_buttons\ash.frame_maximize_button.obj /Fdobj\ash\ash.cc.pdb c:\b\build\slave\cr-win-rel-x64\build\src\ash\wm\caption_buttons\frame_maximize_button.h(73) :error C3668: 'ash::FrameMaximizeButton::OnWindowShowTypeChanged' : method with override specifier 'override' did not override any base class methods ninja: build stopped: subcommand failed. from: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/14916/steps/compile/logs/stdio#error1 [email protected] Review URL: https://codereview.chromium.org/165283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251217 0039d316-1c4b-4281-b951-d872f2087c98

- A user hovers the minimize button with the mouse then taps the snap left / snap right button - When the MaximizeBubbleFrameState computed by GetMaximizeBubbleFrameState() changes while the maximize button help bubble is visible due to the work area bounds changing (See comment crosswalk-project#6 in bug) BUG=342867 TEST=FrameMaximizeButtonTest.MaximizeBubbleMouseHoverAndTouch Review URL: https://codereview.chromium.org/166543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251589 0039d316-1c4b-4281-b951-d872f2087c98

> Fixes crashes wrt to the maximize button when: > - A user hovers the minimize button with the mouse then taps the snap left / snap right button > - When the MaximizeBubbleFrameState computed by GetMaximizeBubbleFrameState() changes while the maximize button help bubble is visible due to the work area bounds changing (See comment crosswalk-project#6 in bug) > > BUG=342867 > TEST=FrameMaximizeButtonTest.MaximizeBubbleMouseHoverAndTouch > > Review URL: https://codereview.chromium.org/166543004 [email protected] Review URL: https://codereview.chromium.org/169433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251647 0039d316-1c4b-4281-b951-d872f2087c98

…org/140583003/) Reason for revert: Appears to have caused a memory leak. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%282%29/builds/23519/steps/content_unittests/logs/AvailableService Indirect leak of 176 byte(s) in 1 object(s) allocated from: #0 0x49c001 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54 #1 0xf42228 in content::PowerProfilerServiceTest::ServiceStartTest() content/browser/power_profiler/power_profiler_service_unittest.cc:85 #2 0xf4212d in content::PowerProfilerServiceTest_AvailableService_Test::TestBody() content/browser/power_profiler/power_profiler_service_unittest.cc:138 #3 0x2d3587a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #4 0x2d3587a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #5 0x2d379ca in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #6 0x2d38793 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #7 0x2d4984a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #8 0x2d48e30 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #9 0x2d48e30 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #10 0x2cc09cc in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #11 0x2cc09cc in base::TestSuite::Run() base/test/test_suite.cc:213 #12 0x2cb4041 in Run base/callback.h:401 #13 0x2cb4041 in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #14 0x195d8ce in main content/test/run_all_unittests.cc:14 #15 0x7f515353d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > This CL implemented part of chrome power profiler, including the service, data provider and observer base. > > BUG=337138 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254116 [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=337138 Review URL: https://codereview.chromium.org/184583004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254146 0039d316-1c4b-4281-b951-d872f2087c98

This caused a memory leak. It appears |suggestions| was mismanaged? http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASAN%20Tests%20%283%29/builds/13714/steps/unit_tests/logs/OfflinePageDontProceed Direct leak of 40 byte(s) in 1 object(s) allocated from: #0 0x4b1711 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54 #1 0x61e7518 in LocalizedError::GetStrings(int, std::string const&, GURL const&, bool, bool, std::string const&, std::string const&, scoped_ptr\u003CLocalizedError::ErrorPageParams, base::DefaultDeleter\u003CLocalizedError::ErrorPageParams> >, base::DictionaryValue*) chrome/common/localized_error.cc:686 #2 0x111d82c0 in chromeos::OfflineLoadPage::GetHTMLContents() chrome/browser/chromeos/offline/offline_load_page.cc:98 #3 0xfb6f1fd in content::InterstitialPageImpl::Show() content/browser/frame_host/interstitial_page_impl.cc:248 #4 0x13fc43e in chromeos::OfflineLoadPageTest::ShowInterstitial(char const*) chrome/browser/chromeos/offline/offline_load_page_unittest.cc:71 #5 0x13fc870 in chromeos::OfflineLoadPageTest_OfflinePageDontProceed_Test::TestBody() chrome/browser/chromeos/offline/offline_load_page_unittest.cc:128 #6 0x800bf1a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #7 0x800bf1a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #8 0x800e349 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #9 0x800f0c3 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #10 0x801fd1a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #11 0x801f320 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #12 0x801f320 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #13 0x129f3154 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #14 0x129f3154 in base::TestSuite::Run() base/test/test_suite.cc:213 #15 0x129ea3b7 in Run base/callback.h:401 #16 0x129ea3b7 in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #17 0x820ee6d in main chrome/test/base/run_all_unittests.cc:13 #18 0x7f1d7d44d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 > Switch to using the new Link Doctor API. > > The new API allows Link Doctor results to be integrated into Chrome's > own error pages. > > BUG=64832 > [email protected], [email protected], [email protected], [email protected] > > Review URL: https://codereview.chromium.org/137623011 [email protected] Review URL: https://codereview.chromium.org/185003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254241 0039d316-1c4b-4281-b951-d872f2087c98

This made the Asan bot unhappy http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASan%2BLSan%20Tests%20%282%29&number=396 P2PSocketHostTest.TestInvalidTurnChannelMessages (run #1): [ RUN ] P2PSocketHostTest.TestInvalidTurnChannelMessages ================================================================= ==13684==ERROR: AddressSanitizer: global-buffer-overflow on address 0x00000cc54404 at pc 0x278fe5c bp 0x7fff34be4350 sp 0x7fff34be4348 READ of size 1 at 0x00000cc54404 thread T0 #0 0x278fe5b in IsRtpPacket content/browser/renderer_host/p2p/socket_host.cc:54 #1 0x278fe5b in content::packet_processing_helpers::GetRtpPacketStartPositionAndLength(char*, int, int*, int*) content/browser/renderer_host/p2p/socket_host.cc:304 #2 0x1f5a542 in content::P2PSocketHostTest_TestInvalidTurnChannelMessages_Test::TestBody() content/browser/renderer_host/p2p/socket_host_unittest.cc:208 #3 0x2c38e7a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #4 0x2c38e7a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #5 0x2c3afca in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #6 0x2c3bd93 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #7 0x2c4ce4a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #8 0x2c4c430 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #9 0x2c4c430 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #10 0x2bcad1c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #11 0x2bcad1c in base::TestSuite::Run() base/test/test_suite.cc:213 #12 0x2bbebbb in Run base/callback.h:401 #13 0x2bbebbb in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #14 0x198401e in main content/test/run_all_unittests.cc:14 #15 0x7f28c9fa576c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 #16 0x4b322c in _start (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x4b322c) 0x00000cc54404 is located 60 bytes to the left of global variable 'kRtpMsgWith2ByteExtnHeader' from '../../content/browser/renderer_host/p2p/socket_host_unittest.cc' (0xcc54440) of size 20 0x00000cc54404 is located 0 bytes to the right of global variable 'kTurnChannelMsgWithZeroLength' from '../../content/browser/renderer_host/p2p/socket_host_unittest.cc' (0xcc54400) of size 4 SUMMARY: AddressSanitizer: global-buffer-overflow content/browser/renderer_host/p2p/socket_host.cc:54 IsRtpPacket Shadow bytes around the buggy address: 0x000081982830: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x000081982840: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x000081982850: 00 00 f9 f9 f9 f9 f9 f9 00 00 f9 f9 f9 f9 f9 f9 0x000081982860: 00 00 04 f9 f9 f9 f9 f9 00 00 04 f9 f9 f9 f9 f9 0x000081982870: 00 00 00 04 f9 f9 f9 f9 00 f9 f9 f9 f9 f9 f9 f9 =>0x000081982880:[04]f9 f9 f9 f9 f9 f9 f9 00 00 04 f9 f9 f9 f9 f9 0x000081982890: 00 00 00 f9 f9 f9 f9 f9 00 00 00 00 00 04 f9 f9 0x0000819828a0: f9 f9 f9 f9 00 00 00 00 00 00 00 f9 f9 f9 f9 f9 0x0000819828b0: 00 00 f9 f9 f9 f9 f9 f9 00 00 00 f9 f9 f9 f9 f9 0x0000819828c0: 03 f9 f9 f9 f9 f9 f9 f9 00 00 05 f9 f9 f9 f9 f9 0x0000819828d0: 04 f9 f9 f9 f9 f9 f9 f9 00 00 00 00 00 00 00 00 > This CL adds methods to manipulate RTP header extension, particularly > AbsoulteSendTime extension. If there is matching extension ID present > in RTP packet, we will update with the current time. > > [email protected], [email protected], [email protected] > > BUG= > > Review URL: https://codereview.chromium.org/159353002 [email protected] Review URL: https://codereview.chromium.org/197933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256584 0039d316-1c4b-4281-b951-d872f2087c98

The linux asan bot went red ResourceDispatcherHostTest.DownloadToFile (run #1): [ RUN ] ResourceDispatcherHostTest.DownloadToFile [ OK ] ResourceDispatcherHostTest.DownloadToFile (212 ms) [----------] 1 test from ResourceDispatcherHostTest (212 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (213 ms total) [ PASSED ] 1 test. YOU HAVE 5 DISABLED TESTS ================================================================= ==9125==ERROR: LeakSanitizer: detected memory leaks Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x49be81 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54 #1 0x23ce695 in content::ResourceDispatcherHostImpl::BeginRequest(int, ResourceHostMsg_Request const&, IPC::Message*, int) content/browser/loader/resource_dispatcher_host_impl.cc:1045 #2 0x23cba80 in OnRequestResource content/browser/loader/resource_dispatcher_host_impl.cc:879 #3 0x23cba80 in Dispatch\u003Ccontent::ResourceDispatcherHostImpl, content::ResourceDispatcherHostImpl, int, const ResourceHostMsg_Request &> content/common/resource_messages.h:305 #4 0x23cba80 in content::ResourceDispatcherHostImpl::OnMessageReceived(IPC::Message const&, content::ResourceMessageFilter*, bool*) content/browser/loader/resource_dispatcher_host_impl.cc:841 #5 0xe04954 in content::ResourceDispatcherHostTest_DownloadToFile_Test::TestBody() content/browser/loader/resource_dispatcher_host_unittest.cc:2840 #6 0x2c10c9a in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #7 0x2c10c9a in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #8 0x2c12dea in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #9 0x2c13bb3 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #10 0x2c24c6a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #11 0x2c24250 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #12 0x2c24250 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #13 0x2b9ed2c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #14 0x2b9ed2c in base::TestSuite::Run() base/test/test_suite.cc:213 #15 0x2b92bcb in Run base/callback.h:401 #16 0x2b92bcb in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #17 0x199a83e in main content/test/run_all_unittests.cc:14 #18 0x7f6e898bf76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 SUMMARY: AddressSanitizer: 16 byte(s) leaked in 1 allocation(s). http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/409 > Fix various issues in RedirectToFileResourceHandler. > > - Handle errors in creating temporary files. > - Cancel on write failure instead of resuming. This used to work, but got > lost in some refactoring in r142108. > - Fix the OnResponseCompleted resume logic to account for partial writes. > - Don't lose write errors which occur after OnResponseCompleted is received. > - WeakPtrFactory goes after other members. > - OnWillStart was never forwarded to downstream handlers. > - Make sure the file is closed before deleting it. > > Also add a lot of machinery so we can better unit test this stack. > > BUG=316634,347663 > TEST=ResourceDispatcherHostTest.DownloadToFile > ResourceDispatcherHostTest.RegisterDownloadedTempFile > ResourceLoaderTest.RedirectToFile* > TemporaryFileStreamTest.Basic > > Review URL: https://codereview.chromium.org/82273002 [email protected] Review URL: https://codereview.chromium.org/196533013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256704 0039d316-1c4b-4281-b951-d872f2087c98

Turned the chromeos lsan bot red: Indirect leak of 48 byte(s) in 1 object(s) allocated from: #0 0x480201 in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:54 #1 0x49e263 in ui::AXTreeSerializer\u003Cviews::View*>::SerializeChangedNodes(views::View*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:372 #2 0x49b75a in ui::AXTreeSerializer\u003Cviews::View*>::SerializeChanges(views::View*, ui::AXTreeUpdate*) ui/accessibility/ax_tree_serializer.h:329 #3 0x49992d in views::AXTreeSourceViewsTest_SimpleSerialization_Test::TestBody() ui/views/accessibility/ax_tree_source_views_unittest.cc:75 #4 0xb859ba in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #5 0xb859ba in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #6 0xb874c9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #7 0xb88243 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #8 0xb98e9a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #9 0xb984a0 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #10 0xb984a0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #11 0xb51664 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #12 0xb51664 in base::TestSuite::Run() base/test/test_suite.cc:213 #13 0xb47d1d in Run base/callback.h:401 #14 0xb47d1d in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 #15 0x80bdba in main ui/views/run_all_unittests.cc:46 #16 0x7f0caf06376c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%2BLSan%20Tests%20%281%29/builds/222/steps/views_unittests/logs/SimpleSerialization > Reland r256396 Add views implementation for AXTreeSource. > > BUG=318758 > [email protected] > > Review URL: https://codereview.chromium.org/196603003 [email protected] Review URL: https://codereview.chromium.org/196953009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256745 0039d316-1c4b-4281-b951-d872f2087c98

Leaks: Linux LSan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/1508 E.g.: Indirect leak of 1544 byte(s) in 1 object(s) allocated from: #0 0x4fc78b in operator new(unsigned long) /usr/local/google/home/thakis/src/chrome/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x232ebeb in allocate /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/ext/new_allocator.h:92 #2 0x232ebeb in _M_allocate /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_vector.h:150 #3 0x232ebeb in _M_allocate_and_copy<std::move_iterator<__gnu_cxx::_Hashtable_node<std::pair<const std::basic_string<char>, content::SiteInstance *> > **> > /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_vector.h:1052 #4 0x232ebeb in reserve /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/vector.tcc:74 crosswalk-project#5 0x232ebeb in _M_initialize_buckets /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/backward/hashtable.h:577 crosswalk-project#6 0x232ebeb in __gnu_cxx::hashtable<std::pair<std::string const, content::SiteInstance*>, std::string, __gnu_cxx::hash<std::string>, std::_Select1st<std::pair<std::string const, content::SiteInstance*> >, std::equal_to<std::string>, std::allocator<content::SiteInstance*> >::hashtable(unsigned long, __gnu_cxx::hash<std::string> const&, std::equal_to<std::string> const&, std::allocator<std::pair<std::string const, content::SiteInstance*> > const&) /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/backward/hashtable.h:334 crosswalk-project#7 0x232cb58 in RefCounted /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/ext/hash_map:126 crosswalk-project#8 0x232cb58 in content::BrowsingInstance::BrowsingInstance(content::BrowserContext*) content/browser/browsing_instance.cc:18 crosswalk-project#9 0x28d4131 in content::SiteInstance::Create(content::BrowserContext*) content/browser/site_instance_impl.cc:220 crosswalk-project#10 0x2db9c92 in CreateTestWebContents content/public/test/test_renderer_host.cc:138 crosswalk-project#11 0x2db9c92 in content::RenderViewHostTestHarness::SetUp() content/public/test/test_renderer_host.cc:182 crosswalk-project#12 0xda5e2d in content::RenderFrameHostManagerTest::SetUp() content/browser/frame_host/render_frame_host_manager_unittest.cc:204 crosswalk-project#13 0x2eea0f2 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2045 crosswalk-project#14 0x2eea0f2 in testing::Test::Run() testing/gtest/src/gtest.cc:2057 crosswalk-project#15 0x2eec3a9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 crosswalk-project#16 0x2eed183 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 crosswalk-project#17 0x2efe463 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 crosswalk-project#18 0x2efda30 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 crosswalk-project#19 0x2efda30 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 crosswalk-project#20 0x2e7712c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 crosswalk-project#21 0x2e7712c in base::TestSuite::Run() base/test/test_suite.cc:213 crosswalk-project#22 0x2e6aebd in Run base/callback.h:401 crosswalk-project#23 0x2e6aebd in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback<int ()> const&, int) base/test/launcher/unit_test_launcher.cc:494 crosswalk-project#24 0x1bfec66 in main content/test/run_all_unittests.cc:14 crosswalk-project#25 0x7f853fc5876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 > Introduce RenderFrameProxyHost object and use it in RFHM. > > This is the first CL in a series to create RenderFrameProxy(Host) infrastructure. Before the Blink codebase is ready to transform local and remote frames, the proxy objects will keep internally the existing RF/RFH in swapped out state. This CL creates the browser side proxy object and wraps the swapped out RFH. > > BUG=357747 > > Review URL: https://codereview.chromium.org/217163007 [email protected] Review URL: https://codereview.chromium.org/236003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263367 0039d316-1c4b-4281-b951-d872f2087c98

…correctly. (https://codereview.chromium.org/255543009/) Reason for revert: Causes leaks: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2046/steps/browser_tests/logs/SadTabCancelsSubframeDialogs Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x56973b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x52464ce in IPC::SyncMessage::GenerateReply(IPC::Message const*) ipc/ipc_sync_message.cc:99 #2 0x9f6ec47 in Tuple4 ipc/ipc_message_utils.h:877 #3 0x9f6ec47 in bool FrameHostMsg_RunJavaScriptMessage::DispatchDelayReply\u003Ccontent::RenderFrameHostImpl, void (content::RenderFrameHostImpl::*)(std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, GURL const&, content::JavaScriptMessageType, IPC::Message*)>(IPC::Message const*, content::RenderFrameHostImpl*, void (content::RenderFrameHostImpl::*)(std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, std::basic_string\u003Cunsigned short, base::string16_char_traits, std::allocator\u003Cunsigned short> > const&, GURL const&, content::JavaScriptMessageType, IPC::Message*)) content/common/frame_messages.h:545 #4 0x9f6b9d3 in content::RenderFrameHostImpl::OnMessageReceived(IPC::Message const&) content/browser/frame_host/render_frame_host_impl.cc:287 #5 0xa1185d9 in content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) content/browser/renderer_host/render_process_host_impl.cc:1346 #6 0x5239eec in IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) ipc/ipc_channel_proxy.cc:269 #7 0x3256fbf in Run base/callback.h:401 #8 0x3256fbf in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:450 #9 0x3258e35 in DeferOrRunPendingTask base/message_loop/message_loop.cc:462 #10 0x3258e35 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:576 #11 0x32fab87 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_glib.cc:270 #12 0x3290314 in base::RunLoop::Run() base/run_loop.cc:49 #13 0xc55c305 in content::RunThisRunLoop(base::RunLoop*) content/public/test/test_utils.cc:103 #14 0xc55e252 in operator-> content/public/test/test_utils.cc:165 #15 0xc55e252 in content::WindowedNotificationObserver::Wait() content/public/test/test_utils.cc:225 #16 0x31af7c1 in ui_test_utils::WaitForAppModalDialog() chrome/test/base/ui_test_utils.cc:342 #17 0x19c1ed8 in BrowserTest_SadTabCancelsSubframeDialogs_Test::RunTestOnMainThread() chrome/browser/ui/browser_browsertest.cc:585 #18 0x31996b8 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:419 Original issue's description: > Ensure that modal dialogs from subframes can be cleaned up correctly. > > BUG=366510 > TEST=See bug comment 7 for repro steps. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266638 [email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=366510 Review URL: https://codereview.chromium.org/257863004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266669 0039d316-1c4b-4281-b951-d872f2087c98

…//codereview.chromium.org/258713002/) Reason for revert: views_unittest TooltipController test failures views_unittests views_unittests 4 disabled 10 flaky failed 10 ( 9 secs ) stdio Capture CloseOnCaptureLost DontShowEmptyTooltips EnableOrDisableTooltips HideOnExit ReshowOnClickAfterEnterExit TooltipHidesOnKeyPressAndStaysHiddenUntilChange TooltipHidesOnTimeoutAndStaysHiddenUntilChange TooltipsInMultipleViews ViewTooltip TooltipControllerTest.ViewTooltip (run #2): [ RUN ] TooltipControllerTest.ViewTooltip Xlib: extension "RANDR" missing on display ":9". Received signal 11 SEGV_MAPERR 000000000000 #0 0x000000a88e4e base::debug::StackTrace::StackTrace() #1 0x000000a89068 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f9474270cb0 \u003Cunknown> #3 0x000000736b83 views::NativeWidgetAura::Activate() #4 0x000000737508 views::NativeWidgetAura::ShowWithWindowState() #5 0x000000738acb views::Widget::Show() #6 0x00000052cb09 views::corewm::test::(anonymous namespace)::CreateWidget() #7 0x00000052d397 views::corewm::test::TooltipControllerTest::SetUp() #8 0x00000065a16a testing::Test::Run() Original issue's description: > Linux Aura: get tooltip background color from theme > > the border color can still conflict with the theme (e.g., no visible border if the tooltip bg is dark), but fixing that is a lot harder because the border, window roundedness, and shadow are all one tiled set of images (see shadow.cc). > > BUG=348194 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266974 [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=348194 Review URL: https://codereview.chromium.org/263533003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266992 0039d316-1c4b-4281-b951-d872f2087c98

….chromium.org/250113002/) Reason for revert: views_unittest TooltipController test failures views_unittests views_unittests 4 disabled 10 flaky failed 10 ( 9 secs ) stdio Capture CloseOnCaptureLost DontShowEmptyTooltips EnableOrDisableTooltips HideOnExit ReshowOnClickAfterEnterExit TooltipHidesOnKeyPressAndStaysHiddenUntilChange TooltipHidesOnTimeoutAndStaysHiddenUntilChange TooltipsInMultipleViews ViewTooltip TooltipControllerTest.ViewTooltip (run #2): [ RUN ] TooltipControllerTest.ViewTooltip Xlib: extension "RANDR" missing on display ":9". Received signal 11 SEGV_MAPERR 000000000000 #0 0x000000a88e4e base::debug::StackTrace::StackTrace() #1 0x000000a89068 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f9474270cb0 \u003Cunknown> #3 0x000000736b83 views::NativeWidgetAura::Activate() #4 0x000000737508 views::NativeWidgetAura::ShowWithWindowState() #5 0x000000738acb views::Widget::Show() #6 0x00000052cb09 views::corewm::test::(anonymous namespace)::CreateWidget() #7 0x00000052d397 views::corewm::test::TooltipControllerTest::SetUp() #8 0x00000065a16a testing::Test::Run(). Original issue's description: > Move DefaultActivationClient to wm/core > > Several tests are using AuraTestHelper and were relying on it to set up the DefaultActivationClient, so I had to have them instantiate the DAC directly after calling SetUp() on the helper. I also had to make the DAC delete itself after the root window it's bound to is destroyed. > > [email protected] > http://crbug.com/308710 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266616 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266975 [email protected],[email protected] NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/261553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267001 0039d316-1c4b-4281-b951-d872f2087c98

unit_tests failing a DCHECK, e.g.: out/Debug/unit_tests --gtest_filter='*BrowsingData*.*' [32145:32145:0502/110725:1563688322251:FATAL:ref_counted.cc(32)] Check failed: !in_dtor_. #0 0x7f45e6b227de base::debug::StackTrace::StackTrace() #1 0x7f45e6bb0a85 logging::LogMessage::~LogMessage() #2 0x7f45e6bcc063 base::subtle::RefCountedThreadSafeBase::AddRef() #3 0x7f45da6ad895 base::RefCountedThreadSafe<>::AddRef() #4 0x7f45daec3be2 scoped_refptr<>::scoped_refptr() #5 0x7f45daf0048b content::ServiceWorkerStorage::ServiceWorkerStorage() #6 0x7f45daea61e8 content::ServiceWorkerContextCore::ServiceWorkerContextCore() ... > ServiceWorker: Create sequenced task runner for database > > > BUG=369464 > TEST=pass all existing tests (no behavioral change) > NOTRY=true > > Review URL: https://codereview.chromium.org/265743012 [email protected] Review URL: https://codereview.chromium.org/262973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267870 0039d316-1c4b-4281-b951-d872f2087c98

This test fails consistently on Linux Tests (dbg) (1) [ RUN ] PDFExtensionTest.BasicPlugin ... [1023:1023:0618/142028:INFO:CONSOLE(0)] "[SUCCESS] testPageSize", source: chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/index.html?http://127.0.0.1:42118/pdf/test.pdf (0) [17:17:0618/142028:WARNING:resource_message_handler.cc(49)] 'Post' message handler failed to complete successfully. [17:17:0618/142028:ERROR:pepper_uma_host.cc(106)] Host or histogram name is not allowed to use the UMA API. [17:17:0618/142028:WARNING:resource_message_handler.cc(49)] 'Post' message handler failed to complete successfully. memory allocation bug: object at 0x7f5a852272c0 has never been allocated BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f9e4351c8b5 base::debug::StackTrace::StackTrace() #1 0x00000462f8f2 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f9e2fb2f4a0 \u003Cunknown> #3 0x7f9e2fbe1a43 __poll #4 0x7f9e30917ff6 \u003Cunknown> #5 0x7f9e30918124 g_main_context_iteration #6 0x7f9e434e49e5 base::MessagePumpGlib::Run() <truncated, full output is in gzipped JSON output at end of step> #31 0x7f9e34f05dc7 content::RunNamedProcessTypeMain() #32 0x7f9e34f074df content::ContentMainRunnerImpl::Run() #33 0x7f9e34f0528b content::ContentMain() ... > Re-enable PDFExtensionTest.BasicPlugin > > This test was disabled because it was failing. A few changes have been made: > -The page zoom cannot be assumed to be 100% on load as it will depend on the screen size being tested on. So testPageSize now doesn't make that assumption. > -testAccessibilityWithPage was flaking because accessibility information was not always returned for the two text boxes. I spent a bit of time investigating, but couldn't work it out so I've left it partially disabled for now and filed crbug.com/378091. > -The files have all been moved to a more appropriate location (in particular the test was moved out of the data directory). > > BUG=303491 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273819 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274186 > > Review URL: https://codereview.chromium.org/290803007 [email protected] Review URL: https://codereview.chromium.org/346693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278191 0039d316-1c4b-4281-b951-d872f2087c98

…es. (https://codereview.chromium.org/339073002/) Reason for revert: Brand new test fails in ASAN: Direct leak of 112 byte(s) in 1 object(s) allocated from: #0 0x462ccb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x7ee8f9 in CreateNextFrame remoting/host/video_frame_recorder_unittest.cc:96 #2 0x7ee8f9 in remoting::VideoFrameRecorderTest::CreateTestFrames() remoting/host/video_frame_recorder_unittest.cc:112 #3 0x7f1184 in remoting::VideoFrameRecorderTest_EncodeButDontRecord_Test::TestBody() remoting/host/video_frame_recorder_unittest.cc:269 #4 0xb3bf38 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2045 #5 0xb3bf38 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #6 0xb3e1c9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #7 0xb3ef56 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #8 0xb5206a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #9 0xb516a0 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #10 0xb516a0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #11 0xab66bc in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #12 0xab66bc in base::TestSuite::Run() base/test/test_suite.cc:227 #13 0xaada32 in Run base/callback.h:401 #14 0xaada32 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #15 0xaad3ad in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553 #16 0x4e8067 in main chrome/test/base/run_all_remoting_unittests.cc:31 #17 0x7f1f660df76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Add VideoFrameRecorder for use recording test frame sequences. > > This will be used to record representative frame sequences for performance evaluation of the new VP9 encoder. > > BUG=260879 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279795 [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=260879 Review URL: https://codereview.chromium.org/350903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279805 0039d316-1c4b-4281-b951-d872f2087c98

Seems to have introduced leaks: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/3527/steps/net_unittests/logs/stdio For example: Direct leak of 112 byte(s) in 1 object(s) allocated from: #0 0x5166cb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x16ce6be in MockDiskCache::CreateEntry(std::string const&, disk_cache::Entry**, base::Callback<void (int)> const&) net/http/mock_http_cache.cc:408 #2 0x37654a7 in DoCreate net/http/disk_based_cert_cache.cc:187 #3 0x37654a7 in net::DiskBasedCertCache::WriteWorker::DoLoop(int) net/http/disk_based_cert_cache.cc:158 #4 0x3768f23 in Start net/http/disk_based_cert_cache.cc:125 #5 0x3768f23 in net::DiskBasedCertCache::Set(CERTCertificateStr*, base::Callback<void (std::string const&)> const&) net/http/disk_based_cert_cache.cc:533 #6 0x10d0ffa in net::DiskBasedCertCache_SyncSet_Test::TestBody() net/http/disk_based_cert_cache_unittest.cc:231 #7 0x33ce728 in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2045 #8 0x33ce728 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #9 0x33d0f09 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #10 0x33d1c96 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #11 0x33e4daa in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #12 0x33e43e0 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #13 0x33e43e0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #14 0x40a6d1c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #15 0x40a6d1c in base::TestSuite::Run() base/test/test_suite.cc:227 #16 0x409b4e2 in Run base/callback.h:401 #17 0x409b4e2 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #18 0x409ae5d in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553 #19 0x2b986cc in main net/test/run_all_unittests.cc:64 #20 0x7fc4683a976c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 > Creation of a new and improved object for the caching of certificate objects on disk. > > Review URL: https://codereview.chromium.org/329733002 [email protected] Review URL: https://codereview.chromium.org/349533004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280492 0039d316-1c4b-4281-b951-d872f2087c98

Broke the Linux ASan LSan Test(2) bot Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0x5ac35b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x1df3a96 in (anonymous namespace)::BuildFaviconService(content::BrowserContext*) chrome/browser/favicon/favicon_handler_unittest.cc:1408 #2 0xf2c3cc0 in BrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) components/keyed_service/content/browser_context_keyed_service_factory.cc:88 #3 0x549067a in FaviconServiceFactory::GetForProfile(Profile*, Profile::ServiceAccessType) chrome/browser/favicon/favicon_service_factory.cc:25 #4 0x1df00f4 in (anonymous namespace)::FaviconHandlerTest_UnableToDownloadFavicon_Test::TestBody() chrome/browser/favicon/favicon_handler_unittest.cc:1432 #5 0x6cc96f8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #6 0x6cc96f8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #7 0x6ccbed9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #8 0x6cccc66 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #9 0x6cdfd7a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #10 0x6cdf3b0 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #11 0x6cdf3b0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #12 0x1021320c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #13 0x1021320c in base::TestSuite::Run() base/test/test_suite.cc:227 #14 0x1020a9d2 in Run base/callback.h:401 #15 0x1020a9d2 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #16 0x1020a34d in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:553 #17 0x6df1bee in main chrome/test/base/run_all_unittests.cc:15 #18 0x7f93160dc76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 > Pass an instance of FaviconClient to FaviconService. > > This is an intermediary CL where the FaviconClient is not used by the FaviconService. > Subsequent CLs will start using the FaviconClient in the FaviconService to abstract usage of chrome/ code. > > BUG=377505 > > Review URL: https://codereview.chromium.org/302433010 [email protected] Review URL: https://codereview.chromium.org/370663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281309 0039d316-1c4b-4281-b951-d872f2087c98

…https://codereview.chromium.org/373153002/) Reason for revert: Causing memory leaks: Indirect leak of 328 byte(s) in 1 object(s) allocated from: #0 0x515feb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0xc334cfb in BookmarkModel::CreatePermanentNode(BookmarkNode::Type) components/bookmarks/browser/bookmark_model.cc:910 #2 0xc326772 in BookmarkModel::CreateLoadDetails(std::string const&) components/bookmarks/browser/bookmark_model.cc:1006 #3 0xc326553 in BookmarkModel::Load(PrefService*, std::string const&, base::FilePath const&, scoped_refptr\u003Cbase::SequencedTaskRunner> const&, scoped_refptr\u003Cbase::SequencedTaskRunner> const&) components/bookmarks/browser/bookmark_model.cc:151 #4 0x232a4d7 in BookmarkModelFactory::BuildServiceInstanceFor(content::BrowserContext*) const chrome/browser/bookmarks/bookmark_model_factory.cc:65 #5 0xc0bc85f in BrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) components/keyed_service/content/browser_context_keyed_service_factory.cc:91 #6 0x260de89 in ProfileImpl::DoFinalInit() chrome/browser/profiles/profile_impl.cc:657 #7 0x260beb5 in ProfileImpl::OnPrefsLoaded(bool) chrome/browser/profiles/profile_impl.cc:881 #8 0x260ae3e in ProfileImpl::ProfileImpl(base::FilePath const&, Profile::Delegate*, Profile::CreateMode, base::SequencedTaskRunner*) chrome/browser/profiles/profile_impl.cc:492 #9 0x2608ddb in Profile::CreateProfile(base::FilePath const&, Profile::Delegate*, Profile::CreateMode) chrome/browser/profiles/profile_impl.cc:297 #10 0x18de165 in ProfileBrowserTest::CreateProfile(base::FilePath const&, Profile::Delegate*, Profile::CreateMode) chrome/browser/profiles/profile_browsertest.cc:106 #11 0x18df8f8 in ProfileBrowserTest_CreateOldProfileSynchronous_Test::RunTestOnMainThread() chrome/browser/profiles/profile_browsertest.cc:153 #12 0x33f5434 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:427 #13 0x2e6ca18 in Run base/callback.h:401 #14 0x2e6ca18 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1548 #15 0x2e69666 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:975 #16 0x59381d7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:694 #17 0x5c8f207 in Run base/callback.h:401 #18 0x5c8f207 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #19 0x59342e0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:594 #20 0x5e8a153 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106 #21 0xf0228a0 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22 #22 0xef6cbc4 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:763 #23 0xef69d3f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19 #24 0xcf5b57f in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:253 #25 0x33f2563 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:210 #26 0x3e81941 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #27 0x3e81941 in testing::Test::Run() testing/gtest/src/gtest.cc:2057 #28 0x3e83cd9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #29 0x3e84a66 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #30 0x3e97b7a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #31 0x3e971b0 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #32 0x3e971b0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #33 0x359557c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #34 0x359557c in base::TestSuite::Run() base/test/test_suite.cc:227 Original issue's description: > Fixed use-after-free in LoadCallback in bookmark_storage.cc > > BookmarkStorage isn't ref counted anymore since > https://codereview.chromium.org/370323002, and the LoadCallback() task > now gets a WeakPtr to the owning BookmarkStorage. However, it gets a > raw pointer to the BookmarkLoadDetails object, which is still owned > by BookmarkStorage and may have been destroyed when the background > task runs. > > This happened on iOS tests after a recent merge. > > [email protected] > BUG=165760 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281830 [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=165760 Review URL: https://codereview.chromium.org/379643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281843 0039d316-1c4b-4281-b951-d872f2087c98

…ttps://codereview.chromium.org/386043002/) Reason for revert: Causes LSAN errors on CrOS: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/2299/steps/ui_unittests/logs/DoubleTap e.g. Indirect leak of 2904 byte(s) in 1 object(s) allocated from: #0 0x44edfb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0x9fbc47 in CreateStrategy ui/events/gesture_detection/velocity_tracker.cc:201 #2 0x9fbc47 in ui::VelocityTracker::VelocityTracker(ui::VelocityTracker::Strategy) ui/events/gesture_detection/velocity_tracker.cc:234 #3 0x9fa322 in ui::VelocityTrackerState::VelocityTrackerState() ui/events/gesture_detection/velocity_tracker_state.cc:18 #4 0x9f5d64 in ui::GestureDetector::GestureDetector(ui::GestureDetector::Config const&, ui::GestureDetector::GestureListener*, ui::GestureDetector::DoubleTapListener*) ui/events/gesture_detection/gesture_detector.cc:191 #5 0x1431ddf in GestureListenerImpl ui/events/gesture_detection/gesture_provider.cc:296 #6 0x1431ddf in ui::GestureProvider::InitGestureDetectors(ui::GestureProvider::Config const&) ui/events/gesture_detection/gesture_provider.cc:629 #7 0x142ebdd in ui::FilteredGestureProvider::FilteredGestureProvider(ui::GestureProvider::Config const&, ui::GestureProviderClient*) ui/events/gesture_detection/filtered_gesture_provider.cc:19 #8 0x1410cd3 in ui::GestureProviderAura::GestureProviderAura(ui::GestureProviderAuraClient*) ui/events/gestures/gesture_provider_aura.cc:19 #9 0x9e9bcd in ui::TouchExplorationController::TouchExplorationController(aura::Window*) ui/chromeos/touch_exploration_controller.cc:33 #10 0x663c47 in ui::TouchExplorationTest::SwitchTouchExplorationMode(bool) ui/chromeos/touch_exploration_controller_unittest.cc:214 #11 0x674532 in ui::TouchExplorationTest_DoubleTap_Test::TestBody() ui/chromeos/touch_exploration_controller_unittest.cc:563 #12 0x7babc8 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #13 0x7babc8 in testing::Test::Run() testing/gtest/src/gtest.cc:2061 #14 0x7bcd08 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #15 0x7bda46 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #16 0x7d072a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #17 0x7cfd70 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #18 0x7cfd70 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #19 0x7770b4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #20 0x7770b4 in base::TestSuite::Run() base/test/test_suite.cc:227 #21 0x76e0c1 in Run base/callback.h:401 #22 0x76e0c1 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback\u003Cint ()> const&, int, bool, base::Callback\u003Cvoid ()> const&) base/test/launcher/unit_test_launcher.cc:498 #23 0x76da5c in base::LaunchUnitTests(int, char**, base::Callback\u003Cint ()> const&) base/test/launcher/unit_test_launcher.cc:553 #24 0x59cfaa in main ui/base/test/run_all_unittests.cc:105 #25 0x7fd0195b276c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Added wrapper test class for touch_exploration_controller. > Wrapper class is currently located in the unittest file and is a friend of touch_exploration_controller. > > BUG=377040 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283741 [email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=377040 Review URL: https://codereview.chromium.org/404473006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283811 0039d316-1c4b-4281-b951-d872f2087c98

…://codereview.chromium.org/397233002/) Reason for revert: Broke 'Chromium Linux on Linux Clang (dbg)': http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/62289 AutofillDialogControllerTest.BillingVsShippingStreetAddress (run #1): [ RUN ] AutofillDialogControllerTest.BillingVsShippingStreetAddress Xlib: extension "RANDR" missing on display ":9". /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/debug/safe_iterator.h:289: error: attempt to advance a past-the-end iterator 1 steps, which falls outside its valid range. Objects involved in the operation: iterator @ 0x0x7fffd4a50d58 { state = past-the-end; references sequence @ 0x0x7fffd4a50d58 } Received signal 6 #0 0x7f716d77ecee base::debug::StackTrace::StackTrace() #1 0x7f716d77e827 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f7168451cb0 \u003Cunknown> #3 0x7f71648cf425 gsignal #4 0x7f71648d2b8b abort #5 0x7f7164ed25ad __gnu_debug::_Error_formatter::_M_error() #6 0x0000026271ce __gnu_debug::_Safe_iterator\u003C>::operator+=() #7 0x0000026270f5 __gnu_debug::_Safe_iterator\u003C>::operator+() #8 0x000005506f39 i18n::addressinput::(anonymous namespace)::CombineLinesForLanguage() #9 0x00000550703a i18n::addressinput::GetStreetAddressLinesAsSingleLine() #10 0x000005548289 autofill::(anonymous namespace)::FillStreetAddress() #11 0x000005547b91 autofill::AutofillField::FillFormField() #12 0x0000055907cd autofill::FormStructure::FillFields() #13 0x000004972335 autofill::AutofillDialogControllerImpl::Show() #14 0x000001ec0f2a autofill::(anonymous namespace)::AutofillDialogControllerTest::SetUpControllerWithFormData() #15 0x000001ece5c8 autofill::AutofillDialogControllerTest_BillingVsShippingStreetAddress_Test::TestBody() #16 0x0000039fcc63 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() #17 0x0000039e9f9e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #18 0x0000039e0e05 testing::Test::Run() #19 0x0000039e151b testing::TestInfo::Run() #20 0x0000039e1b0a testing::TestCase::Run() #21 0x0000039e6118 testing::internal::UnitTestImpl::RunAllTests() #22 0x0000039f5973 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() #23 0x0000039ebb0e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #24 0x0000039e5da4 testing::UnitTest::Run() #25 0x000005b72b61 RUN_ALL_TESTS() #26 0x000005b71be7 base::TestSuite::Run() #27 0x000005b8455d content::UnitTestTestSuite::Run() #28 0x000003aa40d2 base::internal::RunnableAdapter\u003C>::Run() #29 0x000003aa403c base::internal::InvokeHelper\u003C>::MakeItSo() #30 0x000003aa3fea base::internal::Invoker\u003C>::Run() #31 0x000002a29e9e base::Callback\u003C>::Run() #32 0x000005b6b830 base::(anonymous namespace)::LaunchUnitTestsInternal() #33 0x000005b6b527 base::LaunchUnitTests() #34 0x000003aa3db5 main #35 0x7f71648ba76d __libc_start_main #36 0x000000715159 \u003Cunknown> r8: 00007f715f665980 r9: 00007fffd4a507d8 r10: 0000000000000008 r11: 0000000000000206 r12: 00007fffd4a50aa0 r13: 0000000000000001 r14: 0000000000000001 r15: 0000000000000000 di: 00000000000016b2 si: 00000000000016b2 bp: 0000000000000002 bx: 00007fffd4a50a30 dx: 0000000000000006 ax: 0000000000000000 cx: ffffffffffffffff sp: 00007fffd4a50828 ip: 00007f71648cf425 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 Original issue's description: > Use language-specific street address line separators > > Fill street address into a single-line text input field with separators > that depend on the language code of the profile. > > TEST=components_unittests:AutofillFieldTest.FillStreetAddress* > BUG=270261 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284335 [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=270261 Review URL: https://codereview.chromium.org/401103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284340 0039d316-1c4b-4281-b951-d872f2087c98

Reverting as broke chrome and chromeos dbg builders: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32615/steps/browser_tests/logs/SuccessfulLoadUMA [ RUN ] NaClBrowserTestPnacl.SuccessfulLoadUMA Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [18889:18889:0722/130648:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. HTTP server started on http://127.0.0.1:56115... sending server_data: {"host": "127.0.0.1", "port": 56115} (36 bytes) [9:10:0722/130650:ERROR:pnacl_translation_resource_host.cc(135)] Got invalid platformfilefortransit /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/debug/vector:461: error: attempt to insert into container with an iterator from a different container. Objects involved in the operation: sequence "this" @ 0x0x392ba6c93260 { } iterator "__position" @ 0x0x7fff9ff24e20 { state = past-the-end; references sequence @ 0x0x7fff9ff24e20 } [18889:18938:0722/130651:WARNING:raw_channel_posix.cc(214)] recvmsg: Connection reset by peer BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7fe4bf491cee base::debug::StackTrace::StackTrace() #1 0x000004af93fa content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fe4b68074a0 \u003Cunknown> #3 0x7fe4b68b9a43 __poll #4 0x7fe4b76faff6 \u003Cunknown> #5 0x7fe4b76fb124 g_main_context_iteration #6 0x7fe4bf44ff75 base::MessagePumpGlib::Run() #7 0x7fe4bf54b1f0 base::MessageLoop::RunHandler() #8 0x7fe4bf5b18e2 base::RunLoop::Run() #9 0x000004b63969 content::RunThisRunLoop() #10 0x000004b638fa content::RunMessageLoop() #11 0x000004b0ea15 content::JavascriptTestObserver::Run() #12 0x000001312927 NaClBrowserTestBase::RunJavascriptTest() #13 0x000001312a48 NaClBrowserTestBase::RunLoadTest() #14 0x00000130f514 (anonymous namespace)::NaClBrowserTestPnacl_SuccessfulLoadUMA_Test::RunTestOnMai ... > Pepper: Delete FileDownloader in trusted plugin. > > This simplifies PnaclCoordinator considerably and reduces the total > amount of code in the trusted plugin. > > BUG=239656 > > Review URL: https://codereview.chromium.org/393693004 [email protected] Review URL: https://codereview.chromium.org/406323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284791 0039d316-1c4b-4281-b951-d872f2087c98

…um.org/420603011/) Reason for revert: Appears to have broken Linux Chromium OS ASan LSan Tests (3) (stats): http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29 athena_unittests failed 13 Basic Accelerators AppSelection BasicTransition VirtualKeyboardTransition Basic CreateContainer GrabAndMouseCapture GrabInputContainer GrabShouldNotBlockVirtualKeyboard NonActivatableContainer Zorder Empty [ RUN ] ActivityManagerTest.Basic ================================================================= ==8808==ERROR: AddressSanitizer: heap-use-after-free on address 0x60200000ad70 at pc 0x00000054eebe bp 0x7fff975aaa70 sp 0x7fff975aaa68 READ of size 8 at 0x60200000ad70 thread T0 #0 0x54eebd in __find<__gnu_cxx::__normal_iterator<athena::WindowManagerObserver **, std::vector<athena::WindowManagerObserver *, std::allocator<athena::WindowManagerObserver *> > >, athena::WindowManagerObserver *> /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_algo.h:190:8 #1 0x54eebd in find<__gnu_cxx::__normal_iterator<athena::WindowManagerObserver **, std::vector<athena::WindowManagerObserver *, std::allocator<athena::WindowManagerObserver *> > >, athena::WindowManagerObserver *> /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_algo.h:4402 #2 0x54eebd in ObserverListBase<athena::WindowManagerObserver>::RemoveObserver(athena::WindowManagerObserver*) base/observer_list.h:168 #3 0x560f79 in ~SplitViewController athena/wm/split_view_controller.cc:63:3 #4 0x560f79 in athena::SplitViewController::~SplitViewController() athena/wm/split_view_controller.cc:62 #5 0x54d340 in operator() base/memory/scoped_ptr.h:137:5 #6 0x54d340 in ~scoped_ptr_impl base/memory/scoped_ptr.h:220 #7 0x54d340 in ~scoped_ptr base/memory/scoped_ptr.h:432 #8 0x54d340 in athena::(anonymous namespace)::WindowManagerImpl::~WindowManagerImpl() athena/wm/window_manager_impl.cc:124 #9 0x54d57d in athena::(anonymous namespace)::WindowManagerImpl::~WindowManagerImpl() athena/wm/window_manager_impl.cc:116:41 #10 0x567127 in athena::ShutdownAthena() athena/main/athena_launcher.cc:86:3 #11 0x5657af in athena::test::AthenaTestHelper::TearDown() athena/test/athena_test_helper.cc:98:3 #12 0x5645b6 in athena::test::AthenaTestBase::TearDown() athena/test/athena_test_base.cc:51:3 #13 0x4fc938 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #14 0x4fd676 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #15 0x5138f5 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #16 0x512ee6 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #17 0x512ee6 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #18 0x1602b74 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #19 0x1602b74 in base::TestSuite::Run() base/test/test_suite.cc:227 #20 0x15fa231 in Run base/callback.h:401:12 #21 0x15fa231 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #22 0x15faf7e in base::LaunchUnitTestsSerially(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:564:10 #23 0x4d74ca in main athena/test/athena_unittests.cc:51:10 #24 0x7f9020d2d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 #25 0x4d726c in _start (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x4d726c) Please follow instructions on how to setup ASan on your workstation here: http://www.chromium.org/developers/testing/addresssanitizer LSan may also be of use: http://www.chromium.org/developers/testing/leaksanitizer You may also want run your patch through the linux_lsan try bot. Original issue's description: > Split Screen mode implementation. > > Implements Split Screen mode and window cycling behavior. > > BUG=383421 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288593 TBR=oshima,sadrul,mfomitchev,mukai NOTRY=true Review URL: https://codereview.chromium.org/451363002 Cr-Commit-Position: refs/heads/master@{#288607} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288607 0039d316-1c4b-4281-b951-d872f2087c98

…or certain languages. (patchset #6 of https://codereview.chromium.org/382973002/) Reason for revert: Link failure of browser_tests on ChromiumOS build bot: http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Builder%20%28dbg%29&number=50192 Original issue's description: > ChromeOS: should not show "Language changed" notification for certain languages. > > BUG=317718 > TEST=manually tested > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289985 NOTREECHECKS=true NOTRY=true [email protected], [email protected], [email protected] Review URL: https://codereview.chromium.org/471403005 Cr-Commit-Position: refs/heads/master@{#290017} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290017 0039d316-1c4b-4281-b951-d872f2087c98

…um.org/420603011/) Reason for revert: Appears to have broken Linux Chromium OS ASan LSan Tests (3) (stats): http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29 athena_unittests failed 13 Basic Accelerators AppSelection BasicTransition VirtualKeyboardTransition Basic CreateContainer GrabAndMouseCapture GrabInputContainer GrabShouldNotBlockVirtualKeyboard NonActivatableContainer Zorder Empty [ RUN ] ActivityManagerTest.Basic ================================================================= ==8808==ERROR: AddressSanitizer: heap-use-after-free on address 0x60200000ad70 at pc 0x00000054eebe bp 0x7fff975aaa70 sp 0x7fff975aaa68 READ of size 8 at 0x60200000ad70 thread T0 #0 0x54eebd in __find<__gnu_cxx::__normal_iterator<athena::WindowManagerObserver **, std::vector<athena::WindowManagerObserver *, std::allocator<athena::WindowManagerObserver *> > >, athena::WindowManagerObserver *> /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_algo.h:190:8 #1 0x54eebd in find<__gnu_cxx::__normal_iterator<athena::WindowManagerObserver **, std::vector<athena::WindowManagerObserver *, std::allocator<athena::WindowManagerObserver *> > >, athena::WindowManagerObserver *> /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/bits/stl_algo.h:4402 #2 0x54eebd in ObserverListBase<athena::WindowManagerObserver>::RemoveObserver(athena::WindowManagerObserver*) base/observer_list.h:168 #3 0x560f79 in ~SplitViewController athena/wm/split_view_controller.cc:63:3 #4 0x560f79 in athena::SplitViewController::~SplitViewController() athena/wm/split_view_controller.cc:62 #5 0x54d340 in operator() base/memory/scoped_ptr.h:137:5 #6 0x54d340 in ~scoped_ptr_impl base/memory/scoped_ptr.h:220 #7 0x54d340 in ~scoped_ptr base/memory/scoped_ptr.h:432 #8 0x54d340 in athena::(anonymous namespace)::WindowManagerImpl::~WindowManagerImpl() athena/wm/window_manager_impl.cc:124 #9 0x54d57d in athena::(anonymous namespace)::WindowManagerImpl::~WindowManagerImpl() athena/wm/window_manager_impl.cc:116:41 #10 0x567127 in athena::ShutdownAthena() athena/main/athena_launcher.cc:86:3 #11 0x5657af in athena::test::AthenaTestHelper::TearDown() athena/test/athena_test_helper.cc:98:3 #12 0x5645b6 in athena::test::AthenaTestBase::TearDown() athena/test/athena_test_base.cc:51:3 #13 0x4fc938 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #14 0x4fd676 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #15 0x5138f5 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #16 0x512ee6 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #17 0x512ee6 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #18 0x1602b74 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #19 0x1602b74 in base::TestSuite::Run() base/test/test_suite.cc:227 #20 0x15fa231 in Run base/callback.h:401:12 #21 0x15fa231 in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #22 0x15faf7e in base::LaunchUnitTestsSerially(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:564:10 #23 0x4d74ca in main athena/test/athena_unittests.cc:51:10 #24 0x7f9020d2d76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 #25 0x4d726c in _start (/mnt/data/b/build/slave/Linux_Chromium_OS_ASan_LSan_Tests__3_/build/src/out/Release/athena_unittests+0x4d726c) Please follow instructions on how to setup ASan on your workstation here: http://www.chromium.org/developers/testing/addresssanitizer LSan may also be of use: http://www.chromium.org/developers/testing/leaksanitizer You may also want run your patch through the linux_lsan try bot. Original issue's description: > Split Screen mode implementation. > > Implements Split Screen mode and window cycling behavior. > > BUG=383421 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288593 TBR=oshima,sadrul,mfomitchev,mukai NOTRY=true Review URL: https://codereview.chromium.org/451363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288607 0039d316-1c4b-4281-b951-d872f2087c98

… (patchset #2 id:60001 of https://codereview.chromium.org/562763002/) Reason for revert: This broken the Linux ASan LSan Tests: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7506 http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/5717 Sample callstacks: Direct leak of 400 byte(s) in 10 object(s) allocated from: #0 0x55c6eb in __interceptor_malloc (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x55c6eb) #1 0xab24bb8 in raw_desc_to_config third_party/libusb/src/libusb/descriptor.c:501:45 #2 0xab24ab9 in libusb_get_active_config_descriptor third_party/libusb/src/libusb/descriptor.c:601:7 #3 0xab14aae in device::UsbDeviceImpl::GetConfiguration() device/usb/usb_device_impl.cc:199:9 #4 0xb37d57b in EnumerateOnFileThread(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>) chrome/browser/devtools/device/usb/android_usb_device.cc:262:42 #5 0xb38aebf in Run base/bind_internal.h:288:12 #6 0xb38aebf in base::internal::InvokeHelper\u003Cfalse, void, base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, void (crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*) base/bind_internal.h:927 #7 0x2d58bff in Run base/callback.h:401:12 #8 0x2d58bff in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #9 0x2ca519c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #10 0x2ca629e in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #11 0x2ca629e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #12 0x2c23ddf in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #13 0x2cd57b4 in base::RunLoop::Run() base/run_loop.cc:49:3 #14 0x2ca39c4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #15 0x50fd018 in content::BrowserThreadImpl::FileThreadRun(base::MessageLoop*) content/browser/browser_thread_impl.cc:190:3 #16 0x50fdca7 in content::BrowserThreadImpl::Run(base::MessageLoop*) content/browser/browser_thread_impl.cc:244:14 #17 0x2d1ebc8 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #18 0x2d12b20 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #19 0x7f4d560a3e99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Direct leak of 400 byte(s) in 10 object(s) allocated from: #0 0x55c6eb in __interceptor_malloc (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/browser_tests+0x55c6eb) #1 0xab24bb8 in raw_desc_to_config third_party/libusb/src/libusb/descriptor.c:501:45 #2 0xab24ab9 in libusb_get_active_config_descriptor third_party/libusb/src/libusb/descriptor.c:601:7 #3 0xab14aae in device::UsbDeviceImpl::GetConfiguration() device/usb/usb_device_impl.cc:199:9 #4 0xb37d57b in EnumerateOnFileThread(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>) chrome/browser/devtools/device/usb/android_usb_device.cc:262:42 #5 0xb38aebf in Run base/bind_internal.h:288:12 #6 0xb38aebf in base::internal::InvokeHelper\u003Cfalse, void, base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, void (crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*) base/bind_internal.h:927 #7 0x2d58bff in Run base/callback.h:401:12 #8 0x2d58bff in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #9 0x2ca519c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #10 0x2ca629e in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #11 0x2ca629e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #12 0x2c23ddf in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #13 0x2cd57b4 in base::RunLoop::Run() base/run_loop.cc:49:3 #14 0x2ca39c4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #15 0x50fd018 in content::BrowserThreadImpl::FileThreadRun(base::MessageLoop*) content/browser/browser_thread_impl.cc:190:3 #16 0x50fdca7 in content::BrowserThreadImpl::Run(base::MessageLoop*) content/browser/browser_thread_impl.cc:244:14 #17 0x2d1ebc8 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #18 0x2d12b20 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #19 0x7f4aef980e99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Original issue's description: > Convert device::UsbConfigDescriptor and friends to structs. > > These classes do not need to be classes and expecially don't need to be > abstract classes as this leads to a complicated implementation and > complicated tests. All USB devices no matter the platform will have the > same descriptor data. > > This change follows the model of device::HidDeviceInfo. > > BUG= > > Committed: https://crrev.com/be9e363a3af57bd313fbb96ec3b5fa02cef769b5 > Cr-Commit-Position: refs/heads/master@{#294594} [email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/567003002 Cr-Commit-Position: refs/heads/master@{#294640}

…ngs (patchset #6 id:240001 of https://codereview.chromium.org/276573011/) Reason for revert: Becuase this CL seems to break linux asan test http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/882 Original issue's description: > remove deprecated extension notification from content_settings. > > Use ExtensionRegistryObserver instead. > > [email protected] > BUG=354046, 354458 > TEST=unit_tests > > Committed: https://crrev.com/76ad58487578183de69a8caeb48b8a22dccad652 > Cr-Commit-Position: refs/heads/master@{#294768} [email protected] NOTREECHECKS=true NOTRY=true BUG=354046, 354458 Review URL: https://codereview.chromium.org/553263004 Cr-Commit-Position: refs/heads/master@{#294773}

…id:100001 of https://codereview.chromium.org/568793002/) Reason for revert: Sorry to revert but I randomly noticed this to be causing a top crasher e.g. go/crash/75090c1e31f33cfd The reason is because the patch explicitly calls PluginGlobals::SetPluginProxyDelegate with NULL from PpapiThread::Shutdown but the pointer is used immediately inside the function. I guess it should be a simple fix. I was going to put up a fix which just reset the browser_sender_ to NULL in that case, but then I noticed there were cases where we call GetBrowserSender() and use it without checking whether it is NULL (e.g. https://code.google.com/p/chromium/codesearch#search/&q=%22PluginGlobals::Get()-%3EGetBrowserSender()-%3ESend%22&sq=package:chromium&type=cs) I felt it would be better to just revert for now, sorry :( Original issue's description: > PPAPI: Fix GetBrowserInterface race conditions > > BUG=413513 > > Committed: https://crrev.com/d1b2c8f719b0ab471a476bf53911a3657bb4c06a > Cr-Commit-Position: refs/heads/master@{#294715} [email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=413513 Review URL: https://codereview.chromium.org/566243004 Cr-Commit-Position: refs/heads/master@{#294782}

…disable GCM (patchset #8 id:150001 of https://codereview.chromium.org/561943002/) Reason for revert: this CL might be breaking browser_tests and interactive_ui_tests on ChromeOS because it's starting a request on startup. here's an example: [15345:15369:0918/132152:ERROR:leak_tracker.h(97)] Leaked 0x11cd70da7cc0 which was allocated by: [15345:15369:0918/132152:ERROR:leak_tracker.h(98)] #0 0x7f44b584025e base::debug::StackTrace::StackTrace() #1 0x000000dfc481 base::debug::LeakTracker<>::LeakTracker() #2 0x000000df3e8d SystemURLRequestContextGetter::SystemURLRequestContextGetter() #3 0x000000df57f1 IOThread::InitSystemRequestContext() #4 0x000000df570b IOThread::system_url_request_context_getter() #5 0x000001443d9e BrowserProcessImpl::system_request_context() #6 0x000001028a8e SafeBrowsingService::Initialize() #7 0x0000014462c9 BrowserProcessImpl::CreateSafeBrowsingService() #8 0x000001446196 BrowserProcessImpl::safe_browsing_service() #9 0x0000014b9a06 ChromeResourceDispatcherHostDelegate::ChromeResourceDispatcherHostDelegate() #10 0x0000014466dc BrowserProcessImpl::ResourceDispatcherHostCreated() #11 0x0000008a88e5 chrome::ChromeContentBrowserClient::ResourceDispatcherHostCreated() #12 0x7f44be489a2f content::ResourceDispatcherHostImpl::ResourceDispatcherHostImpl() #13 0x7f44be060f44 content::BrowserMainLoop::BrowserThreadsStarted() #14 0x7f44be068302 base::internal::RunnableAdapter<>::Run() #15 0x7f44be06826c base::internal::InvokeHelper<>::MakeItSo() #16 0x7f44be06821a base::internal::Invoker<>::Run() #17 0x7f44be54e46e base::Callback<>::Run() #18 0x7f44be8d223b content::StartupTaskRunner::RunAllTasksNow() #19 0x7f44be05ff97 content::BrowserMainLoop::CreateStartupTasks() #20 0x7f44be06b824 content::BrowserMainRunnerImpl::Initialize() #21 0x7f44be05c7df content::BrowserMain() #22 0x7f44bdee5f6f content::RunNamedProcessTypeMain() #23 0x7f44bdee9268 content::ContentMainRunnerImpl::Run() #24 0x7f44bdee5505 content::ContentMain() #25 0x0000041aa8cb content::BrowserTestBase::SetUp() #26 0x00000173e117 InProcessBrowserTest::SetUp() #27 0x000000671180 ExtensionBrowserTest::SetUp() #28 0x0000006711b2 ExtensionBrowserTest::SetUp() #29 0x0000017fb993 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #30 0x0000017e8bfe testing::internal::HandleExceptionsInMethodIfSupported<>() #31 0x0000017dd1e3 testing::Test::Run() #32 0x0000017dd92b testing::TestInfo::Run() #33 0x0000017ddf1a testing::TestCase::Run() #34 0x0000017e3413 testing::internal::UnitTestImpl::RunAllTests() #35 0x0000017f47d3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #36 0x0000017ea96e testing::internal::HandleExceptionsInMethodIfSupported<>() #37 0x0000017e30b1 testing::UnitTest::Run() #38 0x000004187e41 RUN_ALL_TESTS() #39 0x000004186e67 base::TestSuite::Run() #40 0x0000007fcd62 InteractiveUITestSuiteRunner::RunTestSuite() #41 0x00000173c7b8 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #42 0x0000041bc2fb content::LaunchTests() #43 0x00000173c6e9 LaunchChromeTests() #44 0x0000007fccbf main #45 0x7f44ad8ed76d __libc_start_main #46 0x000000601389 <unknown> [15345:15369:0918/132152:FATAL:leak_tracker.h(102)] Check failed: 0u == count (0 vs. 1) #0 0x7f44b584025e base::debug::StackTrace::StackTrace() #1 0x7f44b58d7a62 logging::LogMessage::~LogMessage() #2 0x000000dfdd01 base::debug::LeakTracker<>::CheckForLeaks() #3 0x000000df8e13 IOThread::CleanUp() #4 0x7f44be0810b6 content::BrowserThreadImpl::CleanUp() #5 0x7f44be07e852 content::BrowserProcessSubThread::CleanUp() #6 0x7f44b59d0601 base::Thread::ThreadMain() #7 0x7f44b59bba3c base::(anonymous namespace)::ThreadFunc() #8 0x7f44b1aa9e9a start_thread #9 0x7f44ad9c03fd clone Original issue's description: > Add GCMChannelStatusSyncer to schedule requests and enable/disable GCM > > BUG=384041 > TEST=new tests added > > Committed: https://crrev.com/3c23f4a188e171998f3042ad62f4aa5717e66d63 > Cr-Commit-Position: refs/heads/master@{#295524} [email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=384041 Review URL: https://codereview.chromium.org/582913003 Cr-Commit-Position: refs/heads/master@{#295549}

…50001 of https://codereview.chromium.org/542733002/) Reason for revert: Introduced memory leaks on linux asan http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/5892: Direct leak of 80 byte(s) in 2 object(s) allocated from: #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb) #1 0x309f8d7 in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:620:5 #2 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17 #3 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17 #4 0x2e3b0bf in Run base/callback.h:401:12 #5 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #6 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #7 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #8 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #9 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #10 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3 #11 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #12 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #13 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #14 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Indirect leak of 64 byte(s) in 2 object(s) allocated from: #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb) #1 0x30ebaaf in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:435:5 #2 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36 #3 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11 #4 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17 #5 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17 #6 0x2e3b0bf in Run base/callback.h:401:12 #7 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #8 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #9 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #10 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #11 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #12 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3 #13 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #14 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #15 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #16 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Indirect leak of 36 byte(s) in 1 object(s) allocated from: #0 0x501ccb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/net_unittests+0x501ccb) #1 0x30c0696 in AllocateData net/disk_cache/blockfile/storage_block-inl.h:179:5 #2 0x30c0696 in disk_cache::StorageBlock<disk_cache::RankingsNode>::Load() net/disk_cache/blockfile/storage_block-inl.h:121 #3 0x30e6fe9 in disk_cache::Rankings::GetRanking(disk_cache::StorageBlock<disk_cache::RankingsNode>*) net/disk_cache/blockfile/rankings.cc:586:8 #4 0x30ebd5a in disk_cache::Rankings::GetNext(disk_cache::StorageBlock<disk_cache::RankingsNode>*, disk_cache::Rankings::List) net/disk_cache/blockfile/rankings.cc:440:8 #5 0x30a219d in disk_cache::BackendImpl::OpenFollowingEntryFromList(disk_cache::Rankings::List, disk_cache::StorageBlock<disk_cache::RankingsNode>**, disk_cache::EntryImpl**) net/disk_cache/blockfile/backend_impl.cc:1694:36 #6 0x309fa3d in disk_cache::BackendImpl::OpenNextEntryImpl(void**) net/disk_cache/blockfile/backend_impl.cc:638:11 #7 0x30a02cd in disk_cache::BackendImpl::SyncOpenNextEntry(void**, disk_cache::Entry**) net/disk_cache/blockfile/backend_impl.cc:436:17 #8 0x30d49dd in disk_cache::BackendIO::ExecuteBackendOperation() net/disk_cache/blockfile/in_flight_backend_io.cc:248:17 #9 0x2e3b0bf in Run base/callback.h:401:12 #10 0x2e3b0bf in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #11 0x2dc22fc in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #12 0x2dc33cc in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #13 0x2dc33cc in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #14 0x2e2361f in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #15 0x2ddd94b in base::RunLoop::Run() base/run_loop.cc:54:3 #16 0x2dc0bc4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #17 0x2e0ad90 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #18 0x2dfeaf0 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #19 0x7fa9f4e0ce99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Original issue's description: > Remove void** from disk_cache interface. > > Enumeration and iteration were passing around void**. With this CL, we > instead use an Iterator object. > > [email protected],[email protected],[email protected] > BUG=413644 > > Committed: https://crrev.com/732c8306d4864296511e7a3a252724b1bb34c342 > Cr-Commit-Position: refs/heads/master@{#295659} [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=413644 Review URL: https://codereview.chromium.org/585833002 Cr-Commit-Position: refs/heads/master@{#295677}

…410) (patchset #1 id:1 of https://codereview.chromium.org/590143002/) Reason for revert: Linux ASAN memory leaks after "Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407)" http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7724/steps/content_unittests/logs/stdio ==30366==ERROR: LeakSanitizer: detected memory leaks Direct leak of 34 byte(s) in 1 object(s) allocated from: #0 0x50482b in malloc (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x50482b) #1 0x58b7516 in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:538:20 #2 0x58b7516 in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:554 #3 0x58b7516 in createUninitialized third_party/WebKit/Source/wtf/text/StringImpl.cpp:299 #4 0x58b7516 in WTF::StringImpl::create(unsigned char const*, unsigned int) third_party/WebKit/Source/wtf/text/StringImpl.cpp:418 #5 0x58e809f in WTF::String::fromUTF8(unsigned char const*, unsigned long) third_party/WebKit/Source/wtf/text/WTFString.cpp:911:16 #6 0x58ffa2f in fromUTF8 third_party/WebKit/Source/wtf/text/WTFString.h:400:67 #7 0x58ffa2f in blink::WebString::fromUTF8(char const*, unsigned long) third_party/WebKit/Source/platform/exported/WebString.cpp:91 #8 0x20a09ac in WebString<23> third_party/WebKit/public/platform/WebString.h:113:16 #9 0x20a09ac in content::MockMediaStreamRegistry::AddVideoTrack(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/renderer/media/mock_media_stream_registry.cc:36 #10 0x217484a in VideoSourceHandlerTest_OpenWithoutClose_Test content/renderer/media/video_source_handler_unittest.cc:97:1 #11 0x217484a in testing::internal::TestFactoryImpl<content::VideoSourceHandlerTest_OpenWithoutClose_Test>::CreateTest() testing/gtest/include/gtest/internal/gtest-internal.h:486 #12 0x2f13c63 in HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test *> testing/gtest/src/gtest.cc:2418:12 #13 0x2f13c63 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2601 #14 0x2f14df6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #15 0x2f28853 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #16 0x2f27e54 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #17 0x2f27e54 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #18 0x2eb1e53 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #19 0x2eb1e53 in base::TestSuite::Run() base/test/test_suite.cc:226 #20 0x2ea717b in Run base/callback.h:401:12 #21 0x2ea717b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #22 0x2ea6c70 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553:10 #23 0x1ff5d0c in main content/test/run_all_unittests.cc:14:10 #24 0x7f375d21876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Roll src/third_party/WebKit 0f6e289:a63b92e (svn 182407:182410) > > Summary of changes available at: > https://chromium.googlesource.com/chromium/blink/+log/0f6e289..a63b92e > > [email protected],[email protected],[email protected] > > Committed: https://crrev.com/09e1192db2fc7c5295eb373626b77945ca10aee3 > Cr-Commit-Position: refs/heads/master@{#295959} [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/593693004 Cr-Commit-Position: refs/heads/master@{#295961}

…407) (patchset #1 id:1 of https://codereview.chromium.org/588163003/) Reason for revert: Linux ASAN memory leaks after "Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407)" http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7724/steps/content_unittests/logs/stdio ==30366==ERROR: LeakSanitizer: detected memory leaks Direct leak of 34 byte(s) in 1 object(s) allocated from: #0 0x50482b in malloc (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/content_unittests+0x50482b) #1 0x58b7516 in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:538:20 #2 0x58b7516 in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:554 #3 0x58b7516 in createUninitialized third_party/WebKit/Source/wtf/text/StringImpl.cpp:299 #4 0x58b7516 in WTF::StringImpl::create(unsigned char const*, unsigned int) third_party/WebKit/Source/wtf/text/StringImpl.cpp:418 #5 0x58e809f in WTF::String::fromUTF8(unsigned char const*, unsigned long) third_party/WebKit/Source/wtf/text/WTFString.cpp:911:16 #6 0x58ffa2f in fromUTF8 third_party/WebKit/Source/wtf/text/WTFString.h:400:67 #7 0x58ffa2f in blink::WebString::fromUTF8(char const*, unsigned long) third_party/WebKit/Source/platform/exported/WebString.cpp:91 #8 0x20a09ac in WebString<23> third_party/WebKit/public/platform/WebString.h:113:16 #9 0x20a09ac in content::MockMediaStreamRegistry::AddVideoTrack(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) content/renderer/media/mock_media_stream_registry.cc:36 #10 0x217484a in VideoSourceHandlerTest_OpenWithoutClose_Test content/renderer/media/video_source_handler_unittest.cc:97:1 #11 0x217484a in testing::internal::TestFactoryImpl<content::VideoSourceHandlerTest_OpenWithoutClose_Test>::CreateTest() testing/gtest/include/gtest/internal/gtest-internal.h:486 #12 0x2f13c63 in HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test *> testing/gtest/src/gtest.cc:2418:12 #13 0x2f13c63 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2601 #14 0x2f14df6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #15 0x2f28853 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #16 0x2f27e54 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #17 0x2f27e54 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #18 0x2eb1e53 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #19 0x2eb1e53 in base::TestSuite::Run() base/test/test_suite.cc:226 #20 0x2ea717b in Run base/callback.h:401:12 #21 0x2ea717b in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int ()> const&, int, bool, base::Callback<void ()> const&) base/test/launcher/unit_test_launcher.cc:498 #22 0x2ea6c70 in base::LaunchUnitTests(int, char**, base::Callback<int ()> const&) base/test/launcher/unit_test_launcher.cc:553:10 #23 0x1ff5d0c in main content/test/run_all_unittests.cc:14:10 #24 0x7f375d21876c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Roll src/third_party/WebKit 08e97a9:0f6e289 (svn 182386:182407) > > Summary of changes available at: > https://chromium.googlesource.com/chromium/blink/+log/08e97a9..0f6e289 > > [email protected],[email protected],[email protected] > > Committed: https://crrev.com/f57e3cf2113ac892f16777e5ab225f3c68b94ede > Cr-Commit-Position: refs/heads/master@{#295950} [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/592783002 Cr-Commit-Position: refs/heads/master@{#295962}

…the point of creation. (patchset #6 id:120001 of https://codereview.chromium.org/565803002/) Reason for revert: investigate build error Original issue's description: > Removing browser.Start() and instead starts the browser at the point of creation. > > BUG=412126 > > Committed: https://crrev.com/01c68e8765254d9971296b291ff718b4f6af3004 > Cr-Commit-Position: refs/heads/master@{#295591} > > Committed: https://crrev.com/74c6ef17a08754abadb6fb64da14249898285fa8 > Cr-Commit-Position: refs/heads/master@{#296107} [email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=412126 Review URL: https://codereview.chromium.org/601473002 Cr-Commit-Position: refs/heads/master@{#296247}

… id:220001 of https://codereview.chromium.org/543753002/) Reason for revert: One of the new unit tests failed with uninit memory access: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%282%29/builds/43137/ Original issue's description: > [Suggestions] Move ImageManager to the component > > Keeps the fetcher functionality as ImageFetcherImpl in chrome/browser/search/suggestions. > > BUG=387751 > TBR=blundell > TEST=ImageManagerTest,ImageFetcherBrowserTest > > Committed: https://crrev.com/5a25f30080dd57d200679546c970d70f2247def9 > Cr-Commit-Position: refs/heads/master@{#296503} [email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=387751 Review URL: https://codereview.chromium.org/600203002 Cr-Commit-Position: refs/heads/master@{#296553}

…id:100001 of https://codereview.chromium.org/584653004/) Reason for revert: The new tests are flaky: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944 Original issue's description: > [AiS] Merge answers into highest-scoring result > > Answer contents and type must always be copied to the highest-scoring > suggestion, to ensure answers are not lost due to suggestion > deduplication. > > BUG=415836 > R=mpearson > > Committed: https://crrev.com/978a4bf4a3be714950ed265660bd9566f7abd922 > Cr-Commit-Position: refs/heads/master@{#296520} [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=415836 Review URL: https://codereview.chromium.org/598253002 Cr-Commit-Position: refs/heads/master@{#296555}

…patchset #1 id:1 of https://codereview.chromium.org/598253002/) Reason for revert: Broken GN build: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/13101 Original issue's description: > Revert of [AiS] Merge answers into highest-scoring result (patchset #6 id:100001 of https://codereview.chromium.org/584653004/) > > Reason for revert: > The new tests are flaky: > http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7944 > > Original issue's description: > > [AiS] Merge answers into highest-scoring result > > > > Answer contents and type must always be copied to the highest-scoring > > suggestion, to ensure answers are not lost due to suggestion > > deduplication. > > > > BUG=415836 > > R=mpearson > > > > Committed: https://crrev.com/978a4bf4a3be714950ed265660bd9566f7abd922 > > Cr-Commit-Position: refs/heads/master@{#296520} > > [email protected],[email protected],[email protected],[email protected] > NOTREECHECKS=true > NOTRY=true > BUG=415836 > > Committed: https://crrev.com/ba5d32190d4f056b11738b050b94895b655c52f7 > Cr-Commit-Position: refs/heads/master@{#296555} [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=415836 Review URL: https://codereview.chromium.org/599273002 Cr-Commit-Position: refs/heads/master@{#296573}

…data (patchset #6 id:100001 of https://codereview.chromium.org/562423002/) Reason for revert: We're not longer doing this. Original issue's description: > Clear GCM data when the user clears cookies and other site data > > This is needed for the work to drop GCM sign-in enforcement. Since > we no longer wipe out the GCM data when the user signs out, we need > to give user a chance to clear the data if he or she wants. > > BUG=384041 > TEST=Manual test by selecting "Cookies and other site and plugin data" > > Committed: https://crrev.com/6967652cefa1e306d21e70d4a12dcc0ac572c28b > Cr-Commit-Position: refs/heads/master@{#294754} [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=384041 Review URL: https://codereview.chromium.org/608813003 Cr-Commit-Position: refs/heads/master@{#296989}

Cr-Commit-Position: refs/branch-heads/2171@{#6} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}

Remove LOG(FATAL) from the path that is not actually fatal, but is valid on format enumeration. If a format is not suitable, we should just continue querying the hardware for more. TBR to prevent CFQ failures, as revert is now too complicated. [email protected],[email protected] BUG=None TEST=None Review URL: https://codereview.chromium.org/847273004 Cr-Commit-Position: refs/branch-heads/2272@{#6} Cr-Branched-From: 827a380-refs/heads/master@{#310958}

#6 id:100001 of https://codereview.chromium.org/869233008/) Reason for revert: Possibly caused issues on Win WebGL debug: http://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/26853 BUG=457685 Original issue's description: > Use Surfaces on Windows, Linux, and Mac OS (try #4) > > Surfaces should be feature-complete, so try enabling them on Windows, Linux, and Mac OS. They're still disabled on Chrome OS because they rely on single-threaded browser compositing, and on Android because they haven't been implemented there yet. > > BUG=334090 > [email protected] > > Committed: https://crrev.com/951a985779ceb581576c8b3c0f83223ea3689dd0 > Cr-Commit-Position: refs/heads/master@{#315682} TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=334090 Review URL: https://codereview.chromium.org/917913002 Cr-Commit-Position: refs/heads/master@{#315831}

…01 of https://codereview.chromium.org/899403003/) Reason for revert: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/55780 found more ODR violations in libjingle. Original issue's description: > Linux: Enable ODR violation detection. > > BUG=449754 > > Committed: https://crrev.com/e86588abd0f3b65777d8bc679747eeb6bbdf21f8 > Cr-Commit-Position: refs/heads/master@{#315906} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=449754 Review URL: https://codereview.chromium.org/874743007 Cr-Commit-Position: refs/heads/master@{#315916}

…ttps://codereview.chromium.org/899403002/) Reason for revert: This is blocking downstream and people are complaining. I tried to land the downstream fix but there was a compile problem. Sorry, hope you can fix the problems and re-land. Original issue's description: > Upstream Enhanced Bookmark Model > > This is the data layout of enhanced bookmark. There is no reason why > this class should live in private repository. > > BUG=428832 > > Committed: https://crrev.com/691b64f43fc0a69752344e5edbbc4d8f406cf261 > Cr-Commit-Position: refs/heads/master@{#315939} [email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=428832 Review URL: https://codereview.chromium.org/920043003 Cr-Commit-Position: refs/heads/master@{#315976}

… of https://codereview.chromium.org/904163003/) Reason for revert: Conflict with https://codereview.chromium.org/872633008/ Original issue's description: > Reset Screen moved to ScreenContext. > > BUG=456778 > > Committed: https://crrev.com/4b77f613917020e58b31975355e4ca2347f216e2 > Cr-Commit-Position: refs/heads/master@{#316212} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=456778 Review URL: https://codereview.chromium.org/917613005 Cr-Commit-Position: refs/heads/master@{#316213}

id:100001 of https://codereview.chromium.org/939673002/) Reason for revert: Timing out on Blink waterfall. See https://code.google.com/p/chromium/issues/detail?id=458577#c10 . Original issue's description: > Test that visual state callbacks do not deadlock. > > Visual state callbacks should always be received, > even if there are no pending commits. We add > a test for that. See crbug/458577 for more details. > > BUG=458577 > > Committed: https://crrev.com/dcc18cb569b31bc07c97d49573e695ec8b1f80c0 > Cr-Commit-Position: refs/heads/master@{#317306} [email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=458577 Review URL: https://codereview.chromium.org/942973002 Cr-Commit-Position: refs/heads/master@{#317381}

BUG=440407 Review URL: https://codereview.chromium.org/950993002 (cherry picked from commit 9b3d6f1) Cr-Original-Commit-Position: refs/heads/master@{#317647} Cr-Commit-Position: refs/branch-heads/2311@{#6} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}

BUG=488739 [email protected] Review URL: https://codereview.chromium.org/1137393004 Cr-Commit-Position: refs/heads/master@{#330270} (cherry picked from commit 0e7b20b) Review URL: https://codereview.chromium.org/1137553004 Cr-Commit-Position: refs/branch-heads/2403@{crosswalk-project#6} Cr-Branched-From: f54b809-refs/heads/master@{#330231}

…-project#6 id:100001 of https://codereview.chromium.org/1103163004/) Reason for revert: It broke Clank bots. Original issue's description: > [Contextual Search] Remove opt-in code. > > This CL requires a downstream change: > https://chrome-internal-review.googlesource.com/#/c/214963/ > > BUG=482618 > [email protected], [email protected], [email protected] > > Committed: https://chromium.googlesource.com/chromium/src/+/277f043bb56fb1e4bb93d9d17fc3de4ada0eb81b [email protected],[email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=482618 Review URL: https://codereview.chromium.org/1123313006 Cr-Commit-Position: refs/heads/master@{#330248} Review URL: https://codereview.chromium.org/1133403004 Cr-Commit-Position: refs/branch-heads/2403@{crosswalk-project#9} Cr-Branched-From: f54b809-refs/heads/master@{#330231}

…tps://codereview.chromium.org/1418003006/ ) Reason for revert: This caused several regressions: https://code.google.com/p/chromium/issues/detail?id=555914 https://code.google.com/p/chromium/issues/detail?id=553078 https://code.google.com/p/chromium/issues/detail?id=553493 Original issue's description: > Simplify starting a navigation > > Remove a whole bunch of accumulated technical debt in > DocumentLoader and core/fetch/ related to starting a navigation > and handling redirects. > > BUG= > > Committed: https://crrev.com/83a52878976eaffc8753993a7689c9c178664fba > Cr-Commit-Position: refs/heads/master@{#358420} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=555914,553078 Review URL: https://codereview.chromium.org/1444413002 Cr-Commit-Position: refs/heads/master@{#359864} (cherry picked from commit 65a9812) Review URL: https://codereview.chromium.org/1497753004 . Cr-Commit-Position: refs/branch-heads/2564@{#225} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

To disable WebNotifications

Cr-Commit-Position: refs/branch-heads/2623@{crosswalk-project#6} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}

When MSE started logging these events we accidentally started getting them for the Android MediaSource players. These metrics should only be recorded for Pipeline based players. BUG=589717 TEST=Android MediaSourcePlayer doesn't generate UMA. Review URL: https://codereview.chromium.org/1747453002 Cr-Commit-Position: refs/heads/master@{#378083} (cherry picked from commit a14620d) Review URL: https://codereview.chromium.org/1748833002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#6} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}

This will enable us to have better compatibility between GYP and GN builds across the transition without requiring them to build 'all' (which is fragile due to crbug.com/531296). [email protected], [email protected], [email protected], [email protected], [email protected] BUG=531296, 555741 patch from issue 1446883002 at patchset 1 (http://crrev.com/1446883002#ps1) Review URL: https://codereview.chromium.org/1451593002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#6} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#6} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}

> This reverts commit cd8bc9f. > > Reason for revert: Breaks thestig@'s theme. Also, ShouldWindowContentsBeTransparent() should only return true on the Windows Aero theme > > Original change's description: > > X11: Fix transparency on certain windows > > > > Transparency on arrow windows stopped working after CL [1]. This CL > > is a one-line selective revert of that CL. Note that transparency on > > all other windows that I've tested (drag images, dragged URLs, etc) > > were not broken. > > > > [1] https://chromium.googlesource.com/chromium/src/+/5785866a9b2a0db4854552eb87af7229d4b11a43 > > > > BUG=758304 > > R=[email protected] > > > > Change-Id: I37020d930bd081facce65b0a8be0eeb2e1756c69 > > Reviewed-on: https://chromium-review.googlesource.com/629538 > > Commit-Queue: Thomas Anderson <[email protected]> > > Reviewed-by: Elliot Glaysher <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#496775} > > [email protected],[email protected] > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 758304 > Change-Id: I5fa80e041c77d485afa08dea99d893f84474c458 > Reviewed-on: https://chromium-review.googlesource.com/647032 > Reviewed-by: Thomas Anderson <[email protected]> > Commit-Queue: Thomas Anderson <[email protected]> > Cr-Commit-Position: refs/heads/master@{#499131} > BUG=758304 [email protected] [email protected] NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I5e69899078d27d1b24b95ee2d02a84a8db6270ee Reviewed-on: https://chromium-review.googlesource.com/648089 Reviewed-by: Thomas Anderson <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#6} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

WIP : to get comments

f02ce63

gyp changes needed to make it compile for efl

riju closed this Jun 11, 2013

riju deleted the riju_gypChanges branch June 11, 2013 12:30

darktears pushed a commit that referenced this pull request Oct 6, 2014

Updating XTBs based on .GRDs from branch 2171

29f26d7

Cr-Commit-Position: refs/branch-heads/2171@{#6} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}

pozdnyakov mentioned this pull request Jan 14, 2015

[Extensions] Build glib message pump on Ozone by default #225

Merged

PeterWangIntel pushed a commit to PeterWangIntel/chromium-crosswalk that referenced this pull request Dec 29, 2015

Merge pull request crosswalk-project#6 from PeterWangIntel/noti-17

d86898f

To disable WebNotifications

smishenk pushed a commit to smishenk/chromium-crosswalk that referenced this pull request Apr 29, 2016

Incrementing VERSION to 49.0.2623.5

3366fbf

Cr-Commit-Position: refs/branch-heads/2623@{crosswalk-project#6} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}

huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request Oct 9, 2016

Incrementing VERSION to 52.0.2743.2

ccf46d5

Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#6} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP : to get comments #6

WIP : to get comments #6

riju commented Jun 11, 2013

xingnan commented Jun 11, 2013

WIP : to get comments #6

WIP : to get comments #6

Conversation

riju commented Jun 11, 2013

xingnan commented Jun 11, 2013

Trybot Dashboard