This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
[Tizen] Get visibilityChange events fired by window focus change. #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joone
commented
Jan 13, 2015
joone
commented
This reverts commit a17de8f. BUG= Review URL: https://codereview.chromium.org/710843002 Cr-Commit-Position: refs/branch-heads/2214@{#2} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
…e server can push directives (and messages, though they are not yet handled) over GCM." This reverts commit 19b4f63. Revert "[GCM] Fetching OAuth2 tokens periodically in account tracker" This reverts commit ede4117. Revert "Fixing all of problems found by vc++ /analyze in GCM code" This reverts commit 3e02198. Revert "PPAPI: Make GetProxiedInterface not re-enter the plugin" This reverts commit a17de8f. BUG= Review URL: https://codereview.chromium.org/713643002 Cr-Commit-Position: refs/branch-heads/2214@{#3} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
Adding GCM support to the copresence component. The Copresence server can push directives (and messages, though they are not yet handled) over GCM. BUG=424253,425681 Review URL: https://codereview.chromium.org/710513004 Cr-Commit-Position: refs/heads/master@{#303342} (cherry picked from commit 19b4f63) Review URL: https://codereview.chromium.org/712833002 Cr-Commit-Position: refs/branch-heads/2214@{#5} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
Revert "Disable notification views when clearing all notifications" This reverts commit e38e7b4. BUG= Review URL: https://codereview.chromium.org/708323002 Cr-Commit-Position: refs/branch-heads/2214@{#6} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
BUG=431907 Revert "Reject certificates that are valid for too long." Was: https://codereview.chromium.org/20628006 We want this change in M41, not M40. Also, it has a date math bug. A new CL to fix the bug and re-land will come soon. BUG=119211 [email protected],abarth,felt Review URL: https://codereview.chromium.org/717653002 Cr-Commit-Position: refs/heads/master@{#303562} (cherry picked from commit 03ef204) Review URL: https://codereview.chromium.org/716843002 Cr-Commit-Position: refs/branch-heads/2214@{#8} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
BUG=431639 Revert "Fixed detection of WS_OVERLAPPED windows, bug introduced in change 6561311." This reverts commit 26b57c2. [email protected] Review URL: https://codereview.chromium.org/720443003 Cr-Commit-Position: refs/branch-heads/2214@{#10} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
Restore naive vertical centering for multi-line Labels. Restore multi-line label unit test expectations. Multi-line labels in horizontal box layouts regressed in: https://chromium.googlesource.com/chromium/src/+/6060457aff422c0202da9fa0ed1f6243394a5fb1 This does not regress the original baseline fix. See screenshots at http://crbug.com/429595#c17 BUG=429595 TEST=page info bubble, other labels are vertically centered. [email protected] Review URL: https://codereview.chromium.org/712003005 Cr-Commit-Position: refs/heads/master@{#303526} (cherry picked from commit 9a0f2e9) Review URL: https://codereview.chromium.org/719483002 Cr-Commit-Position: refs/branch-heads/2214@{#12} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
BUG=403800 BUG=431848 TBR= Review URL: https://codereview.chromium.org/707193004 Cr-Commit-Position: refs/heads/master@{#303483} (cherry picked from commit 8f72990) Review URL: https://codereview.chromium.org/720843005 Cr-Commit-Position: refs/branch-heads/2214@{#13} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
Dramatically improves scaling quality. BUG=351458 TEST=videos are noticeably sharper. TBR=ananta Review URL: https://codereview.chromium.org/713603002 Cr-Commit-Position: refs/heads/master@{#303545} (cherry picked from commit 991bb31) Review URL: https://codereview.chromium.org/720913002 Cr-Commit-Position: refs/branch-heads/2214@{#14} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
Add debug::Alias for version to track unexpected DwmIsCompositionEnabled call DwmIsCompositionEnabled is being called on XP machines, which doesn't make any sense given the version check. Alias version to see what's actually being returned for these crashes. Will need to be merged to 40. [email protected] [email protected] BUG=431549 Review URL: https://codereview.chromium.org/711053004 Cr-Commit-Position: refs/heads/master@{#303527} (cherry picked from commit c40bdae) Review URL: https://codereview.chromium.org/718173002 Cr-Commit-Position: refs/branch-heads/2214@{#15} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
…inish. This is a correctness fix as we can't assume GLFence::HasCompleted() will return true after glFinish has been called. BUG=430933 Review URL: https://codereview.chromium.org/707833003 Cr-Commit-Position: refs/heads/master@{#303584} (cherry picked from commit cc241eb) Review URL: https://codereview.chromium.org/722823002 Cr-Commit-Position: refs/branch-heads/2214@{#16} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
This reverts commit f6158b0. Speculative revert to attempt to fix https://code.google.com/p/chromium/issues/detail?id=431608 NOTREECHECKS=true NOTRY=true BUG=431608 [email protected],[email protected] Review URL: https://codereview.chromium.org/716463002 Cr-Commit-Position: refs/heads/master@{#303411} (cherry picked from commit 8bdca01) Review URL: https://codereview.chromium.org/722813003 Cr-Commit-Position: refs/branch-heads/2214@{#17} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
… watch operation. 6f315b8 master@{#300036} introduced a regression where the two registry keys that are watched for changes to detect installation of NPAPI plugins, were being mixed. This CL fixes the issue... using the correct key each time a new StartWatching is called. BUG=428560 [email protected] Review URL: https://codereview.chromium.org/708933002 Cr-Commit-Position: refs/heads/master@{#303347} (cherry picked from commit b805615) [email protected] Review URL: https://codereview.chromium.org/718223002 Cr-Commit-Position: refs/branch-heads/2214@{#18} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
BUG=310374, 430968, 431272 Review URL: https://codereview.chromium.org/713353002 Cr-Commit-Position: refs/heads/master@{#303741} (cherry picked from commit 5cf0ba7) Merge remote-tracking branch 'refs/remotes/branch-heads/2214' into drover_2214 Add debug::Alias for version to track unexpected DwmIsCompositionEnabled call DwmIsCompositionEnabled is being called on XP machines, which doesn't make any sense given the version check. Alias version to see what's actually being returned for these crashes. Will need to be merged to 40. [email protected] [email protected] BUG=431549 Review URL: https://codereview.chromium.org/711053004 Cr-Commit-Position: refs/heads/master@{#303527} (cherry picked from commit c40bdae) Review URL: https://codereview.chromium.org/721933002 Cr-Commit-Position: refs/branch-heads/2214@{#19} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
…ery files in the RecoveryComponentInstaller::Install. NOTRY=true BUG=432164 Review URL: https://codereview.chromium.org/719613002 Cr-Commit-Position: refs/heads/master@{#303769} (cherry picked from commit 301089d) Review URL: https://codereview.chromium.org/715303004 Cr-Commit-Position: refs/branch-heads/2214@{#20} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
These match the latest UX team recommendations. BUG=431334 TEST=none [email protected] Review URL: https://codereview.chromium.org/709193002 Cr-Commit-Position: refs/heads/master@{#303357} (cherry picked from commit b2b83f6) Review URL: https://codereview.chromium.org/718053004 Cr-Commit-Position: refs/branch-heads/2214@{#21} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
…e should limit their TTL. BUG=431871 [email protected],[email protected] Review URL: https://codereview.chromium.org/710183003 Cr-Commit-Position: refs/heads/master@{#303542} (cherry picked from commit 9baadc9) Review URL: https://codereview.chromium.org/718303002 Cr-Commit-Position: refs/branch-heads/2214@{#23} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
The FileTransferController#selectedAsyncData is cache of data that cannot be obtained synchronously. This is needed for assigning the data to DataTransfer in the event handler. The data can be null if the event is dispatched before the data is obtained. BUG=431650 TEST=None TBR=fukino Review URL: https://codereview.chromium.org/704333003 Cr-Commit-Position: refs/heads/master@{#303444} (cherry picked from commit 5bb64a5) Review URL: https://codereview.chromium.org/723053002 Cr-Commit-Position: refs/branch-heads/2214@{#24} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
The check is needed in relayout method of FileManagerUI. The list view may be not initialized. BUG=432025 TEST=None TBR=fukino Review URL: https://codereview.chromium.org/712323002 Cr-Commit-Position: refs/heads/master@{#303607} (cherry picked from commit ed2ca7c) Review URL: https://codereview.chromium.org/726473002 Cr-Commit-Position: refs/branch-heads/2214@{#25} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
…iting initialization in SelectFileAndCancel test. The current message "worker-initialized" does not ensure the whole initialize process completed in Files.app, and it causes races in the test after the refactoring of crbug.com/267281. BUG=432029 TEST=Run SelectFileAndCancel TBR=sky Review URL: https://codereview.chromium.org/714813002 Cr-Commit-Position: refs/heads/master@{#303788} (cherry picked from commit 8866b6d) Review URL: https://codereview.chromium.org/726483002 Cr-Commit-Position: refs/branch-heads/2214@{#26} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
ConnectToBestNetwork will now also be triggered after policy application and after client certificate patterns were resolved. I.e. that managed networks will autoconnect more reliably. BUG=424036 [email protected] Review URL: https://codereview.chromium.org/701863002 Cr-Commit-Position: refs/heads/master@{#303457} (cherry picked from commit 627248e) Review URL: https://codereview.chromium.org/718413002 Cr-Commit-Position: refs/branch-heads/2214@{#27} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
We want the overlay cast icon to be visible on all backgrounds, so its background has to be at least semi-opaque. The non-overlay cast icon, however, should have the same background as the media controls, which is easiest to achive by making its background transparent. As such we need different icons for the two cases. This CL simply provides the new icons. The corresponding Blink CL, which uses them, is https://codereview.chromium.org/716613002. BUG=426373 Review URL: https://codereview.chromium.org/711083002 [email protected] Cr-Commit-Position: refs/heads/master@{#303620} (cherry picked from commit bea7c9b) Review URL: https://codereview.chromium.org/719213003 Cr-Commit-Position: refs/branch-heads/2214@{#28} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
…romeOS. This CL is an alternative to the https://codereview.chromium.org/709763002/. BUG=430042 TEST=manual tests on a falco device Review URL: https://codereview.chromium.org/695193004 Cr-Commit-Position: refs/heads/master@{#303465} (cherry picked from commit 45f512b) Review URL: https://codereview.chromium.org/723163002 Cr-Commit-Position: refs/branch-heads/2214@{#29} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
BUG=431833 [email protected] NOTRY=true Review URL: https://codereview.chromium.org/715633003 Cr-Commit-Position: refs/heads/master@{#303518} (cherry picked from commit b35d1e1) Review URL: https://codereview.chromium.org/727533003 Cr-Commit-Position: refs/branch-heads/2214@{#30} Cr-Branched-From: 03655fd-refs/heads/master@{#303346}
rakuco
pushed a commit
that referenced
this pull request
Aug 13, 2015
If the user has already dragged outside the initial selected word region by the time the browser gets a selection update, or if the selected word isn't coincident with the longpress location, the subsequently dragged selection endpoint can be wrong. For such cases, rather than using the drag direction for drag anchor picking, just use the distance between the current touch point and the selection endpoints. BUG=466749 Review URL: https://codereview.chromium.org/1271823002 Cr-Commit-Position: refs/heads/master@{#341791} (cherry picked from commit a188bd6) Review URL: https://codereview.chromium.org/1259593010 . Cr-Commit-Position: refs/branch-heads/2454@{#228} Cr-Branched-From: 12bfc33-refs/heads/master@{#338390}
rakuco
force-pushed
the
master
branch
2 times, most recently
from
5d9bef8
to
18a33ff
Compare
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
This CL: 1- Makes adding and removing columns to the task manager a lot easier and cleaner. 2- Stores/retrieves the columns visibility to/from the local state prefs. 3- Stores/retrieves the sorted column and the sort order. [email protected] BUG=452521 TEST=browser_tests --gtest_filter=NewTaskManagerViewTest.* Committed: https://crrev.com/4e16add803fbb0ed18413496d3fb4424fa4957c6 Cr-Commit-Position: refs/heads/master@{#346524} Review URL: https://codereview.chromium.org/1320563002 Cr-Commit-Position: refs/heads/master@{#346734} (cherry picked from commit 4780b87) Review URL: https://codereview.chromium.org/1332083002 . Cr-Commit-Position: refs/branch-heads/2490@{#228} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
rakuco
force-pushed
the
master
branch
2 times, most recently
from
830d9f6
to
5ad5a18
Compare
rakuco
force-pushed
the
master
branch
2 times, most recently
from
1072537
to
512d729
Compare
rakuco
force-pushed
the
master
branch
2 times, most recently
from
0f31e18
to
3da217c
Compare
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
…xpectations." This reverts commit b5e7bd9. This change isn't actually needed on M49; it's only needed on master. BUG=583013 Review URL: https://codereview.chromium.org/1656063004 . Cr-Commit-Position: refs/branch-heads/2623@{#228} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
As it turns out that the committed entry may omit the base URL if there has been a javascript: URL navigation after LoadDataWithBaseURL. Thus we have to store the base url on DidStartLoading and use it in DidStopLoading / DidFinishLoad. We have to preserve the old hack with SetToBaseURLForDataURLIfNeeded because if the base URL is not valid, DidFinishLoad doesn't receive it from the renderer. This change is a short-term workaround. The correct solution is to pass a flag that the load was through LoadDataWithBaseURL via Blink, so base URL can be restored correctly within NavigationController. BUG=594001 Review URL: https://codereview.chromium.org/1779363004 Cr-Commit-Position: refs/heads/master@{#381108} (cherry picked from commit ce1f4d0) Review URL: https://codereview.chromium.org/1799973002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#228} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#228}
Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
Keep min payload size to be 32 KB, but make that a field trial param. Also, move |use_small_responses_| to the NQE params class. Bug: 764145 Change-Id: I8bfd37d602705367d294fff037a47ba72c93f2f7 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Reviewed-on: https://chromium-review.googlesource.com/657202 Commit-Queue: Tarun Bansal <[email protected]> Reviewed-by: Ryan Sturm <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#501153}(cherry picked from commit fc13d59) Reviewed-on: https://chromium-review.googlesource.com/667127 Reviewed-by: Tarun Bansal <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#228} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.