This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Cameo webview proto #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evas dependency is needed to build content_shell executable.
After making sub process launcher, chrome_path can be changed.
halton
pushed a commit
that referenced
this pull request
Nov 6, 2013
…s already deleted Test case #27 MediaSourceEvents in YouTube HTML5 MSE/EME conformance test (http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/tot.html) fails due to a condition where the callback UpdateNetworkState() in WebMediaPlayerAndroid object is invoked after the object is already deleted. This CL prevents such case from taking place. BUG=308861 Review URL: https://codereview.chromium.org/35193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230657 0039d316-1c4b-4281-b951-d872f2087c98
rakuco
pushed a commit
that referenced
this pull request
Aug 11, 2014
…ps://codereview.chromium.org/339433003/) Reason for revert: Broke linux lsan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/4075/steps/browser_tests/logs/EndToEnd Direct leak of 336 byte(s) in 1 object(s) allocated from: #0 0x514ffb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0xbdd835 in extensions::CastStreamingApiTestWithPixelOutput_EndToEnd_Test::RunTestOnMainThread() chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc:314 <truncated, full output is in gzipped JSON output at end of step> #23 0x3e70dd1 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #24 0x3e70dd1 in testing::Test::Run() testing/gtest/src/gtest.cc:2057 #25 0x3e73169 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #26 0x3e73ef6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #27 0x3e8700a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #28 0x3e86640 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #29 0x3e86640 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #30 0x35a505c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #31 0x35a505c in base::TestSuite::Run() base/test/test_suite.cc:227 #32 0x2118154 in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14 #33 0xce70779 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:468 #34 0x33ff4bb in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:129 #35 0x2118048 in main chrome/test/base/browser_tests_main.cc:21 #36 0x7f2add6cd76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 Original issue's description: > Fix test CastStreamingApiTestWithPixelOutput.EndToEnd. > Update end_to_end_sender.js to use standard WebAudio API. > Modify unit test to use a larger window size (previous window size was > too small, which negatively impacted the median color computation > routine.) > > BUG=349599 > [email protected] > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279210 [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=349599 Review URL: https://codereview.chromium.org/351683003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279231 0039d316-1c4b-4281-b951-d872f2087c98
rakuco
pushed a commit
that referenced
this pull request
Aug 11, 2014
…https://codereview.chromium.org/373153002/) Reason for revert: Causing memory leaks: Indirect leak of 328 byte(s) in 1 object(s) allocated from: #0 0x515feb in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:55 #1 0xc334cfb in BookmarkModel::CreatePermanentNode(BookmarkNode::Type) components/bookmarks/browser/bookmark_model.cc:910 #2 0xc326772 in BookmarkModel::CreateLoadDetails(std::string const&) components/bookmarks/browser/bookmark_model.cc:1006 #3 0xc326553 in BookmarkModel::Load(PrefService*, std::string const&, base::FilePath const&, scoped_refptr\u003Cbase::SequencedTaskRunner> const&, scoped_refptr\u003Cbase::SequencedTaskRunner> const&) components/bookmarks/browser/bookmark_model.cc:151 #4 0x232a4d7 in BookmarkModelFactory::BuildServiceInstanceFor(content::BrowserContext*) const chrome/browser/bookmarks/bookmark_model_factory.cc:65 #5 0xc0bc85f in BrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) components/keyed_service/content/browser_context_keyed_service_factory.cc:91 #6 0x260de89 in ProfileImpl::DoFinalInit() chrome/browser/profiles/profile_impl.cc:657 #7 0x260beb5 in ProfileImpl::OnPrefsLoaded(bool) chrome/browser/profiles/profile_impl.cc:881 #8 0x260ae3e in ProfileImpl::ProfileImpl(base::FilePath const&, Profile::Delegate*, Profile::CreateMode, base::SequencedTaskRunner*) chrome/browser/profiles/profile_impl.cc:492 #9 0x2608ddb in Profile::CreateProfile(base::FilePath const&, Profile::Delegate*, Profile::CreateMode) chrome/browser/profiles/profile_impl.cc:297 #10 0x18de165 in ProfileBrowserTest::CreateProfile(base::FilePath const&, Profile::Delegate*, Profile::CreateMode) chrome/browser/profiles/profile_browsertest.cc:106 #11 0x18df8f8 in ProfileBrowserTest_CreateOldProfileSynchronous_Test::RunTestOnMainThread() chrome/browser/profiles/profile_browsertest.cc:153 #12 0x33f5434 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:427 #13 0x2e6ca18 in Run base/callback.h:401 #14 0x2e6ca18 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1548 #15 0x2e69666 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:975 #16 0x59381d7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:694 #17 0x5c8f207 in Run base/callback.h:401 #18 0x5c8f207 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #19 0x59342e0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:594 #20 0x5e8a153 in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106 #21 0xf0228a0 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22 #22 0xef6cbc4 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:763 #23 0xef69d3f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19 #24 0xcf5b57f in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:253 #25 0x33f2563 in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:210 #26 0x3e81941 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045 #27 0x3e81941 in testing::Test::Run() testing/gtest/src/gtest.cc:2057 #28 0x3e83cd9 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237 #29 0x3e84a66 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344 #30 0x3e97b7a in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065 #31 0x3e971b0 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045 #32 0x3e971b0 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697 #33 0x359557c in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231 #34 0x359557c in base::TestSuite::Run() base/test/test_suite.cc:227 Original issue's description: > Fixed use-after-free in LoadCallback in bookmark_storage.cc > > BookmarkStorage isn't ref counted anymore since > https://codereview.chromium.org/370323002, and the LoadCallback() task > now gets a WeakPtr to the owning BookmarkStorage. However, it gets a > raw pointer to the BookmarkLoadDetails object, which is still owned > by BookmarkStorage and may have been destroyed when the background > task runs. > > This happened on iOS tests after a recent merge. > > [email protected] > BUG=165760 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281830 [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=165760 Review URL: https://codereview.chromium.org/379643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281843 0039d316-1c4b-4281-b951-d872f2087c98
rakuco
pushed a commit
that referenced
this pull request
Aug 11, 2014
…://codereview.chromium.org/397233002/) Reason for revert: Broke 'Chromium Linux on Linux Clang (dbg)': http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/62289 AutofillDialogControllerTest.BillingVsShippingStreetAddress (run #1): [ RUN ] AutofillDialogControllerTest.BillingVsShippingStreetAddress Xlib: extension "RANDR" missing on display ":9". /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/debug/safe_iterator.h:289: error: attempt to advance a past-the-end iterator 1 steps, which falls outside its valid range. Objects involved in the operation: iterator @ 0x0x7fffd4a50d58 { state = past-the-end; references sequence @ 0x0x7fffd4a50d58 } Received signal 6 #0 0x7f716d77ecee base::debug::StackTrace::StackTrace() #1 0x7f716d77e827 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f7168451cb0 \u003Cunknown> #3 0x7f71648cf425 gsignal #4 0x7f71648d2b8b abort #5 0x7f7164ed25ad __gnu_debug::_Error_formatter::_M_error() #6 0x0000026271ce __gnu_debug::_Safe_iterator\u003C>::operator+=() #7 0x0000026270f5 __gnu_debug::_Safe_iterator\u003C>::operator+() #8 0x000005506f39 i18n::addressinput::(anonymous namespace)::CombineLinesForLanguage() #9 0x00000550703a i18n::addressinput::GetStreetAddressLinesAsSingleLine() #10 0x000005548289 autofill::(anonymous namespace)::FillStreetAddress() #11 0x000005547b91 autofill::AutofillField::FillFormField() #12 0x0000055907cd autofill::FormStructure::FillFields() #13 0x000004972335 autofill::AutofillDialogControllerImpl::Show() #14 0x000001ec0f2a autofill::(anonymous namespace)::AutofillDialogControllerTest::SetUpControllerWithFormData() #15 0x000001ece5c8 autofill::AutofillDialogControllerTest_BillingVsShippingStreetAddress_Test::TestBody() #16 0x0000039fcc63 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() #17 0x0000039e9f9e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #18 0x0000039e0e05 testing::Test::Run() #19 0x0000039e151b testing::TestInfo::Run() #20 0x0000039e1b0a testing::TestCase::Run() #21 0x0000039e6118 testing::internal::UnitTestImpl::RunAllTests() #22 0x0000039f5973 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() #23 0x0000039ebb0e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #24 0x0000039e5da4 testing::UnitTest::Run() #25 0x000005b72b61 RUN_ALL_TESTS() #26 0x000005b71be7 base::TestSuite::Run() #27 0x000005b8455d content::UnitTestTestSuite::Run() #28 0x000003aa40d2 base::internal::RunnableAdapter\u003C>::Run() #29 0x000003aa403c base::internal::InvokeHelper\u003C>::MakeItSo() #30 0x000003aa3fea base::internal::Invoker\u003C>::Run() #31 0x000002a29e9e base::Callback\u003C>::Run() #32 0x000005b6b830 base::(anonymous namespace)::LaunchUnitTestsInternal() #33 0x000005b6b527 base::LaunchUnitTests() #34 0x000003aa3db5 main #35 0x7f71648ba76d __libc_start_main #36 0x000000715159 \u003Cunknown> r8: 00007f715f665980 r9: 00007fffd4a507d8 r10: 0000000000000008 r11: 0000000000000206 r12: 00007fffd4a50aa0 r13: 0000000000000001 r14: 0000000000000001 r15: 0000000000000000 di: 00000000000016b2 si: 00000000000016b2 bp: 0000000000000002 bx: 00007fffd4a50a30 dx: 0000000000000006 ax: 0000000000000000 cx: ffffffffffffffff sp: 00007fffd4a50828 ip: 00007f71648cf425 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 Original issue's description: > Use language-specific street address line separators > > Fill street address into a single-line text input field with separators > that depend on the language code of the profile. > > TEST=components_unittests:AutofillFieldTest.FillStreetAddress* > BUG=270261 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284335 [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=270261 Review URL: https://codereview.chromium.org/401103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284340 0039d316-1c4b-4281-b951-d872f2087c98
darktears
pushed a commit
that referenced
this pull request
Sep 29, 2014
Broke ASan/LSan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/6376 @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@Direct leak of 136 byte(s) in 1 object(s) allocated from:@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #0 0x4f295b in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__2_/build/src/out/Release/browser_tests+0x4f295b)@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #1 0x4f41e33 in GrGpuGL::onCreateIndexBuffer(unsigned long, bool) third_party/skia/src/gpu/gl/GrGpuGL.cpp:1374:13@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #2 0x4ec41b3 in createIndexBuffer third_party/skia/src/gpu/GrGpu.cpp:159:12@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #3 0x4ec41b3 in GrGpu::getQuadIndexBuffer() const third_party/skia/src/gpu/GrGpu.cpp:273@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #4 0x4ecbad0 in GrInOrderDrawBuffer::onDrawRect(SkRect const&, SkRect const*, SkMatrix const*) third_party/skia/src/gpu/GrInOrderDrawBuffer.cpp:174:34@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #5 0x4e998f8 in drawRect third_party/skia/src/gpu/GrDrawTarget.h:384:9@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #6 0x4e998f8 in drawSimpleRect third_party/skia/src/gpu/GrDrawTarget.h:391@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #7 0x4e998f8 in GrContext::drawRect(GrPaint const&, SkRect const&, GrStrokeInfo const*) third_party/skia/src/gpu/GrContext.cpp:904@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #8 0xf895e0c in SkAlphaThresholdFilterImpl::asNewEffect(GrEffect**, GrTexture*, SkMatrix const&, SkIRect const&) const third_party/skia/src/effects/SkAlphaThresholdFilter.cpp:287:17@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #9 0x4d531c9 in SkImageFilter::filterImageGPU(SkImageFilter::Proxy*, SkBitmap const&, SkImageFilter::Context const&, SkBitmap*, SkIPoint*) const third_party/skia/src/core/SkImageFilter.cpp:272:5@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #10 0xf8b4aad in filter_texture(SkBaseDevice*, GrContext*, GrTexture*, SkImageFilter const*, int, int, SkImageFilter::Context const&, SkBitmap*, SkIPoint*) third_party/skia/src/gpu/SkGpuDevice.cpp:1398:16@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #11 0xf8b3d42 in SkGpuDevice::drawSprite(SkDraw const&, SkBitmap const&, int, int, SkPaint const&) third_party/skia/src/gpu/SkGpuDevice.cpp:1434:13@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #12 0x4d16942 in SkCanvas::drawSprite(SkBitmap const&, int, int, SkPaint const*) third_party/skia/src/core/SkCanvas.cpp:1194:13@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #13 0xe2828c3 in cc::ApplyImageFilter(scoped_ptr\u003Ccc::GLRenderer::ScopedUseGrContext, base::DefaultDeleter\u003Ccc::GLRenderer::ScopedUseGrContext> >, cc::ResourceProvider*, gfx::Point const&, gfx::Vector2dF const&, SkImageFilter*, cc::ScopedResource*) cc/output/gl_renderer.cc:722:3@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #14 0xe275474 in cc::GLRenderer::DrawRenderPassQuad(cc::DirectRenderer::DrawingFrame*, cc::RenderPassDrawQuad const*) cc/output/gl_renderer.cc:1051:13@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #15 0xe4598a4 in cc::DirectRenderer::DrawRenderPass(cc::DirectRenderer::DrawingFrame*, cc::RenderPass const*) cc/output/direct_renderer.cc:385:7@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #16 0xe458480 in cc::DirectRenderer::DrawFrame(cc::ScopedPtrVector\u003Ccc::RenderPass>*, float, gfx::Rect const&, gfx::Rect const&, bool) cc/output/direct_renderer.cc:232:5@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #17 0xe3bd5cc in cc::LayerTreeHostImpl::DrawLayers(cc::LayerTreeHostImpl::FrameData*, base::TimeTicks) cc/trees/layer_tree_host_impl.cc:1578:5@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #18 0xe3fb78e in cc::SingleThreadProxy::DoComposite(base::TimeTicks, cc::LayerTreeHostImpl::FrameData*) cc/trees/single_thread_proxy.cc:438:7@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #19 0xe3fade5 in cc::SingleThreadProxy::CompositeImmediately(base::TimeTicks) cc/trees/single_thread_proxy.cc:356:7@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #20 0x651589b in ui::Compositor::Draw() ui/compositor/compositor.cc:234:5@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #21 0x345c43f in Run base/callback.h:401:12@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #22 0x345c43f in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #23 0x339b64c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:435:3@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #24 0x339c710 in DeferOrRunPendingTask base/message_loop/message_loop.cc:445:5@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #25 0x339c710 in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:552@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #26 0x3445422 in HandleDispatch base/message_loop/message_pump_glib.cc:267:7@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #27 0x3445422 in base::(anonymous namespace)::WorkSourceDispatch(_GSource*, int (*)(void*), void*) base/message_loop/message_pump_glib.cc:109@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #28 0x7f5f9395dd12 in g_main_dispatch /build/buildd/glib2.0-2.32.4/./glib/gmain.c:2539@@@ @@@STEP_LOG_LINE@FindStayVisibleOnAnchorLoad@ #29 0x7f5f9395dd12 in g_main_context_dispatch /build/buildd/glib2.0-2.32.4/./glib/gmain.c:3075@@@ > Skia roll de21804:94ce9ac > > https://skia.googlesource.com/skia/+log/de218041b99e8f9af0e80b34452b0e8d7f770765..94ce9ac8624dbb45656b8f5c992fad9c9ff3ee5f > > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel > [email protected] > BUG= > > Review URL: https://codereview.chromium.org/485173003 [email protected],[email protected] Review URL: https://codereview.chromium.org/485523003 Cr-Commit-Position: refs/heads/master@{#290648} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290648 0039d316-1c4b-4281-b951-d872f2087c98
darktears
pushed a commit
that referenced
this pull request
Sep 29, 2014
…r_tests compiling on MacViews (patchset #7 of https://codereview.chromium.org/486063002/) Reason for revert: browser_test fails in Linux ASAN/LSAN test. WebDialogBrowserTest.SizeWindow (run #1): [ RUN ] WebDialogBrowserTest.SizeWindow [30383:30383:0820/232516:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on. Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [30383:30383:0820/232516:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. [30473:30473:0820/232516:ERROR:renderer_main.cc(204)] Running without renderer sandbox [30496:30496:0820/232516:ERROR:renderer_main.cc(204)] Running without renderer sandbox ================================================================= ==30383==ERROR: LeakSanitizer: detected memory leaks Direct leak of 128 byte(s) in 1 object(s) allocated from: #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb) #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3 #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5 #3 0x2d6de03 in Run base/callback.h:401:12 #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555 #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18 #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5 #7 0x5d3ac48 in Run base/callback.h:401:12 #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3 #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5 #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19 #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12 #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15 #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3 #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3 #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227 #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12 #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12 #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10 #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10 #29 0x7feeddc6676c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 ----------------------------------------------------- Suppressions used: count bytes template 1767 75328 libfontconfig ----------------------------------------------------- SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s). [0820/232518:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox! Most likely you need to configure your SUID sandbox correctly WebDialogBrowserTest.SizeWindow (run #2): [ RUN ] WebDialogBrowserTest.SizeWindow [16767:16767:0820/232720:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on. Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [16767:16767:0820/232720:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. [16871:16871:0820/232720:ERROR:renderer_main.cc(204)] Running without renderer sandbox [16911:16911:0820/232720:ERROR:renderer_main.cc(204)] Running without renderer sandbox ================================================================= ==16767==ERROR: LeakSanitizer: detected memory leaks Direct leak of 128 byte(s) in 1 object(s) allocated from: #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb) #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3 #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5 #3 0x2d6de03 in Run base/callback.h:401:12 #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555 #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18 #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5 #7 0x5d3ac48 in Run base/callback.h:401:12 #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3 #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5 #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19 #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12 #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15 #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3 #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3 #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227 #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12 #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12 #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10 #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10 #29 0x7fb13f28476c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 ----------------------------------------------------- Suppressions used: count bytes template 1767 75328 libfontconfig ----------------------------------------------------- SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s). [0820/232722:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox! Most likely you need to configure your SUID sandbox correctly WebDialogBrowserTest.SizeWindow (run #3): [ RUN ] WebDialogBrowserTest.SizeWindow [16994:16994:0820/232723:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on. Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [16994:16994:0820/232724:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. [17026:17026:0820/232724:ERROR:renderer_main.cc(204)] Running without renderer sandbox [17038:17038:0820/232724:ERROR:renderer_main.cc(204)] Running without renderer sandbox ================================================================= ==16994==ERROR: LeakSanitizer: detected memory leaks Direct leak of 128 byte(s) in 1 object(s) allocated from: #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb) #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3 #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5 #3 0x2d6de03 in Run base/callback.h:401:12 #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555 #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18 #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5 #7 0x5d3ac48 in Run base/callback.h:401:12 #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3 #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5 #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19 #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12 #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15 #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3 #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3 #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227 #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12 #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12 #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10 #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10 #29 0x7f0688ff376c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 ----------------------------------------------------- Suppressions used: count bytes template 1767 75328 libfontconfig ----------------------------------------------------- SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s). [0820/232725:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox! Most likely you need to configure your SUID sandbox correctly WebDialogBrowserTest.SizeWindow (run #4): [ RUN ] WebDialogBrowserTest.SizeWindow [17073:17073:0820/232726:ERROR:browser_main_loop.cc(162)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on. Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [17073:17073:0820/232726:WARNING:password_store_factory.cc(215)] Using basic (unencrypted) store for password storage. See http://code.google.com/p/chromium/wiki/LinuxPasswordStorage for more information about password storage options. [17105:17105:0820/232726:ERROR:renderer_main.cc(204)] Running without renderer sandbox [17116:17116:0820/232726:ERROR:renderer_main.cc(204)] Running without renderer sandbox ================================================================= ==17073==ERROR: LeakSanitizer: detected memory leaks Direct leak of 128 byte(s) in 1 object(s) allocated from: #0 0x4f2bbb in operator new(unsigned long) (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x4f2bbb) #1 0x1dace96 in WebDialogBrowserTest_SizeWindow_Test::RunTestOnMainThread() chrome/browser/ui/views/web_dialog_view_browsertest.cc:95:3 #2 0x32aaae3 in InProcessBrowserTest::RunTestOnMainThreadLoop() chrome/test/base/in_process_browser_test.cc:434:5 #3 0x2d6de03 in Run base/callback.h:401:12 #4 0x2d6de03 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() chrome/browser/chrome_browser_main.cc:1555 #5 0x2d6a146 in ChromeBrowserMainParts::PreMainMessageLoopRun() chrome/browser/chrome_browser_main.cc:980:18 #6 0x59d80b7 in content::BrowserMainLoop::PreMainMessageLoopRun() content/browser/browser_main_loop.cc:736:5 #7 0x5d3ac48 in Run base/callback.h:401:12 #8 0x5d3ac48 in content::StartupTaskRunner::RunAllTasksNow() content/browser/startup_task_runner.cc:45 #9 0x59d40a0 in content::BrowserMainLoop::CreateStartupTasks() content/browser/browser_main_loop.cc:636:3 #10 0x5f3839d in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) content/browser/browser_main_runner.cc:106:5 #11 0xf90f1a5 in content::BrowserMain(content::MainFunctionParams const&) content/browser/browser_main.cc:22:19 #12 0xf8416c0 in content::ContentMainRunnerImpl::Run() content/app/content_main_runner.cc:764:12 #13 0xf83db5f in content::ContentMain(content::ContentMainParams const&) content/app/content_main.cc:19:15 #14 0xd6b57e1 in content::BrowserTestBase::SetUp() content/public/test/browser_test_base.cc:257:3 #15 0x32a773b in InProcessBrowserTest::SetUp() chrome/test/base/in_process_browser_test.cc:217:3 #16 0x3de9f81 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2418:12 #17 0x3de9f81 in testing::Test::Run() testing/gtest/src/gtest.cc:2430 #18 0x3dec559 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2610:5 #19 0x3ded5b6 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2728:5 #20 0x3e03055 in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4591:11 #21 0x3e02664 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2418:12 #22 0x3e02664 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4209 #23 0x348e02f in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2304:10 #24 0x348e02f in base::TestSuite::Run() base/test/test_suite.cc:227 #25 0x20fb8cd in ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) chrome/test/base/browser_tests_main.cc:14:12 #26 0xd737de7 in content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) content/public/test/test_launcher.cc:469:12 #27 0x32a4b8b in LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) chrome/test/base/chrome_test_launcher.cc:124:10 #28 0x20fb7b8 in main chrome/test/base/browser_tests_main.cc:21:10 #29 0x7f5f8410c76c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226 ----------------------------------------------------- Suppressions used: count bytes template 1767 75328 libfontconfig ----------------------------------------------------- SUMMARY: AddressSanitizer: 128 byte(s) leaked in 1 allocation(s). [0820/232728:ERROR:nacl_helper_linux.cc(282)] NaCl helper process running without a sandbox! Most likely you need to configure your SUID sandbox correctly Original issue's description: > MacViews: Fix WebDialogBrowserTest.SizeWindow to get browser_tests compiling on MacViews > > gyp changes are made to filter out toolkit-views browser_tests that > aren't yet compiled in to a toolkit-views Chrome binary on Mac. > > One, WebDialogBrowserTest.SizeWindow, was a disabled test (disabled for > 4 years :o). It was preventing browser_tests compiling on MacViews > because it was passing a gfx::NativeWindow to CreateWindowWithParent, > which takes a view. > > The parent isn't important for the test - it's just adding widget > context. This CL changes the parent to be web_contents->GetNativeView() > instead so the test compiles. > > To ensure nothing breaks, the test needs to be enabled. According to the > comment, the reasons for it being disabled on Windows still seem > relevant. However, on Linux the test was just timing out due to a quirk > of the test. So the quirk is fixed, and WebDialogBrowserTest.SizeWindow > is enabled on Linux Aura. > > The test is also enabled on Mac, but currently fails because > NativeViewHost isn't implemented yet. That's coming, and leaving the > test enabled will ensure we check it. > > With this change browser_tests compiles and links on toolkit-views Mac. > > BUG=404979, 399191, 52602 > TEST=browser_tests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290998 [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=404979, 399191, 52602 Review URL: https://codereview.chromium.org/490123002 Cr-Commit-Position: refs/heads/master@{#291014} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291014 0039d316-1c4b-4281-b951-d872f2087c98
darktears
pushed a commit
that referenced
this pull request
Sep 29, 2014
…ttps://codereview.chromium.org/459553003/) Reason for revert: Failed memory tests: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/6791 Original issue's description: > Replace NPObject usage in ppapi with gin > > This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side. > > There are 4 major parts to this CL: > 1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc). > 2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects. > 3) Changing postMessage bindings (message_channel.cc) be gin-backed objects. > 4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8. > > > BUG=351636 > > Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3 > > Committed: https://chromium.googlesource.com/chromium/src/+/ee49e63baf57e503bd71dfe61c8a80df63eac9aa [email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=351636 Review URL: https://codereview.chromium.org/522583002 Cr-Commit-Position: refs/heads/master@{#292574}
darktears
pushed a commit
that referenced
this pull request
Sep 29, 2014
…hset #5 id:100001 of https://codereview.chromium.org/516293007/) Reason for revert: Chrome OS build with DCHECKs enabled fails on start. This CL breaks assumption, that GAIA extension can be loaded without performing IO-operations. Log and stack trace: [16275:16275:0903/161435:WARNING:renderer_freezer.cc(55)] Cgroup freezer does not exist or is not writable. Processes will not be frozen during suspend. [16275:16275:0903/161435:WARNING:configuration_policy_pref_store.cc(30)] Policy RemoteAccessClientFirewallTraversal: This policy has been deprecated. [16275:16275:0903/161437:FATAL:thread_restrictions.cc(38)] Function marked as IO-only was called from a thread that disallows IO! If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup. #0 0x7fe3122e555e base::debug::StackTrace::StackTrace() #1 0x7fe31237c462 logging::LogMessage::~LogMessage() #2 0x7fe3124824af base::ThreadRestrictions::AssertIOAllowed() #3 0x7fe3123630a1 base::PathExists() #4 0x7fe321cfd5f3 extensions::(anonymous namespace)::CollectPlatformSpecificResourceArchs() #5 0x7fe321cfad22 extensions::Extension::InitFromValue() #6 0x7fe321cfa490 extensions::Extension::Create() #7 0x7fe321cfa114 extensions::Extension::Create() #8 0x7fe3233ebe1b extensions::ComponentLoader::Load() #9 0x7fe3233ec3cf extensions::ComponentLoader::Add() #10 0x7fe3233ec32a extensions::ComponentLoader::Add() #11 0x7fe3233ec2b0 extensions::ComponentLoader::Add() #12 0x7fe32437505f (anonymous namespace)::LoadGaiaAuthExtension() #13 0x7fe324374d5e extensions::GaiaAuthExtensionLoader::LoadIfNeeded() #14 0x7fe324237f7e ScopedGaiaAuthExtension::ScopedGaiaAuthExtension() #15 0x7fe322f68bb2 chromeos::WebUILoginView::Init() #16 0x7fe322f556ef chromeos::LoginDisplayHostImpl::InitLoginWindowAndView() #17 0x7fe322f52640 chromeos::LoginDisplayHostImpl::LoadURL() #18 0x7fe322f5226a chromeos::LoginDisplayHostImpl::StartWizard() #19 0x7fe322f54acd chromeos::LoginDisplayHostImpl::StartPostponedWebUI() #20 0x7fe322f541f8 chromeos::LoginDisplayHostImpl::Observe() #21 0x7fe322f54bfd chromeos::LoginDisplayHostImpl::Observe() #22 0x7fe31b222377 content::NotificationServiceImpl::Notify() #23 0x7fe322d51a24 chromeos::(anonymous namespace)::UserWallpaperDelegate::OnWallpaperAnimationFinished() #24 0x7fe31188692f ash::RootWindowController::OnWallpaperAnimationFinished() #25 0x7fe3117c633a ash::(anonymous namespace)::ShowWallpaperAnimationObserver::OnImplicitAnimationsCompleted() #26 0x7fe311f72d30 ui::ImplicitAnimationObserver::CheckCompleted() #27 0x7fe311f72cd5 ui::ImplicitAnimationObserver::SetActive() #28 0x7fe311f965d5 ui::ScopedLayerAnimationSettings::~ScopedLayerAnimationSettings() #29 0x7fe3117c5ec7 ash::DesktopBackgroundWidgetController::StartAnimating() #30 0x7fe3117bbb0c ash::DesktopBackgroundController::InstallDesktopController() #31 0x7fe3117bbc03 ash::DesktopBackgroundController::InstallDesktopControllerForAllWindows() #32 0x7fe3117bb3cc ash::DesktopBackgroundController::SetDesktopBackgroundImageMode() #33 0x7fe3117bb096 ash::DesktopBackgroundController::SetWallpaperImage() #34 0x7fe322f9a6b9 chromeos::WallpaperManager::DoSetDefaultWallpaper() #35 0x7fe322f99b73 chromeos::WallpaperManager::PendingWallpaper::ProcessRequest() #36 0x7fe322fbac72 base::internal::RunnableAdapter<>::Run() #37 0x7fe322fbabe9 base::internal::InvokeHelper<>::MakeItSo() #38 0x7fe322fbaba5 base::internal::Invoker<>::Run() #39 0x7fe3122cc9ce base::Callback<>::Run() #40 0x7fe312488f86 base::Timer::RunScheduledTask() #41 0x7fe3124890bc base::BaseTimerTaskInternal::Run() #42 0x7fe312489382 base::internal::RunnableAdapter<>::Run() #43 0x7fe3124892ec base::internal::InvokeHelper<>::MakeItSo() #44 0x7fe312489295 base::internal::Invoker<>::Run() #45 0x7fe3122cc9ce base::Callback<>::Run() #46 0x7fe3122eb9b3 base::debug::TaskAnnotator::RunTask() #47 0x7fe3123a1c57 base::MessageLoop::RunTask() #48 0x7fe3123a1d9b base::MessageLoop::DeferOrRunPendingTask() #49 0x7fe3123a228d base::MessageLoop::DoDelayedWork() #50 0x7fe3122a1f25 base::MessagePumpGlib::Run() #51 0x7fe3123a17f0 base::MessageLoop::RunHandler() #52 0x7fe3124093b2 base::RunLoop::Run() #53 0x7fe324217e4d ChromeBrowserMainParts::MainMessageLoopRun() #54 0x7fe31ad2a8bf content::BrowserMainLoop::RunMainMessageLoopParts() #55 0x7fe31ad344c7 content::BrowserMainRunnerImpl::Run() #56 0x7fe31ad251b1 content::BrowserMain() #57 0x7fe31abb997f content::RunNamedProcessTypeMain() #58 0x7fe31abbcce8 content::ContentMainRunnerImpl::Run() #59 0x7fe31abb8ee5 content::ContentMain() #60 0x7fe3206d3505 ChromeMain #61 0x7fe3206d34b2 main Cannot upload crash dump: cannot exec /sbin/crash_reporter Crash_reporter failed to process crash report Original issue's description: > Enable forced extension updates on NaCl arch mismatch > > This makes extensions aware of the platforms for which > they have platform-specific resources installed, if any. > > This also hooks up the extension update code with some > additional logic to place an extension in forced-update > mode if it has platform-specific resources which don't > match the current NaCl architecture. > > BUG=409948 > TEST=install an extension which uses NaCl (QuickOffice for example). Rename the _platform-specific/<your-nacl-arch> directory some something else and force an update (e.g. via chrome://extensions button). Observe that a new CRX is downloaded and installed. > > Committed: https://chromium.googlesource.com/chromium/src/+/4a92281fa5d331860d65a59ba45dc882a5c71df4 [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=409948 Review URL: https://codereview.chromium.org/532183003 Cr-Commit-Position: refs/heads/master@{#293128}
darktears
pushed a commit
that referenced
this pull request
Sep 29, 2014
…::ExecuteCommands. (patchset #1 id:1 of https://codereview.chromium.org/547783002/) Reason for revert: Broke Linux ChromiumOS Tests (dbg)(3) http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/1206 BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f3bcf3aa67e base::debug::StackTrace::StackTrace() #1 0x0000041c884a content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f3bc709f4a0 <unknown> #3 0x7f3bc7151a43 __poll #4 0x7f3bc7b8dff6 <unknown> #5 0x7f3bc7b8e124 g_main_context_iteration #6 0x7f3bcf366f35 base::MessagePumpGlib::Run() #7 0x7f3bcf468180 base::MessageLoop::RunHandler() #8 0x7f3bcf4cfcc2 base::RunLoop::Run() #9 0x0000041e0729 content::RunThisRunLoop() #10 0x0000041e06ba content::RunMessageLoop() #11 0x000000668feb ExtensionApiTest::ResultCatcher::GetNextResult() #12 0x0000006a30dd extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread() #13 0x0000006a3712 extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread() #14 0x00000176be8b InProcessBrowserTest::RunTestOnMainThreadLoop() #15 0x0000041c85c8 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #16 0x0000041c9cf2 base::internal::RunnableAdapter<>::Run() #17 0x0000041c9c69 base::internal::InvokeHelper<>::MakeItSo() #18 0x0000041c9c25 base::internal::Invoker<>::Run() #19 0x00000063f0de base::Callback<>::Run() #20 0x0000042dddd2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #21 0x0000042dca92 ChromeBrowserMainParts::PreMainMessageLoopRun() #22 0x000002e77daf chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #23 0x7f3bd7bd2e96 content::BrowserMainLoop::PreMainMessageLoopRun() #24 0x7f3bd7bd96f2 base::internal::RunnableAdapter<>::Run() #25 0x7f3bd7bd965c base::internal::InvokeHelper<>::MakeItSo() #26 0x7f3bd7bd960a base::internal::Invoker<>::Run() #27 0x7f3bd80a852e base::Callback<>::Run() #28 0x7f3bd841bd2b content::StartupTaskRunner::RunAllTasksNow() #29 0x7f3bd7bd12f0 content::BrowserMainLoop::CreateStartupTasks() #30 0x7f3bd7bdcc72 content::BrowserMainRunnerImpl::Initialize() #31 0x7f3bd7bcda55 content::BrowserMain() #32 0x7f3bd7a6224f content::RunNamedProcessTypeMain() #33 0x7f3bd7a655b8 content::ContentMainRunnerImpl::Run() #34 0x7f3bd7a617b5 content::ContentMain() #35 0x0000041c82cb content::BrowserTestBase::SetUp() #36 0x00000176afc3 InProcessBrowserTest::SetUp() #37 0x000000674823 ExtensionBrowserTest::SetUp() #38 0x000000674852 ExtensionBrowserTest::SetUp() #39 0x0000018298a3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #40 0x00000181686e testing::internal::HandleExceptionsInMethodIfSupported<>() #41 0x00000180ad73 testing::Test::Run() #42 0x00000180b4cb testing::TestInfo::Run() #43 0x00000180baca testing::TestCase::Run() #44 0x000001811009 testing::internal::UnitTestImpl::RunAllTests() #45 0x0000018225b3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #46 0x0000018185fe testing::internal::HandleExceptionsInMethodIfSupported<>() #47 0x000001810c97 testing::UnitTest::Run() #48 0x0000041a5531 RUN_ALL_TESTS() #49 0x0000041a4547 base::TestSuite::Run() #50 0x0000008026d2 InteractiveUITestSuiteRunner::RunTestSuite() #51 0x000001769618 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #52 0x0000041d9efb content::LaunchTests() #53 0x00000176954b LaunchChromeTests() #54 0x00000080262f main #55 0x7f3bc708a76d __libc_start_main #56 0x0000005ffda9 <unknown> [123/334] CommandsApiTest.ContinuePropagation (TIMED OUT) Original issue's description: > Fixes HasEventListener check in ExtensionKeybindingRegistry::ExecuteCommands. > > ExtensionKeybindingRegistry::ExecuteCommands functions in two distinct ways -- execute all commands based on an accelerator, or, execute an accelerator for a given extension. The former behavior is implied by passing an empty string. > > Previously, only the latter case was handled when trying to continue propagating keys. > > BUG=407163 > TEST=try bots (interactive_ui_tests --gtest_filter=CommandsApiTest.*). > > Committed: https://chromium.googlesource.com/chromium/src/+/189a2ed4d209231d517b0e64a722722dead3f17a [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=407163 Review URL: https://codereview.chromium.org/552533003 Cr-Commit-Position: refs/heads/master@{#293780}
darktears
pushed a commit
that referenced
this pull request
Sep 29, 2014
…disable GCM (patchset #8 id:150001 of https://codereview.chromium.org/561943002/) Reason for revert: this CL might be breaking browser_tests and interactive_ui_tests on ChromeOS because it's starting a request on startup. here's an example: [15345:15369:0918/132152:ERROR:leak_tracker.h(97)] Leaked 0x11cd70da7cc0 which was allocated by: [15345:15369:0918/132152:ERROR:leak_tracker.h(98)] #0 0x7f44b584025e base::debug::StackTrace::StackTrace() #1 0x000000dfc481 base::debug::LeakTracker<>::LeakTracker() #2 0x000000df3e8d SystemURLRequestContextGetter::SystemURLRequestContextGetter() #3 0x000000df57f1 IOThread::InitSystemRequestContext() #4 0x000000df570b IOThread::system_url_request_context_getter() #5 0x000001443d9e BrowserProcessImpl::system_request_context() #6 0x000001028a8e SafeBrowsingService::Initialize() #7 0x0000014462c9 BrowserProcessImpl::CreateSafeBrowsingService() #8 0x000001446196 BrowserProcessImpl::safe_browsing_service() #9 0x0000014b9a06 ChromeResourceDispatcherHostDelegate::ChromeResourceDispatcherHostDelegate() #10 0x0000014466dc BrowserProcessImpl::ResourceDispatcherHostCreated() #11 0x0000008a88e5 chrome::ChromeContentBrowserClient::ResourceDispatcherHostCreated() #12 0x7f44be489a2f content::ResourceDispatcherHostImpl::ResourceDispatcherHostImpl() #13 0x7f44be060f44 content::BrowserMainLoop::BrowserThreadsStarted() #14 0x7f44be068302 base::internal::RunnableAdapter<>::Run() #15 0x7f44be06826c base::internal::InvokeHelper<>::MakeItSo() #16 0x7f44be06821a base::internal::Invoker<>::Run() #17 0x7f44be54e46e base::Callback<>::Run() #18 0x7f44be8d223b content::StartupTaskRunner::RunAllTasksNow() #19 0x7f44be05ff97 content::BrowserMainLoop::CreateStartupTasks() #20 0x7f44be06b824 content::BrowserMainRunnerImpl::Initialize() #21 0x7f44be05c7df content::BrowserMain() #22 0x7f44bdee5f6f content::RunNamedProcessTypeMain() #23 0x7f44bdee9268 content::ContentMainRunnerImpl::Run() #24 0x7f44bdee5505 content::ContentMain() #25 0x0000041aa8cb content::BrowserTestBase::SetUp() #26 0x00000173e117 InProcessBrowserTest::SetUp() #27 0x000000671180 ExtensionBrowserTest::SetUp() #28 0x0000006711b2 ExtensionBrowserTest::SetUp() #29 0x0000017fb993 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #30 0x0000017e8bfe testing::internal::HandleExceptionsInMethodIfSupported<>() #31 0x0000017dd1e3 testing::Test::Run() #32 0x0000017dd92b testing::TestInfo::Run() #33 0x0000017ddf1a testing::TestCase::Run() #34 0x0000017e3413 testing::internal::UnitTestImpl::RunAllTests() #35 0x0000017f47d3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #36 0x0000017ea96e testing::internal::HandleExceptionsInMethodIfSupported<>() #37 0x0000017e30b1 testing::UnitTest::Run() #38 0x000004187e41 RUN_ALL_TESTS() #39 0x000004186e67 base::TestSuite::Run() #40 0x0000007fcd62 InteractiveUITestSuiteRunner::RunTestSuite() #41 0x00000173c7b8 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #42 0x0000041bc2fb content::LaunchTests() #43 0x00000173c6e9 LaunchChromeTests() #44 0x0000007fccbf main #45 0x7f44ad8ed76d __libc_start_main #46 0x000000601389 <unknown> [15345:15369:0918/132152:FATAL:leak_tracker.h(102)] Check failed: 0u == count (0 vs. 1) #0 0x7f44b584025e base::debug::StackTrace::StackTrace() #1 0x7f44b58d7a62 logging::LogMessage::~LogMessage() #2 0x000000dfdd01 base::debug::LeakTracker<>::CheckForLeaks() #3 0x000000df8e13 IOThread::CleanUp() #4 0x7f44be0810b6 content::BrowserThreadImpl::CleanUp() #5 0x7f44be07e852 content::BrowserProcessSubThread::CleanUp() #6 0x7f44b59d0601 base::Thread::ThreadMain() #7 0x7f44b59bba3c base::(anonymous namespace)::ThreadFunc() #8 0x7f44b1aa9e9a start_thread #9 0x7f44ad9c03fd clone Original issue's description: > Add GCMChannelStatusSyncer to schedule requests and enable/disable GCM > > BUG=384041 > TEST=new tests added > > Committed: https://crrev.com/3c23f4a188e171998f3042ad62f4aa5717e66d63 > Cr-Commit-Position: refs/heads/master@{#295524} [email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=384041 Review URL: https://codereview.chromium.org/582913003 Cr-Commit-Position: refs/heads/master@{#295549}
rakuco
pushed a commit
that referenced
this pull request
Oct 10, 2014
> > BUG=418214 > > Review URL: https://codereview.chromium.org/609983002 > > Cr-Commit-Position: refs/heads/master@{#297094} > (cherry picked from commit 2a49d59) [email protected] Review URL: https://codereview.chromium.org/624623002 Cr-Commit-Position: refs/branch-heads/2171@{#27} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco
pushed a commit
that referenced
this pull request
Jan 26, 2015
…UV420 format enumeration." This reverts commit 3936948. The reason is that we think this causes none working devices to be enumerated, see crbug/448599 original code review: https://codereview.chromium.org/802633006 BUG=441836,448599 TBR=mcasas,[email protected] Review URL: https://codereview.chromium.org/814573008 Cr-Commit-Position: refs/heads/master@{#311690} (cherry picked from commit c0b2e72) Review URL: https://codereview.chromium.org/814833010 Cr-Commit-Position: refs/branch-heads/2272@{#27} Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco
pushed a commit
that referenced
this pull request
Mar 2, 2015
…nabled Previously streams would be intercepted even if the MimeHandlerView plugin associated with them was disabled which would prevent the resource from being download if a plugin wasn't being enabled to handle it. BUG=459383 Review URL: https://codereview.chromium.org/933093002 Cr-Commit-Position: refs/heads/master@{#317673} (cherry picked from commit 553cec8) Review URL: https://codereview.chromium.org/957703005 Cr-Commit-Position: refs/branch-heads/2311@{#27} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco
pushed a commit
that referenced
this pull request
Jun 8, 2015
This patch fixes the regression by https://codereview.chromium.org/1134603002/diff/1/ui/file_manager/video_player/css/video_player.css BUG=488213 TEST=none [email protected] Review URL: https://codereview.chromium.org/1141183004 Cr-Commit-Position: refs/heads/master@{#330342} (cherry picked from commit 3ff0cb0) Review URL: https://codereview.chromium.org/1144953003 Cr-Commit-Position: refs/branch-heads/2403@{#27} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
smishenk
pushed a commit
to smishenk/chromium-crosswalk
that referenced
this pull request
Apr 29, 2016
Cr-Commit-Position: refs/branch-heads/2623@{crosswalk-project#27}
Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
Removes https:// schema from original URLs of offline pages. BUG=585209 Review URL: https://codereview.chromium.org/1747523002 Cr-Commit-Position: refs/heads/master@{#378349} (cherry picked from commit 8c1173f) Review URL: https://codereview.chromium.org/1757473002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#27} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
fujunwei
pushed a commit
to fujunwei/chromium-crosswalk
that referenced
this pull request
May 27, 2016
This was broken in http://crrev.com/1248613003, which replaced JS code to show/hide the message with CSS selectors based on the 'legacy-supervised' class. However, that class was only used on desktop, not on CrOS. This CL is a minimal fix, for merging to M48: Set this particular class also on CrOS. Longer-term, it would be nice to clean up the user pod stuff to be less different on CrOS vs desktop... BUG=546183 Review URL: https://codereview.chromium.org/1446193002 Cr-Commit-Position: refs/heads/master@{#360037} (cherry picked from commit 36d442b) Review URL: https://codereview.chromium.org/1453913003 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#27} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Signin_Signin_FromStartPage has been moved. Signin_Impression_FromStartPage has been removed. BUG=608179 Review-Url: https://codereview.chromium.org/1996393002 Cr-Commit-Position: refs/heads/master@{#395292} (cherry picked from commit 78a3967) [email protected] NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2000133002 Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#27} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
On newer ARC-enabled devices, the Chrome versions of the default apps that were replaced by their corresponding ARC apps won't be installed. [email protected], [email protected], [email protected], [email protected] BUG=744719 TEST=Create a new account on an ARC device and notice no Chrome versions of the apps Play Books, Play Movies, and Play Music. Only ARC apps of these apps are available. (cherry picked from commit 9ef29e0) Change-Id: I698d74b8bc26c51623c8d6d2e5b054bbe1423666 Reviewed-on: https://chromium-review.googlesource.com/620027 Reviewed-by: Devlin <[email protected]> Reviewed-by: Elijah Taylor <[email protected]> Reviewed-by: Sky Malice <[email protected]> Reviewed-by: Yury Khmel <[email protected]> Commit-Queue: Ahmed Fakhry <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#499211} Reviewed-on: https://chromium-review.googlesource.com/651106 Reviewed-by: Ahmed Fakhry <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#27} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix content_shell break