Fix 2 title related issues in aura port #38

hmin · 2013-07-18T09:43:38Z

No description provided.

Since each DesktopNativeWidgetAura uses a sole aura::Window as its backed, once the title of native widget gets updated, the title of aura::Window should also be updated in addition to updating the XWindow created by DesktopRootWindowHostX11. BUG=crosswalk-project/crosswalk#191 TEST=xwalk_browsertest --gtest_filter=XWalkRuntimeTest.GetWindowTitle

hmin · 2013-07-18T09:43:56Z

@kenchris @huningxin Please have a review. Thanks.

Trybot · 2013-07-18T09:44:11Z

Trybot Dashboard

Building status:

Finished the build of the PATCH in this pull request

Fri Jul 19 2013 01:46:38 GMT+0800 (CST) [content_linux] Passed LOGS: [Build successful]
Fri Jul 19 2013 01:57:43 GMT+0800 (CST) [content_win] Passed LOGS: [Build successful]
Fri Jul 19 2013 02:04:58 GMT+0800 (CST) [content_android] Passed LOGS: [Build successful]

Rebuild the failed bots you want!

Select the bots:

content_linux
content_win
content_android

Start the building:

< START >

huningxin · 2013-07-18T09:51:10Z

LGTM. Thanks for the fix.

Fix 2 title related issues in aura port

…hset #5 id:100001 of https://codereview.chromium.org/516293007/) Reason for revert: Chrome OS build with DCHECKs enabled fails on start. This CL breaks assumption, that GAIA extension can be loaded without performing IO-operations. Log and stack trace: [16275:16275:0903/161435:WARNING:renderer_freezer.cc(55)] Cgroup freezer does not exist or is not writable. Processes will not be frozen during suspend. [16275:16275:0903/161435:WARNING:configuration_policy_pref_store.cc(30)] Policy RemoteAccessClientFirewallTraversal: This policy has been deprecated. [16275:16275:0903/161437:FATAL:thread_restrictions.cc(38)] Function marked as IO-only was called from a thread that disallows IO! If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup. #0 0x7fe3122e555e base::debug::StackTrace::StackTrace() #1 0x7fe31237c462 logging::LogMessage::~LogMessage() #2 0x7fe3124824af base::ThreadRestrictions::AssertIOAllowed() #3 0x7fe3123630a1 base::PathExists() #4 0x7fe321cfd5f3 extensions::(anonymous namespace)::CollectPlatformSpecificResourceArchs() #5 0x7fe321cfad22 extensions::Extension::InitFromValue() #6 0x7fe321cfa490 extensions::Extension::Create() #7 0x7fe321cfa114 extensions::Extension::Create() #8 0x7fe3233ebe1b extensions::ComponentLoader::Load() #9 0x7fe3233ec3cf extensions::ComponentLoader::Add() #10 0x7fe3233ec32a extensions::ComponentLoader::Add() #11 0x7fe3233ec2b0 extensions::ComponentLoader::Add() #12 0x7fe32437505f (anonymous namespace)::LoadGaiaAuthExtension() #13 0x7fe324374d5e extensions::GaiaAuthExtensionLoader::LoadIfNeeded() #14 0x7fe324237f7e ScopedGaiaAuthExtension::ScopedGaiaAuthExtension() #15 0x7fe322f68bb2 chromeos::WebUILoginView::Init() #16 0x7fe322f556ef chromeos::LoginDisplayHostImpl::InitLoginWindowAndView() #17 0x7fe322f52640 chromeos::LoginDisplayHostImpl::LoadURL() #18 0x7fe322f5226a chromeos::LoginDisplayHostImpl::StartWizard() #19 0x7fe322f54acd chromeos::LoginDisplayHostImpl::StartPostponedWebUI() #20 0x7fe322f541f8 chromeos::LoginDisplayHostImpl::Observe() #21 0x7fe322f54bfd chromeos::LoginDisplayHostImpl::Observe() #22 0x7fe31b222377 content::NotificationServiceImpl::Notify() #23 0x7fe322d51a24 chromeos::(anonymous namespace)::UserWallpaperDelegate::OnWallpaperAnimationFinished() #24 0x7fe31188692f ash::RootWindowController::OnWallpaperAnimationFinished() #25 0x7fe3117c633a ash::(anonymous namespace)::ShowWallpaperAnimationObserver::OnImplicitAnimationsCompleted() #26 0x7fe311f72d30 ui::ImplicitAnimationObserver::CheckCompleted() #27 0x7fe311f72cd5 ui::ImplicitAnimationObserver::SetActive() #28 0x7fe311f965d5 ui::ScopedLayerAnimationSettings::~ScopedLayerAnimationSettings() #29 0x7fe3117c5ec7 ash::DesktopBackgroundWidgetController::StartAnimating() #30 0x7fe3117bbb0c ash::DesktopBackgroundController::InstallDesktopController() #31 0x7fe3117bbc03 ash::DesktopBackgroundController::InstallDesktopControllerForAllWindows() #32 0x7fe3117bb3cc ash::DesktopBackgroundController::SetDesktopBackgroundImageMode() #33 0x7fe3117bb096 ash::DesktopBackgroundController::SetWallpaperImage() #34 0x7fe322f9a6b9 chromeos::WallpaperManager::DoSetDefaultWallpaper() #35 0x7fe322f99b73 chromeos::WallpaperManager::PendingWallpaper::ProcessRequest() #36 0x7fe322fbac72 base::internal::RunnableAdapter<>::Run() #37 0x7fe322fbabe9 base::internal::InvokeHelper<>::MakeItSo() #38 0x7fe322fbaba5 base::internal::Invoker<>::Run() #39 0x7fe3122cc9ce base::Callback<>::Run() #40 0x7fe312488f86 base::Timer::RunScheduledTask() #41 0x7fe3124890bc base::BaseTimerTaskInternal::Run() #42 0x7fe312489382 base::internal::RunnableAdapter<>::Run() #43 0x7fe3124892ec base::internal::InvokeHelper<>::MakeItSo() #44 0x7fe312489295 base::internal::Invoker<>::Run() #45 0x7fe3122cc9ce base::Callback<>::Run() #46 0x7fe3122eb9b3 base::debug::TaskAnnotator::RunTask() #47 0x7fe3123a1c57 base::MessageLoop::RunTask() #48 0x7fe3123a1d9b base::MessageLoop::DeferOrRunPendingTask() #49 0x7fe3123a228d base::MessageLoop::DoDelayedWork() #50 0x7fe3122a1f25 base::MessagePumpGlib::Run() #51 0x7fe3123a17f0 base::MessageLoop::RunHandler() #52 0x7fe3124093b2 base::RunLoop::Run() #53 0x7fe324217e4d ChromeBrowserMainParts::MainMessageLoopRun() #54 0x7fe31ad2a8bf content::BrowserMainLoop::RunMainMessageLoopParts() #55 0x7fe31ad344c7 content::BrowserMainRunnerImpl::Run() #56 0x7fe31ad251b1 content::BrowserMain() #57 0x7fe31abb997f content::RunNamedProcessTypeMain() #58 0x7fe31abbcce8 content::ContentMainRunnerImpl::Run() #59 0x7fe31abb8ee5 content::ContentMain() #60 0x7fe3206d3505 ChromeMain #61 0x7fe3206d34b2 main Cannot upload crash dump: cannot exec /sbin/crash_reporter Crash_reporter failed to process crash report Original issue's description: > Enable forced extension updates on NaCl arch mismatch > > This makes extensions aware of the platforms for which > they have platform-specific resources installed, if any. > > This also hooks up the extension update code with some > additional logic to place an extension in forced-update > mode if it has platform-specific resources which don't > match the current NaCl architecture. > > BUG=409948 > TEST=install an extension which uses NaCl (QuickOffice for example). Rename the _platform-specific/<your-nacl-arch> directory some something else and force an update (e.g. via chrome://extensions button). Observe that a new CRX is downloaded and installed. > > Committed: https://chromium.googlesource.com/chromium/src/+/4a92281fa5d331860d65a59ba45dc882a5c71df4 [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=409948 Review URL: https://codereview.chromium.org/532183003 Cr-Commit-Position: refs/heads/master@{#293128}

…::ExecuteCommands. (patchset #1 id:1 of https://codereview.chromium.org/547783002/) Reason for revert: Broke Linux ChromiumOS Tests (dbg)(3) http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/1206 BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f3bcf3aa67e base::debug::StackTrace::StackTrace() #1 0x0000041c884a content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f3bc709f4a0 <unknown> #3 0x7f3bc7151a43 __poll #4 0x7f3bc7b8dff6 <unknown> #5 0x7f3bc7b8e124 g_main_context_iteration #6 0x7f3bcf366f35 base::MessagePumpGlib::Run() #7 0x7f3bcf468180 base::MessageLoop::RunHandler() #8 0x7f3bcf4cfcc2 base::RunLoop::Run() #9 0x0000041e0729 content::RunThisRunLoop() #10 0x0000041e06ba content::RunMessageLoop() #11 0x000000668feb ExtensionApiTest::ResultCatcher::GetNextResult() #12 0x0000006a30dd extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread() #13 0x0000006a3712 extensions::CommandsApiTest_ContinuePropagation_Test::RunTestOnMainThread() #14 0x00000176be8b InProcessBrowserTest::RunTestOnMainThreadLoop() #15 0x0000041c85c8 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #16 0x0000041c9cf2 base::internal::RunnableAdapter<>::Run() #17 0x0000041c9c69 base::internal::InvokeHelper<>::MakeItSo() #18 0x0000041c9c25 base::internal::Invoker<>::Run() #19 0x00000063f0de base::Callback<>::Run() #20 0x0000042dddd2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #21 0x0000042dca92 ChromeBrowserMainParts::PreMainMessageLoopRun() #22 0x000002e77daf chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #23 0x7f3bd7bd2e96 content::BrowserMainLoop::PreMainMessageLoopRun() #24 0x7f3bd7bd96f2 base::internal::RunnableAdapter<>::Run() #25 0x7f3bd7bd965c base::internal::InvokeHelper<>::MakeItSo() #26 0x7f3bd7bd960a base::internal::Invoker<>::Run() #27 0x7f3bd80a852e base::Callback<>::Run() #28 0x7f3bd841bd2b content::StartupTaskRunner::RunAllTasksNow() #29 0x7f3bd7bd12f0 content::BrowserMainLoop::CreateStartupTasks() #30 0x7f3bd7bdcc72 content::BrowserMainRunnerImpl::Initialize() #31 0x7f3bd7bcda55 content::BrowserMain() #32 0x7f3bd7a6224f content::RunNamedProcessTypeMain() #33 0x7f3bd7a655b8 content::ContentMainRunnerImpl::Run() #34 0x7f3bd7a617b5 content::ContentMain() #35 0x0000041c82cb content::BrowserTestBase::SetUp() #36 0x00000176afc3 InProcessBrowserTest::SetUp() #37 0x000000674823 ExtensionBrowserTest::SetUp() #38 0x000000674852 ExtensionBrowserTest::SetUp() #39 0x0000018298a3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #40 0x00000181686e testing::internal::HandleExceptionsInMethodIfSupported<>() #41 0x00000180ad73 testing::Test::Run() #42 0x00000180b4cb testing::TestInfo::Run() #43 0x00000180baca testing::TestCase::Run() #44 0x000001811009 testing::internal::UnitTestImpl::RunAllTests() #45 0x0000018225b3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #46 0x0000018185fe testing::internal::HandleExceptionsInMethodIfSupported<>() #47 0x000001810c97 testing::UnitTest::Run() #48 0x0000041a5531 RUN_ALL_TESTS() #49 0x0000041a4547 base::TestSuite::Run() #50 0x0000008026d2 InteractiveUITestSuiteRunner::RunTestSuite() #51 0x000001769618 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #52 0x0000041d9efb content::LaunchTests() #53 0x00000176954b LaunchChromeTests() #54 0x00000080262f main #55 0x7f3bc708a76d __libc_start_main #56 0x0000005ffda9 <unknown> [123/334] CommandsApiTest.ContinuePropagation (TIMED OUT) Original issue's description: > Fixes HasEventListener check in ExtensionKeybindingRegistry::ExecuteCommands. > > ExtensionKeybindingRegistry::ExecuteCommands functions in two distinct ways -- execute all commands based on an accelerator, or, execute an accelerator for a given extension. The former behavior is implied by passing an empty string. > > Previously, only the latter case was handled when trying to continue propagating keys. > > BUG=407163 > TEST=try bots (interactive_ui_tests --gtest_filter=CommandsApiTest.*). > > Committed: https://chromium.googlesource.com/chromium/src/+/189a2ed4d209231d517b0e64a722722dead3f17a [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=407163 Review URL: https://codereview.chromium.org/552533003 Cr-Commit-Position: refs/heads/master@{#293780}

…disable GCM (patchset #8 id:150001 of https://codereview.chromium.org/561943002/) Reason for revert: this CL might be breaking browser_tests and interactive_ui_tests on ChromeOS because it's starting a request on startup. here's an example: [15345:15369:0918/132152:ERROR:leak_tracker.h(97)] Leaked 0x11cd70da7cc0 which was allocated by: [15345:15369:0918/132152:ERROR:leak_tracker.h(98)] #0 0x7f44b584025e base::debug::StackTrace::StackTrace() #1 0x000000dfc481 base::debug::LeakTracker<>::LeakTracker() #2 0x000000df3e8d SystemURLRequestContextGetter::SystemURLRequestContextGetter() #3 0x000000df57f1 IOThread::InitSystemRequestContext() #4 0x000000df570b IOThread::system_url_request_context_getter() #5 0x000001443d9e BrowserProcessImpl::system_request_context() #6 0x000001028a8e SafeBrowsingService::Initialize() #7 0x0000014462c9 BrowserProcessImpl::CreateSafeBrowsingService() #8 0x000001446196 BrowserProcessImpl::safe_browsing_service() #9 0x0000014b9a06 ChromeResourceDispatcherHostDelegate::ChromeResourceDispatcherHostDelegate() #10 0x0000014466dc BrowserProcessImpl::ResourceDispatcherHostCreated() #11 0x0000008a88e5 chrome::ChromeContentBrowserClient::ResourceDispatcherHostCreated() #12 0x7f44be489a2f content::ResourceDispatcherHostImpl::ResourceDispatcherHostImpl() #13 0x7f44be060f44 content::BrowserMainLoop::BrowserThreadsStarted() #14 0x7f44be068302 base::internal::RunnableAdapter<>::Run() #15 0x7f44be06826c base::internal::InvokeHelper<>::MakeItSo() #16 0x7f44be06821a base::internal::Invoker<>::Run() #17 0x7f44be54e46e base::Callback<>::Run() #18 0x7f44be8d223b content::StartupTaskRunner::RunAllTasksNow() #19 0x7f44be05ff97 content::BrowserMainLoop::CreateStartupTasks() #20 0x7f44be06b824 content::BrowserMainRunnerImpl::Initialize() #21 0x7f44be05c7df content::BrowserMain() #22 0x7f44bdee5f6f content::RunNamedProcessTypeMain() #23 0x7f44bdee9268 content::ContentMainRunnerImpl::Run() #24 0x7f44bdee5505 content::ContentMain() #25 0x0000041aa8cb content::BrowserTestBase::SetUp() #26 0x00000173e117 InProcessBrowserTest::SetUp() #27 0x000000671180 ExtensionBrowserTest::SetUp() #28 0x0000006711b2 ExtensionBrowserTest::SetUp() #29 0x0000017fb993 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #30 0x0000017e8bfe testing::internal::HandleExceptionsInMethodIfSupported<>() #31 0x0000017dd1e3 testing::Test::Run() #32 0x0000017dd92b testing::TestInfo::Run() #33 0x0000017ddf1a testing::TestCase::Run() #34 0x0000017e3413 testing::internal::UnitTestImpl::RunAllTests() #35 0x0000017f47d3 testing::internal::HandleSehExceptionsInMethodIfSupported<>() #36 0x0000017ea96e testing::internal::HandleExceptionsInMethodIfSupported<>() #37 0x0000017e30b1 testing::UnitTest::Run() #38 0x000004187e41 RUN_ALL_TESTS() #39 0x000004186e67 base::TestSuite::Run() #40 0x0000007fcd62 InteractiveUITestSuiteRunner::RunTestSuite() #41 0x00000173c7b8 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite() #42 0x0000041bc2fb content::LaunchTests() #43 0x00000173c6e9 LaunchChromeTests() #44 0x0000007fccbf main #45 0x7f44ad8ed76d __libc_start_main #46 0x000000601389 <unknown> [15345:15369:0918/132152:FATAL:leak_tracker.h(102)] Check failed: 0u == count (0 vs. 1) #0 0x7f44b584025e base::debug::StackTrace::StackTrace() #1 0x7f44b58d7a62 logging::LogMessage::~LogMessage() #2 0x000000dfdd01 base::debug::LeakTracker<>::CheckForLeaks() #3 0x000000df8e13 IOThread::CleanUp() #4 0x7f44be0810b6 content::BrowserThreadImpl::CleanUp() #5 0x7f44be07e852 content::BrowserProcessSubThread::CleanUp() #6 0x7f44b59d0601 base::Thread::ThreadMain() #7 0x7f44b59bba3c base::(anonymous namespace)::ThreadFunc() #8 0x7f44b1aa9e9a start_thread #9 0x7f44ad9c03fd clone Original issue's description: > Add GCMChannelStatusSyncer to schedule requests and enable/disable GCM > > BUG=384041 > TEST=new tests added > > Committed: https://crrev.com/3c23f4a188e171998f3042ad62f4aa5717e66d63 > Cr-Commit-Position: refs/heads/master@{#295524} [email protected],[email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=384041 Review URL: https://codereview.chromium.org/582913003 Cr-Commit-Position: refs/heads/master@{#295549}

Currently, the host list is fetched from the main activity's onStart() handler. If onStart() is triggered again during the process of authentication, this could cause an infinite loop of pending requests. Review URL: https://codereview.chromium.org/607453004 Cr-Commit-Position: refs/heads/master@{#297088} (cherry picked from commit f1318ec) BUG=419602 Review URL: https://codereview.chromium.org/626713002 Cr-Commit-Position: refs/branch-heads/2171@{#38} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}

Update history on every embedded webview navigation for the Chrome signin page Manually push history entries on each completed chrome://chrome-signin navigation, so that the back/forward navigation buttons work correctly. Just picking up Hui's original CL: https://codereview.chromium.org/730243002/ She originally had a crash when updating the webview src, but that is no longer reproducible. BUG=447539 Review URL: https://codereview.chromium.org/846063003 Cr-Commit-Position: refs/heads/master@{#311136} (cherry picked from commit 42785e8) Review URL: https://codereview.chromium.org/855743002 Cr-Commit-Position: refs/branch-heads/2272@{#38} Cr-Branched-From: 827a380-refs/heads/master@{#310958}

- Fix the task queue so that cancelling a task doesn't leave it hanging out in the queue, which then will jam everything up. - Fix the error code so that errors are handled consistently (and are non-terminal, as they should be) - Rename UpdateType.SUCCESS to UpdateType.COMPLETE. This better reflects the fact that errors can occur during an import task but the task still runs to completion. BUG=460597 Review URL: https://codereview.chromium.org/947583002 Cr-Commit-Position: refs/heads/master@{#317538} (cherry picked from commit fb5551a) TBR=mtomasz Review URL: https://codereview.chromium.org/964533003 Cr-Commit-Position: refs/branch-heads/2311@{#38} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}

> BUG=473077 > > Review URL: https://codereview.chromium.org/1072643002 > > Cr-Commit-Position: refs/heads/master@{#324368} > (cherry picked from commit 5c35815) [email protected] Review URL: https://codereview.chromium.org/1055573004 Cr-Commit-Position: refs/branch-heads/2357@{#38} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}

…oid. 512MB is needed on desktop to not regress performance on some important benchmarks but this limit is much more than needed on Android. By reducing it to 128MB we can also avoid using a different allocation size on Android. This makes the discardable memory behavior more consistent across platforms and improves the browser's ability to purge memory on Android. This change also reduces the amount of discardable memory used on low end devices to 1/8th of the normal limit. BUG=489174 Review URL: https://codereview.chromium.org/1013533002 Cr-Commit-Position: refs/heads/master@{#330754} (cherry picked from commit df13fe3) [email protected] Review URL: https://codereview.chromium.org/1148303003 Cr-Commit-Position: refs/branch-heads/2403@{#38} Cr-Branched-From: f54b809-refs/heads/master@{#330231}

The only supported SPDY versions are SPDY/3.1 and HTTP/2, both of which specify both stream and session level flow control. Therefore enum FlowControlState, members and accessors of this type, and associated UMA histograms and event types are obsolete, and are removed by this CL. BUG=474216 Review URL: https://codereview.chromium.org/1581103006 Cr-Commit-Position: refs/heads/master@{#370255} (cherry picked from commit 3ab2528) Review URL: https://codereview.chromium.org/1619543003 . Cr-Commit-Position: refs/branch-heads/2623@{#38} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}

…aSession UI." The old path intentionally assumed we could always suspend paused players, but in cases where a MediaSession UI is present, a user may resume these players at a later time. This is reasonable in a world where a user gesture is required for playback. A later CL will tune this to separate the suspension process from the release of the MediaSession, allowing us to suspend all players while still providing the MediaSession UI to appropriate ones. BUG=590099 TEST=updated unittest, manually confirmed MediaSession is not expired (at least until renderer process is killed). Review URL: https://codereview.chromium.org/1750753002 Cr-Commit-Position: refs/heads/master@{#378306} (cherry picked from commit 78f7596) Review URL: https://codereview.chromium.org/1757613002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#38} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}

This was missed in https://codereview.chromium.org/1414923004/ BUG=546108 Review URL: https://codereview.chromium.org/1455723002 Cr-Commit-Position: refs/heads/master@{#360152} (cherry picked from commit 457554d) Review URL: https://codereview.chromium.org/1461723002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#38} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

…ded. This avoids querying for offline pages if the model is not loaded, so that the maximum possible delay is minimal (once the model is loaded, all pages are stored in memory). Additionally checks for null when obtaining the offline page model. BUG=607573,613359 Review-Url: https://codereview.chromium.org/1982483002 Cr-Commit-Position: refs/heads/master@{#395096} (cherry picked from commit 9a12ce0) Review URL: https://codereview.chromium.org/2007563005 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#38} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}

We add the base language to the Accept-Language headers, if a corresponding language+region code is present. This change wants to address a long-standing bug that occasionally makes websites return resources in a non-preferred language. See design doc: https://docs.google.com/document/d/10eGUww_2Ufv-YyGwnmr9ke_89Q6By_94v02FM_NTU24 [email protected] (cherry picked from commit 81326f9) Bug: 737232 Change-Id: I67bea7cb368c744330ec11773fe4a6a69c0e3959 Reviewed-on: https://chromium-review.googlesource.com/625496 Commit-Queue: Claudio M <[email protected]> Reviewed-by: Dimitri Glazkov <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#499136} Reviewed-on: https://chromium-review.googlesource.com/651830 Reviewed-by: Marti Wong <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#38} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

Hongbo Min added 2 commits July 18, 2013 17:35

Use XmbSetWMProperties to set window title for i18n issue

8c980f4

BUG=crosswalk-project/crosswalk#189

kenchris pushed a commit that referenced this pull request Jul 18, 2013

Merge pull request #38 from hmin/title

4a31ab3

Fix 2 title related issues in aura port

kenchris merged commit 4a31ab3 into crosswalk-project:master Jul 18, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix 2 title related issues in aura port #38

Fix 2 title related issues in aura port #38

hmin commented Jul 18, 2013

hmin commented Jul 18, 2013

Trybot commented Jul 18, 2013

huningxin commented Jul 18, 2013

Fix 2 title related issues in aura port #38

Fix 2 title related issues in aura port #38

Conversation

hmin commented Jul 18, 2013

hmin commented Jul 18, 2013

Trybot commented Jul 18, 2013

Trybot Dashboard

Building status:

Finished the build of the PATCH in this pull request

Rebuild the failed bots you want!

Select the bots:

Start the building:

huningxin commented Jul 18, 2013