Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 ➡️ 12 (main) #303

Merged
merged 27 commits into from
Mar 26, 2022
Merged

11 ➡️ 12 (main) #303

merged 27 commits into from
Mar 26, 2022

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-transport11 to main

Branch comparison: main...ign-transport11

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 27 commits September 29, 2021 14:11
Signed-off-by: Louise Poubel <[email protected]>
Port forward fix Homebrew warning

Signed-off-by: Carlos Agüero <[email protected]>
* Bump to 10.1.0

Signed-off-by: Carlos Agüero <[email protected]>
* NetUtils: remove unused variable

The preferred_ip array is initialized to {0} and no code
writes to it; it is only read from, so just remove it.

* Remove if/else block with identical actions

Each branch executes the same code, so just run that code
unconditionally.

Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Alexander Graber-Tilton <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from caguero as a code owner March 25, 2022 18:34
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Mar 25, 2022
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #303 (f493a8f) into main (e967abb) will decrease coverage by 0.00%.
The diff coverage is 76.19%.

❗ Current head f493a8f differs from pull request most recent head d4bbe37. Consider uploading reports for the commit d4bbe37 to get more accurate results

@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   88.76%   88.76%   -0.01%     
==========================================
  Files          52       52              
  Lines        4789     4797       +8     
==========================================
+ Hits         4251     4258       +7     
- Misses        538      539       +1     
Impacted Files Coverage Δ
include/ignition/transport/AdvertiseOptions.hh 100.00% <ø> (ø)
include/ignition/transport/Discovery.hh 87.06% <ø> (ø)
include/ignition/transport/Publisher.hh 100.00% <ø> (ø)
include/ignition/transport/RepHandler.hh 85.36% <ø> (ø)
log/include/ignition/transport/log/Playback.hh 100.00% <ø> (ø)
log/include/ignition/transport/log/QueryOptions.hh 100.00% <ø> (ø)
src/Discovery.cc 75.00% <ø> (ø)
src/NodeShared.cc 78.55% <ø> (ø)
src/NetUtils.cc 74.03% <75.00%> (+1.31%) ⬆️
src/cmd/ign.cc 95.31% <75.00%> (-2.13%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e967abb...d4bbe37. Read the comment docs.

@scpeters scpeters merged commit 606b31c into main Mar 26, 2022
@scpeters scpeters deleted the chapulina/11_to_12 branch March 26, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.