Issue2614 chilled beam sequences controls only #3081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated release notes and conversion script * Merged IBPSA, issue1477_diffuseRadiation_AND_issue1478_BESTEST_weatherfiles and issue1494_plugflowpipe_singleoutlet BESTEST and other results only changed slightly. Some examples such as Buildings.HeatTransfer.Windows.BaseClasses.Examples.WindowRadiation changed significantly because the model used the latitude as a parameter which was set to a different value than the location of the weather data file has. With this code change, the latitude from the weather data file is used * Updated BESTEST results * Added input signal for altitude Dymola assumes a signal of 0 if it is not set on the weather data bus, whereas OCT issues a translation error
* Added changes to connector location and documentation This is from IBPSA, issue1477_diffuseRadiation_AND_issue1478_BESTEST_weatherfiles * Updated documentation
* Fix issue link * Corrected html format Co-authored-by: tbeu <[email protected]>
* Removed parameter qualifiers from record definition * Added revision notes Co-authored-by: Francesco Casella <[email protected]>
* added header file, lbl-srg#2617
This is for lbl-srg#2636
* Update models * Update documentation for System2 * Update first part of System3 documentation * Update documentation for second part of System3 * Update revision sections * Update reference results for unit tests * Changed temperatures to Kelvin (as tools will then show them in degC) * Fixed format * Fix sup-ret typo in system2 doc * Update HVAC parameterization * Update revisions section * Update unit test results * Update release notes Co-authored-by: Michael Wetter <[email protected]>
* Merged IBPSA, issue 1524 and issue 1522
* combined if statements for fluid connector into single parameter * unified boolean flag names (lbl-srg#2644) Co-authored-by: mingzhe37 <[email protected]> Co-authored-by: Mingzhe <[email protected]>
* Updated OpenModelica version to 1.18, switched to use of Docker for OMC.
* Make cryptographic hash functions static
* changed block names for lbl-srg#2650
* Changed model structure to separate building and HVAC system. For lbl-srg#2652 Renamed import buildingspy.development.refactor as r r.move_class(Buildings.Examples.VAVReheat.Controls, Buildings.Examples.VAVReheat.BaseClasses.Controls) r.move_class(Buildings.Examples.VAVReheat.BaseClasses.FreezeStat, Buildings.Examples.VAVReheat.BaseClasses.Controls.FreezeStat) r.move_class(Buildings.Examples.VAVReheat.BaseClasses.PartialOpenLoop, Buildings.Examples.VAVReheat.BaseClasses.PartialHVAC)
* Merged IBPSA, issue1494_plugflowpipe_singleoutlet * Updated reference results
This is needed for the case study
* Merged IBPSA, issue1494_plugflowpipe_singleoutlet * Updated reference results * Merged IBPSA, issue1527_moverDocumentation
* Added missing parameter declaration For lbl-srg#2669
This avoids a potential overflow in the analytical derivative of the splice function
* Merged IBPSA, issue1494_plugflowpipe_singleoutlet * Merged IBPSA, issue1527_moverDocumentation * Merged IBPSA, issue1529_leftJustified2 issue1534_signalRanker issue1533_moversValidationDocImage
* Changed icon and set min attribute of nout For lbl-srg#2689
* first commit * fix errors * update buried pipe results * Updated comment * Made res public In PlugFlowPipe, res is also public, so it makes sense that both models have the same public members * Renamed PlugFlowDiscretized to PlugFlowPipeDiscretized to have a similiar name as PlugFlowPipe * Maded pipSeg protected * Refactored models to avoid replaceable class for res in GUI Co-authored-by: Michael Wetter <[email protected]>
* Updated binaries for lbl-srg#2602. This fixes QLat_flow and QPeo_flow
* Reformulated function to return tuple rather than record This is for lbl-srg#2698 * declare function parameters * Declared function parameters to avoid division by zero in Dymola Co-authored-by: Baptiste Ravache <[email protected]>
* Merged IBPSA, issue1540_FMIExportContainerParameterization issue1529_leftJustified2
* Updated test for BOM This is for lbl-srg#3028
* Merged IBPSA
* Implementation of CDL.Continuous.Derivative For lbl-srg#3022
* Implemented PID block with gains as input. For lbl-srg#2993 * Removed duplicate name label * Rearranged connections Co-authored-by: Huang <[email protected]>
This only affects the special case of nEle=1. Results are not affected by this change
* updated to latest BESTEST * added release note and revision note for the CenterOfGlass class * Corrected air pressure to be the same as in weather data file This required adding a small flow resistance to decouple the pressure boundary condition from the room model. Annual cooling for Case 900 changes by 4%. * Added models to exclude list Co-authored-by: Michael Wetter <[email protected]>
* Added release information for version 9.0.0 * Updated date * Added 8.1.3 release notes
* Added test case from lbl-srg#3043 Files were added manually to exclude the large file Buildings/Resources/Data/Fluid/HeatExchangers/Examples/WetCoilCounterFlowPescribedBoundary.dat * Simplified example * Avoided division by zero if nEle=1 * Updated reference results for lbl-srg#3027
* Merged IBPSA * Reverted formatting changes
* changed conDam.yMin from 0.1 to 0.25 * updated unit test results * updated change logs
…arksNominalFlowRate Closes lbl-srg#3067.
…BeamSequences_ControlsOnly
…notation. Changed parameter values in validation model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mwetter I am submitting this PR to resolve the comments left on #2614. I have moved the package out of the ASHRAE subpackage since we are not referencing any ASHRAE-published documents for the control sequences. I have also added a schematic to show how the controllers should be used in the package documentation.
I have also changed the logic I was using to normalize the static pressure measurement signal to make it clearer and reduce ambiguity. I have also added a minimum limit to the parameter value to indicate it has to be positive.
I have merged the latest master branch in with this PR and updated the models and unit test results based on CDL updates. Can you please merge the master into the base branch as well before you review the changes?
Thanks!