Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streams: update .readable/.writable to false #1217

Closed
wants to merge 1,248 commits into from
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Oct 21, 2015

  1. doc: add TSC meeting minutes 2015-10-14

    Reviewed-By: James M Snell <[email protected]>
    PR-URL: nodejs#3463
    rvagg authored and jasnell committed Oct 21, 2015
    Configuration menu
    Copy the full SHA
    0a0926e View commit details
    Browse the repository at this point in the history
  2. lib: avoid REPL exit on completion error

    If a tab completion is attempted on an undefined reference inside of a
    function, the REPL was exiting without reporting an error or anything
    else. This change results in the REPL reporting the ReferenceError and
    continuing.
    
    Fixes: nodejs#3346
    PR-URL: nodejs#3358
    Reviewed-By: James M Snell <[email protected]>
    Trott committed Oct 21, 2015
    Configuration menu
    Copy the full SHA
    b354be7 View commit details
    Browse the repository at this point in the history
  3. node: improve GetActiveRequests performance

    v8 is faster at setting object properties in JS than C++. Even when it
    requires calling into JS from native code. Make
    process._getActiveRequests() faster by doing this when populating the
    array containing request objects.
    
    Simple benchmark:
    
        for (let i = 0; i < 22; i++)
          fs.open(__filename, 'r', function() { });
        let t = process.hrtime();
        for (let i = 0; i < 1e6; i++)
          process._getActiveRequests();
        t = process.hrtime(t);
        console.log((t[0] * 1e9 + t[1]) / 1e6);
    
    Results between the two:
    
        Previous:  4406 ns/op
        Patched:    690 ns/op     5.4x faster
    
    PR-URL: nodejs#3375
    Reviewed-By: James Snell <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    trevnorris committed Oct 21, 2015
    Configuration menu
    Copy the full SHA
    494227b View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2015

  1. tools: use absolute paths in test-npm

    Updated test-npm to use absolute paths for tmp/cache/prefix
    
    PR-URL: nodejs#3309
    Reviewed-By: Rod Vagg <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    iarna authored and Fishrock123 committed Oct 22, 2015
    Configuration menu
    Copy the full SHA
    f5445db View commit details
    Browse the repository at this point in the history
  2. repl: event ordering: delay 'close' until 'flushHistory'

    Emitting 'close' before the history has flushed is somewhat incorrect
    and rather confusing.
    
    This also makes the 'close' event always asynchronous for consistency.
    
    Refs: nodejs#2356
    PR-URL: nodejs#3435
    Reviewed By: Evan Lucas <[email protected]>
    Reviewed-By: Trevor Norris <[email protected]>
    Fishrock123 committed Oct 22, 2015
    Configuration menu
    Copy the full SHA
    ecab7a6 View commit details
    Browse the repository at this point in the history
  3. tools: update test-npm to work with npm 3

    Refs: nodejs#3308
    PR-URL: nodejs#3489
    Reviewed-By: Rod Vagg <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    iarna authored and Fishrock123 committed Oct 22, 2015
    Configuration menu
    Copy the full SHA
    349fbe9 View commit details
    Browse the repository at this point in the history
  4. tools: ensure npm always uses the local node

    Refs: nodejs#3308
    PR-URL: nodejs#3489
    Reviewed-By: Rod Vagg <[email protected]>
    Fishrock123 committed Oct 22, 2015
    Configuration menu
    Copy the full SHA
    9b88864 View commit details
    Browse the repository at this point in the history
  5. deps: upgrade npm to 3.3.6

    PR-URL: nodejs#3310
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    iarna authored and Fishrock123 committed Oct 22, 2015
    1 Configuration menu
    Copy the full SHA
    41923c0 View commit details
    Browse the repository at this point in the history
  6. v8: pull fix for builtin code size on PPC

    Pull in the change that has been committed to v8 master in
    https://codereview.chromium.org/1415463002/.  We are currently
    cherry-picking into 4.6 and 4.7 but until next next v8 update
    into Node Master I'd like to float it as it will make PPC LE
    go green in the CI
    
    Fixes: nodejs#3390
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    PR-URL: nodejs#3474
    mhdawson authored and jasnell committed Oct 22, 2015
    Configuration menu
    Copy the full SHA
    1cbc2d0 View commit details
    Browse the repository at this point in the history
  7. doc: clarify API buffer.concat

    * Add a simple example for buffer.concat
    * Change grammar slightly.
    
    Fixes: nodejs#3219
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Trevor Norris <[email protected]>
    PR-URL: nodejs#3255
    Martii authored and jasnell committed Oct 22, 2015
    Configuration menu
    Copy the full SHA
    e32aca6 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2015

  1. deps: fix upgrade to npm 3.3.6

    41923c0 broke things. This fixes them.
    
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Evan Lucas <[email protected]>
    PR-URL: nodejs#3494
    iarna authored and jasnell committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    68471dd View commit details
    Browse the repository at this point in the history
  2. deps: update V8 to 4.6.85.28

    This update fixes a breaking regression in the date parser.
    
    Ref: https://code.google.com/p/chromium/issues/detail?id=539813
    Ref: https://code.google.com/p/chromium/issues/detail?id=543320
    PR-URL: nodejs#3484
    Reviewed-By: Ben Noordhuis <[email protected]>
    targos committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    6456fcf View commit details
    Browse the repository at this point in the history
  3. build: Updates for AIX npm support - part 1

    This PR is the first step enabling support for native modules
    for AIX.  The main issue is that unlike linux where all
    symbols within the Node executable are available to the shared
    library for a native module (npm), on AIX the symbols must
    be explicitly exported.  In addition, when the shared library is
    built it must be linked using a list of the available symbols.
    
    This patch covers the changes need to:
    
     1) Export the symbols when building the node executable
     2) Generate the file listing the symbols that can be used when
        building the shared library.
    
    For AIX, it breaks the build process into 2 steps.  The first builds
    a static library and then generates a node.exp file which contains
    the symbols from that library.  The second builds the node executable
    and uses the node.exp file to specify which symbols should be
    exported.  In addition, it save the node.exp file so that it can
    later be used in the creation of the shared library when building
    a native module.
    
    The following additional steps will be required in dependent projects
    to fully enable AIX for native modules and are being worked
    separately:
    
     - Updates to node-gyp to use node.exp when creating the
       shared library for a native module
     - Fixes to gyp related to copying files as covered in
          https://codereview.chromium.org/1368133002/patch/1/10001
     - Pulling in updated gyp versions to Node and node-gyp
     - Pulling latest libuv
    
    These changes were done to minimize the change to other platforms
    by working within the existing structure to add the 2 step process
    for AIX without changing the process for other platforms.
    
    PR-URL: nodejs#3114
    Reviewed-By: Ben Noordhuis <[email protected]>
    mhdawson committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    15bcbf8 View commit details
    Browse the repository at this point in the history
  4. test: disable test-tick-processor - aix and be ppc

    This test is already partially disabled for several platforms with
    the comment that the required info is not provided at the C++ level.
    I'm adding AIX as and PPC BE linux as they currently fall into
    the same category.  We are working to see if we can change that
    in v8 but it will be non-trivial if is possible at all so I don't
    want to leave the CI with failing tests until that point.
    
    PR-URL: nodejs#3491
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    mhdawson committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    5f3fb1c View commit details
    Browse the repository at this point in the history
  5. test: add node::MakeCallback() test coverage

    PR-URL: nodejs#3478
    Reviewed-By: Trevor Norris <[email protected]>
    bnoordhuis committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    3a091d2 View commit details
    Browse the repository at this point in the history
  6. buffer: don't CHECK on zero-sized realloc

    malloc(0) and realloc(ptr, 0) have implementation-defined behavior in
    that the standard allows them to either return a unique pointer or a
    nullptr for zero-sized allocation requests.  Normalize by always using
    a nullptr.
    
    Fixes: nodejs#3496
    PR-URL: nodejs#3499
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    Reviewed-By: Trevor Norris <[email protected]>
    bnoordhuis committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    594500f View commit details
    Browse the repository at this point in the history
  7. fs: pass err to callback if buffer is too big

    In fs.readFile, if an encoding is specified and toString fails, do not
    throw an error. Instead, pass the error to the callback.
    
    Fixes: nodejs#2767
    PR-URL: nodejs#3485
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Trevor Norris <[email protected]>
    evanlucas committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    b620790 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2015

  1. test: wrap assert.fail when passed to callback

    Currently there are many instances where assert.fail is directly passed
    to a callback for error handling. Unfortunately this will swallow the
    error as it is the third argument of assert.fail that sets the message
    not the first.
    
    This commit adds a new function to test/common.js that simply wraps
    assert.fail and calls it with the provided message.
    
    Tip of the hat to @Trott for pointing me in the direction of this.
    
    PR-URL: nodejs#3453
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Myles Borins authored and Trott committed Oct 24, 2015
    Configuration menu
    Copy the full SHA
    28e9a02 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2015

  1. test: print helpful err msg on test-dns-ipv6.js

    The test sometimes fail on an assertion but no useful error message
    was generated for debugging. Modify the test to generate useful
    debugging message.
    
    PR-URL: nodejs#3501
    Reviewed-By: Trevor Norris <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Junliang Yan authored and Trott committed Oct 25, 2015
    Configuration menu
    Copy the full SHA
    f4c0ed4 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2015

  1. fs: don't throw in read if buffer too big

    If the resulting buffer.toString() call in fs.read throws, catch the
    error and pass it back in the callback.
    
    This issue only presents itself when fs.read is called using the legacy
    string interface:
    
    fs.read(fd, length, position, encoding, callback)
    
    PR-URL: nodejs#3503
    Reviewed-By: Trevor Norris <[email protected]>
    evanlucas committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    57359cd View commit details
    Browse the repository at this point in the history
  2. test: improve tests for util.inherits

    inherits is used in lib and tests but its functionality itself is not
    tested yet.
    
    PR-URL: nodejs#3507
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    targos committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    df738ac View commit details
    Browse the repository at this point in the history
  3. tls, crypto: add ALPN Support

    ALPN is added to tls according to RFC7301, which supersedes NPN.
    When the server receives both NPN and ALPN extensions from the client,
    ALPN takes precedence over NPN and the server does not send NPN
    extension to the client. alpnProtocol in TLSSocket always returns
    false when no selected protocol exists by ALPN.
    In https server, http/1.1 token is always set when no
    options.ALPNProtocols exists.
    
    PR-URL: nodejs#2564
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Shigeki Ohtsu committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    802a2e7 View commit details
    Browse the repository at this point in the history
  4. tls,crypto: move NPN protcol data to hidden value

    This fix is to be consistent implementation with ALPN. Tow NPN
    protocol data in the persistent memebers move to hidden variables in
    the wrap object.
    
    PR-URL: nodejs#2564
    Reviewed-By: Ben Noordhuis <[email protected]>
    Shigeki Ohtsu committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    7eee372 View commit details
    Browse the repository at this point in the history
  5. doc: add TSC meeting minutes 2015-10-21

    Reviewed-By: James M Snell <[email protected]>
    PR-URL: nodejs#3480
    rvagg authored and jasnell committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    052611b View commit details
    Browse the repository at this point in the history
  6. buffer: fix value check for writeUInt{B,L}E

    Fixes: nodejs#3497
    PR-URL: nodejs#3500
    Reviewed-By: Ben Noordhuis <[email protected]>
    trevnorris committed Oct 26, 2015
    Configuration menu
    Copy the full SHA
    3308e5e View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2015

  1. http{s}: don't connect to localhost on invalid URL

    If the URL passed to `http{s}.request` or `http{s}.get` is not properly
    parsable by `url.parse`, we fall back to use `localhost` and port 80.
    This creates confusing error messages like in this question
    http://stackoverflow.com/q/32675907/1903116.
    
    This patch throws an error message, if `url.parse` fails to parse the
    URL properly.
    
    Previous Discussion: nodejs#2966
    PR-URL: nodejs#2967
    
    Reviewed-By: Сковорода Никита Андреевич <[email protected]>
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    thefourtheye committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    437930c View commit details
    Browse the repository at this point in the history
  2. util: make inherits work with classes

    The current implementation overwrites the prototype of the target
    constructor. It is not allowed with ES2015 classes because the prototype
    property is read only. Use Object.setPrototypeOf instead.
    
    Fixes: nodejs#3452
    PR-URL: nodejs#3455
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    targos committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    29da8cf View commit details
    Browse the repository at this point in the history
  3. src: fix race condition in debug signal on exit

    Before this commit, sending a SIGUSR1 at program exit could trigger a
    hard to reproduce race condition where `v8::Debug::DebugBreak(isolate)`
    got called when the isolate was in the process of being torn down.
    
    A similar race condition is in theory possible when sending signals
    to two threads simultaneously but I haven't been able to reproduce
    that myself (and I tried, oh how I tried.)
    
    This commit fixes the race condition by turning `node_isolate` into
    a `std::atomic` and using it as an ad hoc synchronization primitive
    in places where that is necessary.
    
    A bare minimum std::atomic polyfill is added for OS X because Apple
    wouldn't be Apple if things just worked out of the box.
    
    PR-URL: nodejs#3528
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    bnoordhuis committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    53e64bb View commit details
    Browse the repository at this point in the history
  4. fs: reduced duplicate code in fs.write()

    PR-URL: nodejs#2947
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    Reviewed-By: Trevor Norris <[email protected]>
    ronkorving authored and trevnorris committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    c339fa3 View commit details
    Browse the repository at this point in the history
  5. lib: fix cluster handle leak

    It is possible to cause a resource leak in SharedHandle. This commit
    fixes the leak.
    
    Fixes: nodejs#2510
    PR-URL: nodejs#3510
    Reviewed-By: Ben Noordhuis <[email protected]>
    Trott committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    da21dba View commit details
    Browse the repository at this point in the history
  6. tools: enable prefer-const eslint rule

    Description from: http://eslint.org/docs/rules/prefer-const.html
    
    If a variable is never modified, using the `const` declaration is
    better. `const` declaration tells readers, "this variable is never
    modified," reducing cognitive load and improving maintainability.
    
    Refer: nodejs#3118
    PR-URL: nodejs#3152
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Сковорода Никита Андреевич <[email protected]>
    Reviewed-By: Roman Reiss <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    thefourtheye committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    b0e7b36 View commit details
    Browse the repository at this point in the history
  7. lib,test: update let to const where applicable

    As per the `prefer-const` eslint rule, few instances of `let` have been
    identified to be better with `const`. This patch updates all those
    instances.
    
    Refer: nodejs#3118
    PR-URL: nodejs#3152
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Сковорода Никита Андреевич <[email protected]>
    Reviewed-By: Roman Reiss <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    thefourtheye committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    aaf9b48 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2015

  1. deps: backport 8d6a228 from the v8's upstream

    Original commit message:
    
        [heap] fix crash during the scavenge of ArrayBuffer
        Scavenger should not attempt to visit ArrayBuffer's storage, it is a
        user-supplied pointer that may have any alignment. Visiting it, may
        result in a crash.
    
        BUG=
        R=jochen
    
        Review URL: https://codereview.chromium.org/1406133003
    
        Cr-Commit-Position: refs/heads/master@{nodejs#31611}
    
    PR-URL: nodejs#3549
    Reviewed-By: Trevor Norris <[email protected]>
    indutny committed Oct 28, 2015
    4 Configuration menu
    Copy the full SHA
    3223704 View commit details
    Browse the repository at this point in the history
  2. repl: handle comments properly

    As it is, the comments are not handled properly in REPL. So, if the
    comments have `'` or `"`, then they are treated as incomplete string
    literals and the error is thrown in REPL.
    
    This patch refactors the existing logic and groups everything in a
    class.
    
    Fixes: nodejs#3421
    PR-URL: nodejs#3515
    Reviewed-By: Brian White <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    thefourtheye committed Oct 28, 2015
    Configuration menu
    Copy the full SHA
    6cf1910 View commit details
    Browse the repository at this point in the history
  3. doc: createServer's key option can be an array

    The `tls` module's `createServer` and `createSecureContext` accept
    `key` option and it can be an array of keys as well. This patch
    explains the format of the entries in that array.
    
    Corresponding code:
    https://github.com/nodejs/node/blob/v4.1.1/lib/_tls_common.js#L73-L90
    
    PR-URL: nodejs#3123
    Reviewed-By: Roman Reiss <[email protected]>
    Reviewed-By: Fedor Indutny <[email protected]>
    thefourtheye committed Oct 28, 2015
    Configuration menu
    Copy the full SHA
    5d5a4c4 View commit details
    Browse the repository at this point in the history
  4. test: use port number from env in tls socket test

    Tests normally use common.PORT to allow the user to select which port
    number to listen on. Hardcoding the port number will cause parallel
    instances of the test to fail.
    
    PR-URL: nodejs#3557
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: Johan Bergström <[email protected]>
    stefanmb authored and bnoordhuis committed Oct 28, 2015
    Configuration menu
    Copy the full SHA
    c9e682d View commit details
    Browse the repository at this point in the history
  5. deps: backport 010897c from V8 upstream

    This is a reland of nodejs#3165. The patch abates
    the truncation of script filenames in the perf-event output produced by V8.
    
    V8 commits:
    Original: v8/v8@03ef3cd
    Reland: v8/v8@010897c
    
    Original commit message:
      improve perf_basic_prof filename reporting
    
      The buffer used for appending filenames to the string printed to the
      perf_basic_prof log was unnecessarily too small. Bump it up to be at least
      kUtf8BufferSize.
    
      Truncation of filenames makes it really hard to work with profiles gathered on
      Node.js. Because of the way Node.js works, you can have node module dependencies
      in deeply nested directories. The last thing you want when investigating a
      performance problem is to have script names be truncated.
    
      This patch is a stop-gap. Ideally, I want no truncation of the filename at all
      and use a dynamically growing buffer. That would be a larger change, and I
      wanted to have a quick fix available that can be back-ported to Node.js LTS
      release.
    
      [email protected],[email protected]
      BUG=
    
      Review URL: https://codereview.chromium.org/1388543002
    
    PR-URL: nodejs#3520
    Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
    ofrobots committed Oct 28, 2015
    Configuration menu
    Copy the full SHA
    81f6b54 View commit details
    Browse the repository at this point in the history
  6. doc: add LTS info to COLLABORATOR_GUIDE.md

    There is currently no information in the Collaborators guide regarding
    LTS. This commit adds some basic copy explaining what LTS is, what is
    considered for LTS, and a simple way collaborators can help.
    
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Steven R. Loomis <[email protected]>
    PR-URL: nodejs#3442
    Myles Borins authored and jasnell committed Oct 28, 2015
    Configuration menu
    Copy the full SHA
    d394e9e View commit details
    Browse the repository at this point in the history
  7. test: split independent tests into separate files

    Move ENOENT related tests out of general fs.watch() test file and into
    its own file. This may help diagnose
    nodejs#3541.
    
    PR-URL: nodejs#3548
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Johan Bergström <[email protected]>
    Trott committed Oct 28, 2015
    Configuration menu
    Copy the full SHA
    26e47ef View commit details
    Browse the repository at this point in the history
  8. test: fix missing unistd.h on windows

    PR-URL: nodejs#3532
    Reviewed-By: Ben Noordhuis <[email protected]>
    Junliang Yan authored and bnoordhuis committed Oct 28, 2015
    Configuration menu
    Copy the full SHA
    4139f2a View commit details
    Browse the repository at this point in the history
  9. test: fix heap-profiler link error LNK1194 on win

    Fix the following error message in windows using VS 2013:
    
        LINK : fatal error LNK1194: cannot delay-load 'node.exe'
        due to import of data symbol '"__declspec(dllimport)
        const v8::OutputStream::`vftable'"
        (__imp_??_7OutputStream@v8@@6b@)'; link without
        /DELAYLOAD:node.exe
    
    PR-URL: nodejs#3572
    Reviewed-By: Ben Noordhuis <[email protected]>
    Junliang Yan authored and bnoordhuis committed Oct 28, 2015
    Configuration menu
    Copy the full SHA
    9f96705 View commit details
    Browse the repository at this point in the history
  10. lib,doc: return boolean from child.send()

    The documentation indicates that child.send() returns a boolean but it
    has returned undefinined at since v0.12.0. It now returns a boolean per
    the (slightly updated) documentation.
    
    PR-URL: nodejs#3516
    Reviewed-By: Ben Noordhuis <[email protected]>
    Trott committed Oct 28, 2015
    Configuration menu
    Copy the full SHA
    cdcf00a View commit details
    Browse the repository at this point in the history
  11. tls: remove util and calls to util.format

    Currently util.format is being used for string templating in tls.
    By replacing all of the instances of util.format with backtick
    string we can remove the need to require util in tls all together.
    
    PR-URL: nodejs#3456
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Fedor Indutny <[email protected]>
    Myles Borins authored and Trott committed Oct 28, 2015
    Configuration menu
    Copy the full SHA
    6b0c906 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2015

  1. child_process: don't fork bomb ourselves from -e

    Remove the `-e` argument from process.execArgv in child_process.fork()
    to keep `node -e 'require("child_process").fork("empty.js")'` from
    spawning itself recursively.
    
    Fixes: nodejs#3574
    PR-URL: nodejs#3575
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    bnoordhuis committed Oct 29, 2015
    Configuration menu
    Copy the full SHA
    57bce60 View commit details
    Browse the repository at this point in the history
  2. Revert "src: fix stuck debugger process"

    This reverts commit ff877e9.
    
    Reverted for breaking `node --debug-brk -e 0`.  It should immediately
    quit but instead it hangs now.
    
    PR-URL: nodejs#3585
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    bnoordhuis committed Oct 29, 2015
    Configuration menu
    Copy the full SHA
    9b02442 View commit details
    Browse the repository at this point in the history
  3. test: add regression test for --debug-brk -e 0

    Check that `node --debug-brk -e 0` immediately quits.
    
    PR-URL: nodejs#3585
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    bnoordhuis committed Oct 29, 2015
    Configuration menu
    Copy the full SHA
    810cc05 View commit details
    Browse the repository at this point in the history
  4. src: wrap source before doing syntax check

    This is to ensure that it is evaluated the same way it would be if it
    were to be run by node or required.
    
    Before, the following would pass if run by node, but fail if run via
    the syntax check flag:
    
        if (true) {
          return;
        }
    
    Now, this will pass the syntax check
    
    PR-URL: nodejs#3587
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    evanlucas committed Oct 29, 2015
    Configuration menu
    Copy the full SHA
    08166cb View commit details
    Browse the repository at this point in the history
  5. 2015-10-29, Version 5.0.0 (Stable)

    Notable changes:
    
    * buffer: (Breaking) Removed both 'raw' and 'raws' encoding types from Buffer,
      these have been deprecated for a long time (Sakthipriyan Vairamani) nodejs#2859.
    * console: (Breaking) Values reported by console.time() now have 3 decimals of
      accuracy added (Michaël Zasso) nodejs#3166.
    * fs:
      - fs.readFile*(), fs.writeFile*(), and fs.appendFile*() now also accept a file
        descriptor as their first argument (Johannes Wüller) nodejs#3163.
      - (Breaking) In fs.readFile(), if an encoding is specified and the internal
        toString() fails the error is no longer thrown but is passed to the callback
        (Evan Lucas) nodejs#3485.
      - (Breaking) In fs.read() (using the fs.read(fd, length, position, encoding,
        callback) form), if the internal toString() fails the error is no longer
        thrown but is passed to the callback (Evan Lucas) nodejs#3503.
    * http:
      - Fixed a bug where pipelined http requests would stall (Fedor Indutny) nodejs#3342.
      - (Breaking) When parsing HTTP, don't add duplicates of the following headers:
        Retry-After, ETag, Last-Modified, Server, Age, Expires. This is in addition
        to the following headers which already block duplicates: Content-Type,
        Content-Length, User-Agent, Referer, Host, Authorization,
        Proxy-Authorization, If-Modified-Since, If-Unmodified-Since, From, Location,
        Max-Forwards (James M Snell) nodejs#3090.
      - (Breaking) The callback argument to OutgoingMessage#setTimeout() must be a
        function or a TypeError is thrown (James M Snell) nodejs#3090.
      - (Breaking) HTTP methods and header names must now conform to the RFC 2616
        "token" rule, a list of allowed characters that excludes control characters
        and a number of separator characters. Specifically, methods and header names
        must now match /^[a-zA-Z0-9_!#$%&'*+.^`|~-]+$/ or a TypeError will be thrown
        (James M Snell) nodejs#2526.
    * node:
      - (Breaking) Deprecated the _linklist module (Rich Trott) nodejs#3078.
      - (Breaking) Removed require.paths and require.registerExtension(), both had
        been previously set to throw Error when accessed
        (Sakthipriyan Vairamani) nodejs#2922.
    * npm: Upgraded to version 3.3.6 from 2.14.7, see
      https://github.com/npm/npm/releases/tag/v3.3.6 for more details. This is a
      major version bump for npm and it has seen a significant amount of change.
      Please see the original npm v3.0.0 release notes for a list of major changes
      (Rebecca Turner) nodejs#3310.
    * src: (Breaking) Bumped NODE_MODULE_VERSION to 47 from 46, this is necessary
      due to the V8 upgrade. Native add-ons will need to be recompiled
      (Rod Vagg) nodejs#3400.
    * timers: Attempt to reuse the timer handle for setTimeout().unref(). This fixes
      a long-standing known issue where unrefed timers would perviously hold
      beforeExit open (Fedor Indutny) nodejs#3407.
    * tls:
      - Added ALPN Support (Shigeki Ohtsu) nodejs#2564.
      - TLS options can now be passed in an object to createSecurePair()
        (Коренберг Марк) nodejs#2441.
      - (Breaking) The default minimum DH key size for tls.connect() is now 1024
        bits and a warning is shown when DH key size is less than 2048 bits. This a security consideration to prevent "logjam" attacks. A new minDHSize TLS
        option can be used to override the default. (Shigeki Ohtsu) nodejs#1831.
    * util:
      - (Breaking) util.p() was deprecated for years, and has now been removed
        (Wyatt Preul) nodejs#3432.
      - (Breaking) util.inherits() can now work with ES6 classes. This is considered
        a breaking change because of potential subtle side-effects caused by a
        change from directly reassigning the prototype of the constructor using
        `ctor.prototype = Object.create(superCtor.prototype, { constructor: { ... } })`
        to using `Object.setPrototypeOf(ctor.prototype, superCtor.prototype)`
        (Michaël Zasso) nodejs#3455.
    * v8: (Breaking) Upgraded to 4.6.85.25 from 4.5.103.35 (Ali Ijaz Sheikh) nodejs#3351.
      - Implements the spread operator, see
        https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_operator
        for further information.
      - Implements new.target, see
        https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.target
        for further information.
    * zlib: Decompression now throws on truncated input (e.g. unexpected end of
      file) (Yuval Brik) nodejs#2595.
    
    PR-URL: nodejs#3466
    rvagg committed Oct 29, 2015
    Configuration menu
    Copy the full SHA
    837b174 View commit details
    Browse the repository at this point in the history
  6. doc: made code spans more visible in the API docs

    This makes the code spans in the API docs more visible and
    therefore readable by adding some background color.
    
    PR-URL: nodejs#3573
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Roman Reiss <[email protected]>
    phillipj authored and silverwind committed Oct 29, 2015
    Configuration menu
    Copy the full SHA
    d995b72 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2015

  1. lib: return boolean from child.send()

    Previous change reinstated returning boolean from child.send() but
    missed one instance where undefined might be returned instead.
    
    PR-URL: nodejs#3577
    Reviewed-By: Ben Noordhuis <[email protected]>
    Trott committed Oct 30, 2015
    Configuration menu
    Copy the full SHA
    cf0130d View commit details
    Browse the repository at this point in the history
  2. tools: update gyp to b3cef02

    Includes two patches for AIX. Adds support for both 32-bit and 64-bit
    files[0] and uses -RPf for cp instead of -af (which is unsupported)[1]
    
    [0] https://codereview.chromium.org/1319663007
    [1] https://codereview.chromium.org/1368133002
    
    PR-URL: nodejs#3487
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    Imran Iqbal authored and bnoordhuis committed Oct 30, 2015
    Configuration menu
    Copy the full SHA
    1d65b99 View commit details
    Browse the repository at this point in the history
  3. tools: fix gyp to work on MacOSX without XCode

    This issue has already submitted to the upstream in
    https://code.google.com/p/gyp/issues/detail?id=477
    Use this commit until the upstream is to be fixed.
    
    PR-URL: nodejs#1325
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Shigeki Ohtsu authored and bnoordhuis committed Oct 30, 2015
    Configuration menu
    Copy the full SHA
    be65f5f View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2015

  1. doc: add final full stop in CONTRIBUTING.md

    PR-URL: nodejs#3576
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Roman Reiss <[email protected]>
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    emilyaviva authored and Trott committed Oct 31, 2015
    Configuration menu
    Copy the full SHA
    b7cc19c View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2015

  1. doc: fix crypto spkac function descriptions

    Fix regarding description of the following functions:
    
    Certificate.exportPublicKey(spkac)
    Certificate.exportChallenge(spkac)
    
    The descriptions were applied incorrectly.
    
    PR-URL: nodejs#3614
    Reviewed-By: Ben Noordhuis <[email protected]>
    jas- authored and bnoordhuis committed Nov 1, 2015
    Configuration menu
    Copy the full SHA
    9e3aa45 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2015

  1. buffer: neuter external nullptr buffers

    Neuter external `nullptr` buffers, otherwise their contents will be
    materialized on access, and the buffer instance will be internalized.
    
    This leads to a crash like this:
    
        v8::ArrayBuffer::Neuter Only externalized ArrayBuffers can be
        neutered
    
    Fix: nodejs#3619
    PR-URL: nodejs#3624
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Trevor Norris <[email protected]>
    indutny committed Nov 2, 2015
    Configuration menu
    Copy the full SHA
    827ee49 View commit details
    Browse the repository at this point in the history
  2. tools: update npm test tooling for 3.3.10+

    PR-URL: nodejs#3599
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    iarna authored and Fishrock123 committed Nov 2, 2015
    Configuration menu
    Copy the full SHA
    754061f View commit details
    Browse the repository at this point in the history
  3. gitignore: don't ignore 'debug' in deps/npm

    PR-URL: nodejs#3599
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    iarna authored and Fishrock123 committed Nov 2, 2015
    Configuration menu
    Copy the full SHA
    6e40bf0 View commit details
    Browse the repository at this point in the history
  4. deps: upgrade npm to 3.3.10

    PR-URL: nodejs#3599
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    iarna authored and Fishrock123 committed Nov 2, 2015
    Configuration menu
    Copy the full SHA
    507fc53 View commit details
    Browse the repository at this point in the history
  5. test: remove flaky designation from ls-no-sslv3

    This test was marked flaky after failing in CI on arm7-wheezy two months
    ago. It has not failed there since. This commit removes the flaky
    designation.
    
    Fixes: nodejs#2554
    PR-URL: nodejs#3620
    Reviewed-By: Johan Bergström <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    Trott committed Nov 2, 2015
    Configuration menu
    Copy the full SHA
    f6230b9 View commit details
    Browse the repository at this point in the history
  6. doc: add note about timeout delay > TIMEOUT_MAX

    When setTimeout() and setInterval() are called with `delay` greater than
    TIMEOUT_MAX (2147483647), the supplied value is ignored and 1 is used
    instead. Add a note about this in the timers docs.
    
    PR-URL: nodejs#3512
    Reviewed-By: Trevor Norris <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    sitegui authored and trevnorris committed Nov 2, 2015
    Configuration menu
    Copy the full SHA
    ac7dd5f View commit details
    Browse the repository at this point in the history
  7. test: mark http-pipeline-flood flaky

    test-http-pipeline-flood has been flaky on Windows for some time.
    Hopefully, nodejs#2862 fixes it and
    lands soon, but until then, let's mark it as flaky.
    
    PR-URL: nodejs#3616
    Reviewed-By: Johan Bergström <[email protected]>
    Trott committed Nov 2, 2015
    Configuration menu
    Copy the full SHA
    6d6bc5d View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2015

  1. test: add regression test for 512 bits DH key

    Check that trying to use a < 1024 bits DH key throws an exception.
    
    parallel/test-tls-dhe tests this as well but it feels incongruous not to
    do it here when both tests have similar logic for 1024/2048 bits keys.
    
    PR-URL: nodejs#3629
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    bnoordhuis committed Nov 3, 2015
    Configuration menu
    Copy the full SHA
    cddf358 View commit details
    Browse the repository at this point in the history
  2. test: more regression tests for minDHSize option

    Check that tls.connect() fails in the expected way when passing in
    invalid minDHSize options.
    
    PR-URL: nodejs#3629
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    bnoordhuis committed Nov 3, 2015
    Configuration menu
    Copy the full SHA
    82022a7 View commit details
    Browse the repository at this point in the history
  3. repl: don't crash if cannot open history file

    Previously, if we are unable to open the history file, an error would
    be thrown. Now, print an error message that we could not open
    the history file, but don't fail.
    
    Fixes: nodejs#3610
    PR-URL: nodejs#3630
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    evanlucas committed Nov 3, 2015
    Configuration menu
    Copy the full SHA
    a4a0efc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3be3fb6 View commit details
    Browse the repository at this point in the history
  5. doc: typo fix in readme.md

    Minor typo fix in the list of keys
    
    Reviewed-By: James M Snell <[email protected]>
    PR-URL: nodejs#3649
    SPGB authored and jasnell committed Nov 3, 2015
    Configuration menu
    Copy the full SHA
    47f6541 View commit details
    Browse the repository at this point in the history
  6. deps: update http-parser to 2.6.0

    significant updates:
    
    * [[`777ba4eded`](nodejs@777ba4eded)] - **src**: introduce `http_parser_url_init` (Fedor Indutny) [nodejs/http-parser#225](nodejs/http-parser#225)
    * [[`e557b62744`](nodejs@e557b62744)] - **src**: support LINK/UNLINK (RFC 2068, draft-snell-link-method) (Olivier Mengué) [nodejs/http-parser#267](nodejs/http-parser#267)
    * [[`eb5e9928b4`](nodejs@eb5e9928b4)] - **src**: support ACL (WebDAV, RFC3744, Section 8.1). (Ivan Enderlin) [nodejs/http-parser#260](nodejs/http-parser#260)
    * [[`8b1d652322`](nodejs@8b1d652322)] - **src**: support BIND/REBIND/UNBIND (WebDAV, RFC5842) (Ivan Enderlin) [nodejs/http-parser#242](nodejs/http-parser#242)
    * [[`7d75dd7325`](nodejs@7d75dd7325)] - **src**: support IPv6 Zone ID as per RFC 6874 (Tatsuhiro Tsujikawa) [nodejs/http-parser#253](nodejs/http-parser#253)
    
    PR-URL: nodejs#3569
    Reviewed-By: Brian White <[email protected]>
    Reviewed-By: Johan Bergström <[email protected]>
    jasnell committed Nov 3, 2015
    Configuration menu
    Copy the full SHA
    d006d6a View commit details
    Browse the repository at this point in the history
  7. doc:fix function param order in assert doc

    PR-URL: nodejs#3533
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    birnam authored and jasnell committed Nov 3, 2015
    Configuration menu
    Copy the full SHA
    471aa5a View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2015

  1. test: fix test-net-persistent-keepalive for AIX

    Fixed an intermittent issue on AIX where the 600ms timeout was reached
    before the 'connection' event was fired. This resulted in a failure as
    serverConnection would be undefined and the assert.equal would throw an
    error. Changed the flow of the test so that the timeout is only set
    after a connection has been made.
    
    PR-URL: nodejs#3646
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Imran Iqbal authored and jasnell committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    a6a7338 View commit details
    Browse the repository at this point in the history
  2. doc: fix wrong date and known issue in changelog.md

    * A known issue was resolved but not removed from the list
    * The wrong date was documented in the changelog for v4.2.2
    
    PR-URL: nodejs#3650
    Reviewed-By: Michaël Zasso <[email protected]>
    jasnell committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    3268383 View commit details
    Browse the repository at this point in the history
  3. doc: rename iojs-* groups to nodejs-*

    As per nodejs#2525 a bunch of WGs are renamed from iojs-* to nodejs-*.
    Update the WORKING_GROUPS.md to match.
    
    Note specifically iojs-cn and iojs-tw were renamed to nodejs-zh-CN and
    nodejs-zh-TW respectively.
    
    Fixes: nodejs#3247
    PR-URL: nodejs#3634
    Reviewed-By: James M Snell <[email protected]>
    srl295 authored and jasnell committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    363a4e9 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2015

  1. doc: stdout/stderr can block when directed to file

    Update the documentation for `process.stdout` and `process.stdout` to
    clarify that writes can block when stdio is redirected to a file.  In
    all other cases, it's non-blocking.
    
    PR-URL: nodejs#3170
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    bnoordhuis committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    dac1d38 View commit details
    Browse the repository at this point in the history
  2. http: remove unneeded cb check from setTimeout()

    - This check is already covered in EventEmitter#addListener()
    
    Refs: nodejs#3618
    PR-URL: nodejs#3631
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    aks- authored and Fishrock123 committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    8625a38 View commit details
    Browse the repository at this point in the history
  3. docs: fs - remove encoding list and link to buffer

    fansworld-claudio authored and jasnell committed Nov 5, 2015
    6 Configuration menu
    Copy the full SHA
    2e38079 View commit details
    Browse the repository at this point in the history
  4. docs: fs - change links to buffer encoding to Buffer class anchor

    PR-URL: nodejs#2796
    Reviewed-By: Trevor Norris <[email protected]>
    Reviewed-By: Roman Reiss <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    fansworld-claudio authored and jasnell committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    30ce3eb View commit details
    Browse the repository at this point in the history
  5. build: omit -gline-tables-only for --enable-asan

    `-gline-tables-only` is a clang-only flag.  Drop it, it's not needed for
    address sanitizer-enabled builds and it makes it impossible to build
    with gcc.
    
    Fixes: nodejs#3656
    PR-URL: nodejs#3680
    Reviewed-By: Fedor Indutny <[email protected]>
    bnoordhuis committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    d461a07 View commit details
    Browse the repository at this point in the history
  6. module: remove unnecessary JSON.stringify

    `debuglog` uses `%j` as a placeholder for replacement with
    `JSON.stringify`. So that `JSON.stringify` is only called when the
    appropriate debug flag is on. The other `%s` changes are for style
    consistency.
    
    PR-URL: nodejs#3578
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    zertosh authored and jasnell committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    faa3bb8 View commit details
    Browse the repository at this point in the history
  7. Add missing va_end before return

    PR-URL: nodejs#3565
    Reviewed-By: Brian White <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    usta authored and jasnell committed Nov 5, 2015
    3 Configuration menu
    Copy the full SHA
    44a298b View commit details
    Browse the repository at this point in the history
  8. doc: add caveats of algs and key size in crypto

    Add description of user responsibility in the choice of cypto
    algorithms and its key length. Some of recommendations for the safer
    use are also described.
    
    PR-URL: nodejs#3479
    Reviewed-By: James M Snell <[email protected]>
    Shigeki Ohtsu authored and jasnell committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    017fc5b View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2015

  1. doc: add method links in events.markdown

    Added referenced method links.
    
    PR-URL: nodejs#3187
    Reviewed-By: Roman Reiss <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    a0viedo authored and targos committed Nov 6, 2015
    Configuration menu
    Copy the full SHA
    d26927c View commit details
    Browse the repository at this point in the history
  2. util: use regexp instead of str.replace().join()

    PR-URL: nodejs#3689
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    hellopao authored and jasnell committed Nov 6, 2015
    Configuration menu
    Copy the full SHA
    02a44e0 View commit details
    Browse the repository at this point in the history
  3. deps: upgrade npm to 3.3.12

    PR-URL: nodejs#3685
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    iarna authored and Fishrock123 committed Nov 6, 2015
    Configuration menu
    Copy the full SHA
    df9c4a6 View commit details
    Browse the repository at this point in the history
  4. cluster: remove handles when disconnecting worker

    Due to the race window between the master's "disconnect" message and the
    worker's "handle received" message, connections sometimes got stuck in
    the pending handles queue when calling `worker.disconnect()` in the
    master process.
    
    The observable effect from the client's perspective was a TCP or HTTP
    connection that simply stalled.  This commit fixes that by closing open
    handles in the master when the "disconnect" message is sent.
    
    Fixes: nodejs#3551
    PR-URL: nodejs#3677
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    bnoordhuis committed Nov 6, 2015
    1 Configuration menu
    Copy the full SHA
    33827e3 View commit details
    Browse the repository at this point in the history
  5. async_wrap: allow some hooks to be optional

    Only enforce that the init callback is passed to setupHooks(). The
    remaining hooks can be optionally passed.
    
    Throw if async_wrap.enable() runs before setting the init callback or if
    setupHooks() is called while async wrap is enabled.
    
    Add test to verify calls throw appropriately.
    
    PR-URL: nodejs#3461
    Reviewed-By: Fedor Indutny <[email protected]>
    trevnorris committed Nov 6, 2015
    Configuration menu
    Copy the full SHA
    a4e9487 View commit details
    Browse the repository at this point in the history
  6. async_wrap: new instances get uid

    New instances of AsyncWrap are automatically assigned a unique id. The
    value will be used in future commits to communicate additional
    information via the async hooks.
    
    While the largest value we can reliably communicate to JS is 2^53, even
    if a new AsyncWrap is created every 100ns the uid won't reach its end
    for 28.5 years.
    
    PR-URL: nodejs#3461
    Reviewed-By: Fedor Indutny <[email protected]>
    trevnorris committed Nov 6, 2015
    Configuration menu
    Copy the full SHA
    80a66ba View commit details
    Browse the repository at this point in the history
  7. async_wrap: call callback in destructor

    Call a user's callback to notify that the handle has been destroyed.
    Only pass the id of the AsyncWrap instance since the object no longer
    exists.
    
    The object that's being destructed should never be inspected within the
    callback or any time afterward.
    
    This commit make a breaking change. The init callback will now be passed
    arguments in the order of provider, id, parent.
    
    PR-URL: nodejs#3461
    Reviewed-By: Fedor Indutny <[email protected]>
    trevnorris committed Nov 6, 2015
    Configuration menu
    Copy the full SHA
    bb1bd76 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2015

  1. src: Revert "nix stdin _readableState.reading"

    This reverts 8cee8f5 which was causing stdin to behave strangely on
    Windows 8 and 10. The suspected explanation for the issue is that there
    might be a race condition occuring when stdin._readableState.reading is
    set indirectly through `push('')`.
    
    PR-URL: nodejs#3490
    Fixes: nodejs#2996
    Fixes: nodejs#2504
    Reviewed-By: Trevor Norris <[email protected]>
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    Reviewed-By: Rod Vagg <[email protected]>
    silverwind committed Nov 8, 2015
    Configuration menu
    Copy the full SHA
    af46112 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2015

  1. lib: Consistent error messages in all modules

    This commit fixes some error messages that are not consistent with
    some general rules which most of the error messages follow.
    
    PR-URL: nodejs#3374
    Reviewed-By: Roman Reiss <[email protected]>
    micnic authored and silverwind committed Nov 9, 2015
    Configuration menu
    Copy the full SHA
    20285ad View commit details
    Browse the repository at this point in the history
  2. test: use really invalid hostname

    On my slow Ubuntu 14.04 machine, this fails to resolve the host name
    used (`no.way.you.will.resolve.this`) and it times out in local testing.
    This patch uses an invalid name (`...`) and does stricter validation of
    the error returned.
    
    PR-URL: nodejs#3711
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    thefourtheye authored and jasnell committed Nov 9, 2015
    Configuration menu
    Copy the full SHA
    5707258 View commit details
    Browse the repository at this point in the history
  3. repl: To exit, press ^C again or type .exit.

    When the user hits `^C` in the REPL show more info about `.exit`.
    
    The idea was to give more info to the user when they hit ^C.
    Current version just displays `(^C again to quit)` and most
    of the users are not aware of the `.exit` command that would
    Exit the repl.
    
    PR-URL: nodejs#3368
    Reviewed-By: James M Snell <[email protected]>
    hemanth authored and jasnell committed Nov 9, 2015
    Configuration menu
    Copy the full SHA
    354f9ce View commit details
    Browse the repository at this point in the history
  4. doc: add saghul as a collaborator

    PR_URL: nodejs#3724
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    saghul committed Nov 9, 2015
    4 Configuration menu
    Copy the full SHA
    64208ef View commit details
    Browse the repository at this point in the history
  5. doc: add thealphanerd to collaborators

    PR-URL: nodejs#3723
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
    Myles Borins committed Nov 9, 2015
    Configuration menu
    Copy the full SHA
    7b89a3d View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2015

  1. test: fix tests that check error messages

    20285ad changed the format
    of error messages throughout lib. However, the tests were not
    updated to reflect these changes. This commit makes those
    changes.
    
    PR-URL: nodejs#3727
    Reviewed-By: Roman Reiss <[email protected]>
    Reviewed-By: Johan Bergström <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    cjihrig authored and silverwind committed Nov 10, 2015
    Configuration menu
    Copy the full SHA
    2c33819 View commit details
    Browse the repository at this point in the history
  2. test: fix test-module-loading-error for musl

    When a compiled library file does not have the proper format,
    musl returns the error message ENOEXEC as 'Exec format error' but
    glibc returns 'file too short' if the file is under a certain size.
    
    Reference:
    http://git.musl-libc.org/cgit/musl/tree/src/errno/__strerror.h#n46
    
    This patch consists of tolerating musl's error.
    
    PR-URL: nodejs#3657
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Johan Bergström <[email protected]>
    hmalphettes authored and bnoordhuis committed Nov 10, 2015
    Configuration menu
    Copy the full SHA
    1bacf37 View commit details
    Browse the repository at this point in the history
  3. console: use 'label' argument for time and timeEnd

    Turns out the argument is actually called label in the console spec,
    while being wrongly named on MDN. This reverts commit
    8c043c1.
    
    MDN has been updated in:
    
    https://developer.mozilla.org/en-US/docs/Web/API/Console/timeEnd$compare?locale=en-US&to=947893&from=918571
    https://developer.mozilla.org/en-US/docs/Web/API/Console/time$compare?locale=en-US&to=947891&from=896987
    
    PR-URL: nodejs#3590
    Reviewed-By: targos - Michaël Zasso <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    silverwind committed Nov 10, 2015
    Configuration menu
    Copy the full SHA
    9aee2c0 View commit details
    Browse the repository at this point in the history
  4. test: enhance fs-watch-recursive test

    This patch
    
      - issues a TAP plugin parsable message on non darwin/windows boxes
      - uses `const` wherever applicable
      - moves the test to parallel
    
    PR-URL: nodejs#2599
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Johan Bergström <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    thefourtheye authored and jasnell committed Nov 10, 2015
    Configuration menu
    Copy the full SHA
    a28b938 View commit details
    Browse the repository at this point in the history
  5. dns: prevent undefined values in results

    When getaddrinfo linked-list results contain entries other than AF_INET
    and AF_INET6, the resulting v8::Array will contain undefined values.
    That's because initialization of v8::Array pre-allocates entries for all
    linked-list nodes, but not all of them will be in the final results.
    This commit ensures that the array only contains valid results.
    
    PR-URL: nodejs#3696
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Junliang Yan authored and cjihrig committed Nov 10, 2015
    Configuration menu
    Copy the full SHA
    19bf72d View commit details
    Browse the repository at this point in the history
  6. doc: add romankl to collaborators

    PR-URL: nodejs#3725
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    r-52 committed Nov 10, 2015
    Configuration menu
    Copy the full SHA
    5235143 View commit details
    Browse the repository at this point in the history
  7. doc: add note on tls connection meta data methods

    PR-URL: nodejs#3746
    Reviewed-By: Ben Noordhuis <[email protected]>
    DaftMonk authored and bnoordhuis committed Nov 10, 2015
    Configuration menu
    Copy the full SHA
    eff8c3e View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2015

  1. src: force line buffering for stderr

    SmartOS does not line buffer stderr by default, or at least that is the
    behavior on the Node project Jenkins server. Force line buffering. This
    resolves the flakiness observed on SmartOS for
    test-debug-signal-cluster.
    
    PR-URL: nodejs#3701
    Fixes: nodejs#2476
    Refs: nodejs#3615
    Reviewed-By: Johan Bergström <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Trott committed Nov 11, 2015
    Configuration menu
    Copy the full SHA
    0966ab9 View commit details
    Browse the repository at this point in the history
  2. tools: Use throw new Error() consistently

    In preparation for a lint rule that will enforce `throw new Error()`
    over `throw Error()`, fix the handful of instances in the code that
    use `throw Error()`.
    
    PR-URL: nodejs#3714
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott committed Nov 11, 2015
    Configuration menu
    Copy the full SHA
    35f2f64 View commit details
    Browse the repository at this point in the history
  3. tools: enforce throw new Error() with lint rule

    Add linting rule requiring `throw new Error()` over `throw Error()`.
    
    PR-URL: nodejs#3714
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott committed Nov 11, 2015
    Configuration menu
    Copy the full SHA
    25cd455 View commit details
    Browse the repository at this point in the history
  4. deps: update V8 to 4.6.85.31

    This update contains the patch floated in
    nodejs#3390 and a fix for
    Intl.NumberFormat.
    
    Diff: https://chromium.googlesource.com/v8/v8.git/+/4.6.85.28..4.6.85.31
    
    PR-URL: nodejs#3698
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Ali Ijaz Sheikh <[email protected]>
    targos committed Nov 11, 2015
    Configuration menu
    Copy the full SHA
    2930867 View commit details
    Browse the repository at this point in the history
  5. lib,test: remove publicly exposed freelist

    The freelist module was deprecated in io.js and moved to an
    internal module. This commit removes public access to freelist,
    while leaving the internal module, which is still in use.
    
    Fixes: nodejs#569
    PR-URL: nodejs#3738
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    cjihrig committed Nov 11, 2015
    Configuration menu
    Copy the full SHA
    b70dc67 View commit details
    Browse the repository at this point in the history
  6. cluster: send suicide message on disconnect

    This commit causes Worker.prototype.disconnect() to send a
    suicide message to the cluster master. The function is also
    restructured to eliminate redundant code.
    
    Fixes: nodejs#3238
    PR-URL: nodejs#3720
    Reviewed-By: James M Snell <[email protected]>
    cjihrig committed Nov 11, 2015
    Configuration menu
    Copy the full SHA
    f299d87 View commit details
    Browse the repository at this point in the history
  7. fs: return null error on readFile() success

    This commit ensures that readFile() callsback with a null
    error consistently on success.
    
    PR-URL: nodejs#3740
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    zbinlin authored and cjihrig committed Nov 11, 2015
    Configuration menu
    Copy the full SHA
    1594198 View commit details
    Browse the repository at this point in the history
  8. doc: update lts description in the collaborator guide

    PR-URL: nodejs#3668
    Reviewed-By: Julien Gilli <[email protected]>
    jasnell committed Nov 11, 2015
    Configuration menu
    Copy the full SHA
    dac387e View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2015

  1. tools: add tap output to cpplint

    Implement a crude TAP13 writer for cpplint. Does its job and
    not much else. Only supports writing TAP output to file,
    not vs7 or emacs formats.
    
    PR-URL: nodejs#3448
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    jbergstroem committed Nov 12, 2015
    Configuration menu
    Copy the full SHA
    7b45163 View commit details
    Browse the repository at this point in the history
  2. deps: cherry-pick 68e89fb from v8's upstream

    Original commit message:
    
        This commit adds some postmortem data that is otherwise unavailable.
    
        I have discovered need in those values when writing:
    
        https://github.com/indutny/llnode
    
        BUG=
    
        Review URL: https://codereview.chromium.org/1436473002
    
        Cr-Commit-Position: refs/heads/master@{nodejs#31947}
    
    This postmortem information is useful for both object inspection, and
    function's context variables inspection.
    
    PR-URL: nodejs#3779
    Reviewed-By: Ben Noordhuis <[email protected]>
    indutny committed Nov 12, 2015
    Configuration menu
    Copy the full SHA
    81e32cc View commit details
    Browse the repository at this point in the history
  3. doc: Describe FIPSDIR environment variable

    As per the OpenSSL User Guide, it is possible to use the FIPSDIR
    environment variable to specify a custom install path for the
    validated cryptographic module.
    
    PR-URL: nodejs#3752
    Reviewed-By: Michael Dawsson <[email protected]>
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    Reviewed-By: Fedor Indutny <[email protected]>
    stefanmb authored and mhdawson committed Nov 12, 2015
    Configuration menu
    Copy the full SHA
    9f71a31 View commit details
    Browse the repository at this point in the history
  4. doc: add note to util.isBuffer

    Since util.isBuffer is deprecated, we should be explicit that
    Buffer.isBuffer should be used instead.
    
    PR-URL: nodejs#3790
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    evanlucas committed Nov 12, 2015
    Configuration menu
    Copy the full SHA
    7cb3a54 View commit details
    Browse the repository at this point in the history
  5. docs: improve discoverability of Code of Conduct

    - move CoC from CONTRIBUTING to top-level, separate COC file
    - add note/link in CONTRIBUTING
    - add note/link in README (both at top, and newcomer resources)
    - move CoC section in CONTRIBUTING to top of file
    
    PR-URL: nodejs#3774
    Reviewed-By: Rich Trott <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    ashleygwilliams authored and jasnell committed Nov 12, 2015
    Configuration menu
    Copy the full SHA
    d781cdc View commit details
    Browse the repository at this point in the history
  6. crypto: Improve error checking and reporting

    Added checks where necessary to prevent hard crashes and gave
    precedence to returning the OpenSSL error strings instead of generic
    error strings.
    
    PR-URL: nodejs#3753
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    stefanmb authored and mhdawson committed Nov 12, 2015
    Configuration menu
    Copy the full SHA
    b7089f6 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2015

  1. doc: sort assert alphabetically

    Reorders, with no contextual changes, the assert documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    e16c669 View commit details
    Browse the repository at this point in the history
  2. doc: sort buffer alphabetically

    Reorders, with minimal contextual duplication, the buffer documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    c0360c1 View commit details
    Browse the repository at this point in the history
  3. doc: sort child_process alphabetically

    Reorders, with no contextual changes, the child_process documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    f7169d2 View commit details
    Browse the repository at this point in the history
  4. doc: sort cluster alphabetically

    Reorders, with no contextual changes, the cluster documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    4c91220 View commit details
    Browse the repository at this point in the history
  5. doc: sort console alphabetically

    Reorders, with no contextual changes, the console documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    42d6431 View commit details
    Browse the repository at this point in the history
  6. doc: sort dns alphabetically

    Reorders, with no contextual changes, the dns documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    bf5e177 View commit details
    Browse the repository at this point in the history
  7. doc: sort crypto alphabetically

    Reorders, with no contextual changes, the crypto documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    6f8e481 View commit details
    Browse the repository at this point in the history
  8. doc: sort dgram alphabetically

    Reorders, with no contextual changes, the dgram documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    4315601 View commit details
    Browse the repository at this point in the history
  9. doc: sort errors alphabetically

    Reorders, with no contextual changes, the errors documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    084e540 View commit details
    Browse the repository at this point in the history
  10. doc: sort events alphabetically

    Reorders, with minimal contextual duplication, the events documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    6009c4b View commit details
    Browse the repository at this point in the history
  11. doc: sort fs alphabetically

    Reorders, with no contextual changes, the fs documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    b35c57b View commit details
    Browse the repository at this point in the history
  12. doc: sort globals alphabetically

    Reorders, with no contextual changes, the globals documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    b690c78 View commit details
    Browse the repository at this point in the history
  13. doc: sort os alphabetically

    Reorders, with no contextual changes, the os documentation alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    39a7fdf View commit details
    Browse the repository at this point in the history
  14. doc: sort path alphabetically

    Reorders, with no contextual changes, the path documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    a58f389 View commit details
    Browse the repository at this point in the history
  15. doc: sort punycode alphabetically

    Reorders, with no contextual changes, the punycode documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    69cbaf6 View commit details
    Browse the repository at this point in the history
  16. doc: sort querystring alphabetically

    Reorders, with no contextual changes, the querystring documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    ed1f10d View commit details
    Browse the repository at this point in the history
  17. doc: sort vm alphabetically

    Reorders, with no contextual changes, the vm documentation alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    cff45b9 View commit details
    Browse the repository at this point in the history
  18. doc: sort url alphabetically

    Reorders, with no contextual changes, the url documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    32d0d67 View commit details
    Browse the repository at this point in the history
  19. doc: sort tty alphabetically

    Reorders, with no contextual changes, the tty documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    e4009b6 View commit details
    Browse the repository at this point in the history
  20. doc: sort timers alphabetically

    Reorders, with no contextual changes, the timers documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    7e5a6b3 View commit details
    Browse the repository at this point in the history
  21. doc: sort string_decoder alphabetically

    Reorders, with no contextual changes, the string_decode documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    16f9ba0 View commit details
    Browse the repository at this point in the history
  22. doc: sort repl alphabetically

    Reorders, with no contextual changes, the repl documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    8a245ea View commit details
    Browse the repository at this point in the history
  23. doc: sort readline alphabetically

    Reorders, with no contextual changes, the readline documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    6e6103b View commit details
    Browse the repository at this point in the history
  24. doc: sort modules alphabetically

    Reorders, with no contextual changes, the modules documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    0ca44b0 View commit details
    Browse the repository at this point in the history
  25. doc: sort http alphabetically

    Reorders, with no contextual changes, the http documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    f4c259a View commit details
    Browse the repository at this point in the history
  26. doc: sort https alphabetically

    Reorders, with no contextual changes, the https documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    54d8bdb View commit details
    Browse the repository at this point in the history
  27. doc: sort util alphabetically

    Reorders, with no contextual changes, the util documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    8c703cd View commit details
    Browse the repository at this point in the history
  28. doc: sort zlib alphabetically

    Reorders, with some contextual changes, the zlib documentation
    alphabetically.
    
    - Put Convenience Methods children under the Convenience Methods header
    - Renamed Options to Class Options and put above the Class definitions
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    e50d32c View commit details
    Browse the repository at this point in the history
  29. doc: sort process alphabetically

    Reorders, with no contextual changes, the process documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    42a9cc7 View commit details
    Browse the repository at this point in the history
  30. doc: sort net alphabetically

    Reorders, with minimal contextual duplication, the net documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    403d2bf View commit details
    Browse the repository at this point in the history
  31. doc: sort stream alphabetically

    Reorders, with no contextual changes, the stream documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    4efa7de View commit details
    Browse the repository at this point in the history
  32. doc: sort tls alphabetically

    Reorders, with no contextual changes, the tls documentation
    alphabetically.
    
    PR-URL: nodejs#3662
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    f8390fd View commit details
    Browse the repository at this point in the history
  33. child_process: add safety checks on stdio access

    When a child process is spawned, there is no guarantee that stdout
    and stderr will be created successfully. This commit adds checks
    before attempting to access the streams.
    
    PR-URL: nodejs#3799
    Reviewed-By: Brian White <[email protected]>
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    cjihrig authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    7b355c5 View commit details
    Browse the repository at this point in the history
  34. doc: repl: add defineComand and displayPrompt

    Also some minor edits so the additions make sense.
    
    PR-URL: nodejs#3765
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    bengl authored and Trott committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    061b2c8 View commit details
    Browse the repository at this point in the history
  35. test: fix flaky test test-http-pipeline-flood

    PR-URL: nodejs#3636
    Reviewed-By: Ben Noordhuis <[email protected]>
    dnakamura authored and Trott committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    974767e View commit details
    Browse the repository at this point in the history
  36. test: refactor test-http-pipeline-flood

    This extends fixes for test-https-pipeline-flood to hopefully fully
    eliminate its flakiness on Windows in our continuous integration
    process.
    
    PR-URL: nodejs#3636
    Reviewed-By: Ben Noordhuis <[email protected]>
    Trott committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    d9734b7 View commit details
    Browse the repository at this point in the history
  37. console: delete timers that have ended

    Currently, console timers that have been ended with timeEnd()
    are not removed. This has the potential to leak memory. This
    commit deletes ended timers from the containing Map.
    
    PR-URL: nodejs#3562
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Vladimir Varankin authored and cjihrig committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    a5cce79 View commit details
    Browse the repository at this point in the history
  38. tls: copy client CAs and cert store on CertCb

    Copy client CA certs and cert store when asynchronously selecting
    `SecureContext` during `SNICallback`. We already copy private key,
    certificate, and certificate chain, but the client CA certs were
    missing.
    
    Fix: nodejs#2772
    PR-URL: nodejs#3537
    Reviewed-By: Ben Noordhuis <[email protected]>
    indutny committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    483a41c View commit details
    Browse the repository at this point in the history
  39. querystring: Parse multiple separator characters

    Fix querystring.parse to handle multiple separator characters
    
    PR-URL: nodejs#3807
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Brian White <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    yosuke-furukawa authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    a776a86 View commit details
    Browse the repository at this point in the history
  40. test: stronger crypto in test fixtures

    Several test fixtures use use weak crypto (e.g. RC4 or MD5).
    Rgenerated the test fixtures to be compatible with FIPS mode.
    
    PR-URL: nodejs#3759
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    stefanmb authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    76f40f7 View commit details
    Browse the repository at this point in the history
  41. doc: clarify duplicate header handling

    This commit documents how duplicate HTTP headers are handled.
    
    PR-URL: nodejs#3810
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Roman Reiss <[email protected]>
    bengl authored and cjihrig committed Nov 13, 2015
    5 Configuration menu
    Copy the full SHA
    4008961 View commit details
    Browse the repository at this point in the history
  42. doc: reword message.headers to indicate they are not read-only

    message.headers states that the headers are read-only, when in fact they
    are not. This change rewords the docs to a more appropriate description,
    while not promoting this kind of behavior.
    
    Fixes: nodejs#3146
    PR-URL: nodejs#3814
    Reviewed-By: Roman Klauke <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    tflanagan authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    934149a View commit details
    Browse the repository at this point in the history
  43. doc: added what buf.copy returns

    as of https://github.com/nodejs/node/blob/v5.x/src/node_buffer.cc#L555
    
    buf.copy returns the number of bytes copied.
    
    PR-URL: nodejs#3555
    Reviewed-By: Trevor Norris <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    baslr authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    3c56d5e View commit details
    Browse the repository at this point in the history
  44. doc: add warning about Windows process groups

    This commit adds a warning for Windows platforms. `process.kill` wont
    kill a process group on Windows and instead it throws an error.
    
    Refs: nodejs#3617
    PR-URL: nodejs#3681
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    r-52 authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    406c596 View commit details
    Browse the repository at this point in the history
  45. doc: Updated streams simplified constructor API

    The examples for implementing the simplified constructor API
    was missing some details on its correct usages.
    
    PR-URL: nodejs#3602
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Chris Dickinson <[email protected]>
    tomgco authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    4270e7f View commit details
    Browse the repository at this point in the history
  46. doc: add link to [customizing util.inspect colors].

    PR-URL: nodejs#3749
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    jmm authored and jasnell committed Nov 13, 2015
    Configuration menu
    Copy the full SHA
    b445938 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2015

  1. test: run pipeline flood test in parallel

    PR-URL: nodejs#3811
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and jasnell committed Nov 14, 2015
    Configuration menu
    Copy the full SHA
    3fea3cb View commit details
    Browse the repository at this point in the history
  2. test: Fix test-cluster-worker-exit.js for AIX

    test fails intermittently due to the assertion that the 'disconnect'
    event should come before the 'exit' event. This is caused be the
    non-deteministic behaviour of pollset_poll[1] on AIX
    (see deps/uv/src/unix/aix.c). This API makes no garauntee for the order
    in which file descriptors are returned. On linux epoll_wait[2] is used,
    which also does not make a garauntee on order of file descriptors
    returned. In the failing case we recieve our file descriptor with a
    callback of uv__signal_event (which causes JavaScript to receive the
    exit event) before our file descriptor with uv__stream_io as its
    callback (which in turn causes JavaScript receive the disconnect event).
    This change simply removes the assertion that the disconnect event
    happens before exit event and processes the test regardless of which
    event comes first.
    
    [1] https://www-01.ibm.com/support/knowledgecenter/ssw_aix_71/com.ibm.ai
    x.basetrf1/pollset.htm
    [2] http://linux.die.net/man/2/epoll_pwait
    
    PR-URL: nodejs#3666
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Imran Iqbal authored and jasnell committed Nov 14, 2015
    2 Configuration menu
    Copy the full SHA
    8b57b31 View commit details
    Browse the repository at this point in the history
  3. util: improve typed array formatting

    Pretty-print typed arrays like regular arrays.  Speeds up formatting by
    almost 300% because it no longer stringifies the array indices.
    
    Pretty-print ArrayBuffer and DataView as well by including byteLength,
    byteOffset and buffer properties in the stringified representation.
    
    PR-URL: nodejs#3793
    Reviewed-By: Trevor Norris <[email protected]>
    bnoordhuis committed Nov 14, 2015
    Configuration menu
    Copy the full SHA
    34a3591 View commit details
    Browse the repository at this point in the history
  4. deps: backport bc2e393 from v8 upstream

    Original commit message:
    
      [tools] Make gen-postmortem-metadata.py more reliable
    
      Instead of basing matches off of whitespace, walk the
      inheritance chain and include any classes that inherit
      from Object.
    
      [email protected],[email protected]
      NOTRY=true
    
      Review URL: https://codereview.chromium.org/1435643002
    
      Cr-Commit-Position: refs/heads/master@{nodejs#31964}
    
    This adds some missing classes to postmortem info like
    JSMap and JSSet.
    
    PR-URL: nodejs#3792
    Reviewed-By: Trevor Norris <[email protected]>
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    evan.lucas authored and evanlucas committed Nov 14, 2015
    Configuration menu
    Copy the full SHA
    70405d4 View commit details
    Browse the repository at this point in the history
  5. crypto: DSA parameter validation in FIPS mode

    FIPS 180-4 requires specific (L,N) values. OpenSSL will crash if an
    invalid combination is used, so we must check the input sanity first.
    
    PR-URL: nodejs#3756
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    stefanmb authored and jasnell committed Nov 14, 2015
    Configuration menu
    Copy the full SHA
    4adaaa4 View commit details
    Browse the repository at this point in the history
  6. test: add test for invalid DSA key size

    Check that invalid DSA key sizes are rejected in FIPS mode.
    
    PR-URL: nodejs#3756
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    stefanmb authored and jasnell committed Nov 14, 2015
    Configuration menu
    Copy the full SHA
    20cd932 View commit details
    Browse the repository at this point in the history
  7. test: add hasFipsCrypto to test/common.js

    Utility function for tests to check if OpenSSL is using
    a FIPS verified cryptographic provider.
    
    PR-URL: nodejs#3756
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    stefanmb authored and jasnell committed Nov 14, 2015
    Configuration menu
    Copy the full SHA
    8ac852f View commit details
    Browse the repository at this point in the history
  8. zlib: pass kind to recursive calls to flush

    Bug spotted by @bnoordhuis while doing code review on nodejs#3534
    
    Refs: nodejs#3534 (comment)
    PR-URL: nodejs#3534
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Myles Borins authored and jasnell committed Nov 14, 2015
    Configuration menu
    Copy the full SHA
    fa27c56 View commit details
    Browse the repository at this point in the history
  9. zlib: only apply drain listener if given callback

    When stream.flush() is called without a callback, an empty listener is
    being added. Since flush may be called multiple times to push SSE's
    down to the client, multiple noop listeners are being added. This in
    turn causes the memory leak detected message.
    
    PR-URL: nodejs#3534
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    CraigCav authored and jasnell committed Nov 14, 2015
    Configuration menu
    Copy the full SHA
    1736ad8 View commit details
    Browse the repository at this point in the history
  10. test: add test-zlib-flush-drain

    This test assures that if flush is called while the zlib object needs
    to be drained that it will defer the callback until after the drain.
    
    PR-URL: nodejs#3534
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Myles Borins authored and jasnell committed Nov 14, 2015
    Configuration menu
    Copy the full SHA
    a49b3af View commit details
    Browse the repository at this point in the history
  11. test: increase crypto strength for FIPS standard

    Use stronger crypto (larger keys, etc.) for arbitrary tests so
    they will pass in both FIPS and non-FIPS mode without altering
    the original intent of the test cases.
    
    PR-URL: nodejs#3758
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    stefanmb authored and jasnell committed Nov 14, 2015
    Configuration menu
    Copy the full SHA
    11ad744 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2015

  1. build: fix --with-intl=system-icu for x-compile

    * add toolset stuff to icu-system.gyp
    * update docs
    
    Fixes: nodejs#3801
    PR-URL: nodejs#3808
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    srl295 authored and jasnell committed Nov 15, 2015
    Configuration menu
    Copy the full SHA
    84f0964 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2015

  1. test: fix path to module for repl test on Windows

    Use path join to construct the path instead of concatenating strings.
    Replace backslash with double backslash so that they are escaped
    correctly in the string passed to REPL.
    
    PR-URL: nodejs#3608
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    mcornac authored and jasnell committed Nov 16, 2015
    Configuration menu
    Copy the full SHA
    c0bac95 View commit details
    Browse the repository at this point in the history
  2. util: use Object.create(null) for dictionary object

    Fixes nodejs#3788
    `arrayToHash()` needs to use `Object.create(null)` for its dictionary object.
    
    Refs: nodejs#3791
    PR-URL: nodejs#3831
    Reviewed-By: Trevor Norris <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    JungMinu authored and jasnell committed Nov 16, 2015
    Configuration menu
    Copy the full SHA
    9d0396c View commit details
    Browse the repository at this point in the history
  3. build: fix configuring with prebuilt libraries

    Fix configure_library() to produce correct LDFLAGS when configuring with
    prebuilt 3rd-party libraries (libuv, openssl, etc) using `pkg-config' or
    `--shared-{LIBRARY}-includes=xxx --shared-{LIBRARY}-libpath=xxx'.
    
    PR-URL: nodejs#3135
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Johan Bergström <[email protected]>
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    zyxar authored and bnoordhuis committed Nov 16, 2015
    Configuration menu
    Copy the full SHA
    e2eb334 View commit details
    Browse the repository at this point in the history
  4. test: skip test if FreeBSD jail will break it

    `test/internet/test-dgram-broadcast-multi-process.js` fails if it is in
    a FreeBSD jail. This issue is with the way FreeBSD jails work and not
    with Node. Skip the test if in a FreeBSD jail.
    
    PR-URL: nodejs#3839
    Fixes: nodejs#2472
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Johan Bergström <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Trott authored and jasnell committed Nov 16, 2015
    Configuration menu
    Copy the full SHA
    a2144fc View commit details
    Browse the repository at this point in the history
  5. doc: consistent reference-style links

    Moved all the URLs in API docs to the bottom of the files as
    reference-style links.
    
    PR-URL: nodejs#3845
    Reviewed-By: James M Snell <[email protected]>
    bengl authored and jasnell committed Nov 16, 2015
    Configuration menu
    Copy the full SHA
    cd1123a View commit details
    Browse the repository at this point in the history
  6. debugger: also exit when the repl emits 'exit'

    Exit the debug repl when repl emits 'exit'
    
    Refs: nodejs/node-v0.x-archive#5637
    Fixes: nodejs/node-v0.x-archive#5631
    PR-URL: nodejs#2369
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    fb55 authored and jasnell committed Nov 16, 2015
    Configuration menu
    Copy the full SHA
    a95eb5c View commit details
    Browse the repository at this point in the history
  7. doc: address use of profanity in code of conduct

    PR-URL: nodejs#3827
    Reviewed-By: Brian White <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Julien Gilli <[email protected]>
    Reviewed-By: Sakthipriyan Vairamani <[email protected]>
    Reviewed-By: Alexis Campailla <[email protected]>
    jasnell committed Nov 16, 2015
    Configuration menu
    Copy the full SHA
    3f6b921 View commit details
    Browse the repository at this point in the history
  8. test: fix flaky SmartOS test

    SmartOS has an issue where it will trigger ECONNREFUSED when it should
    not. See https://smartos.org/bugview/OS-2767.
    
    This change adds logic to test-net-server-max-connections.js to work
    around the issue.
    
    Fixes: nodejs#2663
    PR-URL: nodejs#3830
    Reviewed-By: James M Snell <[email protected]>
    Trott committed Nov 16, 2015
    Configuration menu
    Copy the full SHA
    5b80ca9 View commit details
    Browse the repository at this point in the history
  9. tls: Use SHA1 for sessionIdContext in FIPS mode

    FIPS 140-2 disallows use of MD5, which is used to derive the
    default sessionIdContext for tls.createServer().
    
    PR-URL: nodejs#3755
    Reviewed-By: Fedor Indutny <[email protected]>
    stefanmb authored and indutny committed Nov 16, 2015
    Configuration menu
    Copy the full SHA
    424ae5d View commit details
    Browse the repository at this point in the history
  10. tls: use SHA1 for sessionIdContext

    FIPS 140-2 disallows use of MD5, which is used to derive the
    default sessionIdContext for tls.createServer().
    
    PR-URL: nodejs#3866
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    stefanmb authored and indutny committed Nov 16, 2015
    Configuration menu
    Copy the full SHA
    df268f9 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2015

  1. buffer: let WriteFloatGeneric silently drop values

    Documentation currently states that setting noAssert and passing a value
    larger than can fit in the Buffer will cause data to be silently
    dropped. Change implementation to match documented behavior.
    
    Fixes: nodejs#3766
    Reviewed-By: Trevor Norris <[email protected]>
    pmq20 authored and trevnorris committed Nov 17, 2015
    6 Configuration menu
    Copy the full SHA
    0ed3a7c View commit details
    Browse the repository at this point in the history
  2. test: move test-specific function out of common

    common.checkSpawnSyncRet is only used in one test. Move it out of
    common.js and into that test (test-child-process-spawnsync-input.js).
    
    PR-URL: nodejs#3871
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and jasnell committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    b385772 View commit details
    Browse the repository at this point in the history
  3. doc: sort repl alphabetically

    Reorders, with no contextual changes, the repl documentation with class
    definitions at the top and alphabetically.
    
    PR-URL: nodejs#3859
    Reviewed-By: Roman Klauke <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    tflanagan authored and jasnell committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    e3949b2 View commit details
    Browse the repository at this point in the history
  4. module: cache regular expressions

    None of these regular expressions will change, so there is no need to
    generate them every time in hot code paths.
    
    Provides a small performance improvement in module loading. (5-10%)
    
    PR-URL: nodejs#3869
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    evanlucas authored and jasnell committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    4fed62c View commit details
    Browse the repository at this point in the history
  5. doc: replace head of readme with updated text

    PR-URL: nodejs#3482
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    rvagg committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    7ed09a3 View commit details
    Browse the repository at this point in the history
  6. doc: document release types in readme

    PR-URL: nodejs#3482
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    rvagg committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    8ceb36c View commit details
    Browse the repository at this point in the history
  7. debugger: introduce exec method for debugger

    In debugger, the usage of `repl` very ugly. I'd like there is a `p`
    like gdb. So the `exec` is coming.
    
    Usage:
    
    ```
    $ ./iojs debug ~/git/node_research/server.js
    < Debugger listening on port 5858
    connecting to 127.0.0.1:5858 ... ok
    break in /Users/jacksontian/git/node_research/server.js:1
    > 1 var http = require('http');
      2
      3 http.createServer(function (req, res) {
    debug> exec process.title
    /Users/jacksontian/git/io.js/out/Release/iojs
    debug>
    ```
    
    And the `repl`:
    
    ```
    debug> repl
    Press Ctrl + C to leave debug repl
    > process.title
    '/Users/jacksontian/git/io.js/out/Release/iojs'
    debug>
    (^C again to quit)
    ```
    
    The enter and leave debug repl is superfluous.
    
    R-URL: nodejs#1491
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Roman Reiss <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    JacksonTian authored and jasnell committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    b33e9da View commit details
    Browse the repository at this point in the history
  8. 2015-11-17, Version 5.1.0 (Stable)

    PR-URL: nodejs#3736
    Fishrock123 committed Nov 17, 2015
    Configuration menu
    Copy the full SHA
    29cd119 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2015

  1. test: module loading error fix solaris nodejs#3798

    - refactor test to accept multiple error messages per platform
    - add new message to be found in Solaris 11.3 as per nodejs#3798
    
    PR-URL: nodejs#3855
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Evan Lucas <[email protected]>
    fansworld-claudio authored and evanlucas committed Nov 18, 2015
    Configuration menu
    Copy the full SHA
    9a628e2 View commit details
    Browse the repository at this point in the history
  2. test: add OS X to module loading error test

    Previously, this test was not supported on OS X. This change makes sure
    that it is no longer skipped.
    
    PR-URL: nodejs#3901
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    evanlucas committed Nov 18, 2015
    Configuration menu
    Copy the full SHA
    339d384 View commit details
    Browse the repository at this point in the history
  3. process: throw on non-function to nextTick()

    This commit causes process.nextTick() to throw when its callback
    argument is not a function.
    
    PR-URL: nodejs#3860
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Brian White <[email protected]>
    Reviewed-By: Trevor Norris <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    yorkie authored and cjihrig committed Nov 18, 2015
    Configuration menu
    Copy the full SHA
    72e3dd9 View commit details
    Browse the repository at this point in the history
  4. test: fix flaky test-child-process-spawnsync-input

    Move portion of `test-child-process-spawnsync-input.js` (that has been
    flaky on CentOS in CI) to its own file. This allows us to more easily
    eliminate the cause of the flakiness without affecting other unrelated
    portions of the test.
    
    Fixes: nodejs#3863
    PR-URL: nodejs#3889
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Trott authored and jasnell committed Nov 18, 2015
    Configuration menu
    Copy the full SHA
    ac319c3 View commit details
    Browse the repository at this point in the history
  5. test: avoid test timeouts on rpi

    Generating 1024-bit primes on rpi test machines sometimes
    causes timeouts. Avoid this situation by using 256-bit
    primes when not running in FIPS mode.
    
    Fixes: nodejs#3881
    PR-URL: nodejs#3902
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Brian White <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    stefanmb authored and jasnell committed Nov 18, 2015
    Configuration menu
    Copy the full SHA
    e4e5b13 View commit details
    Browse the repository at this point in the history
  6. util: Remove exec, has been deprecated for years

    PR-URL: nodejs#2530
    Reviewed-By: Brian White <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    geek authored and jasnell committed Nov 18, 2015
    5 Configuration menu
    Copy the full SHA
    4cf19ad View commit details
    Browse the repository at this point in the history
  7. tty: Remove deprecated setRawMode wrapper

    PR-URL: nodejs#2528
    Reviewed-By: Brian White <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    geek authored and jasnell committed Nov 18, 2015
    Configuration menu
    Copy the full SHA
    a2c0aa8 View commit details
    Browse the repository at this point in the history
  8. util: remove pump

    Remove util.pump and associated tests
    
    PR-URL: nodejs#2531
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    geek authored and jasnell committed Nov 18, 2015
    Configuration menu
    Copy the full SHA
    007cfea View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2015

  1. doc: add reference for buffer.inspect()

    This commit refers readers to util.inspect() for an explanation
    of buffer.inspect().
    
    Fixes: nodejs#3918
    PR-URL: nodejs#3921
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Brian White <[email protected]>
    cjihrig committed Nov 19, 2015
    Configuration menu
    Copy the full SHA
    5f3ed61 View commit details
    Browse the repository at this point in the history
  2. doc: clarify module loading behavior

    The module loading system will not append node_modules to a
    path already ending in node_modules. This used to be documented,
    but it was lost.
    
    Fixes: nodejs#3873
    PR-URL: nodejs#3920
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    cjihrig committed Nov 19, 2015
    Configuration menu
    Copy the full SHA
    5900d14 View commit details
    Browse the repository at this point in the history
  3. test: skip/replace weak crypto tests in FIPS mode

    FIPS 140-2 does not permit the use of MD5 and RC4, skip or tests
    that use them, or substitute with stronger crypto where applicable.
    
    PR-URL: nodejs#3757
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: James Snell <[email protected]>
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    stefanmb authored and mhdawson committed Nov 19, 2015
    Configuration menu
    Copy the full SHA
    e499ea8 View commit details
    Browse the repository at this point in the history
  4. readline: deprecate undocumented exports

    This commit moves several of readline's undocumented functions
    into an internal module. Specifically, isFullWidthCodePoint,
    stripVTControlCharacters, getStringWidth, and emitKeys are
    moved to the internal module. The existing public exports
    of the first three functions are given a deprecation notice.
    
    Refs: nodejs#3847
    Fixes: nodejs#3836
    PR-URL: nodejs#3862
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Brian White <[email protected]>
    cjihrig committed Nov 19, 2015
    Configuration menu
    Copy the full SHA
    ca2e8b2 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2015

  1. lib: add 'pid' prefix in internal/util

    This PR improves `prefix` in `util` that we've agreed on
    nodejs#3833
    (separate code for javascript to move the printing function
    to C++ directly)
    
    PR-URL: nodejs#3878
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Roman Reiss <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    JungMinu authored and jasnell committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    d01eb68 View commit details
    Browse the repository at this point in the history
  2. test: fix race condition in unrefd interval test

    Rely more on timers implementation rather than arbitrary timeouts.
    
    Refs: nodejs#1781
    PR-URL: nodejs#3550
    
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    mcornac authored and Fishrock123 committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    6de82c6 View commit details
    Browse the repository at this point in the history
  3. crypto: disable crypto.createCipher in FIPS mode

    FIPS 140-2 disallows use of MD5, which is used to derive the
    initialization vector and key for createCipher(). Modify
    all tests to expect exceptions in FIPS mode when disallowed
    API is used, or to avoid testing such API in FIPS Mode.
    
    PR-URL: nodejs#3754
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    stefanmb authored and jasnell committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    56a2b9a View commit details
    Browse the repository at this point in the history
  4. test: http complete list of non-concat headers

    The original test was only testing some of the headers that shouldn't be
    concatenated as per lib/_http_incoming.js, so now the full list is
    there.
    
    'content-length` gives a parse error if you set it to a string, so the
    test for that header uses numbers.
    
    PR-URL: nodejs#3930
    Reviewed-By: Colin Ihrig <[email protected]>
    bengl authored and cjihrig committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    174d4e4 View commit details
    Browse the repository at this point in the history
  5. doc: move fs.existsSync() deprecation message

    This commit moves the deprecation message for fs.existsSync()
    above the function description, making message placement
    uniform across the documentation.
    
    PR-URL: nodejs#3942
    Reviewed-By: Colin Ihrig <[email protected]>
    martfors authored and cjihrig committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    55b1ecc View commit details
    Browse the repository at this point in the history
  6. buffer: move checkFloat from lib into src

    The type and range checks performed by this function can be done more
    efficiently in native code.
    
    PR-URL: nodejs#3763
    Reviewed-By: Trevor Norris <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Matt Loring authored and trevnorris committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    22478d3 View commit details
    Browse the repository at this point in the history
  7. doc: fix broken references

    PR-URL: nodejs#3944
    Reviewed-By: targos - Michaël Zasso <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    gromnitsky authored and Myles Borins committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    94c3507 View commit details
    Browse the repository at this point in the history
  8. module: fix column offsets in errors

    Because Node modules are wrapped, errors on the first line
    of a file leak the wrapper to the user and report the wrong
    column number. This commit adds a line break to the module
    wrapper so that the first line is treated the same as all
    other lines. To compensate for the additional line, a line
    offset of -1 is also applied to errors.
    
    Fixes: nodejs#2860
    PR-URL: nodejs#2867
    Reviewed-By: Colin Ihrig <[email protected]>
    tflanagan authored and cjihrig committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    dfee4e3 View commit details
    Browse the repository at this point in the history
  9. net: small code cleanup

    `options` is already a param of the function.
    
    PR-URL: nodejs#3943
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Myles Borins <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    jscissr authored and jasnell committed Nov 20, 2015
    Configuration menu
    Copy the full SHA
    9472a0c View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2015

  1. fs: fix the error report on fs.link(Sync)

    As the Node.js documentation specified:
    
    > fs.link(srcpath, dstpath, callback)
    
    But when we run:
    
    ```js
    > fs.link()
    ```
    
    We will get the below:
    
    ```js
    TypeError: dest path must be a string
        at TypeError (native)
        at Object.fs.link (fs.js:915:11)
        at repl:1:4
    ```
    
    Just correct the message of relevant 2 errors in this PR :-)
    
    PR-URL: nodejs#3917
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    yorkie authored and jasnell committed Nov 21, 2015
    Configuration menu
    Copy the full SHA
    8b97249 View commit details
    Browse the repository at this point in the history
  2. tools: update certdata.txt

    This is the latest certdata.txt from [0], last updated on 2015-11-13.
    
    [0] https://hg.mozilla.org/mozilla-central/raw-file/64df3815df9c/security/nss/lib/ckfw/builtins/certdata.txt
    
    PR-URL: nodejs#3951
    Reviewed-By: Fedor Indutny <[email protected]>
    bnoordhuis committed Nov 21, 2015
    Configuration menu
    Copy the full SHA
    8c4deff View commit details
    Browse the repository at this point in the history
  3. crypto: update root certificates

    Update the list of root certificates in src/node_root_certs.h with
    tools/mk-ca-bundle.pl.
    
    PR-URL: nodejs#3951
    Reviewed-By: Fedor Indutny <[email protected]>
    bnoordhuis committed Nov 21, 2015
    Configuration menu
    Copy the full SHA
    c83d9b7 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2015

  1. configure: v8_use_snapshot should be true

    `v8_use_snapshot` should be either `true` or `false`, not 1 or 0.
    
    PR-URL: nodejs#3962
    Reviewed-By: Ali Ijaz Sheikh <[email protected]>
    indutny committed Nov 22, 2015
    Configuration menu
    Copy the full SHA
    91ccbf0 View commit details
    Browse the repository at this point in the history
  2. doc: clarify that fs streams expect blocking fd

    This clarifies that fs.createReadStream and fs.createWriteStream, when
    passed a fd, expects the fd to be blocking, and suggests net.Socket as
    an alternative.
    
    PR-URL: nodejs#3641
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    XeCycle authored and bnoordhuis committed Nov 22, 2015
    Configuration menu
    Copy the full SHA
    3f4409e View commit details
    Browse the repository at this point in the history
  3. test: numeric flags to fs.open

    This has been supperted for long but never tested nor documented.
    
    PR-URL: nodejs#3641
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    XeCycle authored and bnoordhuis committed Nov 22, 2015
    Configuration menu
    Copy the full SHA
    804cc76 View commit details
    Browse the repository at this point in the history
  4. doc: numeric flags to fs.open

    This has been supperted for long but never tested nor documented.
    
    PR-URL: nodejs#3641
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    XeCycle authored and bnoordhuis committed Nov 22, 2015
    Configuration menu
    Copy the full SHA
    615fba3 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2015

  1. doc: Adding best practises for crypto.pbkdf2

    Added some information around usages of how to use iterations, how to
    choose decent salts and updating the example to have a significant
    work factor and to use sha512.
    
    PR-URL: nodejs#3290
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: Shigeki Ohtsu <[email protected]>
    tomgco authored and Shigeki Ohtsu committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    d16def5 View commit details
    Browse the repository at this point in the history
  2. doc: replace sane with reasonable

    Removing ableist language because we don't need to make the comparison
    to people with mental health issues to get our point across.
    
    PR-URL: nodejs#3980
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    lewiscowper authored and targos committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    3becac2 View commit details
    Browse the repository at this point in the history
  3. test: address flaky test-http-client-timeout-event

    Use common.platformTimeout() to make test more reliable on Raspberry Pi.
    
    Fixes: nodejs#2555
    PR-URL: nodejs#3968
    
    Reviewed-By: Brendan Ashworth <[email protected]>
    Reviewed-By: Roman Reiss <[email protected]>
    Reviewed-By: Roman Klauke <[email protected]>
    Trott authored and r-52 committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    487de19 View commit details
    Browse the repository at this point in the history
  4. test: retry on smartos if ECONNREFUSED

    SmartOS has a bug that causes unexpected ECONNREFUSED errors.
    
    See https://smartos.org/bugview/OS-2767
    
    If ECONNREFUSED on SmartOS, retry the test one time.
    
    Fixes: nodejs#3864
    Fixes: nodejs#2815
    PR-URL: nodejs#3941
    Reviewed-By: Fedor Indutny <[email protected]>
    Trott committed Nov 23, 2015
    Configuration menu
    Copy the full SHA
    8bc8038 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2015

  1. src: add BE support to StringBytes::Encode()

    Versions of Node.js after v0.12 have relocated byte-swapping away from
    the StringBytes::Encode function, thereby causing a nan test (which
    accesses this function directly) to fail on big-endian machines.
    
    This change re-introduces byte swapping in StringBytes::Encode,
    done via a call to a function in util-inl. Another change in
    NodeBuffer::StringSlice was necessary to avoid double byte swapping
    in big-endian function calls to StringSlice.
    
    PR-URL: nodejs#3410
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Trevor Norris <[email protected]>
    exinfinitum authored and bnoordhuis committed Nov 24, 2015
    Configuration menu
    Copy the full SHA
    2ccde01 View commit details
    Browse the repository at this point in the history
  2. doc: fix typo in README

    PR-URL: nodejs#4000
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Saúl Ibarra Corretgé <[email protected]>
    Trott authored and cjihrig committed Nov 24, 2015
    Configuration menu
    Copy the full SHA
    8d37bbe View commit details
    Browse the repository at this point in the history
  3. test: add TAP diagnostic message for retried tests

    Tests on SmartOS are sometimes retried due to a SmartOS issue on CI.
    When this happens, a TAP diagnostic message is written.
    
    PR-URL: nodejs#3960
    Reviewed-By: Fedor Indutny <[email protected]>
    Trott committed Nov 24, 2015
    Configuration menu
    Copy the full SHA
    41519fd View commit details
    Browse the repository at this point in the history
  4. doc: message.header duplication correction

    The old version of the text here was slightly incorrect, so it
    just defers the details to the section in which they're fully
    described.
    
    PR-URL: nodejs#3997
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Evan Lucas <[email protected]>
    bengl authored and bnoordhuis committed Nov 24, 2015
    Configuration menu
    Copy the full SHA
    6f87aa9 View commit details
    Browse the repository at this point in the history
  5. test: remove flaky status for cluster test

    The test did not fail after 9999 runs in continuous integration.
    
    Remove it's flaky status.
    
    Fixes: nodejs#2557
    PR-URL: nodejs#3975
    Reviewed-By: Rod Vagg <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Roman Klauke <[email protected]>
    Trott authored and r-52 committed Nov 24, 2015
    Configuration menu
    Copy the full SHA
    6588422 View commit details
    Browse the repository at this point in the history
  6. util,src: allow lookup of hidden values

    This commit adds an internal util method that makes hidden
    values in the C++ layer visible in JS.
    
    PR-URL: nodejs#3988
    Reviewed-By: Trevor Norris <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    cjihrig committed Nov 24, 2015
    Configuration menu
    Copy the full SHA
    5169311 View commit details
    Browse the repository at this point in the history
  7. net: add local address/port for better errors

    Adds localAddress and localPort to req so we have better error messages.
    Also fixes a case where ex is used before it is declared.
    
    PR-URL: nodejs#3946
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    jscissr authored and evanlucas committed Nov 24, 2015
    Configuration menu
    Copy the full SHA
    d7b199d View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2015

  1. test: skip test if in FreeBSD jail

    Test test-net-socket-local-address is flaky in FreeBSD jail but robust
    otherwise.
    
    Fixes: nodejs#2475
    PR-URL: nodejs#3995
    Reviewed-By: Rod Vagg <[email protected]>
    Reviewed-By: Johan Bergström <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Trott committed Nov 25, 2015
    Configuration menu
    Copy the full SHA
    b061e3a View commit details
    Browse the repository at this point in the history
  2. deps: backport 819b40a from V8 upstream

    Original commit message:
    
        Use baseline code to compute message locations.
    
        This switches Isolate::ComputeLocation to use baseline code when
        computing message locations. This unifies locations between optimized
        and non-optimized code by always going through the FrameSummary for
        location computation.
    
        [email protected]
        TEST=message/regress/regress-4266
        BUG=v8:4266
        LOG=n
    
        Review URL: https://codereview.chromium.org/1331603002
    
        Cr-Commit-Position: refs/heads/master@{nodejs#30635}
    
    Fixes: nodejs#3934
    PR-URL: nodejs#3937
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Fedor Indutny <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    targos committed Nov 25, 2015
    Configuration menu
    Copy the full SHA
    ab25589 View commit details
    Browse the repository at this point in the history
  3. installer: install the tick processor

    The tick processor is used to provide readable profiling information
    from isolate tick logs (produced by a call to node -prof).
    
    This patch installs the file at $PREFIX/share/doc/node/tick-processor.
    
    PR-URL: nodejs#3032
    Reviewed-By: Ben Noordhuis <[email protected]>
    Matt Loring authored and bnoordhuis committed Nov 25, 2015
    Configuration menu
    Copy the full SHA
    b2e7a4d View commit details
    Browse the repository at this point in the history
  4. build,src: add Intel Vtune profiling support

    This feature supports the Intel Vtune profiling support for JITted
    JavaScript on IA32 / X64 / X32 platform. The advantage of this profiling
    is that the user / developer of NodeJS application can get the detailed
    profiling information for every line of the JavaScript source code.
    This information will be very useful for the owner to optimize their
    applications.
    
    This feature is a compile-time option. For windows platform, the user
    needs to pass the following parameter to vcbuild.bat: "enable-vtune"
    
    For other OS, the user needs to pass the following parameter to
    ./configure command: "--enable-vtune-profiling"
    
    PR-URL: nodejs#3785
    Reviewed-By: Ben Noordhuis <[email protected]>
    cdai2 authored and bnoordhuis committed Nov 25, 2015
    Configuration menu
    Copy the full SHA
    a881b53 View commit details
    Browse the repository at this point in the history
  5. buffer: default to UTF8 in byteLength()

    If an undefined encoding is passed to byteLength(),
    assume that it is UTF8 immediately. This yields a
    small speedup, as it prevents string operations on
    the encoding argument.
    
    PR-URL: nodejs#4010
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Trevor Norris <[email protected]>
    tomgco authored and cjihrig committed Nov 25, 2015
    Configuration menu
    Copy the full SHA
    93739f4 View commit details
    Browse the repository at this point in the history
  6. test: mark fork regression test flaky on windows

    See nodejs#3635 for details and failure
    examples.
    
    Ref: nodejs#3635
    PR-URL: nodejs#4005
    Reviewed-By: Colin Ihrig <[email protected]>
    Trott committed Nov 25, 2015
    Configuration menu
    Copy the full SHA
    fc47e0f View commit details
    Browse the repository at this point in the history
  7. test: mark cluster-net-send test flaky on windows

    See nodejs#3957 for details and examples
    failures.
    
    Ref: nodejs#3957
    Reviewed-By: Ben Noordhuis <[email protected]>
    PR-URL: nodejs#4006
    Trott committed Nov 25, 2015
    Configuration menu
    Copy the full SHA
    16db4c4 View commit details
    Browse the repository at this point in the history
  8. util: add decorateErrorStack()

    This commit adds the decorateErrorStack() method. This function
    uses the internal util's getHiddenValue() method to extract
    arrow messages from error objects and attach them to the
    error's stack trace.
    
    PR-URL: nodejs#4013
    Reviewed-By: Ben Noordhuis <[email protected]>
    cjihrig committed Nov 25, 2015
    Configuration menu
    Copy the full SHA
    8ca412b View commit details
    Browse the repository at this point in the history
  9. repl: attach location info to syntax errors

    Currently, when a file with a syntax error is imported in the
    REPL, no information is provided on the error's location. This
    commit adds the error's location to the stack trace.
    
    Refs: nodejs#2762
    Refs: nodejs#3411
    Refs: nodejs#3784
    PR-URL: nodejs#4013
    Reviewed-By: Ben Noordhuis <[email protected]>
    cjihrig committed Nov 25, 2015
    Configuration menu
    Copy the full SHA
    459b106 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2015

  1. test: use platform-based timeout for reliability

    test-http-client-timeout-with-data fails on Raspberry Pi in CI from time
    to time.
    
    Use a platform-based timeout to improve reliability.
    
    PR-URL: nodejs#4015
    Reviewed-By: Ben Noordhuis <[email protected]>
    Reviewed-By: Roman Reiss <[email protected]>
    Trott committed Nov 26, 2015
    Configuration menu
    Copy the full SHA
    20acc60 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2015

  1. doc: fix rare case of misaligned columns

    By using the same unit for the offset of the main column as used for the
    left column width, we ensure that browsers render the columns
    conistently.
    
    Ref: nodejs/help#32
    
    PR-URL: nodejs#3948
    Reviewed-By: Jeremiah Senkpiel <[email protected]>
    silverwind committed Nov 27, 2015
    Configuration menu
    Copy the full SHA
    8b75030 View commit details
    Browse the repository at this point in the history
  2. test: fix test-domain-exit-dispose-again

    test-domain-exit-dispose-again had been written for node v0.10.x, and
    was using the fact that callbacks scheduled with `process.nextTick`
    wouldn't run if the domain attached to it was disposed.
    
    This is not longer the case, and as a result the test would not catch
    any regression: it would always pass.
    
    This change rewrites that test to check that the current domain is
    cleared properly when processing the rest of the timers list if a
    timer's callback throws an error. This makes the test fail without the
    original fix, and pass with the original fix, as expected.
    
    PR: nodejs#3990
    PR-URL: nodejs#3990
    Reviewed-By: Trevor Norris <[email protected]>
    Julien Gilli committed Nov 27, 2015
    Configuration menu
    Copy the full SHA
    1c85849 View commit details
    Browse the repository at this point in the history
  3. test: move ArrayStream to common

    A number of REPL tests define the same ArrayStream object. This
    commit moves the repeated code into common.js.
    
    PR-URL: nodejs#4027
    Reviewed-By: Ben Noordhuis <[email protected]>
    cjihrig committed Nov 27, 2015
    Configuration menu
    Copy the full SHA
    f2e319b View commit details
    Browse the repository at this point in the history
  4. test: mark test flaky on FreeBSD

    Mark test-net-socket-local-address flaky on FreeBSD. It times out with
    some frequency on CI.
    
    Ref: nodejs#2475
    PR-URL: nodejs#4016
    Reviewed-By: Johan Bergström <[email protected]>
    Reviewed-By: Ben Noordhuis <[email protected]>
    Trott committed Nov 27, 2015
    Configuration menu
    Copy the full SHA
    e25f868 View commit details
    Browse the repository at this point in the history
  5. path: make format() consistent and more functional

    Make the win32 and posix versions of path.format() consistent in when
    they add a directory separator between the dir and base parts of the
    path (always add it unless the dir part is the same as the root).
    
    Also, path.format() is now more functional in that it uses the name
    and ext parts of the path if the base part is left out and it uses
    the root part if the dir part is left out.
    
    Reviewed-By: João Reis <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    PR-URL: nodejs#2408
    nwoltman authored and joaocgreis committed Nov 27, 2015
    Configuration menu
    Copy the full SHA
    d1000b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2015

  1. build: update signtool description, add url

    PR-URL: nodejs#4011
    Reviewed-By: Johan Bergström <[email protected]>
    Reviewed-By: Alexis Campailla <[email protected]>
    rvagg committed Nov 30, 2015
    Configuration menu
    Copy the full SHA
    8a469e4 View commit details
    Browse the repository at this point in the history
  2. doc: fix color of linked code blocks

    Links nested in backticks were not visually distinguishable before, this
    fixes them.
    
    PR-URL: nodejs#4068
    Reviewed-By: Roman Reiss <[email protected]>
    jpersson authored and silverwind committed Nov 30, 2015
    1 Configuration menu
    Copy the full SHA
    f4f1e89 View commit details
    Browse the repository at this point in the history
  3. module,repl: remove repl require() hack

    Remove a hack that was introduced in commit bb6d468 from November 2010.
    This is groundwork for a follow-up commit that makes it possible to use
    internal modules in lib/repl.js.
    
    PR-URL: nodejs#4026
    Reviewed-By: Colin Ihrig <[email protected]>
    bnoordhuis committed Nov 30, 2015
    Configuration menu
    Copy the full SHA
    ee72ee7 View commit details
    Browse the repository at this point in the history
  4. util: move .decorateErrorStack to internal/util

    Move the method that was added in commit 8ca412b from earlier this month
    from lib/util.js to lib/internal/util.js.
    
    Avoids exposing a method that we may not wish to expose just yet, seeing
    how it relies on implementation details.
    
    PR-URL: nodejs#4026
    Reviewed-By: Colin Ihrig <[email protected]>
    bnoordhuis committed Nov 30, 2015
    Configuration menu
    Copy the full SHA
    04b1a2f View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2015

  1. doc: fix the exception description

    A value shouldn't be described as doing inherit from some class, more
    strictly, the value is an instance of the class `Error`.
    
    PR-URL: nodejs#3658
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: Stephan Belanger <[email protected]>
    Reviewed-By: Colin Ihrig <[email protected]>
    Reviewed-By: Rich Trott <[email protected]>
    yorkie authored and Trott committed Dec 1, 2015
    Configuration menu
    Copy the full SHA
    2fb34b6 View commit details
    Browse the repository at this point in the history
  2. util: fix constructor/instanceof checks

    These new checks are similar to the one introduced in 089d688,
    but for other types of objects. Specifically, if an object was
    created in a different context, the constructor object will not be
    the same as the constructor object in the current context, so we
    have to compare constructor names instead.
    
    PR-URL: nodejs#3385
    Reviewed-By: Evan Lucas <[email protected]>
    Reviewed-By: James M Snell <[email protected]>
    Reviewed-By: Michaël Zasso <[email protected]>
    mscdex committed Dec 1, 2015
    Configuration menu
    Copy the full SHA
    82b8355 View commit details
    Browse the repository at this point in the history
  3. streams: update .readable/.writable to false

    These properties were initially used to determine stream status
    back in node v0.8 and earlier. Since streams2 however, these
    properties were *always* true, which can be misleading for
    example if you are trying to immediately determine whether
    a Writable stream is still writable or not (to avoid a "write after
    end" exception).
    mscdex committed Dec 1, 2015
    Configuration menu
    Copy the full SHA
    4330744 View commit details
    Browse the repository at this point in the history