Merge branched 2.5.0.0.4 to master #4917

Merge master to develop

- Relocate PoX-4 stateful property-based tests from ../core-contract-tests/tests/pox-4/ to boot-contracts-stateful-prop-tests/tests/pox-4. - Implement a minimalistic vitest and Clarinet project setup. - Adjust configurations for optimal test isolation. - Ensure Clarinet config is as minimalistic as possible. - For more details, see: #4725 (comment)

…mission

fix: add signer-key to synthetic `stack-aggregation-increase` event

…g out making snapshots (but not saving them)

…r than 1 (i.e. we're not in the prepare phase)

…stacks-blockchain into feat/bitcoin-mev

Multisig order independence

…-scenarios Solo Stacking stateful property-based tests

Multisig order independence

`block-height` can no longer be used in Clarity 3 and above and will cause an analysis error. In its place is `stacks-block-height`.

When the signer is processing a new burn block, it may hit the /v2/pox endpoint before it has been updated with the latest block. This change will check for this case and retry until it receives the expected cycle.

This handles the case where for the first block in a cycle (height % cycle_length == 0), it will report that it is in cycle N, but it will also report that it is in the prepare phase. This was resulting in refreshing the signer config too early. For example, with a cycle length of 20, at block 160, we would see a log: ``` Received a new burnchain block height (160) in the prepare phase of the next reward cycle (9). Checking for signer registration... ``` This is incorrect, because block 160 is not in the prepare phase for cycle 9.

Downgraded log messages about transactions from warning to info.

…rates the correct UTXO linkage data (so the new MEV algorithm won't disqualify Nakamoto miners using TestPeer)

It's okay if it returns a higher cycle than expected.

…ockchain into draft/multisig-order-independence

redid it on top of develop

Co-authored-by: Brice Dobry <[email protected]>

…on of one window length

… nakamoto

… commit by sender

Handle the `tenure-height` keyword in Clarity3, and using the same logic for `block-height` in Clarity 1 or 2.

Changelog

The removal of package-lock.json causes `npm ci` to fail and it should not be removed by this PR any way.

PoX-4 unit testing

fix: handle a race condition between the signer and the /v2/pox endpoint

Feat/mock mining hot swap

…avoid needless network I/O if it's not needed

…om connection_opts.inv_reward_cycles

…ures that a block's hash will depend on the (number of) opts it contains

…with_len`

…e' into draft/multisig-order-independence

Fix/4735

…transaction fee for a STX-transfer from the cost estimators

* next: update per 4638 removing portable flag fix: dont warn about aggregate key in 2.5

…better abstraction over the inner u256

…stacks-blockchain into feat/bitcoin-mev

With this commit, undo the MARF changes following the mechanism used for `block-height` and replace it with a Clarity based solution.

feat: signer monitoring server

Fix/4734

Feat/Bitcoin MEV

Fix/4721

…em; just don't talk to them). instead, track connections and connection attempts

…o do so

@kantai

Instead of defining it separately in each of several different types, just add this method to the macro. h/t @kantai's review suggestion.

@kantai

This new location avoids the need to pass `new_tenure` around to the block begin methods. h/t @kantai

…r its neighbor key

Needed to call `save_analysis` for the deployed contracts.

…r, not that the stackerdb sync state machine is

…s, and don't use the PoX bitvec length to determine when to retry an inv sync

…depends on bootstrap nodes staying connected)

… latter happens fast enough on its own (it only needs to be done once per reward cycle)

…we waste a *ton* of CPU)

[CI] 4746 - Avoid extraneous CI runs (develop)

* develop: (420 commits) remove extra character from vi typo remove paths-ignore 4746 - avoid extra ci runs chore: fix comment typo fix: more PR feedback -- better, more-complete AtcRational tests and better abstraction over the inner u256 chore: address PR feedback and add more test coverage chore: add unit test chore: add unit test feat: add no-op metrics timer when feature disabled chore: get all unit tests to pass chore: API sync chore: add a mode of generating burnchain blocks in TestPeer that ensures that a block's hash will depend on the (number of) opts it contains fix: don't start from reward cycle 0 when doing an inv sync; start from connection_opts.inv_reward_cycles chore: expose set_initial_peer fix: optionally disable resolving bootstrap nodes, so the caller can avoid needless network I/O if it's not needed chore: use the burnchain indexer to find the right block header fix: revert changes in contrib/core-contract-tests/ fix: typos chore: index block-commits by apparent sender, so we can get the last commit by sender fix: generate the expected block commit input so that mining works in nakamoto ...

…ands Signed-off-by: Jacinta Ferrant <[email protected]>

Signed-off-by: Jacinta Ferrant <[email protected]>

Implement this error for MonitoringError and fix clippy warnings

…mmands Remove dead CLI commands including Sign, DKG, and generate Files comm…

…ubmodules Signed-off-by: Jacinta Ferrant <[email protected]>

Fix/4752

Signed-off-by: Jacinta Ferrant <[email protected]>

…maintain network connections

feat: Preserve `PeerNetwork` during Epoch 3.0 transition

Signed-off-by: Jacinta Ferrant <[email protected]>

…e.rs

Signed-off-by: Jacinta Ferrant <[email protected]>

…rk/stacks-core into chore/block-signature-message-type

Signed-off-by: Jacinta Ferrant <[email protected]>

Pull current stacks signer out into v1 implementation and create placeholder v0 mod

Signed-off-by: Jacinta Ferrant <[email protected]>

… into chore/block-signature-message-type

Signed-off-by: Jacinta Ferrant <[email protected]>

Also including some other improvements from PR review.

Signed-off-by: Jacinta Ferrant <[email protected]>

…ssage-type Chore/block signature message type

This is necessary after the new check was added to ensure that the tenure height is not set before epoch 3.0.

Add CODEOWNERS

Fix/4732

CI: Update Used Actions' Versions

Ensure new keywords are still handled as expected.

- it gets both cases: 1. reward set not determined 2. signer not registered without having to modify a lot of the current implementation only to parse an extra separation between them.

Signer message for reward set not determined or not registered signer

Add/update block height keywords in Clarity

Co-authored-by: Aaron Blankstein <[email protected]>

…ay-config feat: add a next_initiative_delay config

Co-authored-by: Brice Dobry <[email protected]>

Feat: Signature order-independence fix for multisig tx

Make rusqlite optional

- removed the step to , defaulting to repo root

Adding 2.5.0.0.4 to the changelog

…s, not rowids

Fix/signer slot count

…lot-count Revert "Fix/signer slot count"

…tests pass

Fix/signer-slot-count

… burnchain forks

…onical-2.5.0.0.4 Fix: never consider Stacks chain tips that are not on the canonical burn chain #4886

Fix: signer slots count in staging

* cow/arcing tuple types and refactoring some checks in analyzer

Performance improvements in Clarity analysis

Add PR's to the changelog for 2.5.0.0.4

* master: remove paths-ignore 4746 - avoid extra ci runs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge branched 2.5.0.0.4 to master #4917

Merge branched 2.5.0.0.4 to master #4917

Commits on Apr 29, 2024

Commits on Apr 30, 2024

Commits on May 1, 2024

Commits on May 2, 2024

Commits on May 3, 2024

Commits on May 4, 2024

Commits on May 5, 2024

Commits on May 6, 2024

Commits on May 7, 2024

Commits on May 8, 2024

Commits on May 9, 2024

Commits on May 10, 2024

Commits on May 11, 2024

Commits on May 13, 2024

Commits on May 14, 2024

Commits on May 15, 2024

Commits on May 16, 2024

Commits on May 17, 2024

Commits on May 20, 2024

Commits on May 21, 2024

Commits on May 23, 2024

Commits on Jun 3, 2024

Commits on Jun 4, 2024

Commits on Jun 18, 2024

Commits on Jun 25, 2024

Commits on Jun 26, 2024