This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Add support for file-picker #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r299567 disabled SSLv3 fallback. This change adds an enterprise policy option to control this value so that enterprises can reenable the fallback if they need it. This option is in contrast to the one added in r299755. That one allows enterprises to be more aggressive in disabling SSLv3, while this one is intended for those who need to more slower that Chrome's default. BUG=418848,419870 Review URL: https://codereview.chromium.org/644913008 (cherry picked from commit 33369a4) Conflicts: components/policy/resources/policy_templates.json Cr-Commit-Position: refs/branch-heads/2171@{#222} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
BUG=423990 [email protected] Review URL: https://codereview.chromium.org/661663002 Cr-Commit-Position: refs/heads/master@{#299826} (cherry picked from commit 17abbb9) Review URL: https://codereview.chromium.org/666053003 Cr-Commit-Position: refs/branch-heads/2171@{#224} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
And stop mis-using user metrics action. BUG=424689 Review URL: https://codereview.chromium.org/659333003 Cr-Commit-Position: refs/heads/master@{#300217} (cherry picked from commit 0fed985) [email protected] Review URL: https://codereview.chromium.org/636283006 Cr-Commit-Position: refs/branch-heads/2171@{#225} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
BUG=422482 [email protected] Review URL: https://codereview.chromium.org/639163003 Cr-Commit-Position: refs/heads/master@{#299672} (cherry picked from commit d3319ba) Review URL: https://codereview.chromium.org/667413002 Cr-Commit-Position: refs/branch-heads/2171@{#227} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
The media player now won't seek after load when there is no actual pending seek. BUG=420645 Review URL: https://codereview.chromium.org/654203005 Cr-Commit-Position: refs/heads/master@{#300452} (cherry picked from commit 43dd925) Review URL: https://codereview.chromium.org/664413002 Cr-Commit-Position: refs/branch-heads/2171@{#228} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
BUG=339101 TBR=kuan Review URL: https://codereview.chromium.org/637243004 Cr-Commit-Position: refs/heads/master@{#300433} (cherry picked from commit 9a27e48) Review URL: https://codereview.chromium.org/666193003 Cr-Commit-Position: refs/branch-heads/2171@{#229} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
MailboxSynchronizer which is used by Android WebView depends on them for correct synchronization. BUG=424293 Review URL: https://codereview.chromium.org/653533005 [email protected] Cr-Commit-Position: refs/heads/master@{#299969} (cherry picked from commit 2e7d8a7) Review URL: https://codereview.chromium.org/668513005 Cr-Commit-Position: refs/branch-heads/2171@{#230} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
Previously we subtracted the interest_rect_over_tiles from the invalid_rect when looking to see what invalidation would not be recorded but this computation is wrong. Instead, we need to expand the invalidation to the bounds of the tiles it touches (including tiles it touches on borders). Then we can subtract the interest rect expanded to the bounds of tiles it touches (including tiles it touches on borders). This makes each expansion match the iteration of the given rect where we include borders. If a tile is touched only on the border by invalidation, but the tile is not touched even on a border by the interest rect, we want to expand the invalidation to cover that tile. TBR=enne, vmpstr BUG=421729 Review URL: https://codereview.chromium.org/657913002 Cr-Commit-Position: refs/heads/master@{#299750} (cherry picked from commit 04a24ab) Review URL: https://codereview.chromium.org/672663002 Cr-Commit-Position: refs/branch-heads/2171@{#231} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
* If CommitFrame is skipped to to stall, ensure we invalidate. * Make sure force_invalidate does not get cancelled by a pending fallback tick. * Allow hardware initialization even when visible rect is empty, so fallback tick is always in the right mode. * Fix visible rect empty checks. BUG=425372 Review URL: https://codereview.chromium.org/654403006 [email protected] Cr-Commit-Position: refs/heads/master@{#300566} (cherry picked from commit 6b96a04) Conflicts: android_webview/browser/browser_view_renderer.h android_webview/native/aw_contents.h Review URL: https://codereview.chromium.org/646303004 Cr-Commit-Position: refs/branch-heads/2171@{#232} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
The overlay cast button had a semi-transparent CSS background color. Unfortunately the button image is treated in Blink as a background image, so this modified the image, rather than simply providing a background for it. As a result the cast button came out as grey on grey on pale backgrounds. Fix this by making the CSS background color transparent, and modifying the icon image itself to make its background semi-transparent. Since the CSS is in Blink the CSS change is in the Blink CL https://codereview.chromium.org/658353002 [email protected] BUG=424180 Review URL: https://codereview.chromium.org/661833005 Cr-Commit-Position: refs/heads/master@{#300130} (cherry picked from commit fe5c903) Review URL: https://codereview.chromium.org/674583002 Cr-Commit-Position: refs/branch-heads/2171@{#233} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
Causing blanks/boxes on mixed CJK configurations. A direct revert wasn't sufficient, I had to add internal:: to LinkedFontsIterator and re-add the implementation of ChooseFallbackFont. [email protected], [email protected] BUG=422142 TEST=zh-hans WinXP, Chrome UI set to Korean, things don't disappear Review URL: https://codereview.chromium.org/638413003 Cr-Commit-Position: refs/branch-heads/2171@{#234} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
+ Switch textContent to innerHTML to accommodate strings with HTML + Hide the details button with inline style to override the media query. BUG=420888 Committed: https://crrev.com/836d61020dcfcf3becfd42172fb73a423551ea17 Cr-Commit-Position: refs/heads/master@{#298539} Review URL: https://codereview.chromium.org/671043002 Cr-Commit-Position: refs/branch-heads/2171@{#235} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
This change is in preparation for a bug fix in Chrome for Android. BUG=419927 [email protected] Review URL: https://codereview.chromium.org/630223003 Cr-Commit-Position: refs/heads/master@{#298896} (cherry picked from commit c021ddc) Review URL: https://codereview.chromium.org/673683002 Cr-Commit-Position: refs/branch-heads/2171@{#236} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
In preparation for a bug fix. BUG=419927 [email protected] Review URL: https://codereview.chromium.org/642623002 Cr-Commit-Position: refs/heads/master@{#298900} (cherry picked from commit cd77acb) Review URL: https://codereview.chromium.org/655463005 Cr-Commit-Position: refs/branch-heads/2171@{#237} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
…Deprecated BUG=424997 [email protected] Review URL: https://codereview.chromium.org/664023002 Cr-Commit-Position: refs/heads/master@{#300379} (cherry picked from commit 9db73d2) Review URL: https://codereview.chromium.org/668333002 Cr-Commit-Position: refs/branch-heads/2171@{#238} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
…al to threshold (currently 1750). TBR=ananta, asvitkine, cpu, scottmg BUG=421305 Review URL: https://codereview.chromium.org/667013003 Cr-Commit-Position: refs/heads/master@{#300345} (cherry picked from commit e2607d4) Conflicts: ui/gfx/win/direct_write.cc Review URL: https://codereview.chromium.org/671743002 Cr-Commit-Position: refs/branch-heads/2125@{#583} Cr-Branched-From: b68026d-refs/heads/master@{#290040} (cherry picked from commit 5cbc557) Review URL: https://codereview.chromium.org/668333003 Cr-Commit-Position: refs/branch-heads/2171@{#239} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
- Add assets for xxxhdpi - Add some missing assets for other dpis. BUG=403506 [email protected] Review URL: https://codereview.chromium.org/655743003 Cr-Commit-Position: refs/heads/master@{#299762} (cherry picked from commit d9cf3f8) Review URL: https://codereview.chromium.org/674593003 Cr-Commit-Position: refs/branch-heads/2171@{#240} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
…type data r272022 introduced grammar check on the mediatype part in a data URI. This broke applications that depend on the behavior that our WebURLLoaderImpl and URLRequestDataJob accept data URIs with incomplete mediatype such as "data:image;base64,xxx". Accept this kind of data URI again for backward compatibility. Instead, fallback to the default mediatype when ParseMimeTypeWithoutParameter() returns false in DataURL::Parse() to avoid generating Content-type header with invalid mediatype. BUG=412479 Review URL: https://codereview.chromium.org/555383003 Cr-Commit-Position: refs/heads/master@{#297593} (cherry picked from commit 5469386) Review URL: https://codereview.chromium.org/674823002 Cr-Commit-Position: refs/branch-heads/2171@{#242} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
…ocessing zero out the audio data Avoid reporting 0 as input level when AudioProcessing zero out the audio data. When the microphone volume is low, the pre-processed audio data contains energy, while the post-processed audio data has only 0, we report 0 as energy before this patch, which is wrong since the audio flow contains energy. This patch fix the problem by checking the energy of pre-processed data before reporting 0 as energy. [email protected] BUG=424149 TEST=1, use a USB headset. 2, set the microphone volume low, like below 50%. 3, join a hangout call. 4, open chrome://webrtc-internals, and look at the energy of input stream, constantly it is 0 there. Review URL: https://codereview.chromium.org/669393002 Cr-Commit-Position: refs/branch-heads/2171@{#243} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
Fix documentation of RegisteredProtocolHandlers policy in policy_templates BUG=419755 Review URL: https://codereview.chromium.org/658513002 Cr-Commit-Position: refs/heads/master@{#299452} (cherry picked from commit a639a52) [email protected] Review URL: https://codereview.chromium.org/678443002 Cr-Commit-Position: refs/branch-heads/2171@{#244} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
Its lifetime is scoped to the RenderFrame, and it might go away before the hosts that refer to it. BUG=423030 Committed: https://crrev.com/3a2cf7d1376ae33054b878232fb38b8fbed29e31 Cr-Commit-Position: refs/heads/master@{#299897} [email protected] Review URL: https://codereview.chromium.org/653243003 Cr-Commit-Position: refs/branch-heads/2171@{#245} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
…TCP if the connection fails. BUG=425599 Review URL: https://codereview.chromium.org/667053006 Cr-Commit-Position: refs/heads/master@{#300536} (cherry picked from commit 13900aa) Conflicts: net/quic/quic_reliable_client_stream.h Review URL: https://codereview.chromium.org/641183008 Cr-Commit-Position: refs/branch-heads/2171@{#246} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
This is similar to http://crrev.com/649253003, but we can't add a string to M39. BUG=421236 [email protected] Review URL: https://codereview.chromium.org/651643006 Cr-Commit-Position: refs/branch-heads/2171@{#247} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
WebView does not gather data_reduction_proxy related statistics at the moment. WebView's statistics object writes the data to pref service which does not upload the data to anywhere. BUG=426140 Review URL: https://codereview.chromium.org/651443005 Cr-Commit-Position: refs/heads/master@{#300613} (cherry picked from commit 4441cc1) Conflicts: android_webview/browser/aw_browser_context.cc Review URL: https://codereview.chromium.org/676863002 Cr-Commit-Position: refs/branch-heads/2171@{#248} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
There are 2 different path that can possibly lead to SetDataReductionProxyEnalbed: 1. AwContents initialization -> InitDataReductionProxyIfNecessary path 2. AwContents statistics SetDataReductionProxyEnalbed JNI path In both paths, we need to make sure before SetDataReductionProxyEnabed is called, we have set the statistics object on DataReductionProxySettings. BUG=b/17998706 Review URL: https://codereview.chromium.org/671823002 Cr-Commit-Position: refs/heads/master@{#300730} (cherry picked from commit 410c610) Review URL: https://codereview.chromium.org/671243002 Cr-Commit-Position: refs/branch-heads/2171@{#249} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
* Refactors the code to allow adding metrics as part of metrics provider interface * Implements a function in android_metrics_provider to record a new histogram which records the current document mode. This is needed for better analysis in Hera. I am adding a new histogram because the semantics are a bit different from DocumentActivity.RunningMode. The previous histogram is used only to record eligible devices that have manually opted in or out. The new histogram will record for all devices regardless of whether they could possibly be in document mode. BUG=418642 [email protected],[email protected] Review URL: https://codereview.chromium.org/658903002 Cr-Commit-Position: refs/heads/master@{#300375} (cherry picked from commit 1910289) Conflicts: chrome/browser/android/chrome_jni_registrar.cc chrome/chrome_browser.gypi Review URL: https://codereview.chromium.org/676783003 Cr-Commit-Position: refs/branch-heads/2171@{#250} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
BUG=426197 NOTRY=true Review URL: https://codereview.chromium.org/669123003 Cr-Commit-Position: refs/heads/master@{#300771} (cherry picked from commit 14852a4) [email protected] Review URL: https://codereview.chromium.org/675843003 Cr-Commit-Position: refs/branch-heads/2171@{#251} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco
force-pushed
the
master
branch
2 times, most recently
from
5d9bef8
to
18a33ff
Compare
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
This is a reland of http://crrev.com/1160143010, with some additional tweaks. It was reverted because it tickled an AppKit crash (crbug.com/504808). The hope is that the crash won't reappear now that we link with 10.10 SDK. In 10.7, AppKit introduced new API for drawing focus rings. This automatic focus ring drawing is automatically enabled for applications linking with 10.8 sdk or later. After we link with 10.10 SDK the new style focus ring gets enabled but we get focus rings with double lines. This is because AppKit thinks the buttons are bordered (-isBordered is YES) and draws lines inside and outside the borders that are actually not there due to drawing overrides. 10.6 before: manually drawn, tab close and avatar buttons missing focus rings. 10.6 after: no change. 10.7 before: broken, no focus rings on toolbar, avatar, tab close, new tab buttons. 10.7 after: manually drawn, same as 10.6. 10.8+ before: broken, no focus rings on toolbar, avatar, tab close, new tab buttons. 10.8+ after: drawn by AppKit. Toolbar.xib changes: Change the toolbar buttons (back, forward, reload, home, wrench) Focus Ring from None to Default, to allow the new style focus ring to draw. BUG=459860, 520471 [email protected] Review URL: https://codereview.chromium.org/1310183005 Cr-Commit-Position: refs/heads/master@{#345989} (cherry picked from commit 9c75e37) Review URL: https://codereview.chromium.org/1327203003 . Cr-Commit-Position: refs/branch-heads/2490@{#218} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
rakuco
force-pushed
the
master
branch
2 times, most recently
from
830d9f6
to
5ad5a18
Compare
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
This method returns the type of the iOS webview currently in use, formatted as a cgi param suitable for appending to omnibox queries. This CL also updates the corresponding experimental flags methods to cache the current experiment state, since the state will soon be queried often when constructing omnibox results. BUG=551851 TEST=None Review URL: https://codereview.chromium.org/1495643002 Cr-Commit-Position: refs/heads/master@{#362773} (cherry picked from commit 4b79d93) Review URL: https://codereview.chromium.org/1492163004 . Cr-Commit-Position: refs/branch-heads/2564@{#218} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
force-pushed
the
master
branch
2 times, most recently
from
1072537
to
512d729
Compare
rakuco
force-pushed
the
master
branch
2 times, most recently
from
0f31e18
to
3da217c
Compare
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
BUG=575728 Review URL: https://codereview.chromium.org/1634323002 Cr-Commit-Position: refs/heads/master@{#372480} (cherry picked from commit 802c997) Review URL: https://codereview.chromium.org/1652213002 . Cr-Commit-Position: refs/branch-heads/2623@{#218} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
Currently only constrained web dialogs for views (Linux/Windows) are able to autoresize. This change implements the option to pass in minimum and maximum sizes and enabling autoresizing functionality for OSX. This change adds two static functions for options on whether to create a ConstrainedWindowsMac that autoresizes or is of fixed size. The first two patches were reverted because of flaky tests on Mac 10.9. Those patches can be found at: 1. https://codereview.chromium.org/1430023002 2. https://codereview.chromium.org/1446623003 After some investigation, we found that the failures are being caused by an occlusion notifications in cocoa, which is not expected in browser tests. This is currently mac-only. By disabling these notifications in browser tests, we see this patch passing on the swarming bots that were previously failing. See http://crbug/558585. The patch to disable occlusion notifications can be found at: https://codereview.chromium.org/1762883002/ The third patch (same as second patch) broke dialogs like print preview. This was because the change used ui::kWindowSizeDeterminedLater for the dialog window's frame for all constrained web dialogs on mac, not just autoresizable dialogs. That has been amended in this change. That patch can be found here: https://codereview.chromium.org/1699763002/ BUG=217034 Review URL: https://codereview.chromium.org/1781433002 Cr-Commit-Position: refs/heads/master@{#380352} (cherry picked from commit 740c410) Review URL: https://codereview.chromium.org/1796273004 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#218} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Another issue similar to 605884. BUG=614992 [email protected] Review-Url: https://codereview.chromium.org/2012273002 Cr-Commit-Position: refs/heads/master@{#397040} (cherry picked from commit b801ad2) Review URL: https://codereview.chromium.org/2034293002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#218} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
This will allow us to calculate: - % of popups blocked - % of popups clicked through Bug: 762617 Change-Id: Iaa850d03adb75e04b629b2d8623b0680b7dd095d Reviewed-on: https://chromium-review.googlesource.com/658225 Reviewed-by: Steven Holte <[email protected]> Reviewed-by: Avi Drissman <[email protected]> Commit-Queue: Charlie Harrison <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#501038}(cherry picked from commit afff863) Reviewed-on: https://chromium-review.googlesource.com/667057 Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#218} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of file-picker patch, which belongs to Chromium content shell.
Bug=XWALK-950