Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on support initial parameters for SkOpt #11

Merged
merged 35 commits into from
Mar 13, 2019

Conversation

adizim
Copy link

@adizim adizim commented Mar 12, 2019

No description provided.

ericl and others added 30 commits March 6, 2019 09:55
*  Use strongly typed IDs for C++.

* Avoid heap allocation in cython.

* Fix JNI part

* Fix rebase conflict

* Refine

* Remove type check from __init__

* Remove unused constructor declarations.
* clean it up

* Update .travis.yml

* Update .travis.yml

* update

* fix example

* suppress

* timeout

* print periodic progress

* Update suppress_output

* Update run_silent.sh

* Update suppress_output

* Update suppress_output

* manually do timeout

* sleep 300

* fix test

* Update run_silent.sh

* Update suppress_output

* Update .travis.yml
* Update arrow

* Change to 2c511979b13b230e73a179dab1d55b03cd81ec02 which is rebased on Arrow 46f75d7

* Update to fix comment

* disable tests which use python/ray/rllib/tests/data/cartpole_small

* Fix get order of meta and data in MockObjectStore.java
…er sync_now (ray-project#4302)

## What do these changes do?
Fixes a tune autoscaling problem where worker recovery causes things to stall.
This introduces a light CLI for Tune.
* Introduce set data structure in GCS. Change object table to Set instance.

* Fix a logic bug. Update python code.

* lint

* lint again

* Remove CURRENT_VALUE mode

* Remove 'CURRENT_VALUE'

* Add more test cases

* rename has_been_created to subscribed.

* Make `changed` parameter type of `bool *`

* Rename mode to notification_mode

* fix build

* RAY.SET_REMOVE return error if entry doesn't exist

* lint

* Address comments

* lint and fix build
@markgoodhead
Copy link

markgoodhead commented Mar 13, 2019

@adizim What's the reasoning behind merging these changes into my branch - it doesn't look like there's any conflict so we should be able to merge both into master separately? I'll make the assertion changes you requested anyway.

EDIT: Never mind I get it - my branch was behind master so the other changes won't conflict with a master merge. I'll work on this branch now.

@markgoodhead markgoodhead merged commit 2ebc920 into longshotsyndicate:skopt-initial2 Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.