Add msquic datagram support and changes from others #1

…dotnet#88242) * Add Native AOT cross-build support for iOS-like platforms * Add -hostos parameter for cross-components build --------- Co-authored-by: Michal Strehovský <[email protected]>

* Read/Write Big/LittleEndian support for Guid * Code review * Jan Kotas code review * Code review MemoryMarshal.Read<Guid>(b); [DoesNotReturn] * Use MemoryMarshal.AsRef * code review try AsBytes(Guid)

…matches clr. (dotnet#88648) Fixes dotnet#88637.

…ro value (dotnet#88623) * Ensure that the CpuId tests set preferredVectorByteLength to a non-zero value * Ensure getPreferredVectorByteLength takes NAOT into account * Don't condition the preferred vector byte length based on stress mode

… implementations (dotnet#88639) - Move the handling for variance so that it is in the same place as it is for instance methods - Validate the behavior of such dispatch is equivalent to the dispatch behavior involving instance variant default dispatch - Rework the fix for dotnet#80350 to avoid violating an invariant of the type system (which is that all MethodDef's of a TypeDef are loaded as MethodDescs when loading the open type). Fixes dotnet#78621

…net#88613)

When you have built a CoreCLR CoreLib, it "poisons" the build s.t. running libraries tests with NAOT becomes impossible. This is because $(IlcFrameworkPath) draws from a shared framework that contains the CoreCLR CoreLib, while it should use the CoreLib from the AOT SDK. This targeted change changes the order in which these two assemblies get passed to ILC and allows one to use "/p:TestNativeAot=true" without additional workarounds.

…pes (dotnet#86875) * Expose IUtf8SpanParsable * Have INumberBase implement IUtf8SpanParsable * Deduplicate some floating-point parsing logic * Refactoring the primitive parsing logic to support UTF-8 * Updating the primitive numeric types to include UTF-8 parsing support * Adding tests covering the new UTF-8 parsing support * Ensure that tests don't try to capture a span in lambda * Ensure that MatchChars does the right thing * Account for the switch from string to ROSpan<TChar> for currSymbol * Ensure EqualsIgnoreCaseUtf8_Scalar handles the remaining elements correctly * Allow alloc-free conversion for the UTF8 parsing fallback paths * Remove unnecessary attributes and ensure trailing elements are correctly handled * Fix the handling of UTF8 as per the feedback * Fix a slightly broken merge * Ensure the lengths are properly checked on the ASCII path * Ensure that length is defined for 32-bit * Responding to PR feedback and allow invalid sequences to self match * Fixing a copy/paste error * Fixing a build failure due to not assigning the out parameter

…#88357)

dotnet/corert@08d78ae The original motivation for this was handling import stubs: ``` Function pointer equality comparison was not handling cross-module pointers correctly when optimizations were enabled (causes target pointers to be wrapped in jump stubs sometimes). The delegate equality comparison was hitting this bug. ``` We do not have import stubs anymore and unwrapping unboxing stubs serves no purpose here. Microbenchmarks of delegate equality show ~3x improvement with this change: ``` Bench_DelegateEquality_Positive_OpenStatic<10000000>() took: 355 ms Bench_DelegateEquality_Positive_ClosedStatic<10000000>() took: 367 ms Bench_DelegateEquality_Positive_ClosedInstance<10000000>() took: 371 ms Bench_DelegateEquality_Positive_OpenStatic<10000000>() took: 121 ms Bench_DelegateEquality_Positive_ClosedStatic<10000000>() took: 120 ms Bench_DelegateEquality_Positive_ClosedInstance<10000000>() took: 122 ms ``` Additionally, there is some desire to upstream changes for a portable RhGetCodeTarget implementation. Not having to deal with it at this relatively low-level layer will make things more robust.

…tnet#88064) * Add browser-bench measurement for int32 and float equals * Add interp intrinsics for Vector128 float and double Equals methods * Implement Vector128 float and double Equals methods in jiterp * Add jiterp validation to make sure we never appendSimd(0) by accident

* Enable finalizer events for EventPipe * FB

…t#79856) * [threads] Save errno when using posix semaphores for thread transitions We already save/restore GetLastError on win32. Do it on posix platforms, too. If one thread is in a pinvoke wrapper, while another thread triggers a STW, the pinvoke wrapper will self-suspend the thread and wait for a notification to resume. Depending on the platform we can use win32 primitives, Mach semaphores or POSIX semaphores. win32 and posix can both change the value of last error (errno, respectively) while the thread is suspended. That means that code like this (generated by the LibraryImportAttribute source generator) cannot reliably retrieve the error from the last pinvoke: ```csharp __retVal = __PInvoke(__path_native, mode); // there is a pinvoke wrapper here, that transitions from GC Safe to GC Unsafe mode __lastError = System.Runtime.InteropServices.Marshal.GetLastSystemError(); ``` The solution is to explicitly preserve the value of GetLastError/errno when exiting from GC Safe. Fixes dotnet#77364 * rename W32_DEFINE_LAST_ERROR_RESTORE_POINT to MONO_DEFINE_LAST_ERROR_RESTORE_POINT and W32_RESTORE_LAST_ERROR_FROM_RESTORE_POINT to MONO_RESTORE_LAST_ERROR_FROM_RESTORE_POINT

…ame matching, & make some formatting improvements (dotnet#88338) * Update binding generator to do case-insensitive config-key/property name matching, & make some formatting improvements * Address feedback

@AustinWise

Omission was noticed by @AustinWise. I reproed the failure and this fix for it on linux-x64. Fixes dotnet#81362

MINT_LDSTR_DYNAMIC for dynamic methods. the data item is an index into the DynamicMethod:method.method_data which stores pointers to MonoString objects that are held by the managed DynamicMethod. MINT_LDSTR_CSTR for ilgen wrappers. the data item is a raw C string that is global, or was allocated by malloc Fixes dotnet#88694 by allowing MINT_LDSTR_CSTR in any method since we no longer depend on mono_method_get_wrapper_data at execution time. And at transform time we have access to the actual wrapper method.

…uild 20230710.1 (dotnet#88658) Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.23357.1 -> To Version 3.11.0-beta1.23360.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* [mono][mini] Fix conversion from STACK_PTR It was hardcoded to int conversion instead of checking the arch ptr size. * Enable tests

* [wasm] WBT: Fix breaking tests `Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations` broke with the latest sdk: `/root/helix/work/workitem/e/dotnet-latest/sdk/8.0.100-preview.7.23362.1/Roslyn/Microsoft.CSharp.Core.targets(80,5): error MSB6004: The specified task executable location "/root/helix/work/workitem/e/dotnet-latest/dotnet/dotnet" is invalid.` This was because dotnet/roslyn#68918 changed to expect `DOTNET_ROOT` to be a directory instead of the exe path. * [wasm] WBT: Set DOTNET_ROOT for tests * [wasm] WBT: Set DOTNET_ROOT explicitly in the helix environment The `NonWasmTemplateBuildTests` avoid using the default environment variables used for all other tests, which includes `DOTNET_ROOT`. Set `DOTNET_ROOT` explicitly in the helix setup script for windows, so we always have a fallback. ``` Wasm.Build.Tests.NonWasmTemplateBuildTests.NonWasmConsoleBuild_WithoutWorkload(config: "Debug", extraBuildArgs: "", targetFramework: "net6.0") [FAIL] Expected 0 exit code but got 1: C:\helix\work\workitem\e\dotnet-none\dotnet.exe build -restore -c Debug -bl:C:\helix\work\workitem\uploads\xharness-output\logs\nonwasm_net6.0_Debug_iyhtgmvj.uu4.binlog -f net6.0 Standard Output: [] MSBuild version 17.8.0-preview-23361-03+5ab64ed27 for .NET [] Determining projects to restore... [] Restored C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj (in 820 ms). [] Determining projects to restore... [] Restored C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj (in 11.21 sec). [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(314,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : You must install or update .NET to run this application. [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : App: C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\bincore\csc.dll [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : Architecture: x64 [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : Framework: 'Microsoft.NETCore.App', version '8.0.0-preview.7.23361.9' (x64) [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : .NET location: C:\helix\work\correlation\dotnet-cli\ [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : The following frameworks were found: [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : 8.0.0-preview.5.23280.8 at [C:\helix\work\correlation\dotnet-cli\shared\Microsoft.NETCore.App] [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : Learn more: [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : https://aka.ms/dotnet/app-launch-failed [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : To install missing framework, download: [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0-preview.7.23361.9&arch=x64&rid=win10-x64 [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] ```

The existing check was too conservative, and blocked inlines of one instantation of a generic method into a different instantiation of the same method, or of two different methods that share the exact same IL stream. Generalize the check to also compare the method handle and runtime context. Fixes dotnet#88667 Fixes dotnet#58824

…otnet#88521) * Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230706.3 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23354.4 -> To Version 1.0.0-prerelease.23356.3 * Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230707.5 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23354.4 -> To Version 1.0.0-prerelease.23357.5 * Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230708.5 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23354.4 -> To Version 1.0.0-prerelease.23358.5 * Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230709.2 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23354.4 -> To Version 1.0.0-prerelease.23359.2 * Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230710.7 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23354.4 -> To Version 1.0.0-prerelease.23360.7 * Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20230711.5 optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23354.4 -> To Version 1.0.0-prerelease.23361.5 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Expanding error message in dotnet#46926 * Removing unnecessary code.

@eiriktsarpalis

* Update dependencies from https://github.com/dotnet/arcade build 20230629.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23328.2 -> To Version 8.0.0-beta.23329.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23319.1 -> To Version 1.0.0-beta.23326.1 (parent: Microsoft.DotNet.Arcade.Sdk * Update dependencies from https://github.com/dotnet/sdk build 20230630.3 Microsoft.DotNet.ApiCompat.Task From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-preview.7.23330.3 * Update dependencies from https://github.com/dotnet/llvm-project build 20230630.2 runtime.linux-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-musl-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.linux-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.ObjWriter , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-arm64.Microsoft.NETCore.Runtime.ObjWriter , runtime.win-x64.Microsoft.NETCore.Runtime.JIT.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.ObjWriter From Version 14.0.0-alpha.1.23326.1 -> To Version 16.0.5-alpha.1.23330.2 * Update dependencies from https://github.com/dotnet/arcade build 20230630.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23328.2 -> To Version 8.0.0-beta.23330.1 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23314.2 -> To Version 8.0.0-beta.23328.1 (parent: Microsoft.DotNet.Arcade.Sdk * Update dependencies from https://github.com/dotnet/sdk build 20230630.15 Microsoft.DotNet.ApiCompat.Task From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-preview.7.23330.15 * Update dependencies from https://github.com/dotnet/runtime build 20230630.6 Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json From Version 8.0.0-preview.7.23325.2 -> To Version 8.0.0-preview.7.23330.6 * Update dependencies from https://github.com/dotnet/arcade build 20230703.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23328.2 -> To Version 8.0.0-beta.23353.2 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23314.2 -> To Version 8.0.0-beta.23330.1 (parent: Microsoft.DotNet.Arcade.Sdk * Update dependencies from https://github.com/dotnet/icu build 20230703.1 Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.7.23326.2 -> To Version 8.0.0-preview.7.23353.1 * Update dependencies from https://github.com/dotnet/hotreload-utils build 20230703.3 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 8.0.0-alpha.0.23326.2 -> To Version 8.0.0-alpha.0.23353.3 * Update dependencies from https://github.com/dotnet/sdk build 20230704.2 Microsoft.DotNet.ApiCompat.Task From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-preview.7.23354.2 * Update dependencies from https://github.com/dotnet/runtime-assets build 20230705.1 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 8.0.0-beta.23326.1 -> To Version 8.0.0-beta.23355.1 * Update dependencies from https://github.com/dotnet/emsdk build 20230705.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.7.23326.1 -> To Version 8.0.0-preview.7.23355.1 * Update dependencies from https://github.com/dotnet/sdk build 20230705.4 Microsoft.DotNet.ApiCompat.Task From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-preview.7.23355.4 * Update dependencies from https://github.com/dotnet/sdk build 20230706.6 Microsoft.DotNet.ApiCompat.Task From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-preview.7.23356.6 * Update dependencies from https://github.com/dotnet/arcade build 20230706.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23328.2 -> To Version 8.0.0-beta.23356.1 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23314.2 -> To Version 8.0.0-beta.23330.1 (parent: Microsoft.DotNet.Arcade.Sdk * Update dependencies from https://github.com/dotnet/sdk build 20230707.1 Microsoft.DotNet.ApiCompat.Task From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-preview.7.23357.1 * Update dependencies from https://github.com/dotnet/arcade build 20230707.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23328.2 -> To Version 8.0.0-beta.23357.3 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23314.2 -> To Version 8.0.0-beta.23355.1 (parent: Microsoft.DotNet.Arcade.Sdk * Update dependencies from https://github.com/dotnet/sdk build 20230707.13 Microsoft.DotNet.ApiCompat.Task From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-preview.7.23357.13 * Update dependencies from https://github.com/dotnet/arcade build 20230710.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23328.2 -> To Version 8.0.0-beta.23360.1 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23314.2 -> To Version 8.0.0-beta.23358.1 (parent: Microsoft.DotNet.Arcade.Sdk * Update dependencies from https://github.com/dotnet/runtime build 20230709.3 Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json From Version 8.0.0-preview.7.23325.2 -> To Version 8.0.0-preview.7.23359.3 * Update dependencies from https://github.com/dotnet/sdk build 20230710.1 Microsoft.DotNet.ApiCompat.Task From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-preview.7.23360.1 * reenable json reflection * Move setting to test project template * Update dependencies from https://github.com/dotnet/arcade build 20230710.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23328.2 -> To Version 8.0.0-beta.23360.4 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23314.2 -> To Version 8.0.0-beta.23359.1 (parent: Microsoft.DotNet.Arcade.Sdk * Update dependencies from https://github.com/dotnet/icu build 20230710.1 Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.7.23326.2 -> To Version 8.0.0-preview.7.23360.1 * Update dependencies from https://github.com/dotnet/xharness build 20230710.3 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.23326.1 -> To Version 8.0.0-prerelease.23360.3 * Update dependencies from https://github.com/dotnet/runtime-assets build 20230710.1 Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData From Version 8.0.0-beta.23326.1 -> To Version 8.0.0-beta.23360.1 * Update dependencies from https://github.com/dotnet/hotreload-utils build 20230710.1 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 8.0.0-alpha.0.23326.2 -> To Version 8.0.0-alpha.0.23360.1 * Update dependencies from https://github.com/dotnet/cecil build 20230710.2 Microsoft.DotNet.Cecil From Version 0.11.4-alpha.23327.1 -> To Version 0.11.4-alpha.23360.2 * Update dependencies from https://github.com/dotnet/sdk build 20230711.2 Microsoft.DotNet.ApiCompat.Task From Version 8.0.100-preview.7.23329.3 -> To Version 8.0.100-preview.7.23361.2 * Moving JsonSerializerIsReflectionEnabledByDefault to only be set in the tests that need it. * Update Version.Details.xml * Update Versions.props * Enable the reflection serializer for EAT builds * Update dependencies from https://github.com/dotnet/arcade build 20230711.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23328.2 -> To Version 8.0.0-beta.23361.1 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23314.2 -> To Version 8.0.0-beta.23360.2 (parent: Microsoft.DotNet.Arcade.Sdk * Update dependencies from https://github.com/dotnet/emsdk build 20230711.2 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.7.23326.1 -> To Version 8.0.0-preview.7.23361.2 * move the JsonSerializerIsReflectionEnabledByDefault to tests.wasm.targets * [wasm] WBT: Fix breaking tests `Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations` broke with the latest sdk: `/root/helix/work/workitem/e/dotnet-latest/sdk/8.0.100-preview.7.23362.1/Roslyn/Microsoft.CSharp.Core.targets(80,5): error MSB6004: The specified task executable location "/root/helix/work/workitem/e/dotnet-latest/dotnet/dotnet" is invalid.` This was because dotnet/roslyn#68918 changed to expect `DOTNET_ROOT` to be a directory instead of the exe path. * Update tests.wasm.targets * [wasm] set JsonSerializerIsReflectionEnabledByDefault unconditionally feedback from @eiriktsarpalis * Update eng/testing/tests.wasm.targets Co-authored-by: Eric Erhardt <[email protected]> * Json Trimming tests use DisabledProperties * [wasm] WBT: Set DOTNET_ROOT for tests * [wasm] WBT: Set DOTNET_ROOT explicitly in the helix environment The `NonWasmTemplateBuildTests` avoid using the default environment variables used for all other tests, which includes `DOTNET_ROOT`. Set `DOTNET_ROOT` explicitly in the helix setup script for windows, so we always have a fallback. ``` Wasm.Build.Tests.NonWasmTemplateBuildTests.NonWasmConsoleBuild_WithoutWorkload(config: "Debug", extraBuildArgs: "", targetFramework: "net6.0") [FAIL] Expected 0 exit code but got 1: C:\helix\work\workitem\e\dotnet-none\dotnet.exe build -restore -c Debug -bl:C:\helix\work\workitem\uploads\xharness-output\logs\nonwasm_net6.0_Debug_iyhtgmvj.uu4.binlog -f net6.0 Standard Output: [] MSBuild version 17.8.0-preview-23361-03+5ab64ed27 for .NET [] Determining projects to restore... [] Restored C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj (in 820 ms). [] Determining projects to restore... [] Restored C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj (in 11.21 sec). [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(314,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : You must install or update .NET to run this application. [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : App: C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\bincore\csc.dll [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : Architecture: x64 [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : Framework: 'Microsoft.NETCore.App', version '8.0.0-preview.7.23361.9' (x64) [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : .NET location: C:\helix\work\correlation\dotnet-cli\ [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : The following frameworks were found: [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : 8.0.0-preview.5.23280.8 at [C:\helix\work\correlation\dotnet-cli\shared\Microsoft.NETCore.App] [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : Learn more: [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : https://aka.ms/dotnet/app-launch-failed [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : To install missing framework, download: [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] C:\helix\work\workitem\e\dotnet-none\sdk\8.0.100-preview.7.23362.1\Roslyn\Microsoft.CSharp.Core.targets(80,5): error : https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0-preview.7.23361.9&arch=x64&rid=win10-x64 [C:\helix\work\workitem\e\wbt\nonwasm_net6.0_Debug_iyhtgmvj.uu4\nonwasm_net6.0_Debug_iyhtgmvj.uu4.csproj] [] ``` --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Larry Ewing <[email protected]> Co-authored-by: Sven Boemer <[email protected]> Co-authored-by: Eric Erhardt <[email protected]> Co-authored-by: Viktor Hofer <[email protected]> Co-authored-by: Ankit Jain <[email protected]>

I don't know anything about this file but when I build illink.sln this file is modified. I'm guessing these changes should be checked in?

…t#88786)

…on (dotnet#88665) Liveness takes a few shortcuts that means it doesn't always handle the case where there is no remainder as the remainder dying, so add a special case in StructDeaths::IsRemainderDying to take care of this case. Some minor improvements from more last-use copy omission are expected.

* Remove DelegateInvokeStubManager All Delegate Invoke scenarios now use the StubLinker. This means there is an inherent confusion between the two stub managers. Upon further inspection combining these two by adding a new flag on the Stub class means they can be combined logically and simplify the code path by removing a StubManager.

These are papercuts but since we have the mechanism for this...

This is another attribute that Roslyn uses for its own purposes only.

Fixes dotnet#74549.

…vicing (dotnet#88707) * Fixes dotnet#42961 Enable strict mode comparison during servicing when `ApiCompatNetCoreAppBaselineVersion` is the current .NET version. When the GA targeting pack is released, that property should be updated which will turn on strict mode comparison and prohibits the addition of new API. Suppressing one error in the baseline file that showed-up because out-of-band assemblies now being passed in as assembly references. While at it I also cleaned-up how private assemblies are handled during the build. * PR feedback

The main goal here is to get rid of the unused `System.Linq` usings. These cause problems for our UnityLinker tests that run against mono class libraries as it requires an additional reference. We could work around it by referencing everything in the mono class libraries, which is what illink does during it's tests. That said, some of the files had a lot of unnecessary usings and I don't think it's a bad thing to clean them up anyways. Rather than hunt down the 10-20 files that were problematic I ran Rider's namespace clean up functionality on `Mono.Linker.Tests.Cases`

Co-authored-by: David Mason <[email protected]>

…net#88819)

* Add support for {ReadOnly}Memory * Address feedback * Remove unintentional comment * Register {ReadOnly}MemoryByteType as a known built-in type

…azor cleanup (dotnet#87959) * Lazy assembly loading * Satellite assembly loading * Library initializers * API cleanup * WBT for new features

…put, not hexadecimal (dotnet#88761) * Ensure DOTNET_MaxVectorTBitwidth is interpreted as a decimal based input, not hexadecimal * Use CLRConfig::LookupOptions::ParseIntegerAsBase10 instead

…>managed stubs (dotnet#88803)

)

* Ensure Vector256.Dot produces a V256 result * Apply formatting patch

…rfaceGenerator warning (dotnet#88212) The warning used to say the default is [In] for blittable arrays, when the default is [In, Out]. Reworks how Unnecessary / Not supported / supported [In, Out] diagnostic reporting is implemented. Each marshaller will decide which details are provided with the diagnostic and which attributes are unnecessary. Shares a single Strings.resx with all projects. "Com" or "LibraryImport" suffixes were added to string names that conflicted. Co-authored-by: Jeremy Koritzinsky <[email protected]>

Explicitly set DOTNET_ROOT for building performance tools.

* Add EnumBuilder implementation and other changes * Update src/libraries/System.Reflection.Emit/src/System/Reflection/Emit/EnumBuilderImpl.cs Co-authored-by: Jan Kotas <[email protected]> * Apply feedback --------- Co-authored-by: Jan Kotas <[email protected]>

duration, current requests, failed requests

This will add the missing sections of type IgnoreSection to the implicitly generated machine.config. Fix dotnet#930

* Added BEGIN and END anchors for disasm output * Fixing build * Feedback

Without holding the condition mutex, the test is starting a new thread that is signaling us back. This means that the new thread could fail to signal us back, because there could be no waiters and the test would deadlock.

…8669) Physically promoted struct locals are marked as dying when their remainder dies since all other state is stored in other locals. However, when we do this we must also mark all replacements as stale; otherwise a future struct use could skip writebacks and effectively introduce new uses, invalidating the previously marked last use bit. Fix dotnet#88616

…RGC to target older runtimes (dotnet#88457) Co-authored-by: Noah Falk <[email protected]>

Fixes dotnet/sdk#33476.

…l values into account (dotnet#88839)

Most of this is duplicated with the official docs. Point to the official docs. `IlcTrimMetadata`/`IlcGenerateCompleteMetadata` are not optimization options anymore - they aid in getting apps that have trimming warnings to work. We don't intend to support them. The rest is all documented.

…#88711) - Add a new helper for the re-abstraction case when the JIT detects an issue - In the late bound case, instead of producing an error directly, produce an IL stub and have it make the virtual stub dispatch call itself, this will fall back to the JIT implementation for re-abstraction - Tweak the late bound case to also actively detect the AmbiguousMatchException case as well and use the same helper there as well. Fixes dotnet#71414

@radical

…tnet#88685) * fix reading metadata info * remove unused comment * Adding test and fixing behavior * improve performance * addressing @radical suggestions * addressing @radical comments * addressing @radical comments

…88626) * Detect an UnsafeAccessorAttribute for method with interpreter * Change field to property * Get Kind from typed_args * define MonoUnsafeAccessorKind enum * Add the frontend for JIT * Add mono_marshal_get_unsafe_accessor_wrapper and WRAPPER_SUBTYPE_UNSAFE_ACCESSOR And the associated AOT compiler/runtime and marshaling caching boilerplate. * [interp] get the unsafe accessor wrapper * fix: skip visibility in unsafe accessor wrappers that is the whole point of them * fix: decode the length and copy the name from UnsafeAccessorAttribute The name has a length as a prefix and doesn not have a null terminator * [mini] compile wrapper * [aot] Emit unsafe accessor wrappers to the AOT image * Add the method to emit wrapper for field * Fix typo * Remove assertion for interpreter * Fix format and replace assertion with proper exception * Free the memory and throw proper NotImplementedException * Enable StaticField and Field tests Co-authored-by: Aleksey Kliger <[email protected]> Co-authored-by: Aaron Robinson <[email protected]>

* Strip trivia from tokens. Fixes dotnet#88798 * Move the trivia stripping into ContainingSyntax record constructor * Make ContainingSyntax a regular struct with a primary constructor instead of a record struct. * Fix dotnet#88867 * Suppress compiler diagnostics based on the linked issue.

…iterp (dotnet#88876) Importing the runtime's function table into compiled traces/helpers causes v8 to allocate a bunch of memory.

Add ICorDebugFunction5::DisableOpimizations with support for inliners in r2r and jit methods. Co-authored-by: Mikelle <[email protected]> Co-authored-by: Juan Sebastian Hoyos Ayala <[email protected]>

…net#88700) * Enable new analyzers CA1862, CA1864 in runtime and fix findings

This only started showing up in the ASAN PR once we had larger runtime tests after test consolidation.

This used a delegate because in the past we had multiple possible callbacks. Now the delegate callback is unnecessary. Saves 12 kB on Hello World with stack traces disabled (the delegate was the only thing keeping the `GetLdFtnReverseLookups_InvokeMap` method alive).

* Ensure that INumberBase implements IUtf8SpanFormattable * Ensure we return the rented buffers in the IUtf8SpanFormattable.TryFormat DIM * Remember to slice the utf16Destination buffer and ensure we throw if we couldn't transcode back to valid UTF-8 in the DIM * Update src/libraries/System.Private.CoreLib/src/System/Numerics/INumberBase.cs Co-authored-by: Miha Zupan <[email protected]> * Update src/libraries/System.Private.CoreLib/src/Resources/Strings.resx Co-authored-by: Dan Moseley <[email protected]> --------- Co-authored-by: Miha Zupan <[email protected]> Co-authored-by: Dan Moseley <[email protected]>

* Expose the DegreesToRadians and RadiansToDegrees APIs * Adding some comments elaborating on the Degrees/Radians conversion APIs * Update src/libraries/System.Private.CoreLib/src/System/Numerics/ITrigonometricFunctions.cs Co-authored-by: Joe4evr <[email protected]> * Fix a copy/paste error for the Half degree to radians tests --------- Co-authored-by: Joe4evr <[email protected]>

…#88847)

This change simplifies the conditon and also makes it more robust. There are situation where the IL code pointer can differ for the same method.

The AddHttpClientDefaults method supports adding configuration to all created HttpClients. The method: - Creates a builder with a null name. Microsoft.Extensions.Configuration automatically applies configuration with a null name to all named configuration. - Ensures that default configuration is added before named configuration in the IServiceCollection. This is to make it so the order of AddHttpClientDefaults and AddHttpClient doesn't matter. Default config is always applied first, then named config is applied after. This is done by wrapping the IServiceCollection in an implementation that modifies the order that IConfigureOptions<HttpClientFactoryOptions> values are added. Fixes dotnet#87914 --------- Co-authored-by: Natalia Kondratyeva <[email protected]>

… Build ID 2221896 (dotnet#88636) Co-authored-by: Alexander Köplinger <[email protected]>

@radical

) * Improve debugger performance. * Loading assembly bytes if JMC is disabled after the debugger session is started. * Fix CI. * Load symbols on demand if JMC is enabled, we don't need to spend a lot of time loading information from 149 assemblies if we will probably not need all of them. * Impriving the performance sending only metadata and not the full assembly. * Fixing compilation error on tvos * Apply suggestions from code review Co-authored-by: Ankit Jain <[email protected]> * Apply suggestions from code review Co-authored-by: Ankit Jain <[email protected]> * fix changes from code review * addressing @radical comments * addressing @radical and @lewing comments --------- Co-authored-by: Ankit Jain <[email protected]>

* stack probe * probe size on x86 * OS_PAGE_SIZE * call sysconf(_SC_PAGESIZE) unconditionally * initialize OS page in PalInit Co-authored-by: Filip Navara <[email protected]>

… with a new clrgc. (dotnet#88852)

… platforms (dotnet#87260) * Initial commit * Add runtime-ioslike-coreclr and runtime-ioslike-mono azp runs * Add support for stripping debug symbols and enabling IL stripping during AOT compilation on iOS * Use the _AppleGenerateAppBundle target from AppleBuild.targets to build the app bundle * Update the CI to use cross-build * Update the sample app to use the cross-build * Disable failing tests with OperatingSystem.Is...(). * Update perf build command for Native AOT * Update IlcToolsPath to use cross-build ilc path * Use /p:BuildNativeAOTRuntimePack=true to pick up NativeAOT assets instead of CoreCLR

* initial changes for process name * add support to get managedEntrypointAssemblyName * FB * FB2 * fix main merge issues * Using assembly location for coreclr per FB * FB * FB * FB

Add 2 interfaces for custom sync and async HttpClient loggers, and extension methods to add or remove HttpClient loggers in AddHttpClient configuration. Fixes dotnet#77312

…th JsonSerializerOptions. (dotnet#88753)

* resx * cs comments * oops

…instead (dotnet#88067) * Remove handwritten binding logic from Logging.Console; use generator instead * Address feedback * Update test * Revert "Update test" This reverts commit fa73b4edcd4a67ad195ab30a405e7f316ae34e5e. * Remove NoWarn for obsolete members; handled by emitted code * Address feedback * Apply suggestions from code review Co-authored-by: Eric Erhardt <[email protected]> --------- Co-authored-by: Eric Erhardt <[email protected]>

Add a using which was incorrectly removed because it's only necessary in NativeAOT configuration

This was fixed to a specific version (`113.0.5672.63`) because of dotnet#86919 . But trying to use latest again now.

…our tests (dotnet#88848)

…emsdk (dotnet#88827) * Update dependencies from https://github.com/dotnet/arcade build 20230712.5 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23361.1 -> To Version 8.0.0-beta.23362.5 Dependency coherency updates Microsoft.SourceLink.GitHub,Microsoft.DotNet.XliffTasks From Version 8.0.0-beta.23360.2 -> To Version 8.0.0-beta.23361.2 (parent: Microsoft.DotNet.Arcade.Sdk * Update dependencies from https://github.com/dotnet/emsdk build 20230712.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.7.23361.2 -> To Version 8.0.0-preview.7.23362.1 * Update Tools.props * Update Version.Details.xml * Suppress warning in test * Workaround for dotnet/sdk#34003 * Update dependencies from https://github.com/dotnet/xharness build 20230713.3 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.23360.3 -> To Version 8.0.0-prerelease.23363.3 * Add reference to NETStandard.Library --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Viktor Hofer <[email protected]> Co-authored-by: Elinor Fung <[email protected]>

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230712.3 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.23360.1 -> To Version 3.11.0-beta1.23362.3 * Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20230713.2 Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.23360.1 -> To Version 3.11.0-beta1.23363.2 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

…otnet-optimization build 20230712.5 (dotnet#88826) optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR From Version 1.0.0-prerelease.23361.5 -> To Version 1.0.0-prerelease.23362.5 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Enabled embedded broadcast for the following ops: and, andn, or, xor, min, max, div, mul, mull, sub, variable shiftleftlogical/rightarithmetic/rightlogical * Bug fix: JIT used to use a uniform intrinsic for bitwise operations with all data types, embedded broadcast is sensitive to input size in this case, adding a helper to let emitter aware when input size is long/ulong. * reset the instruction in the later phase when embedded broadcast is actually enabled * filter irrelevant data type in embedded broadcast There are cases when broadcast node are falsely contained by a embedded broadcast compatible node, while the data type is actually not supported Adding extra logics to avoid this situation. * update the condition on instruction reset: instructions with either long or ulong as basetype should be reset to qword instructions. * Apply format patch * Resolve reviews: make the typecheck based on broadcast node it self. * Resolve review: use `varTypeIsSmall` type check to cover all the unsupported data type in embedded broadcast. * Resolve reviews: 1. put the IsBitwiseInstruction to a proper place. 2. nit: restored unnecessary line delete.

Should be fine to do this since dotnet#88876 was merged.

…d lib (dotnet#88800)

* Add SocketsHttpHandler connection metrics * PR feedback * Improve assert around _originAuthority * Typo

Co-authored-by: Noah Falk <[email protected]>

* Propagate token list to callers by copying instead of passing an out-of-scope address * Create a temp token list when we create a temp compare state. * Update the default constructor of CompareState to set a more useful empty state that won't segfault. * Revert "Update the default constructor of CompareState to set a more useful empty state that won't segfault." This reverts commit 28b3fd5. * Fix last case of using the default constructor in prestub.cpp

…otnet#88931)

* Add System.Net.NameResolution metrics * Avoid potential race condition in test * Fix metrics counter firing twice when called from RunAsync without telemetry * Add an extra assert * More RemoteExecutor

Add support for dotnet-gcdump on Mono. New GC events consumed by dotnet-gcdump has been added to the new ep-rt-mono-runtime-provider.c source file. Disable experimental EventPipe mono profiler provider by default to preserve resources. It is possible to re-enable it by setting the following env variable, MONO_DIAGNOSTICS=--diagnostic-mono-profiler=enable.

* fixing the JITDbl2Ulng helper function. The new AVX512 instruction vcvtsd2usi uses ulong.max_value to show FPE for negative, NAN and ulong_max + 1 values. * Making changes to the library test case expected output based on the architecture. This is because we have changed the JITDbl2Ulng helper function to mimic the new IEEE compliant AVX512 instruction vcvtsd2usi. In the process, we needed to update the library test case because the default Floating Point Error (FPE) value for the new instruction is different from the default MSVC FPE value i.e. 0. * Fixing the JITDbl2Ulng helper function. Also making sure that we are not changing the library test case but the API to make sure NaN cases are handled. * reverting jitformat * Adding a truncate function to the Dbl2Ulng helper to make sure we avoid handling edge cases (-1,0) separately inside the helper. * Adding code to handle vectorized conversion for float/double to/from ulong/uint * reverting changes for float to ulong * enabling float to ulong conversion * Making change to set w1 bit for evex * merging with main. Picking up hwintrinsiclistxarh from main trying to return EA_4BYTE for INS_vcvttss2usi to make sure that we read dword and not qword for float to ulong * jit format * Splitting vcvttss2usi to vcvttss2usi32 and vcvttss2usi64. Also adding a special handling for vcvttss2usi64 to make sure we read only dword instead of qword for float to ulong conversion * undoing jitformat changes due to merge error * removing unused code and correcting throughput and latency information for vcvttsd2usi, vcvttusi2sd32/64 * correcting throughput and latency for vcvttss2usi32 and placing it with other similar instructions * formatting * formatting * updating comments * updating code for github comments. Using compIsaSupportedDebugOnly for nowayasserts and also checking for float and doubel both in lowercast for overflow and conversion to ulong * reverting to original checks for ISA supported Debug only because they are not available in release mode * running jitformat * running jitformat * combine the 2 nodes GT_CAST(GT_CAST(TYP_ULONG, TYP_DOUBLE), TYP_FLOAT) into a single node i.e. GT_CAST(TYP_ULONG, TYP_FLOAT) * merging with main and updating hwintrinsiclistxarch to take into consideration 32bit and 64 bit version of vcvttss2usi. * Changing noway_assert to assert to make sure compOpportunisticallyDependsOn only runs in debug mode. * running jitformat * Changing compOpportunisticallyDependsOn to compIsaSupportedDebugOnly in asserts aka code review changes * Making code review changes. Moving around the comOpportunisticallyDependsOn checks to make sure they are ran only if we need AVX512. These checks being costly, moving them to the innermost checks in nested if checks. * FCALL_CONTRACT should be only used on FCalls itself * Making paralle changes to JITHelper in MathHelper for native AOT * resolving regression issues * Rolling back changes for double/float -> ulong * Rolling back changes for double/float -> ulong * Reverting ouf_or_range_fp_conversion to original version * Reverting ouf_or_range_fp_conversion to original version * Reverting jithelpers.cpp to original versino * Reverting jithelpers.cpp to original version * Changind comments, reverting asserts, skipping to change node for cast * addressing review comments * Update src/coreclr/jit/morph.cpp --------- Co-authored-by: Tanner Gooding <[email protected]>

… Build ID 2222423 (dotnet#88935)

…t#88960)

* [RISC-V] Fix GitHub_17585 test failure * [RISC-V] Fix GitHub_23147 test failure * [RISC-V] Remove lvIsHfaRegArg assertion * [RISC-V] Update

…et#88932) * Fix stack overflow caused by incorrect handling of class load levels * Address code review feedback on the test

…ors (dotnet#88925) * first cut at UnsafeAccessorKind.Constructor * Implement UnsafeAccessorKind.Method and StaticMethod * remove debug output * change some asserts to BadImageFormatException * enable some tests * move CallAmbiguousMethod to a separate test case * Fixup error checking; forbid generics * match CoreCLR: callvirt for instance methods call for static * fixups to pass new tests from dotnet#88268 * Make CallCtorAsMethod tests work Co-authored-by: Aaron Robinson <[email protected]>

* Update dependencies from https://github.com/dotnet/roslyn build 20230629.1 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.7.0-2.23319.4 -> To Version 4.7.0-3.23329.1 * Update dependencies from https://github.com/dotnet/roslyn build 20230710.7 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.7.0-2.23319.4 -> To Version 4.7.0-3.23360.7 * Update dependencies from https://github.com/dotnet/roslyn build 20230711.9 Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.7.0-2.23319.4 -> To Version 4.7.0-3.23361.9 * Disable InlineArrayInvalid due to dotnet#88861 * Disable InlineArrayValid also due to Issue: dotnet#88957 ``` /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(184,28): error CS1061: '(object, short)' does not contain a definition for 'o' and no accessible extension method 'o' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(185,28): error CS1061: '(object, short)' does not contain a definition for 's' and no accessible extension method 's' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(201,20): error CS1061: '(object, short)' does not contain a definition for 'o' and no accessible extension method 'o' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(202,20): error CS1061: '(object, short)' does not contain a definition for 's' and no accessible extension method 's' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(209,36): error CS1061: '(object, short)' does not contain a definition for 'o' and no accessible extension method 'o' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(210,40): error CS1061: '(object, short)' does not contain a definition for 's' and no accessible extension method 's' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(232,40): error CS1061: '(object, short)' does not contain a definition for 'o' and no accessible extension method 'o' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(233,44): error CS1061: '(object, short)' does not contain a definition for 's' and no accessible extension method 's' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(245,20): error CS1061: '(object, short)' does not contain a definition for 'o' and no accessible extension method 'o' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(246,20): error CS1061: '(object, short)' does not contain a definition for 's' and no accessible extension method 's' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(253,36): error CS1061: '(object, short)' does not contain a definition for 'o' and no accessible extension method 'o' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(254,40): error CS1061: '(object, short)' does not contain a definition for 's' and no accessible extension method 's' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(259,20): error CS1061: '(object, short)' does not contain a definition for 'o' and no accessible extension method 'o' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(260,20): error CS1061: '(object, short)' does not contain a definition for 's' and no accessible extension method 's' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(294,29): error CS0306: The type 'Span<object>' may not be used as a type argument [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(294,29): error CS0193: The * or -> operator must be applied to a pointer [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(295,31): error CS0306: The type 'Span<object>' may not be used as a type argument [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(295,30): error CS0193: The * or -> operator must be applied to a pointer [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(309,14): error CS0306: The type 'Span<object>' may not be used as a type argument [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(309,13): error CS0193: The * or -> operator must be applied to a pointer [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(429,43): error CS1061: '(object, short)' does not contain a definition for 'o' and no accessible extension method 'o' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.cs(430,47): error CS1061: '(object, short)' does not contain a definition for 's' and no accessible extension method 's' accepting a first argument of type '(object, short)' could be found (are you missing a using directive or an assembly reference?) [/__w/1/s/src/tests/Loader/classloader/InlineArray/InlineArrayValid.csproj] [/__w/1/s/src/tests/build.proj] /__w/1/s/src/tests/Common/dir.traversal.targets(25,5): error : (No message specified) [/__w/1/s/src/tests/build.proj] [/__w/1/s/src/tests/build.proj] ``` --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Larry Ewing <[email protected]> Co-authored-by: Ankit Jain <[email protected]>

…714.2 (dotnet#88947) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 8.0.0-beta.23362.5 -> To Version 8.0.0-beta.23364.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* Fix GCDesc computation dotnet#86877 appears to have introduced a bug in the GCDesc computation. Consider the following structure layout (we are on 32 bit): struct { int X1; int X2; Object Obj; int X3; } Crucially, the object reference in this struct is placed at a non-zero offset, which means that in an array GCDesc, sizeof(X1 + X2) aka 8 will be added to the "base size" of the object. Since we have one and only series (of GC pointers), it will also be the last. Its "skip" was computed as: bitfield.Count (4) - last (3) = 1 Which is clearly incorrect, as we need to skip 3 pointers when considering the shifted array layout: <Obj, X3][X1, X2, Obj, X3][X1, X2, Obj, X3]... | | [Correct skip] In effect, for the last series, we must consider the skip to include the delta we have included into the base size, which code before dotnet#86877 did, although wrongly - for MD arrays - as well. This change restores a fixed version of it. * Add a test Verified to fail (hit a GC assert) before and pass after. * (actually make it compile)

NativeAOT uses code from ILLinker - specifically we share lot of tests. So if these change we want to make sure it didn't break their usage in NativeAOT. The comment change in the tests is to trigger this new rule in the CI - but we can keep the comment regardless.

…tnet#88655) * Add support for devices in processinfo3 test * Add support for android portable RID OS

…nput (dotnet#88836) New versions of the compiler will introduce new nodes and values. The analyzer can never be 100% in sycn with the compiler, so it needs to be able to gracefully handle nodes it doesn't know anything about. Change the several throws to just Debug.Fail. For end-users if we hit unrecognized node, we will effectively ignore that part of the code. So not 100% precise, but the analyzer will never be 100% regardles. This is in response to dotnet#88684, but we can't add tests for it yet because the necessary compiler changes are in Preview 6, the repo is still on Preview 5.

Co-authored-by: Adam Sitnik <[email protected]> Co-authored-by: Jeremy Barton <[email protected]>

…dotnet#88980) * WBT: Move some common methods to TestUtils.cs * WBT: Add new project type specific base classes for the tests .. derived from `BuildTestBase. * WBT: Move blazor specific code from BuildTestBase into .. BlazorWasmProjectProvider, and BlazorWasmTestBase. This commit avoids doing any cleanup, and just moves code around. * WBT: Move more code from BuildTestBase to the respective provider, and test classes * WBT: use field for buildenvironment * Move blazor files to Blazor/ * move WasmTemplateTests.cs * fix build * Move StatFiles to provider * Fix build * fix build * Fix wasi build * WBT: Update list of tests * Fix UnixFilePermissions test to account for the emscripten cache package

…6841)

dotnet#88864) Adds UseSocketsHttpHandler extension method for IHttpClientBuilder to set SocketsHttpHandler as a primary handler for a named HttpClient. Adds ISocketsHttpHandlerBuilder to configure the handler from IConfiguration and/or via a callback. The API is .NET 5.0+ only. Fixes dotnet#84075

…6715)

Turns out the JIT will not box in tier 1, this was trying to optimize tier 0 code.

@wfurt

* Added QuicException.TransportErrorCode * Code review by Tomas Weinfurt @wfurt * @ManickaP Marie Píchová code review * @ManickaP Marie Píchová code review * @ManickaP Marie Píchová code review * Feedback about error code casts --------- Co-authored-by: ManickaP <[email protected]>

…tnet#88999)

The assignment `bool canSwitchIgnoreCaseToCaseSensitive = ignoreCase;` can just be `bool canSwitchIgnoreCaseToCaseSensitive = true;` since we're just tested that value a couple lines up

both inputs are equal here so if one of them is non ASCII, then the other one is too

…hies. (dotnet#88916)

…0714.11 (dotnet#88997) Microsoft.NET.ILLink.Tasks , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , runtime.native.System.IO.Ports , System.Text.Json From Version 8.0.0-preview.7.23359.3 -> To Version 8.0.0-preview.7.23364.11 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

…" (dotnet#89022) This reverts commit 3fc0f5f.

…otnet#88871) * Enable ExtendedProtectionPolicy in generic System.Net.Security build (used on browser) * Update tests

* Add SocketsHttpHandler requests-queue-duration metrics * Use the IsDefaultPort helper in more places * PR feedback * Simplify queueStartingTimestamp logic in Http3Connection

* Relaxing IsConnected Check for Datagram Sockets * Adding Listener inside Test * Add relaxing to every Connect Path and invert condition to SocketType.Stream * Make test theory and pass ipv4 ipv6 data * Add LoopbacksAndAny * Fix forgotten usage of parameter * Handle OSX case * Review feedback

…uild 20230714.2 (dotnet#88948) Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers From Version 3.11.0-beta1.23363.2 -> To Version 3.11.0-beta1.23364.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* [Mono] Add coreclr_shutdown to mono There was a crash seen in netcordbg due to unavailability of coreclr_shutdown in mono. Implemented it for mono. --------- Co-authored-by: Giridhar Trivedi <[email protected]>

* Add JsonSourceGenerationOptions.UseStringEnumConverter. * Fix failing tests in browser-wasm

…89016) This ignore is pointless. `#if` cannot be used to ignore a test. Tests are collected from whatever version of `Mono.Linker.Tests.Cases` is handy. It could be a net7 build. It could be net471.

… since being made netfx only and now fails due to etw feature removal logic no longer existing. (dotnet#89017) This test dates back to earlier days when the linker had few mechanisms that modified bodies and UnityLinker had many. I added this test to make sure that test framework support for this attribute didn't break since we depended on it. Now days, the linker has many mechanisms that modify bodies and `[ExpectBodyModified]` is heavily used in tests. I don't think there is any value in updating this test to use a different code pattern that results in needing `[ExpectBodyModified]`.

…t#89025) * Checking that BrowserDebugProxy is waiting for this new format to avoid incompatibility * Fix compilation error * fix message format * Fix indentation

* Add collection literal support for immutable collections Add the CollectionBuilderAttribute and use it on the supported immutable collections * Address feedback

* Prevent Arm64 CrossDac builds running on Arm64. Currently, when building the CLR on win-arm64, CrossDac builds for Linux with an (incorrect) host arch of x64 are attempted, failing the build. This patch prevents those builds running on systems with an identical host architecture to the cross target. * Revert to simpler strategy of simply ignoring when arch != x86|x64.

I ran it over runtime, and the only things flagged were for exceptional cases where it's not worth using. Rather than a bunch of suppressions, I'm just enabling it as info-level.

…ry if the default is failed (dotnet#88851) * Register a callback to AssemblyLoadContext.Default.ResolvingUnmanagedDll event that tries to load other libraries * Do not throw when library not found * Check version 2.6 first

* wrap exceptions from callbacks in QuicError.CallbackError * feedback

…ble data streams (dotnet#88280) * Fix regression introduced by dotnet#84279 preventing PAX entries with really long data streams to get its size correctly stored in the extended attributes when the data stream is unseekable. * Move tests for large files to a new manual tests project.

…hs. (dotnet#88532) * Lib upgrade for ToUtf16 * Upgrade NarrowUtf16ToAscii with Vector512 * Complete the upgrade in NarrowUtf16ToAscii method with Vector512 and Vector256 APIs. * Adding VectorXX paths to `GetIndexOfFirstNonAscii` functions. * Adding optimization to Vecto256 VectorContainsNonAsciiChar method. * Code path refactoring and cleanup. * Code changes based on the review: 1. turn some variables into explicitly specified const. 2. removed some helper functions and inlined them. * Resolve comments * revert the changes at GetIndexOfFirstNonAsciiByte --------- Co-authored-by: Ruihan-Yin <[email protected]>

…t#89050)

…88802) * Remove createdump's DAC dependency for the PAL for NativeAOT * Code review feedback - use utf16 mini pal functions * Fix OSX build break * Code review feedback

* ntlm * test base * qpack * FileSys * JSON * interp tests * fix NTAuthentication leak * More in JSON * more tests * ntlmserver disposable * more tests * more tests * tar tests * feedback

Tracking: dotnet#84911

…assertions in this test. No other tests in the `PreserveDependencies` folder have kept attributes inside of `#if NETCOREAPP` (dotnet#89041) `DynamicDependencyOnUnusedMethodInNonReferencedAssemblyWithCopyUsedAction` is the same scenario and doesn't need the #ifs either

When the runtime needs to turn some kinds of signals into managed exceptions (for example: SIGINT turns into `new ExecutionEngineException ("Interrupted (SIGINT)")`, and some SIGFPE turn into `DivideByZeroException`, and some SIGSEGV turn into a `NullReferenceException`) instead of unwinding the stack from inside a signal handler it instead adjusts the normal stack so that when the signal handler returns, execution will resume in `handle_signal_exception`. That means that if the runtime was in GC Safe mode when the signal was raised, even if the signal handler code transitions to GC Unsafe mode, by the time the `handle_signal_exception` runs, we will have undone the GC Unsafe transition and will be back in GC Safe. That means if the code in `handle_signal_exception` (notably `mono_handle_exception`) calls anything that tries to do a transition to GC Safe, we may get an assertion. Fixes dotnet#88405

* Enable AddressSanitizer in CoreCLR, Libs, and Host and update runtime-sanitized to run tests with ASAN on Linux and Mac * Unify on HAS_ADDRESS_SANITIZER define name Centralize setting up sanitizer flags. Remove last usage of CLR_CMAKE_ENABLE_ASAN outside of eng/native Remove unnecessary diffs Use the cpuid intrinsic and enable ASAN on InitJitHelpers1. Add comments for the places where we have ASAN disabled Undo changes to src/coreclr/jit/CMakeLists.txt Add docs and fix the docs in the build script. Add docs for the SkipVCEnvInit hook * Remove CRT runtime changes. We won't need this when we finally onboard to Windows with some changes they have coming down the pipeline, so remove them for now to reduce the diff of this PR. * Remove suppression now that we've fixed the underlying issue. * Remove some Windows-only sanitizer CMake that we won't need when ASAN is ready for us to consume on Windows. * Set schedule for runtime-sanitized pipeline * Remove workaround in JIT memory set/copy helpers now that the JIT bug has been fixed. * Add missing helix queues setup template. * Fix missing command to build nativeaot runtime tests as nativeaot. * Add a scenario name to trigger the extended timeout in the libraries test helix configuration. * Remove extraneous whitespace. * Fix using the cross-targetting ILC when sanitizers are enabled. Also pass through our TargetOS and TargetArchitecture variables to the publish command for our native sanitizers targets to correctly do their extra logic. * Disable LSAN on the CustomMain test. * Disable some tests on sanitized runtimes. * Copy the sanitizer runtime for OSX NativeAOT runtime tests. * A little cleanup to try to get the build right now that we are always doing cross-builds on Linux. * Fix crossgen-corelib.proj syntax. * Fix cross-os dac builds to not include the host architecture in the output path. * Split the debugger components into a separate component and make the "unsanitized cross components" build into an "unsanitized debugger components" build as it can't be part of the regular cross-components build * Always write out the host-arch path on Windows and update the cross-dac build script to expect that. * Change to use the dynamic runtime on Windows, as ASAN in VS is moving to a dynamic-only model. * Update docker images to include the sanitizer runtimes in the crossrootfs images. * Fix explicit image tags * The unsanitized build should be of the target architecture, not the host architecture. As a result, we still need a cross-arch build for the cross-arch use cases when sanitized, as well as an unsanitized target arch build for the debugger tools. * Turn off using the sigaltstack for NativeAOT tests that don't use the asansupport.cpp default options * Make sure the shared ASAN runtime is present for the nativeaot/SmokeTests/SharedLibrary test. * Disable crossgen2 tests with sanitizers as they don't get us interesting coverage. * Fix custom default options and disable some more crossgen2-based tests. * Simplify lookup of asan runtime on mac and fix copying the shared runtime for the SharedLibrary NativeAOT test. * Disable test that's failing for weird reasons. * Fix one more alloc-dealloc mismatch that only started to show up after test merging increased allocations in the runtime * Disable the System.Text.Json test suite on sanitized builds as it causes SO failures on Mac * Fix test exclusion * PR feedback. * Fix mac build * Do review changes * Add libbootstrapper object files to the platform manifest now that NativeAOT has * Disable tests that check size on sanitized builds * Use the built-in `include_guard` option * Disable use-after-return checking in ASAN. CoreCLR doesn't do well with parallel stacks. * Only pass the no UAR flag on C and CXX with Clang (not AppleClang).

… Build ID 2224107 (dotnet#89058) * Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2223937 * Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2223937

The core of the change is that `UnsafeAccessor` creates a code dependency from the accessor method to the target specified by the attribute. The trimmer needs to follow this dependency and preserve the target. Additionally, because the trimmer operates at the IL level, it needs to make sure that the target will keep its name and some other properties intact (so that the runtime implementation of the `UnsafeAccessor` can still work). Implementation choices: * The trimmer will mark the target as "accessed via reflection", this is a simple way to make sure that name and other properties about the target are preserved. This could be optimized in the future, but the savings are probably not that interesting. * The implementation ran into a problem when trying to precisely match the signature overload resolution. Due to Cecil issues and the fact that Cecil's resolution algorithm is not extensible, it was not possible to match the runtime's behavior without adding lot more complexity (currently it seems we would have to reimplement method resolution in the trimmer). So, to simplify the implementation, trimmer will mark all methods of a given name. This means it will mark more than necessary. This is fixable by adding more complexity to the code base if we think there's a good reason for it. * Due to the above choices, there are some behavioral differences: * Trimmer will warn if the target has data flow annotations, always. There's no way to "fix" this in the code without a suppression. * Trimmer will produce different warning codes even if there is a true data flow mismatch - this is because it treats the access as "reflection access" which produces different warning codes from direct access. * These differences are fixable, but it was not deemed necessary right now. * We decided that analyzer will not react to the attribute at all, and thus will not produce any diagnostics around it. The guiding reason to keep the implementation simple is that we don't expect the unsafe accessor to be used by developers directly, instead we assume that vast majority of its usages will be from source generators. So, developer UX is not as important. Test changes: * Adds directed tests for the marking behavior * Adds tests to verify that `Requires*` attributes behave correctly * Adds tests to verify that data flow annotations behave as expected (described above) * The tests are effectively a second validation of the NativeAOT implementation as they cover NativeAOT as well. Fixes in CoreCLR/NativeAOT: This change fixes one bug in the CoreCLR/NativeAOT implementation, unsafe accessor on a instance method of a value type must use "by-ref" parameter for the `this` parameter. Without the "by-ref" the accessor is considered invalid and will throw. This change also adds some tests to the CoreCLR/NativeAOT test suite. Part of dotnet#86161. Related to dotnet#86438. Feature design in dotnet#81741.

* Add switch: Do not resolve URLs by defaults for XML * feedback, test * rename switch per API review * Apply missed feedback, fix test failure * Fix typo in IgnoreEmptyKeySequences Co-authored-by: David Cantú <[email protected]> * Update src/libraries/System.Private.Xml/tests/TrimmingTests/XmlUrlResolverDefaults.IsNetworkingEnabledByDefault.cs Co-authored-by: David Cantú <[email protected]> --------- Co-authored-by: David Cantú <[email protected]>

…tnet#89046) * Improve text for OpenSsl primitives when OpenSSL is not available * Update src/libraries/System.Security.Cryptography/src/Resources/Strings.resx Co-authored-by: Stephen Toub <[email protected]> --------- Co-authored-by: Stephen Toub <[email protected]>

…net#89045)" (dotnet#89071) This reverts commit 9fedcc5.

* [RISC-V][JIT] Fix DevDiv_718151 test * Remove HFA check on RISC-V * [RISC-V][JIT] Update - Update PUTARG_SPLIT - Remove converting in PUTARG_STK

) Fixes dotnet#63159, fixes dotnet#85729.

…#89027) This PR allows an `osx-arm64` or `osx-x64` machine to produce a `mono-aot-cross` compiler that will run on the following host and create AOT images for the following targets: | Host | Target | Test App runs | |--------|--------|--------| | osx-arm64 | iossimulator-x64 | ✅ | | osx-arm64 | android-x64 | ✅ | | osx-arm64 | android-x86 | ✅ - depends on a hack for dotnet#89039 | Additionally a `linux-x64` or `linux-arm64` machine can build a `mono-aot-cross` compiler for these host/target pairs: | Host | Target | Test App runs | |--------|--------|--------| | linux-arm64 | android-x64 | ❓ | | linux-arm64 | linux_musl-x64 | ❓ | | linux-arm64 | android-x86 | ❓ | Related to dotnet#82495 * [aot][ios] Build cross-compilers targeting x64 hosted on arm64 * Use MONO_CROSS_COMPILE instead of host checks * [android][x86] Build mono-aot-cross hosted on osx-arm64 targeting android-x86 * fix build of mono-aot-cross hosted on linux-arm64 targeting android-x64 * runtime pipeline changes to build arm64 artifacts on x64 hardware * Fix linux_musl-arm64 builds --------- Co-authored-by: Jo Shields <[email protected]>

Fixes dotnet#76644, fixes dotnet#82168.

As with Debug.Assert/Fail, by default failures result in fail fasts. It's possible for other trace listeners to be plugged in instead, but there's no way to model that with nullable reference types. There's no reason Trace should be on a different plan from Debug, so this moves it to having the same annotations Debug has had for years.

* Change NegotiateAuthentication implementation to use indirection through NegotiateAuthenticationPal to the actual implementation. The PAL implementation are merged from different sources to follow the same structure: - NTAuthentication.Managed.cs -> NegotiateAuthenticationPal.Managed.cs - NTAuthentication.Common.cs + NegotiateStreamPal.Windows.cs -> NegotiateAuthenticationPal.Windows.cs - NTAuthentication.Common.cs + NegotiateStreamPal.Unix.cs -> NegotiateAuthenticationPal.Unix.cs This split allows to delete ContextFlagsPal, SafeDeleteNegoContext, and SafeFreeNegoCredentials abstractions that were used in NegotiateStreamPal. * Unify impersonation level validation between Windows and Unix pllatforms * Split managed NTLM and managed SPNEGO implementations; add UseManagedNtlm switch on Unix platforms * Remove debug cruft * Fix couple of errors in managed SPNEGO * Remove debug print * Fix message sequence in managed NTLM; remove unused method * Fix fallbacks on macOS GSSAPI * Cleanup and fallbacks for missing NTLM, GSSAPI * Adjust tests to assume that NTLM is always available on Unix * Don't claim NTLM support on Browser * Revert "Don't claim NTLM support on Browser" This reverts commit 87d0c56. * Attempt to fix the browser tests * Revert "Attempt to fix the browser tests" This reverts commit 91d7ce2. * Browser test suppression * Respect UseManagedNtlm=false on platforms without NTLM GSSAPI provider * Update src/libraries/System.Net.Security/src/System/Net/NegotiateAuthenticationPal.Unix.cs * Revert all the fallback code paths, System.Net.Security.UseManagedNtlm has to be enabled explicitly; NativeAOT on Linux Bionic does that by default because it doesn't have GSSAPI and native shim

Since dotnet/emsdk#343, we are now able to support native linux-arm64 on wasm. This change adds linux-arm64 to wasm-tools and wasi-experimental workloads.

* Build the shim assemblies as part of libs.sfx The shims build was intentionally kept out of the libs.sfx subset as some shims reference out-of-band assemblies that also need to be built. Since that change was made, the shim assemblies now don't reference all out-of-band assemblies by default anymore and instead use fine grained dependencies. Because of that, the number of out-of-band projects referenced and built as part of the shims build is much smaller (~10 projects). This fixes issues with ouf-of-band source generators not being able to target the live targeting pack. These source generators need the shims (more precisely the netstandard.dll shims) as some of the referenced Microsoft.CodeAnalysis packages don't provide a .NETCoreApp assembly. * Add fake assemblies for out-of-band type forward destinations * Fix issues with nested classes and wrong type destinations * Disable binplacing * Make stubs private * Disable symbols for stubs * Add build protection to validate API compatibility of shims

Passing arguments to bdn as `"--wasmArgs=--expose_wasm --module"` broke with the latest update. Now this gets incorrectly parsed. Instead, what works is: `--wasmArgs "--expose_wasm --module"`.

…dotnet#88833) Bumps [semver](https://github.com/npm/node-semver) from 7.3.7 to 7.5.4. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.7...v7.5.4) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…716.1 (dotnet#89077) Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.7.0-3.23361.9 -> To Version 4.7.0-3.23366.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

…p to the same version we use for all BDN tests and in BDN extensions. (dotnet#89057)

If a struct contains a byref, then it is known to be on the stack/regs (not in the heap), so GC write barriers are not required. This adds that case to lower*.cpp and attempts to make the code more similar. I didn't actually factor them (especially with a few subtle differences such as the call to `getUnrollThreshold`). This partially handles dotnet#80086. It improves the code for common cases, but since the strategy is not always used, the correctness issue in it is not completely handled. Next step is to apply the fix for that and see how bad the regressions are; this change will reduce the impact. Example: ``` C# static Span<int> Copy1(Span<int> s) => s; ``` ``` asm G_M44162_IG01: ;; offset=0000H vzeroupper ;; size=3 bbWeight=1 PerfScore 1.00 G_M44162_IG02: ;; offset=0003H vmovdqu xmm0, xmmword ptr [rdx] vmovdqu xmmword ptr [rcx], xmm0 ;; size=8 bbWeight=1 PerfScore 6.00 G_M44162_IG03: ;; offset=000BH mov rax, rcx ;; size=3 bbWeight=1 PerfScore 0.25 G_M44162_IG04: ;; offset=000EH ret ;; size=1 bbWeight=1 PerfScore 1.00 ; Total bytes of code 15, prolog size 3, PerfScore 9.75, instruction count 5, allocated bytes for code 15 (MethodHash=4d5b537d) for method ``` Platform | Overall | MinOpts | FullOpts --------------|---------|---------|--------- linux arm64 | -5,232 | -3,260 | -1,972 linux x64 | -1,142 | -750 | -392 osx arm64 | -5,732 | -3,276 | -2,456 windows arm64 | -4,416 | -2,580 | -1,836 windows x64 | -8,993 | -5,772 | -3,221 linux arm | -13,518 | -9,530 | -3,988 windows x86 | 0 | 0 | 0

…t#89079)

…tnet#89047)

Co-authored-by: Viktor Hofer <[email protected]>

Co-authored-by: Andy Ayers <[email protected]>

…uld corrupt state if there is pending send or receive operation and compression is enabled. (dotnet#87966)

…#88886) This change switches from relying on CMake to clang directly for Android library mode. The intent is to keep the number of build dependencies to a minimum.

…9105)

* Fix broken runtime tests build Follow-up on dotnet#89005 * Update build-test-job.yml * Update sfx-ref.proj

…fixes dotnet#83457 * Use Span.CopyTo(Span) in BigInteger's add and subtract In BigIntegerCalculator methods Add and Subtract, if sizes of arguments differ, after processing the part of size of the right (small) argument, there was loop of add/sub carry value. When the carry value once become zero, in fact the rest of the larger argument can be copied to the result. With this commit the second loop is interrupted when carry become zero and applies fast Span.CopyTo(Span) to the rest part. This optimization applied only when size of the greatest argument is more or equal to const CopyToThreshold introduced in this commit. This const is 8 now. See dotnet#83457 for details. Co-authored-by: Adam Sitnik <[email protected]>

* JSON: Add support for Int128, UInt128 and Half and add Number support for Utf8JsonReader.CopyString(...) * Remove parsing limits on Read and move Number support of CopyString to an internal helper * Fix AllowNamedFloatingPointLiterals on Write for Half * Specify InvariantCulture on TryParse and TryFormat Fix handling of floating-point literals on HalfConverter Remove CopyString tests related to Number support * Add test for invalid number input format * Fix net6.0 build error about missing Half.TryParse overload * Move rentedCharBuffer logic to TryParse helper * Address feedback * Disable test for OSX

…otnet#89085) In the mono build we've been setting HOST_IOS/TARGET_IOS when targeting tvOS which differs from the other runtime repo build systems and caused confusion. This aligns the defines so we only set the iOS ones on iOS and not on tvOS. Also removes mono_dl_get_system_dir() since it was not actually used.

…otnet#87583) Co-authored-by: Jan Kotas <[email protected]>

* OpenSSL ENGINE support * Remove trailing spaces on README file * Address PR feedback * Test for PNSE and run tests on all platforms supporting OSSL * Update IsOpenSslSupported * s/IsOpenSslSupported/OpenSslPresentOnSystem * Fix OpenSslNotPresentOnSystem on Windows * Add preventive OpenSslIsAvailable check for better error handling

…th Vector512 code path (dotnet#88650) * merging with main Enabling AVX512 for ASCII.Equals * Correcting defects in the new Equals for AVX512 case * Correcting defects * Upgrading ASCII.Equality.EqualsIgnoreCase * Using intrinsics in AllCharsInVectorAreAscii * Using intrinsics in AllCharsInVectorAreAscii * Removing check for AVX512F and adding a check for Vector512 because the library is not using any functions from AVX512F * Removing check for CompExactlyDependsOn(AVX512F) from AllCharsInVectorAreAscii for Vector 512. Also checking for Vector512 support and not AVX512F in ASCIIEquality.Equals * Correcting the Tloader.Count512 for ushort * resolving merge errors * Adding TLoader method for Vector512 for EqualAndAscii * Updating Load512 for WideningLoader for performance increase * addressing review comments * Addressing review changes. Changing Widen to WidenLower for Load512

…ion implementations (dotnet#89099) Earlier in .NET 8, we updated the Regex compiler and source generator to be able to vectorize a search for any set, not just simple ones. When one of the main routines couldn't be used, we emit a specialized IndexOfAny helper that uses SearchValues to search for any matching ASCII character or a Unicode character, and if it encounters a Unicode character, it falls back to a linear scan. This meant that a bunch of sets that wouldn't previously have taken these paths now do, but some of those sets have more efficient means of searching; for example, for the set `[^aA]` that searches case-insensitive for anything other than an 'A', with these scheme we'll emit a whole routine that uses SearchValues with a fallback, but we could just use IndexOfAnyExcept('A', 'a'). This fixes the compiler / source generator to prefer such helpers instead when available.

…otnet#89121) Added fields don't contribute to the class bitmap, and they also might not have their type resolved yet - move the "is from update" check before we need to access the field's type Fixes dotnet#86172 * Add regression test * [hot_reload] Check for added fields earlier in compute_class_bitmap and in mono_class_create_runtime_vtable

…oad-utils (dotnet#89075) * Update dependencies from https://github.com/dotnet/icu build 20230717.1 Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.7.23360.1 -> To Version 8.0.0-preview.7.23367.1 * Update dependencies from https://github.com/dotnet/emsdk build 20230717.1 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.7.23362.1 -> To Version 8.0.0-preview.7.23367.1 * Update dependencies from https://github.com/dotnet/hotreload-utils build 20230717.4 Microsoft.DotNet.HotReload.Utils.Generator.BuildTool From Version 8.0.0-alpha.0.23360.1 -> To Version 8.0.0-alpha.0.23367.4 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* React to HttpRequestError API changes * Use InvalidResponse for net_http_invalid_response_multiple_status_codes * Use HttpRequestError.Unknown for the rest * Add simple tests for the HttpRequestError property * Fix the inner exception being removed by mistake

Resolves dotnet#87340.

* Fix binding logic for dictionaries with complex elements * Remove interace impls not relevant to test and causing issues

…er when the "enable interop between generated COM interop and built-in COM interop" feature is enabled. (dotnet#89125)

* Fix EqualsIgnoreCaseUtf8_Scalar * revert change * Remove activeissue

…et#89082)

…net#89142) mini_init_delegate () needs to do a reverse lookup from address to method, and its possible for the address to be a static rgctx trampoline if the address is the result of mono_ldftn (). Fixes dotnet#89076.

…net#88892) * [mono] Set the 'dynamic' flag on method builders on creation so a MonoDynamicMethod is allocated instead of a MonoMethodWrapper. * [mono][interp] Fix memory leaks for interpreted dynamic methods. * Add a mempool to MonoDynamicMethod. * Modify the intepreter code to allocate from this mempool when interpreting dynamic methods.

This got broken in dotnet#74623.

dotnet#88723) - Ship a single assembly for all platforms, and have better compatibility between our AOT engines - Size of the shipped assembly for iOS-like platforms is increased by ~113Kb - The fullAOT + UseInterpreter=true configurations with Mono are now interpreting Ref.Emit generated code instead of using Reflection - To prevent size regressions with Mono xamarin/xamarin-macios#18555 needs to be merged

There were a couple things to fix 1) `PEReader` implements `IDisposable` and needs to be disposed. Not least because it is managing the lifetime of the streams opened by `File.OpenRead` calls inside `ILVerifier` 2) In order to dispose of of the pereaders, add `IDisposable` to `ILVerifier` and add a `using` to the caller that creates a new instance. (1) and (2) fix the issues with files being held open. While looking at the code, I didn't see a reason why `TryLoadAssemblyFromFolder` couldn't check the `_assemblyCache` before creating a opening a new stream and creating a new pereader. I don't think this was causing any issues. It just seemed like a harmless just-in-case change.

We need access to this during our mark step.

…dCoreAsync (dotnet#89160) * Avoid unnecessary closure in LoggingHttpMessageHandler.SendCoreAsync * Remove unnecessary closure in LoggingScopeHttpMessageHandler.SendCoreAsync

The change from dotnet#88280 caused an issue when discovering the test: ``` System.InvalidOperationException : An appropriate member 'ManualTestsEnabled' could not be found. The conditional method needs to be a static method, property, or field on the type System.Formats.Tar.Tests.ManualTestsAsync or any ancestor, of any visibility, accepting zero arguments, and having a return type of Boolean. ```

* Fix broken runtime tests build (second attempt) Continuation of dotnet#89115 * Update build-test-job.yml

@http

…et#89177) This fixes problem with posting results, where we crashed with: MONO_WASM: at System.Text.Json.ThrowHelper.ThrowInvalidOperationException_JsonSerializerOptionsNoTypeInfoResolverSpecified() at System.Text.Json.JsonSerializerOptions.MakeReadOnly() at System.Text.Json.JsonSerializerOptions.ConfigureForJsonSerializer() at System.Text.Json.JsonSerializer.GetTypeInfo(JsonSerializerOptions , Type ) at System.Text.Json.JsonSerializer.GetTypeInfo[JsonResultsData](JsonSerializerOptions ) at System.Text.Json.JsonSerializer.Serialize[JsonResultsData](JsonResultsData , JsonSerializerOptions ) at Sample.Test.GetJsonResults() at Sample.Test.GetFullJsonResults() at Sample.Test.__Wrapper_GetFullJsonResults_234275758(JSMarshalerArgument* __arguments_buffer) ManagedError@http://localhost:8781/_framework/dotnet.runtime.js:3:29628 vr@http://localhost:8781/_framework/dotnet.runtime.js:3:34757 Ao@http://localhost:8781/_framework/dotnet.runtime.js:3:52015 To/U</<@http://localhost:8781/_framework/dotnet.runtime.js:3:50790 init@http://localhost:8781/main.js:118:19 setTimeout handler*yieldBench/<@http://localhost:8781/main.js:129:49 yieldBench@http://localhost:8781/main.js:129:16 init@http://localhost:8781/main.js:108:45 setTimeout handler*yieldBench/<@http://localhost:8781/main.js:129:49 yieldBench@http://localhost:8781/main.js:129:16 init@http://localhost:8781/main.js:108:45

…ns Source gen (dotnet#89148)

…B_REF (dotnet#89088) Last-use copy omission allows the JIT to avoid creating copies of struct values that are passed implicitly by-ref when the value is a last-use of a local. When we do this we effectively address expose the local for the lifetime of the call, so we mark the local as address exposed as part of doing so. However, there is a problem where morph may reorder two uses of a such a local and break the last use information. For example, consider the following case: ``` [000015] --CXG------ ▌ CALL void Program:Foo(int,int) [000010] ----------- arg0 ├──▌ LCL_FLD int V00 loc0 [+0] [000012] --CXG------ arg1 └──▌ CALL int Program:Bar(S):int [000011] ----------- arg0 └──▌ LCL_VAR struct<S, 32> V00 loc0 (last use) ``` V00 is used both at [000010] and at [000011], the latter as a last use. Since we only address expose V00 when we get to [000011] we do not mark [000010] with GTF_GLOB_REF; the net effect is the following call args morphing, where we have reordered the two occurrences illegally: ``` [000015] --CXG+----- ▌ CALL void Program:Foo(int,int) [000037] DACXG------ arg1 setup ├──▌ STORE_LCL_VAR int V04 tmp3 [000012] --CXG+----- │ └──▌ CALL int Program:Bar(S):int [000011] -----+----- arg0 in rcx │ └──▌ LCL_ADDR long V00 loc0 [+0] [000038] ----------- arg1 in rdx ├──▌ LCL_VAR int V04 tmp3 [000010] -----+----- arg0 in rcx └──▌ LCL_FLD int (AX) V00 loc0 [+0] ``` This change fixes the problem by running a separate pass over the IR before morph to identify and address expose the candidates for last-use copy omission. The net result is then the following correct IR: ``` [000015] --CXG+----- ▌ CALL void Runtime_85611:Foo(int,int) [000039] DA--G------ arg0 setup ├──▌ STORE_LCL_VAR int V05 tmp4 [000010] ----G+----- │ └──▌ LCL_FLD int (AX) V00 loc0 [+0] [000037] DACXG------ arg1 setup ├──▌ STORE_LCL_VAR int V04 tmp3 [000012] --CXG+----- │ └──▌ CALL int Runtime_85611:Bar(Runtime_85611+S):int [000011] ----G+----- arg0 in rcx │ └──▌ LCL_ADDR long V00 loc0 [+0] [000038] ----------- arg1 in rdx ├──▌ LCL_VAR int V04 tmp3 [000040] ----------- arg0 in rcx └──▌ LCL_VAR int V05 tmp4 ``` The pass has some TP impact but it is mitigated since we only need to visit statements with GTF_CALL and since we can use the locals tree list to prune which statements we visit. Fix dotnet#85611

…t#89149)

) Use script for non-windows and powershell for windows. Use the proper path separators for non-windows and windows.

* Update dependencies from https://github.com/dotnet/emsdk build 20230718.3 Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.0-preview.7.23367.1 -> To Version 8.0.0-rc.1.23368.3 * Compute the package name from the version * Use a generated regex * Use VersionBandForManifestPackages for CI/dev versions * Update dependencies from https://github.com/dotnet/icu build 20230718.2 Microsoft.NETCore.Runtime.ICU.Transport From Version 8.0.0-preview.7.23367.1 -> To Version 8.0.0-rc.1.23368.2 * Fix band calculation --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Larry Ewing <[email protected]>

In release, code motion/compaction may lead to statements ending up in blocks that don't contain their IL offset. This can cause splitting of blocks to create meaningless IL ranges such as [057..020). Since we maintain these IL ranges on a best-effort basis, just clamp them when we do the splitting. Fix dotnet#88348

* Remove `SetupLinkerKeepDebugMembersAttribute`. This isn't supported anymore by the linker. * Remove NETCOREAPP behavior difference in debugger attribute removal tests * Move `DebuggerDisplayAttributeOnTypeWithNonExistentMethod` to the `KeepDebugMembers` folder since that is the scenario this test is testing

We implement our own `Driver.SetupContext`. Our command line parsing logic is different and we have additional command line options. In our very old revision of the upstream linker there was ``` protected LinkContext context; ``` Which we would set. This would ensure that if one of the helper methods that uses the context were called that things would all work. The most common scenario seems to be for error logging. There are many helper methods that will call `Context.LogError` and if we haven't set the `context` field by then we have a problem. We are syncing up and now the `context` field is private and there is a protected property getter, but no setter. Adding a setter was the easiest way to get our context stored in the `context` field.

…9150) * Share SourceWriter between JSON & config binding generators * Fix failing test, clean up impl, and address feedback

The additional osx-x64 and osx-arm64 legs added for NativeAOT in dotnet#89018 caused the `runtime.osx-*.Microsoft.DotNet.ILCompiler` and runtime.osx-*.runtime.native.System.IO.Ports` packages to be duplicated. This change makes sure we only publish them from one leg (the CoreCLR one).

Commits on Jul 20, 2023

Add QUIC datagram API

wegylexy committed Jul 20, 2023

Configuration menu

View commit details

Copy full SHA for b5d2ad4

Browse repository at this point

Copy the full SHA

b5d2ad4 View commit details

Browse the repository at this point in the history

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add msquic datagram support and changes from others #1

Add msquic datagram support and changes from others #1

Commits on Jul 11, 2023

Commits on Jul 12, 2023

Commits on Jul 13, 2023

Commits on Jul 14, 2023

Commits on Jul 15, 2023

Commits on Jul 16, 2023

Commits on Jul 17, 2023

Commits on Jul 18, 2023

Commits on Jul 19, 2023

Commits on Jul 20, 2023

Add msquic datagram support and changes from others #1

Are you sure you want to change the base?

Add msquic datagram support and changes from others #1

Commits on Jul 11, 2023

Commits on Jul 12, 2023

Commits on Jul 13, 2023

Commits on Jul 14, 2023

Commits on Jul 15, 2023

Commits on Jul 16, 2023

Commits on Jul 17, 2023

Commits on Jul 18, 2023

Commits on Jul 19, 2023

Commits on Jul 20, 2023