Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): postpone creation of the WSClient #1449

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Conversation

imobachgs
Copy link
Contributor

The web user interface tries to connect to the WebSocket from the very beginning (most likely
because of
network/routes.js.

This PR introduces an HTTPClient#ws method that builds the WSClient lazily so the initialization is
postponed until it is required.

Co-authored-by: Knut Alejandro Anderssen González <[email protected]>
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit 719d8a5 into master Jul 9, 2024
1 check passed
@imobachgs imobachgs deleted the postpone-wsclient branch July 9, 2024 09:37
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants