Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): add missing option to tsconfig file #1513

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Jul 30, 2024

There were a lot of Cannot write file '<path>.js' because it would overwrite input file. TypeScript complaints apparently because the lack of the outDir option in the tsconfig.json file to avoid the .js files overwrite.

This PR sets the outDir to the same directory than webpack build, although another option would be to simply exclude .js having in mind that the goal is to migrate all of them to .ts. Anyway, it's a temporary problem already solved with the mentioned outDir option.

image

@dgdavid dgdavid requested a review from imobachgs July 30, 2024 08:22
@dgdavid dgdavid merged commit fb123c5 into master Jul 30, 2024
2 checks passed
@dgdavid dgdavid deleted the fix-ts-config branch July 30, 2024 08:43
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants