Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): use queries to track progress #1504

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Conversation

imobachgs
Copy link
Contributor

Follow-up of #1439 the goal of this PR is to change the progress track to use Tanstack Query.

@imobachgs imobachgs marked this pull request as ready for review July 29, 2024 08:29
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor comments

web/src/queries/progress.ts Outdated Show resolved Hide resolved
web/src/queries/progress.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for documenting the queries. It looks good, you can merge it.

@imobachgs imobachgs merged commit 305f35f into master Jul 29, 2024
2 checks passed
@imobachgs imobachgs deleted the progress-queries branch July 29, 2024 11:46
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants