fix(web): change element wrapping core/EmptyState children #1462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The elements in the login page are rendered wrongly since #1441. That's because the
Flex
component used for wrapping thecore/EmptyState
children. It is missing the "direction" prop for telling it to layout children vertically instead of horizontally. Moreover, it looks like aStack
element is a better choice for this case.Solution
Adapt
core/EmptyState
for using an<Stack hasGutter>
instead of a<Flex>
configured to behave almost the same.Testing
Screenshots