Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live): add a SLE flavor to the live image #1475

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Jul 17, 2024

This is an attempt to handle the openSUSE and SLE installation images using a single kiwi definition.

  • Rename agama-installer-openSUSE to agama-installer.
  • Add a SLE profile.
  • Move specific packages to their own profiles.

Todo

  • Inject the proper repositories in the live image (instead of Tumbleweed-based ones).
  • Do more testing.
  • Adapt the self-update script.

@imobachgs imobachgs changed the title feat(live): add a SLE flavour to the live image feat(live): add a SLE flavor to the live image Jul 17, 2024
Copy link
Contributor

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

<package name="agama-products-opensuse"/>
<package name="grub2-branding-openSUSE" arch="aarch64,x86_64"/>
<package name="patterns-openSUSE-base"/>
<package name="ruby3.3-rubygem-agama-yast"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ruby3.3 vs. ruby3.2 packages looks ugly, but there is probably no better way... 😟

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. Quoting @jreidinger:

I think plan for SLE16 is to have suseruby instead of ruby3.3 and it will mean ruby that is supported only for suse products

@imobachgs imobachgs marked this pull request as ready for review July 18, 2024 12:05
type=rpm-md
enabled=1
enabled=0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this breaks the experimental self-update script... 🤔

Copy link
Contributor

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the --all option.

live/root/usr/bin/agama-self-update Outdated Show resolved Hide resolved
live/root/usr/bin/agama-self-update Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 71.035%. remained the same
when pulling 7762e08 on agama-installer-sle
into 6321fe0 on master.

Co-authored-by: Ladislav Slezák <[email protected]>
# configure the repositories in the Live system
# import the OBS key for the systemsmanagement OBS project
rpm --import /tmp/systemsmanagement_key.gpg
rm /tmp/systemsmanagement_key.gpg
# import the OBS key for the Devel:YaST:Agama:Head project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I was confused here, then I realized it is the internal OBS (IBS). Maybe it should be mentioned in the comment.

Copy link
Contributor

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit b66463a into master Jul 19, 2024
@imobachgs imobachgs deleted the agama-installer-sle branch July 19, 2024 11:35
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants