Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): make useProductChanges work as expected #1526

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Aug 2, 2024

By mistake, #1483 introduced a tiny bug in the useProductChanges query hook by checking the event.type against an empty string instead of the exepected ProductChanged event.

https://github.com/openSUSE/agama/pull/1483/files#diff-e671c06f4a1cefe3bef4af838681c780f2ba41356d44f72f5ce97be1b6eead66R172-R185

This PR fixes it for properly performs the software config query invalidation.

Triggering the query invalidation on the ProductChanged event.
@dgdavid dgdavid requested a review from imobachgs August 2, 2024 13:23
@dgdavid dgdavid merged commit b9a73b5 into master Aug 2, 2024
2 checks passed
@dgdavid dgdavid deleted the fix-software-query branch August 2, 2024 14:01
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants