Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): use axios instead of fetch #1530

Merged
merged 13 commits into from
Aug 7, 2024
Merged

refactor(web): use axios instead of fetch #1530

merged 13 commits into from
Aug 7, 2024

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Aug 5, 2024

  • Use axios instead of fetch as it implements a promise-based API which is better for our use case.
  • Move the logic related to interacting with the API to an API module.
  • Handle the ServiceStatusChanged signal properly.

To do

  • software
  • l10n
  • users
  • issues
  • progress
  • status

@imobachgs imobachgs requested a review from dgdavid August 6, 2024 12:00
@imobachgs imobachgs marked this pull request as ready for review August 6, 2024 12:00
dgdavid

This comment was marked as outdated.

@imobachgs imobachgs merged commit 15c0d56 into master Aug 7, 2024
2 checks passed
@imobachgs imobachgs deleted the axios branch August 7, 2024 13:20
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants