Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lidar_centerpoint): remove libtorch from centerpoint #480

Merged

Conversation

yukke42
Copy link
Contributor

@yukke42 yukke42 commented Mar 4, 2022

Related Issue(required)

#488

Description(required)

  • remove libtorch and implement the equivalent libraries for this package using c++/cuda
  • change converted onnx model format, but the pre-trained model is the same as before
  • update links to download trained models

before:

  • GPU memory: 2817MiB
  • inference time: 48.79 ± 3.78 ms

after:

  • GPU memory: 1295MiB
  • inference time: 45.43 ± 3.37 ms

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@yukke42 yukke42 force-pushed the feature/remove-libtorch-from-centerpoint branch from 3559e1b to 6d27d54 Compare March 4, 2022 07:36
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #480 (88d44c3) into main (ca59048) will decrease coverage by 10.76%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #480       +/-   ##
==========================================
- Coverage   10.76%   0.00%   -10.77%     
==========================================
  Files         712      16      -696     
  Lines       50569     402    -50167     
  Branches     6572       0     -6572     
==========================================
- Hits         5445       0     -5445     
+ Misses      40717     402    -40315     
+ Partials     4407       0     -4407     
Impacted Files Coverage Δ
.../lidar_centerpoint/lib/include/centerpoint_trt.hpp 0.00% <0.00%> (ø)
...ption/lidar_centerpoint/lib/include/cuda_utils.hpp 0.00% <ø> (ø)
...nterpoint/lib/include/pointcloud_densification.hpp 0.00% <ø> (ø)
...lidar_centerpoint/lib/include/tensorrt_wrapper.hpp 0.00% <ø> (ø)
.../lidar_centerpoint/lib/include/voxel_generator.hpp 0.00% <ø> (ø)
...tion/lidar_centerpoint/lib/src/centerpoint_trt.cpp 0.00% <0.00%> (ø)
...ion/lidar_centerpoint/lib/src/circle_nms_kernel.cu 0.00% <0.00%> (ø)
...rception/lidar_centerpoint/lib/src/network_trt.cpp 0.00% <0.00%> (ø)
...r_centerpoint/lib/src/pointcloud_densification.cpp 0.00% <0.00%> (ø)
...on/lidar_centerpoint/lib/src/postprocess_kernel.cu 0.00% <0.00%> (ø)
... and 729 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca59048...88d44c3. Read the comment docs.

@yukke42 yukke42 force-pushed the feature/remove-libtorch-from-centerpoint branch from 6d27d54 to 85fc194 Compare March 4, 2022 07:44
YamatoAndo pushed a commit to YamatoAndo/autoware.universe that referenced this pull request Mar 4, 2022
* release v0.4.0

* removed ROS1 package

Signed-off-by: mitsudome-r <[email protected]>

* Revert "removed ROS1 package"

This reverts commit e002b78f1e1ddf980ee7c4010918f1c117ff4be1.

* add COLCON_IGNORE file to all ROS1 packages

Signed-off-by: mitsudome-r <[email protected]>

* rename *.launch files to *.launch.xml

Signed-off-by: mitsudome-r <[email protected]>

* Port to ROS 2

* Fix params file paths

* Re-add autoware_state_monitor

* Update system_launch/launch/system.launch.xml

Co-authored-by: Takamasa Horibe <[email protected]>

* Add linters and missing pakcages dependencies (autowarefoundation#37)

* V0.8 system launch (autowarefoundation#51)

* tmp rename launch file

Signed-off-by: Kosuke Murakami <[email protected]>

* Add system_monitor to system.launch (autowarefoundation#72)

* Add system_monitor to system.launch

Signed-off-by: Kenji Miyake <[email protected]>

* Fix typo

Signed-off-by: Kenji Miyake <[email protected]>

* Add config file of system_monitor (autowarefoundation#115)

Signed-off-by: Kenji Miyake <[email protected]>

* Add config of diagnostic_aggregator (autowarefoundation#128)

Signed-off-by: Kenji Miyake <[email protected]>

* Add vehicle cmd gate config (autowarefoundation#136)

* Add config_file of vehicle_cmd_gate

Signed-off-by: Kenji Miyake <[email protected]>

* Add use_emergency_stop

Signed-off-by: Kenji Miyake <[email protected]>

* Rename emergency_stop to external_emergency_stop

Signed-off-by: Kenji Miyake <[email protected]>

* Fix command_gate diag

Signed-off-by: Kenji Miyake <[email protected]>

* Add use_emergency_hold arg (autowarefoundation#142)

Signed-off-by: Kenji Miyake <[email protected]>

* Fix system.launch (autowarefoundation#161)

Signed-off-by: Kenji Miyake <[email protected]>

* Revert "tmp rename launch file"

This reverts commit d1bb989eac90f43bab2af6669b00638fd2147eeb.

* fix launch file

Signed-off-by: Kosuke Murakami <[email protected]>

* fix minor bug

Signed-off-by: Kosuke Murakami <[email protected]>

* rename .yaml -> .param.yaml

Signed-off-by: Kosuke Murakami <[email protected]>

* fix invalid way to use eval

Signed-off-by: Kosuke Murakami <[email protected]>

* Add new line in yaml

* add num_disks

Signed-off-by: Kosuke Murakami <[email protected]>

* rename .yaml to .param.yaml

Signed-off-by: Kosuke Murakami <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#65)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Add missing '--'

Signed-off-by: Kenji Miyake <[email protected]>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Fix livox param name

Signed-off-by: Kenji Miyake <[email protected]>

* add clock_publisher and autoware_version (autowarefoundation#79)

* add clock_publisher and autoware_version

Signed-off-by: mitsudome-r <[email protected]>

* update package.xml

Signed-off-by: mitsudome-r <[email protected]>

* update build_depends.repos

Signed-off-by: mitsudome-r <[email protected]>

* fix CI

Signed-off-by: mitsudome-r <[email protected]>

* Split system_monitor config (autowarefoundation#98)

Signed-off-by: Kenji Miyake <[email protected]>

* add use_sim-time option (autowarefoundation#99)

* Replace doc by description (autowarefoundation#182)

Signed-off-by: Kenji Miyake <[email protected]>

* Use set_parameter for use_sim_time (autowarefoundation#198)

* Use set_parameter for use_sim_time

Signed-off-by: wep21 <[email protected]>

* Add default parameter for scenario simulator

Signed-off-by: wep21 <[email protected]>

* change system_monitor.launch.xml to launch.py (autowarefoundation#203)

* add README.md and svg files (autowarefoundation#328)

* add md and svg

* fix typo

* fix typo

* fix word

* fix typo

* add lack of things

* Update README

* fix depending packages

* fix word

* Fix pre-commit (autowarefoundation#407)

* Fix pre-commit errors

Signed-off-by: Kenji Miyake <[email protected]>

* Fix package.xml

Signed-off-by: Kenji Miyake <[email protected]>

* Update system.launch.xml (autowarefoundation#411)

* Feature/autoware api autoware versions (autowarefoundation#438)

* Add package version API

* Fix message type

* Modify api name

* use let variable in system_launch (autowarefoundation#473)

* Add sensor_model to system_launch (autowarefoundation#480)

Signed-off-by: Kenji Miyake <[email protected]>

* Change formatter to black (autowarefoundation#488)

* Update pre-commit settings

* Apply Black

* Replace ament_lint_common with autoware_lint_common

* Update build_depends.repos

* Fix build_depends

* Fix diagnostic_aggregator config path (autowarefoundation#118)

* update param

Signed-off-by: tomoya.kimura <[email protected]>

* update readme

Signed-off-by: tomoya.kimura <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: mitsudome-r <[email protected]>
Co-authored-by: Esteve Fernandez <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: Jilada Eccleston <[email protected]>
Co-authored-by: Kosuke Murakami <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Taichi Higashide <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: taikitanaka3 <[email protected]>
YamatoAndo pushed a commit to YamatoAndo/autoware.universe that referenced this pull request Mar 4, 2022
* release v0.4.0

* pointcloud_map_path form autoware_launch as optional (autowarefoundation#45)

* pointcloud_map_path form autoware_launch as optional

* add lanelet2_map_path

* use map_file argments under map_path

* Fix unnecessary "default" tag to "value"

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

* add some dependencies (autowarefoundation#54)

* Add some scenario-simulation specifiec parameters as arguments (autowarefoundation#57)

* Add some scenario-simulation specifiec parameters as arguments

* Update arg to pass 'initial_engage_state' to simple_planning_simulator

* Add new optional argument 'rviz_args'

* Rename some roslaunch arguments

* Remove unneeded arguments

* Fix typo (autowarefoundation#63)

Signed-off-by: Kenji Miyake <[email protected]>

* add obstacle avoid param (autowarefoundation#62)

* Logging simulator (autowarefoundation#65)

* Add logging_simulator.launch

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* Don't load env when launch driver is false

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* Launch vehicle description in logging simulator (autowarefoundation#67)

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* add autoware api launcher (autowarefoundation#64)

* add blocked by obstacle (autowarefoundation#68)

* Fix turn signal topic name (autowarefoundation#75)

* Revert "Fix turn signal topic name (autowarefoundation#75)" (autowarefoundation#76)

This reverts commit f384b9f7b2e59b7f048926e7eb0fe7c936f5cd3b.

* Fix namespace in autoware.rviz (autowarefoundation#78)

* Fix/turn signal topic name (autowarefoundation#77)

* removed ROS1 package

Signed-off-by: mitsudome-r <[email protected]>

* Revert "removed ROS1 package"

This reverts commit 1e33e7e3f3e839bcdf623f9e3b4b6a14dd4ec35a.

* add COLCON_IGNORE file to all ROS1 packages

Signed-off-by: mitsudome-r <[email protected]>

* rename *.launch files to *.launch.xml

Signed-off-by: mitsudome-r <[email protected]>

* Ros2 port autoware launch (autowarefoundation#35)

* [autoware_launch] port CMakelists.txt and remove COLCON_IGNORE

Signed-off-by: mitsudome-r <[email protected]>

* [autoware_launch] fix planning_simulator.launch.xml

Signed-off-by: mitsudome-r <[email protected]>

* [autoware_launch] add rviz config

Signed-off-by: mitsudome-r <[email protected]>

* [autoware_launch] first port of autoware_launch

Signed-off-by: mitsudome-r <[email protected]>

* lanuch rviz with config file

Signed-off-by: kosuke murakami <[email protected]>

* modify launch file for making psim work

Signed-off-by: kosuke murakami <[email protected]>

* add vehicle model in launch

Signed-off-by: kosuke murakami <[email protected]>

* change from vehicle_model to vehicle_param_file

Signed-off-by: kosuke murakami <[email protected]>

* [autoware_launch] add autoware_web_controller and system launch

Signed-off-by: mitsudome-r <[email protected]>

* add rosbrdige_suite to build_depends.repos

Signed-off-by: mitsudome-r <[email protected]>

* Update rviz

Signed-off-by: wep21 <[email protected]>

* update autoware.rviz

Signed-off-by: mitsudome-r <[email protected]>

* remove autoware_ros2.rviz

Signed-off-by: mitsudome-r <[email protected]>

Co-authored-by: kosuke murakami <[email protected]>
Co-authored-by: wep21 <[email protected]>

* Update rviz config for vehicle rviz plugins (autowarefoundation#41)

Signed-off-by: wep21 <[email protected]>

* Ros2 v0.8.0 fix packages (autowarefoundation#64)

* add vehicle_param_file to simple planning simulator

* add vehicle_param_file to lane change planner

* Rename ROS-related .yaml to .param.yaml (autowarefoundation#65)

* Rename ROS-related .yaml to .param.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Add missing '--'

Signed-off-by: Kenji Miyake <[email protected]>

* Rename vehicle_info.yaml to vehicle_info.param.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* Fix livox param name

Signed-off-by: Kenji Miyake <[email protected]>

* Ros2 v0.8.0 autoware launch (autowarefoundation#58)

* [autoware_launch] ros2-porting: v0.5.0 to v0.8.0

Signed-off-by: Takamasa Horibe <[email protected]>

* Cleanup autoware and logging simulator launch

* Add .xml extention

* Fix missing arguments

* Fix tag

* Fix web controller launch

Signed-off-by: wep21 <[email protected]>

* Update rviz

Signed-off-by: wep21 <[email protected]>

* [autoware_launch] Fix yaml name

Signed-off-by: wep21 <[email protected]>

* [autoware_launch] Cleanup dependencies

Signed-off-by: wep21 <[email protected]>

Co-authored-by: wep21 <[email protected]>

* [autoware_launch]: Fix missing arguments (autowarefoundation#66)

Signed-off-by: Autoware <[email protected]>

Co-authored-by: Autoware <[email protected]>

* Ros2 update v0.9.0 (autowarefoundation#67)

* Add pose history into rviz config

Signed-off-by: wep21 <[email protected]>

* add blocked by obstacle option (autowarefoundation#164)

* fix tab name (autowarefoundation#166)

* disenable ndt visualization (autowarefoundation#169)

* disenable ndt visualization

* change alpha

* dont visualize position covariance

Signed-off-by: wep21 <[email protected]>

* change global frame to map (autowarefoundation#171)

* add param (autowarefoundation#156)

Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: Taichi Higashide <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
Co-authored-by: tkimura4 <[email protected]>

* Sync with Ros2 v0.8.0 beta (autowarefoundation#71)

* update sensing launch to support aip_x1 (autowarefoundation#69)

Signed-off-by: taichiH <[email protected]>

* fix logging_simulator_bug (autowarefoundation#68)

Signed-off-by: taichiH <[email protected]>

* fix aip_x1 param (autowarefoundation#70)

Signed-off-by: taichiH <[email protected]>

Co-authored-by: Taichi Higashide <[email protected]>

* temporary disable steering angle plugin to avoid RVIZ2 to crash (autowarefoundation#76)

Signed-off-by: mitsudome-r <[email protected]>

* fix rviz settings (autowarefoundation#77)

* Points -> Squares

* disable road_lanelets

* visualize path of dynamic object

* fix durability policy of route_marker

* fix topic name

* fix topic name of check point

* fix some options about object

* add clock_publisher and autoware_version (autowarefoundation#79)

* add clock_publisher and autoware_version

Signed-off-by: mitsudome-r <[email protected]>

* update package.xml

Signed-off-by: mitsudome-r <[email protected]>

* update build_depends.repos

Signed-off-by: mitsudome-r <[email protected]>

* fix CI

Signed-off-by: mitsudome-r <[email protected]>

* Fix typo in rviz config (autowarefoundation#80)

Signed-off-by: wep21 <[email protected]>

* fixed typo and added AW_ROS2_USE_SIM_TIME setting (autowarefoundation#81)

Co-authored-by: hosokawa <[email protected]>

* Fix point size in rviz (autowarefoundation#84)

Signed-off-by: wep21 <[email protected]>

* Use sensor data qos for pointcloud (autowarefoundation#82)

Signed-off-by: Autoware <[email protected]>

Co-authored-by: Autoware <[email protected]>

* Ros2 fix topic name part1 (autowarefoundation#83)

* Fix topic name for behavior_velocity_planner

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of lane_change_planner

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name of freespace_planner

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name for freespace_planner

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix various typos in launch files (autowarefoundation#97)

* add use_sim-time option (autowarefoundation#99)

* Format launch files (autowarefoundation#178)

Signed-off-by: Kenji Miyake <[email protected]>

* Replace doc by description (autowarefoundation#182)

Signed-off-by: Kenji Miyake <[email protected]>

* Sync public repo (autowarefoundation#185)

* add tier4 usbcam (autowarefoundation#104)

* add tier4 usbcam

* change version

* tier4/ros2

* Ros2 vehicle info param server (autowarefoundation#96)

* add vehicle info param server

* delete vehicle param file

Co-authored-by: taikitanaka <[email protected]>

* Ros2 fix topic name part2 (autowarefoundation#89)

* Fix topic name for traffic_light_classifier

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name for traffic_light_visualization

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name for traffic_light_ssd_fine_detector

Signed-off-by: Takagi, Isamu <[email protected]>

Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: taikitanaka <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>

* Ros2 lsim test (autowarefoundation#186)

* Add group to launch file for var scope

Signed-off-by: Takagi, Isamu <[email protected]>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <[email protected]>

* Add use_sim_time

Signed-off-by: Takagi, Isamu <[email protected]>

* Remove pointcloud relay for localization

Signed-off-by: Takagi, Isamu <[email protected]>

Co-authored-by: Takagi, Isamu <[email protected]>

* Add vehicle info param server into logging simulator (autowarefoundation#194)

Signed-off-by: wep21 <[email protected]>

* Use set_parameter for use_sim_time (autowarefoundation#198)

* Use set_parameter for use_sim_time

Signed-off-by: wep21 <[email protected]>

* Add default parameter for scenario simulator

Signed-off-by: wep21 <[email protected]>

* Add control composed launch (autowarefoundation#201)

Signed-off-by: wep21 <[email protected]>

* add param for psim v2 (autowarefoundation#197)

* add param for psim v2

Signed-off-by: kosuke murakami <[email protected]>

* Update to pass var 'scenario_simulation' to dummy_perception_publisher

* Update dummy_perception_publisher's arg-name

Co-authored-by: yamacir-kit <[email protected]>

* Feature/porting v0.9.1 master (autowarefoundation#202)

* add simulation arg (autowarefoundation#174)

* add simulation arg

* add comment

* change arg name

* add parameter use_empty_dynamic_object_publisher into perception.launch (autowarefoundation#176)

Signed-off-by: Azumi Suzuki <[email protected]>

Co-authored-by: Yusuke FUJII <[email protected]>
Co-authored-by: s-azumi <[email protected]>

* Add vehicle info launch for setting vehicle info param (autowarefoundation#199)

* Add vehicle info launch for setting vehicle info param

Signed-off-by: wep21 <[email protected]>

* Add comment for global parameters section

Signed-off-by: wep21 <[email protected]>

* Fix year and apply format

Signed-off-by: Kenji Miyake <[email protected]>

* Remove ready vehicle info param

Signed-off-by: wep21 <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

* Remove vehicle info param server from logging simulator (autowarefoundation#211)

Signed-off-by: wep21 <[email protected]>

* Add map.launch.py (autowarefoundation#212)

* Add map.launch.py

Signed-off-by: wep21 <[email protected]>

* Update map.launch.xml

Signed-off-by: wep21 <[email protected]>

* Rename parameter for lanelet2 map path

Signed-off-by: wep21 <[email protected]>

* Exclude dummy_perception_publisher.launch.xml if is scenario_simulation (autowarefoundation#230)

* Remove clock publisher (autowarefoundation#217)

Signed-off-by: wep21 <[email protected]>

* Fixup for autowarefoundation#217 (autowarefoundation#254)

* Fixup for autowarefoundation#217

Signed-off-by: Kenji Miyake <[email protected]>

* Fix typo

Signed-off-by: Kenji Miyake <[email protected]>

* Add global_params.launch.py (autowarefoundation#260)

Signed-off-by: Kenji Miyake <[email protected]>

* Add time panel (autowarefoundation#233)

* Move global_params.launch.py and vehicle_info.launch.py to autoware_global_parameter_loader (autowarefoundation#282)

* Move global_params.launch.py and vehicle_info.launch.py to autoware_global_parameter_loader

Signed-off-by: Kenji Miyake <[email protected]>

* Add exec_depend

Signed-off-by: Kenji Miyake <[email protected]>

* add descriptions for autoware_launch autowarefoundation#329

* add README.md and svg files (autowarefoundation#328)

* add md and svg

* fix typo

* fix typo

* fix word

* fix typo

* add lack of things

* Update README

* fix depending packages

* fix word

* Add autoware api (autowarefoundation#376)

* Add external api adaptor (autowarefoundation#267)

* Add external api adaptor

* Add api adaptor to logging simulator

Signed-off-by: Takagi, Isamu <[email protected]>

* Add engage status output

Signed-off-by: Takagi, Isamu <[email protected]>

* Add internal api adaptor (autowarefoundation#273)

Signed-off-by: Takagi, Isamu <[email protected]>

* Add map hash generator (autowarefoundation#319)

Signed-off-by: Takagi, Isamu <[email protected]>

* Add autoware api launch (autowarefoundation#326)

* Add autoware api launch

Signed-off-by: Takagi, Isamu <[email protected]>

* Apply autoware api launch

Signed-off-by: Takagi, Isamu <[email protected]>

* Add deprecated comment

Signed-off-by: Takagi, Isamu <[email protected]>

* Remove unused parameter (autowarefoundation#325)

Signed-off-by: Takagi, Isamu <[email protected]>

* Add api parameter (autowarefoundation#341)

Signed-off-by: Takagi, Isamu <[email protected]>

* Add start request API (autowarefoundation#321)

* Add use start request option

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix lint

Signed-off-by: Takagi, Isamu <[email protected]>

* Feature external cmd selector heartbeat (autowarefoundation#356)

* Rename external command topic

Signed-off-by: Takagi, Isamu <[email protected]>

* Modify command topic name

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix topic name

Signed-off-by: Takagi, Isamu <[email protected]>

* Rename remote_cmd_converter

Signed-off-by: Takagi, Isamu <[email protected]>

* Remove gate mode from external command

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix latest external command name (autowarefoundation#361)

Signed-off-by: Takagi, Isamu <[email protected]>

* Fix merge conflict

Signed-off-by: Takagi, Isamu <[email protected]>

* change external traffic light topic name in behavior velocity planner (autowarefoundation#310)

* fix topic

* change internal topic name

Co-authored-by: yabuta <[email protected]>

* Feature/add virtual traffic light planner (autowarefoundation#317)

* Move autoware api launch files (autowarefoundation#387)

* Fix misspell in rviz config (autowarefoundation#392)

Signed-off-by: Takagi, Isamu <[email protected]>

* update rviz config (autowarefoundation#399)

* update rviz config

* update config

* Fix pre-commit (autowarefoundation#407)

* Fix pre-commit errors

Signed-off-by: Kenji Miyake <[email protected]>

* Fix package.xml

Signed-off-by: Kenji Miyake <[email protected]>

* Add polar grid into rviz config (autowarefoundation#458)

* Add simulator_launch package (autowarefoundation#459)

* Add simulator_launch package

* add argument

* fix depend order

* add argument

* move dummy_perception_publisher

* add arg for dummy_perception_publisher

* Update simulator_launch/launch/simulator.launch.xml

Co-authored-by: Kenji Miyake <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

* add steering angle (autowarefoundation#476)

* Move simple_planning_simulator to simulator_launch (autowarefoundation#462)

* move simple_planning_simulator

* add simulation arg to logging_simulator.launch

* delete unused argument

* add arguments for logging simulation

* change default value

* update README

* add default value to simulator arg

* restore vehicle_simulation arg

* Add sensor_model to system_launch (autowarefoundation#480)

Signed-off-by: Kenji Miyake <[email protected]>

* hide traffic light id by default (autowarefoundation#286)

Co-authored-by: satoshi-ota <[email protected]>

* Feature/porting behavior path planner (autowarefoundation#300)

* modify behavior_planning launch for behavior_path_planner with lane_c… (autowarefoundation#239)

* modify behavior_planning launch for behavior_path_planner with lane_change_only config

Signed-off-by: Takamasa Horibe <[email protected]>

* remove avoidance & side_shift related code

Signed-off-by: Takamasa Horibe <[email protected]>

* Fix launcher and add config files and change obstacle avoid param

* Add new line

* Fix visualization and remove multiple args

* Enable auto approve path change

Co-authored-by: rej55 <[email protected]>
Signed-off-by: wep21 <[email protected]>

* add param in behavior_path_planner (autowarefoundation#255)

Signed-off-by: Takamasa Horibe <[email protected]>

* Fix param (autowarefoundation#251)

* Fix typo

Signed-off-by: wep21 <[email protected]>

Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: rej55 <[email protected]>

* update rviz config & planner params (autowarefoundation#305)

Co-authored-by: satoshi-ota <[email protected]>

* Feature/porting occlusion spot (autowarefoundation#309)

* add occulusion_spot marker (autowarefoundation#266)

* add blindspot marker

* to occlusion spot slow down

* remove debug info from marker (autowarefoundation#287)

* remove debug info from marker

* remove debug arrow

* fix format

* update behavior launch

* apply pep8

* fix format

Co-authored-by: taikitanaka3 <[email protected]>

* Feature/porting camera lidar fusion (autowarefoundation#316)

* Feature/camera lidar fusion (autowarefoundation#248)

* change camera lidar fusion node

* change default mode of object recognition

* change spilit range parameter from 10 to 30 (autowarefoundation#272)

Co-authored-by: Yukihiro Saito <[email protected]>

* add underscore to marker namespace (autowarefoundation#323)

Co-authored-by: satoshi-ota <[email protected]>

* Feature/hide verbose marker (autowarefoundation#322)

* tmp : enable slow down

* hide verbose markers

* Revert "tmp : enable slow down"

This reverts commit 5ad32c5903866d9cf946cc47b0b35cefa359d502.

* update rviz tool bar

Co-authored-by: satoshi-ota <[email protected]>

* update rviz config ( add shoulder road lanelets ) (autowarefoundation#420)

* update rviz config

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Fix for pre-commit (437)

Signed-off-by: Kenji Miyake <[email protected]>

* Change formatter to black (autowarefoundation#488)

* Update pre-commit settings

* Apply Black

* Replace ament_lint_common with autoware_lint_common

* Update build_depends.repos

* Fix build_depends

* Auto/fix launch (autowarefoundation#110)

* fix namespace

* remove dynamic_object_visualization

* fix rviz

* change topic name for rviz plugin (autowarefoundation#114)

* Auto/launcher ground segmentation (autowarefoundation#117)

* add base line launch

* add ground_segmentation launcher

* run pre-commit

* clean up

* fix coding style

* fix topic name

* fix yaml params

* fix loader name

* rename components

* improve implementation

* Sync .auto branch with the latest branch in internal repository (autowarefoundation#120)

* Disbale intersection polygon marker (autowarefoundation#483)

Signed-off-by: wep21 <[email protected]>

* Merge pull request autowarefoundation#384 from tier4/feature/no_stopping_area

Feature/no stopping area

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>

* fix turn signal to indicators (autowarefoundation#123)

* fix no ground points topic name (autowarefoundation#125)

* support x1 perception config (autowarefoundation#129)

* support x1 perception config

* remove product config

* update launch.py

* maintain some filters params in yaml file

* add function to create elevation map pipeline

* add param to yaml

* fix/rviz perception config (autowarefoundation#138)

* fix/rename segmentation namespace (autowarefoundation#139)

* fix namespace: rviz config

* fix namespace: planning stack

* rename segmentatino directory

* fix namespace: perception stack

* fix/add arg in order to disable dummy_perception_publisher from command line (autowarefoundation#144)

* change topic name for predicted trajectory (autowarefoundation#145)

* feature/use common pointcloud container (autowarefoundation#147)

* add container argument

* load composable node to pointcloud_container

* fix autoware_launch

* enable multi-thread

* improve readability

* add vehicle_info_param_file

Signed-off-by: tomoya.kimura <[email protected]>

* ci(pre-commit): autofix

* fix launch files and remove api launch

Signed-off-by: tomoya.kimura <[email protected]>

* ci(pre-commit): autofix

* add initial pose relay

Signed-off-by: tomoya.kimura <[email protected]>

Co-authored-by: mitsudome-r <[email protected]>
Co-authored-by: hiroyuki obinata <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Yamasaki Tatsuya <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Kosuke Murakami <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: wep21 <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: Autoware <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: Taichi Higashide <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
Co-authored-by: HOSOKAWA Ikuto <[email protected]>
Co-authored-by: hosokawa <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: taikitanaka <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
Co-authored-by: Yusuke FUJII <[email protected]>
Co-authored-by: s-azumi <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: yabuta <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
Co-authored-by: satoshi-ota <[email protected]>
Co-authored-by: Takeshi Miura <[email protected]>
Co-authored-by: Sugatyon <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@yukke42 yukke42 force-pushed the feature/remove-libtorch-from-centerpoint branch from 85fc194 to 36fbe73 Compare March 8, 2022 02:29
@yukkysaito
Copy link
Contributor

@yukke42 pls add related PR

@yukke42
Copy link
Contributor Author

yukke42 commented Mar 16, 2022

@yukkysaito
libtorch isn't installed in https://github.com/autowarefoundation/autoware

@yukke42 yukke42 force-pushed the feature/remove-libtorch-from-centerpoint branch from 36fbe73 to fc3ad40 Compare March 16, 2022 10:27
@yukkysaito
Copy link
Contributor

@yukke42 cc @kenji-miyake
how are developpers doing without libtorch?

Does this mean that detection cannot work in https://github.com/autowarefoundation/autoware?

@yukke42 yukke42 marked this pull request as ready for review March 17, 2022 01:53
@yukke42
Copy link
Contributor Author

yukke42 commented Mar 17, 2022

@.yukke42 cc @.kenji-miyake how are developpers doing without libtorch?

Does this mean that detection cannot work in https://github.com/autowarefoundation/autoware?

@yukkysaito
We used cuda 11.1 and tensorrt 7.2.1, but https://github.com/autowarefoundation/autoware requires cuda 11.4 and tensorrt 8.2.2. (here). Perception packages requiring CUDA aren't supported yet. So, we should make sure that lidar_centerpoint and other packages, s.t. lidar_apollo_instance_segmentation, tensorrt_yolo, ..etc, work on both environment at the same time.

@yukke42
Copy link
Contributor Author

yukke42 commented Mar 17, 2022

@yukkysaito @aohsato @mkuri It's now ready for review.

@yukkysaito
Copy link
Contributor

@aohsato @mkuri can you review this PR?

@mkuri
Copy link
Contributor

mkuri commented Mar 17, 2022

@miursh ?

@miursh
Copy link
Contributor

miursh commented Mar 21, 2022

I checked it's working in my pc.
before:
GPU memory: 2819MiB
inference time: 31.94 ± 6.92 ms

after:
GPU memory: 1299MiB
inference time: 27.23 ± 6.94 ms

@wep21 wep21 force-pushed the feature/remove-libtorch-from-centerpoint branch from 05e45cb to 0c6abfb Compare March 22, 2022 08:37
@kaancolak
Copy link
Contributor

I tested it in my computer with sample-map-rosbag and it's working well.

Currently, documentation of rosbag replay simulation not working properly.

@yukke42
Copy link
Contributor Author

yukke42 commented Mar 23, 2022

I tested it in my computer with sample-map-rosbag and it's working well.

Currently, documentation of rosbag replay simulation not working properly.

@kaancolak Thank you for testing this PR.
Cloud you create an issue in https://github.com/autowarefoundation/autoware-documentation and describe the problem in more detail?

@yukke42
Copy link
Contributor Author

yukke42 commented Mar 23, 2022

build-and-test-differential / build-and-test-differential (pull_request) wasn't passed because the model failed to be downloaded from gdrive.

https://github.com/autowarefoundation/autoware.universe/runs/5640881412?check_suite_focus=true

Screenshot from 2022-03-23 09-59-35

@yukke42
Copy link
Contributor Author

yukke42 commented Mar 23, 2022

build-and-test-differential / build-and-test-differential (pull_request) wasn't passed because the model failed to be downloaded from gdrive.

https://github.com/autowarefoundation/autoware.universe/runs/5640881412?check_suite_focus=true

Screenshot from 2022-03-23 09-59-35

I will remove to check downloaded files to pass ci.

@miursh
Copy link
Contributor

miursh commented Mar 25, 2022

@wep21 Since I'm not familiar with CUDA programming, could you help me reviewing this PR?

@miursh miursh requested a review from wep21 March 25, 2022 06:32
@yukke42 yukke42 force-pushed the feature/remove-libtorch-from-centerpoint branch from 6d51384 to 88d44c3 Compare March 30, 2022 01:45
@wep21
Copy link
Contributor

wep21 commented Mar 30, 2022

@miursh I have taken a look at the part of cuda implementation, I guess there is no problem.

@wep21 wep21 self-requested a review April 5, 2022 06:05
Copy link
Contributor

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wep21 wep21 merged commit 51f7a6b into autowarefoundation:main Apr 5, 2022
@yukke42 yukke42 deleted the feature/remove-libtorch-from-centerpoint branch April 5, 2022 07:02
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* feat: remove libtorch

Signed-off-by: yukke42 <[email protected]>

* feat: postprocess cuda

Signed-off-by: yukke42 <[email protected]>

* refactor: remove densificated pointcloud publisher

Signed-off-by: yukke42 <[email protected]>

* refactor: orgainze code

Signed-off-by: yukke42 <[email protected]>

* docs: change ros params and references

Signed-off-by: yukke42 <[email protected]>

* docs: circleNMS description

* feat: warn log when no detected boxes

Signed-off-by: yukke42 <[email protected]>

* chore: update trained model links

Signed-off-by: yukke42 <[email protected]>

* refactor: not memcopy empty voxels

Signed-off-by: yukke42 <[email protected]>

* fix: disable to check downloaded files to pass ci

Signed-off-by: yukke42 <[email protected]>

* chore: change the name of Copyright

Signed-off-by: yukke42 <[email protected]>

* refactor: rename nms_kernel to circle_nms_kernel

Signed-off-by: yukke42 <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat: remove libtorch

Signed-off-by: yukke42 <[email protected]>

* feat: postprocess cuda

Signed-off-by: yukke42 <[email protected]>

* refactor: remove densificated pointcloud publisher

Signed-off-by: yukke42 <[email protected]>

* refactor: orgainze code

Signed-off-by: yukke42 <[email protected]>

* docs: change ros params and references

Signed-off-by: yukke42 <[email protected]>

* docs: circleNMS description

* feat: warn log when no detected boxes

Signed-off-by: yukke42 <[email protected]>

* chore: update trained model links

Signed-off-by: yukke42 <[email protected]>

* refactor: not memcopy empty voxels

Signed-off-by: yukke42 <[email protected]>

* fix: disable to check downloaded files to pass ci

Signed-off-by: yukke42 <[email protected]>

* chore: change the name of Copyright

Signed-off-by: yukke42 <[email protected]>

* refactor: rename nms_kernel to circle_nms_kernel

Signed-off-by: yukke42 <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat: remove libtorch

Signed-off-by: yukke42 <[email protected]>

* feat: postprocess cuda

Signed-off-by: yukke42 <[email protected]>

* refactor: remove densificated pointcloud publisher

Signed-off-by: yukke42 <[email protected]>

* refactor: orgainze code

Signed-off-by: yukke42 <[email protected]>

* docs: change ros params and references

Signed-off-by: yukke42 <[email protected]>

* docs: circleNMS description

* feat: warn log when no detected boxes

Signed-off-by: yukke42 <[email protected]>

* chore: update trained model links

Signed-off-by: yukke42 <[email protected]>

* refactor: not memcopy empty voxels

Signed-off-by: yukke42 <[email protected]>

* fix: disable to check downloaded files to pass ci

Signed-off-by: yukke42 <[email protected]>

* chore: change the name of Copyright

Signed-off-by: yukke42 <[email protected]>

* refactor: rename nms_kernel to circle_nms_kernel

Signed-off-by: yukke42 <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* feat: remove libtorch

Signed-off-by: yukke42 <[email protected]>

* feat: postprocess cuda

Signed-off-by: yukke42 <[email protected]>

* refactor: remove densificated pointcloud publisher

Signed-off-by: yukke42 <[email protected]>

* refactor: orgainze code

Signed-off-by: yukke42 <[email protected]>

* docs: change ros params and references

Signed-off-by: yukke42 <[email protected]>

* docs: circleNMS description

* feat: warn log when no detected boxes

Signed-off-by: yukke42 <[email protected]>

* chore: update trained model links

Signed-off-by: yukke42 <[email protected]>

* refactor: not memcopy empty voxels

Signed-off-by: yukke42 <[email protected]>

* fix: disable to check downloaded files to pass ci

Signed-off-by: yukke42 <[email protected]>

* chore: change the name of Copyright

Signed-off-by: yukke42 <[email protected]>

* refactor: rename nms_kernel to circle_nms_kernel

Signed-off-by: yukke42 <[email protected]>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
tkimura4 referenced this pull request in tier4/autoware.universe Oct 24, 2022
Signed-off-by: kosuke55 <[email protected]>

Signed-off-by: kosuke55 <[email protected]>
dmoszynski pushed a commit to RobotecAI/autoware.universe that referenced this pull request Jun 22, 2023
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
…utowarefoundation#480)

* refactor(tier4_localization_component): input_pointcloud param added

* style(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
* chore: add missing packages into repos

Signed-off-by: wep21 <[email protected]>

* chore: update grid map branch

Signed-off-by: wep21 <[email protected]>

* chore: update ublox branch

Signed-off-by: wep21 <[email protected]>

* remove diagnostics from repos

Signed-off-by: wep21 <[email protected]>

* remove quaternion operations

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* remove plotjuggler from repos

Co-authored-by: Kenji Miyake <[email protected]>

* remove plotjuggler_ros from repos

Co-authored-by: Kenji Miyake <[email protected]>

* remove velodyne simulator

Co-authored-by: Kenji Miyake <[email protected]>

* change Ansible branch

Signed-off-by: Kenji Miyake <[email protected]>

* update env files

Signed-off-by: Kenji Miyake <[email protected]>

* chore(repos): remove autonomoustuff packages from repos

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* update container version of setup-local-dev-env.yaml

Signed-off-by: Kenji Miyake <[email protected]>

* add ros/diagnostics

Signed-off-by: Kenji Miyake <[email protected]>

* chore(repos): remove navigation2

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* update vcs-import

Signed-off-by: Kenji Miyake <[email protected]>

* remove old CI workflow

Signed-off-by: Kenji Miyake <[email protected]>

* WIP: update calibration_tools.repos

Signed-off-by: Kenji Miyake <[email protected]>

* use upstream for grid map

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* ci: update .webauto-ci.yml (#493)

* chore: remove some packages (#566)

chore: remove released packages

Signed-off-by: Daisuke Nishimatsu <[email protected]>

Signed-off-by: Daisuke Nishimatsu <[email protected]>

Signed-off-by: wep21 <[email protected]>
Signed-off-by: Daisuke Nishimatsu <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Co-authored-by: wep21 <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Makoto Tokunaga <[email protected]>
HansOersted pushed a commit to HansOersted/autoware.universe that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants