Improve users management through the CLI (#6001) #10492

Make sure wiki editor sets wiki to true so gitea renders it as a wiki page. Also change the context data attr for edit form. This looks wrong but everywhere else in our code assumes the urlPrefix to be just the repo url when rendering and manually adds /wiki to the rendered url regardless. Fixes go-gitea#11540

Prevent the dashboard from setting an empty query parameter Fix go-gitea#11543 Signed-off-by: Andrew Thornton [email protected]

Fixes go-gitea#11295 Signed-off-by: Gary Kim [email protected]

…n is the initializer (go-gitea#11601) Fix go-gitea#10760 Signed-off-by: Andrew Thornton <[email protected]>

…tea#11565) We use same method for new issue form and issue view, but was missing from new PR view making it one place where markdown preview is inconsistent in font size.

* Update from-package.en-us.md go-gitea#10800 * Update docs/content/doc/installation/from-package.en-us.md Co-authored-by: zeripath <[email protected]> Co-authored-by: zeripath <[email protected]> Co-authored-by: techknowlogick <[email protected]>

Co-authored-by: techknowlogick <[email protected]>

@guillep2k

) * Add warning to mailer documentation about authentication References go-gitea#7966 Signed-off-by: Andrew Thornton <[email protected]> * As per @guillep2k and @mrsdizzie * as per @mrsdizzie Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: guillep2k <[email protected]>

Introduced naively by go-gitea#11463 The margin was being applied too widely.

Co-authored-by: techknowlogick <[email protected]>

* Style code review comment for arc-green * change border around review for light; update border around textarea to match go-gitea#11570 Co-authored-by: zeripath <[email protected]> Co-authored-by: techknowlogick <[email protected]>

Makes styling consistent between two cases. Also removed unnecessary double border.

Also removes stray dot and whitespace. Trying to make base message shorter; I don't envy translators, the message can easily get multi-line in English, I'm sure that is even bigger problem in other languages.

Co-authored-by: techknowlogick <[email protected]> Co-authored-by: zeripath <[email protected]>

Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>

…-gitea#11632)

When "Must Change Password" simplify the navbar header to only show the signout button as all other links will redirect back. This prevents the notifications icon from showing preventing initialization of the event-source and hence preventing redirect_to being set, however in addition do not set the redirect_to cookie if we are looking at the /user/events page. Fix go-gitea#11554 Signed-off-by: Andrew Thornton <[email protected]>

Fix alignment issue between commit SHA and commit message

…ea#11635) Fix go-gitea#11634 Signed-off-by: Andrew Thornton <[email protected]>

* add API specific InternalServerError() Co-authored-by: zeripath <[email protected]> * return 500 error msg only if not Production mode * Revert "return 500 error msg only if not Production mode" This reverts commit 8467b2c. * InternalServerError Co-authored-by: zeripath <[email protected]>

* handle GPG Parse & Email Errors * correct TEST * update Swagger * more Docu

Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]>

…a#11642) Fix go-gitea#11633 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>

* Update go-enry to v2.5.2

…#11657) * translate: Change translate for admin.config.enable_captcha add 'register' to make it more accurate Signed-off-by: a1012112796 <[email protected]> * Update options/locale/locale_en-US.ini Co-authored-by: Cirno the Strongest <[email protected]> Co-authored-by: Cirno the Strongest <[email protected]> Co-authored-by: Lauris BH <[email protected]>

needed to fix issue as described in go-gitea#10280 * rename check-db to check-db-version * add check-db-consistency: * find issues without existing repository * find pulls without existing issues * find tracked times without existing issues/pulls * find labels without repository or org reference Co-authored-by: guillep2k <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>

…imited org (go-gitea#11656) Fixes go-gitea#11651

When matching emoji, use a regex built from the data we have instead of something generic using unicode ranges. A generic regex can't tell the difference between two separate emoji next to each other or one emoji that is built out of two separate emoji next to each other. This means that emoji that are next to each other without space in between will be now accurately spanned individually with proper title etc...

We already made avatars square for .ui avatar.img class but this is not enough, and in some place Fomantic default styling still applied. This PR updates our override of radius to match all Fomantic classes.

* [FEATURE] [API] Add Endpoint for Branch Creation Issue: go-gitea#11376 This commit introduces an API endpoint for branch creation. The added route is POST /repos/{owner}/{repo}/branches. A JSON with the name of the new branch and the name of the old branch is required as parameters. Signed-off-by: Terence Le Huu Phuong <[email protected]> * Put all the logic into CreateBranch and removed CreateRepoBranch * - Added the error ErrBranchDoesNotExist in error.go - Made the CreateNewBranch function return an errBranchDoesNotExist error when the OldBranch does not exist - Made the CreateBranch API function checks that the repository is not empty and that branch exists. * - Added a resetFixtures helper function in integration_test.go to fine-tune test env resetting - Added api test for CreateBranch - Used resetFixture instead of the more general prepareTestEnv in the repo_branch_test CreateBranch tests * Moved the resetFixtures call inside the loop for APICreateBranch function * Put the prepareTestEnv back in repo_branch_test * fix import order/sort api branch test Co-authored-by: zeripath <[email protected]>

@L0veSunshine

Unfortunately go-gitea#11614 introduced a bug whereby the initial commit of a repository could not be seen due to there being no parent commit to create a clear diff from. Here we create a diffstat from the difference between the parentless SHA and the SHA of the empty tree - a constant known to git. (With thanks to @L0veSunshine for informing me of this SHA) Thanks to @a1012112796 for initial attempt to fix. Fix go-gitea#11650 Closes go-gitea#11674 Signed-off-by: Andrew Thornton <[email protected]> Co-Authored-By: L0veSunshine <[email protected]>

* Add logging to long migrations Also fix v136 to not use models Signed-off-by: Andrew Thornton <[email protected]>

* Make tabular menu styling consistent for arc-green * rework completely * transparent borders * use darker color for active item; override only colors for borders * Update web_src/less/themes/theme-arc-green.less Co-authored-by: silverwind <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: zeripath <[email protected]>

…ea#11681) * Change language statistics to save size instead of percentage in database Co-Authored-By: Cirno the Strongest <[email protected]> * Do not exclude if only language * Fix edge cases with special langauges Co-authored-by: Cirno the Strongest <[email protected]>

* Fix language stat calculation * Group languages and ignore 0 size files * remove unneeded code

Co-authored-by: techknowlogick <[email protected]>

* Narrow down Edge version in browser support docs I noticed that Edge 14 has a pretty buggy fetch implementation and because it has already reached end of support I think it's better we don't specifically state support for it, even if it may work to some extend. * mention both edge versions Co-authored-by: techknowlogick <[email protected]>

Fixes go-gitea#9369 Co-authored-by: John Olheiser <[email protected]> Co-authored-by: techknowlogick <[email protected]>

@lafriks

* Add changelog for 1.11.6 * Update CHANGELOG.md Co-authored-by: techknowlogick <[email protected]> * Update CHANGELOG.md Co-authored-by: techknowlogick <[email protected]> * Apply suggestions from @lafriks * go-gitea#11459 is bugfix Co-authored-by: Guillermo Prandi <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: Guillermo Prandi <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: techknowlogick <[email protected]>

as title needed for go-gitea#11641

Expose IsLocked Property

* log slow tests Signed-off-by: Andrew Thornton <[email protected]> * placate lint Signed-off-by: Andrew Thornton <[email protected]> * More lint placation Co-authored-by: 6543 <[email protected]> Co-authored-by: 6543 <[email protected]> Co-authored-by: techknowlogick <[email protected]>

* Update emoji dataset with skin tone variants Since the format of emoji that support skin tone modifiers is predictable we can add different variants into our dataset when generating it so that we can match and properly style most skin tone variants of emoji. No real code change here other than what generates the dataset and the data itself. * use escape unicode sequence in map Co-authored-by: techknowlogick <[email protected]>

@CirnoT

* Properly truncate system notices As noted in go-gitea#11658 the system notifications list will always suffix system notices with ... even when the notice is longer than 120 characters. Instead we should use .text.truncate to auto truncate and make the notices clickable to view their details. Signed-off-by: Andrew Thornton <[email protected]> * As per @CirnoT make table cell clickable * ensure that pre wraps Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>

* Fix chardet test and add ordering option Signed-off-by: Andrew Thornton <[email protected]> * minor fixes Signed-off-by: Andrew Thornton <[email protected]> * remove log Signed-off-by: Andrew Thornton <[email protected]> * remove log2 Signed-off-by: Andrew Thornton <[email protected]> * only iterate through top results Signed-off-by: Andrew Thornton <[email protected]> * Update docs/content/doc/advanced/config-cheat-sheet.en-us.md * slight restructure of for loop Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>

* Show full GPG commit status on PR commit history * move shabox badge to separate template * unnecessary $ Co-authored-by: zeripath <[email protected]> Co-authored-by: Lauris BH <[email protected]>

@guillep2k

* Allow site admin to disable mirrors Signed-off-by: jolheiser <[email protected]> * No need to run through Safe Signed-off-by: jolheiser <[email protected]> * Clarify only disabling NEW mirrors Signed-off-by: jolheiser <[email protected]> * Apply suggestions from @guillep2k Co-authored-by: guillep2k <[email protected]> Co-authored-by: guillep2k <[email protected]>

…gitea#10057) * Change license link to full (raw link) legal code on options/license * Replace link to full legal code at CC site * Update contrib/legal/tos.html.sample Co-authored-by: techknowlogick <[email protected]> Co-authored-by: techknowlogick <[email protected]>

Signed-off-by: Till Faelligen <[email protected]> Co-authored-by: techknowlogick <[email protected]>

* Fix styling for commiter on diff view * Update options/locale/locale_en-US.ini * Update templates/repo/commit_page.tmpl Co-authored-by: silverwind <[email protected]> * Update templates/repo/commit_page.tmpl Co-authored-by: silverwind <[email protected]> * Apply suggestions from code review Co-authored-by: silverwind <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: techknowlogick <[email protected]>

…#11721) As title, maybe fix one of issue in go-gitea#11705 Signed-off-by: a1012112796 <[email protected]> Co-authored-by: techknowlogick <[email protected]>

Add translation for `install-from-package` page Co-authored-by: techknowlogick <[email protected]>

* Fix message wrapping on PR commit list * Update templates/repo/commits_list_small.tmpl Co-authored-by: silverwind <[email protected]>

Fixes: go-gitea#10409 Co-authored-by: Lauris BH <[email protected]>

@6543

* Fix verification of subkeys of default gpg key Fix go-gitea#10309 Signed-off-by: Andrew Thornton <[email protected]> * Remove debug log * Update models/gpg_key.go * As per @6543 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>

…1641) * add API specific InternalServerError() * return 500 error msg only if not Production mode * rm unnessesary change

Some integration test data is being put outside of the integration test folders which means it isn't deleted properly with make clean. Update config so it works as expected. Co-authored-by: John Olheiser <[email protected]> Co-authored-by: techknowlogick <[email protected]>

* increase alpine to 3.12 * Update .drone.yml

Update to [2.8.5](https://github.com/fomantic/Fomantic-UI/releases/tag/2.8.5) and remove the workaround for the CSS build race condition. Co-authored-by: techknowlogick <[email protected]>

* Include query in sign in redirect Include query string in ctx.Data["SignInLink"] so people are redirected to the right page after singing in. Fixes case of: Visit: https://try.gitea.io/mrsdizzie/testcase/issues?q=&type=all&sort=&state=open&labels=7071&milestone=0&assignee=0 Sign in, then redirected to: https://try.gitea.io/mrsdizzie/testcase/issues Create a new "SignInLink" instead of updating the existing "Link" because too many places in the code assume "Link" won't have a query * Apply suggestions from code review Co-authored-by: techknowlogick <[email protected]>

* [API] Expose allowed Reactions * dont be in soutch a rush * add TEST * use ElementsMatch Co-authored-by: Lauris BH <[email protected]>

go-gitea#11757) * API: return an error when Mirrors globaly disabled * keep it consistent with UI Co-authored-by: John Olheiser <[email protected]> Co-authored-by: John Olheiser <[email protected]>

Ensure we return after `ctx.Error(...)`

This PR includes the modifications necessary to make use of the European Portuguese translation from the default setting.

…tea#11671) * bug: fix comment update permision check No the ui only allow poster to update or delet comment, which is not reasonable and different with handle logic, this pr change it to allow poster of comment do it ref code: https://github.com/go-gitea/gitea/blob/e8955173a9be1acaa9a3755c37b6059422acda20/routers/repo/issue.go#L1636 https://github.com/go-gitea/gitea/blob/e8955173a9be1acaa9a3755c37b6059422acda20/routers/repo/issue.go#L1681 fix go-gitea#11663 Signed-off-by: a1012112796 <[email protected]> * simplify code * fix sign in Co-authored-by: zeripath <[email protected]> Co-authored-by: Lauris BH <[email protected]>

* Provide diff and patch API endpoints The diff and patch endpoints on the main routes are not accessible by token therefore we provide new API based endpoints for these Fix go-gitea#10923 Signed-off-by: Andrew Thornton <[email protected]> * placate swagger Signed-off-by: Andrew Thornton <[email protected]> * Make the response an actual string Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: Lauris BH <[email protected]>

…1529) * Show multiple octicons on repo list * fix mixed spaces/tabs * Internal repo octicon * show internal icon in dashboard repolist * swagger * fix icon for normal repo on repo page * don't expose owner visibility directly; provide internal in repo api * fix icons for forks and mirrors Co-authored-by: Lauris BH <[email protected]>

* Fix typo of MSSQL * Fix typo: validates

Signed-off-by: jolheiser <[email protected]> Co-authored-by: Lauris BH <[email protected]>

* Add hide activity option This closes go-gitea#7927 * Adjust for linter * Adjust for linter * Add tests * Remove info that admins can view the activity * Adjust new tests for linter * Rename v139.go to v140.go * Rename v140.go to v141.go * properly indent * gofmt Co-authored-by: Jonas Lochmann <[email protected]> Co-authored-by: techknowlogick <[email protected]>

* Dump: Use mholt/archive/v3 to support tar including many compressions Signed-off-by: Philipp Homann <[email protected]> * Dump: Allow dump output to stdout Signed-off-by: Philipp Homann <[email protected]> * Dump: Fixed bug present since go-gitea#6677 where SessionConfig.Provider is never "file" Signed-off-by: Philipp Homann <[email protected]> * Dump: never pack RepoRootPath, LFS.ContentPath and LogRootPath when they are below AppDataPath Signed-off-by: Philipp Homann <[email protected]> * Dump: also dump LFS (fixes go-gitea#10058) Signed-off-by: Philipp Homann <[email protected]> * Dump: never dump CustomPath if CustomPath is a subdir of or equal to AppDataPath (fixes go-gitea#10365) Signed-off-by: Philipp Homann <[email protected]> * Use log.Info instead of fmt.Fprintf Signed-off-by: Philipp Homann <[email protected]> * import ordering * make fmt Co-authored-by: zeripath <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: Matti R <[email protected]>

* Fix timezone on issue deadline * FormatDate Co-authored-by: zeripath <[email protected]>

per https://www.sqlite.org/limits.html Co-authored-by: techknowlogick <[email protected]>

Fix go-gitea#11704 Signed-off-by: Andrew Thornton <[email protected]> Co-Authored-By: Cirno the Strongest <[email protected]>

) * Fix margin for referenced issue title * Change avatar size to 20px, align referenced issue title to avatar * better align

Co-authored-by: zeripath <[email protected]>

* Fix visibility of forked public repos from private orgs * update forks visibility when org visibility is changed Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: zeripath <[email protected]> Co-authored-by: techknowlogick <[email protected]>

* Add language statistics API * Add tests

fix go-gitea#11725 Signed-off-by: a1012112796 <[email protected]> Co-authored-by: zeripath <[email protected]>

…ea#11791)

Work around fomantic 2.8.5 bugs Closes go-gitea#11759 Related fomantic/Fomantic-UI#1372 and fomantic/Fomantic-UI#1473

* EditPull: add option to change base Close go-gitea#11552

…1724) A pre-receive hook that rejects pushes to refs/pull/index/head will cause a broken PR which causes an internal server error whenever it is viewed. This PR handles prevents the internal server error by handling non-existent pr heads and sends a flash error informing the creator there was a problem. Signed-off-by: Andrew Thornton <[email protected]>

* Honor DEFAULT_PAGING_NUM for API * set pagination to 10 for tests * lint Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]>

Co-authored-by: techknowlogick <[email protected]>

* Use crispEdges rendering for octicon-internal-repo * Update _svg.less Co-authored-by: techknowlogick <[email protected]>

Signed-off-by: jolheiser <[email protected]>

* v119 * v116 * v112

* rework eslint config - use explicit config that only enables rules - upgrade eslint to 7.1.0 - add new plugins with selected rules enabled - fix discovered issues, remove global wipPrefixes * remove if * undo template change * add disabled rules as well for easier config updating * add missing disabled rule * update eslint and plugins * fix new violation * remove deprecated rules Co-authored-by: Lauris BH <[email protected]>

* API allow to create closed milestones * set CloseDate too Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]>

* GeneralRepoSettings expose MirrorsDisabled, HTTPGitDisabled, MaxCreationLimit * Apply suggestions from code review Co-authored-by: proton <[email protected]> * lint Co-authored-by: proton <[email protected]>

As title, run this line in one time is enough. Signed-off-by: a1012112796 <[email protected]>

…o-gitea#11831) Co-authored-by: techknowlogick <[email protected]>

* Fix inserting excerpt on compare diff * use currentTarget * remove comment Co-authored-by: techknowlogick <[email protected]>

This removes the jQuery plugin as well as the associated config options. Native input[type=date] does not require a language attribute as it is localized by default, except for the placeholder attribute for which I currently piggy-back the repo.issues.due_date_form localization option. Implementation should pretty much match GH. Of note is that Safari does not provide a UI for this input type, but I don't think providing one is neccessary and GH did not bother either. Co-authored-by: techknowlogick <[email protected]>

Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Lauris BH <[email protected]>

* Don't add same line code comment box twice Clicking the same '+' button multiple times adds multiple comment boxes to the same line. Prevent this by assigning a unique key to each comment box and checking if it already exists in the DOM. Also cleaned up the code around this a bit. * Update web_src/js/index.js Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]>

Co-authored-by: techknowlogick <[email protected]>

Result of `make npm-update`, no noteworthy changes.

…rname without password (go-gitea#11852) When migrating from gitlab, set the baseUrl in NewGitlabDownloader when using an access token or username without password Fix go-gitea#11851

Signed-off-by: Andrew Thornton <[email protected]>

* Show exact tag for commit on diff view * Fix comment Co-authored-by: techknowlogick <[email protected]>

* Add migration to set IsArchived false if it is null Fix go-gitea#11824 Signed-off-by: Andrew Thornton <[email protected]> * Add doctor Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>

* Improve label edit buttons labels Previously when editing the buttons in the "Edit Label" modal were a strange "Update" and "No". Improved them to "Save" and "Cancel". Also fixed indentation in the template file, recommended to view changes with the "Hide whitespace changes" option enabled on GitHub. * remove unnecessary button icon Co-authored-by: techknowlogick <[email protected]>

* Fix commit search in all branches * comments Co-authored-by: techknowlogick <[email protected]>

* Handle more pathological branch and tag names Signed-off-by: Andrew Thornton <[email protected]> * Fix failing test Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>

Co-authored-by: techknowlogick <[email protected]>

* Fix nil pointer in default issue mail template Fix: template: issue/default:20:17: executing "issue/default" at <.Comment.Type>: nil pointer evaluating interface {}.Type Introduced in go-gitea#11167 * another one Co-authored-by: zeripath <[email protected]>

* Add automatic JS license generation Removed librejs file and replaced it with a plaintext file that is built from all JS dependencies that are included in the webpack build. It does not cover the few remaining statically vendored files and fomantic is added manually because it's not yet in the webpack build process. Fixes: go-gitea#11630 * fix lint * remove jslicense, we're not librejs compatible any more * remove license.txt test as it depens on absent files * small optimization * trailing comma * localize and capitalize the word 'licenses' * reduce text to just 'Licenses' Co-authored-by: Lauris BH <[email protected]>

go-gitea#11846 Introduced feature to show exact tag on commit view. However if a repo has no tags at all git prints out a separate and unhandled error " No names found, cannot describe anything." Adding --always to the command makes it always use the error in the style of "fatal: no tag exactly matches" even if there are no tags at all. Fixes go-gitea#11869 Fixes go-gitea#11868

* Fix repo internal icon when avatar is present * fix tabs * move repo icons in header to separate template

…1871) * Disable all typographic replacements in markdown renderer Previously we only disabled some of them. This disables all the default replacements that goldmark's typographer extension offers, matching GitHub's renderer. Ref: https://github.com/yuin/goldmark#typographer-extension Fixes: go-gitea#11001 * remove typographer extension completely * fix test * really fix test Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]>

* Add count to `GetUserRepositories` so that pagination can be supported for `/user/{username}/repos` * Rework ListMyRepos to use models.SearchRepository ListMyRepos was an odd one. It first fetched all user repositories and then tried to supplement them with accessible map. The end result was that: * Limit for pagination did not work because accessible repos would always be appended * The amount of pages was incorrect if one were to calculate it * When paginating, all accessible repos would be shown on every page Hopefully it should now work properly. Fixes go-gitea#11800 and does not require any change on Drone-side as it can properly interpret and act on Link header which we now set. Co-authored-by: Lauris BH <[email protected]>

@silverwind

…a#11761) * ui: Show update branch item in merge box when it's necessary As title, should show it without care about whether this pr can be merged. fix go-gitea#10959 Signed-off-by: a1012112796 <[email protected]> * fix ui * Fix ui, thanks to @silverwind. Co-authored-by: silverwind <[email protected]> * fix lint * Update templates/repo/issue/view_content/pull.tmpl Co-authored-by: silverwind <[email protected]> * Apply review suggestion Co-authored-by: zeripath <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: techknowlogick <[email protected]>

* Only write to global gitconfig if necessary Fix go-gitea#11855 Signed-off-by: Andrew Thornton <[email protected]> * placate lint Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>

* Invalidate comments when file is shortened Fix go-gitea#10686 Signed-off-by: Andrew Thornton <[email protected]> * handle 1 line Signed-off-by: Andrew Thornton <[email protected]>

* Better align items using flex within review request box * use justify-content Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]>

* Vertically align review icons on repository sidebar * Update web_src/less/_repository.less Co-authored-by: silverwind <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]>

* Rework blame template and styling * cleanup template and add missing NumLines Co-authored-by: techknowlogick <[email protected]>

…o-gitea#11881) Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]>

Co-authored-by: techknowlogick <[email protected]>

Co-authored-by: Lauris BH <[email protected]>

* rm wrong closing tag * Update templates/repo/sub_menu.tmpl Co-authored-by: John Olheiser <[email protected]> Co-authored-by: John Olheiser <[email protected]>

…itea#11912)

…abase (go-gitea#11925) * Use ID or Where to instead directly use Get when load object from database * Apply suggestions from code review Co-authored-by: 6543 <[email protected]> Co-authored-by: 6543 <[email protected]> Co-authored-by: zeripath <[email protected]>

@lunny

* upgrade to use testfixtures v3 * simplify logic * make vendor * update per @lunny * Update templates/repo/empty.tmpl * Update templates/repo/empty.tmpl Co-authored-by: Lauris BH <[email protected]>

@silverwind

* Global default branch setting * add to app.ini example per @silverwind * update per @lunny Co-authored-by: John Olheiser <[email protected]>

Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>

Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]>

Co-authored-by: zeripath <[email protected]> Co-authored-by: techknowlogick <[email protected]>

@6543

…better syntax light on editor (go-gitea#11926) * Rename custom/conf/app.ini.sample to custom/conf/app.sample.ini for better syntax light on editor * rename to app.example.ini * per @6543 's comment, update all references on docs Co-authored-by: techknowlogick <[email protected]>

Co-authored-by: Lauris BH <[email protected]>

* Add comment on non-unicode line to force fail Signed-off-by: Andrew Thornton <[email protected]> * Just quote/unquote patch Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: John Olheiser <[email protected]>

* Changelog v1.11.7 * Update CHANGELOG.md

Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: Lauris BH <[email protected]>

Install tool already sets it as the default so we can just update example ini and docs to it. Fixes: go-gitea#11081

…tea#11960) * Use only first line of commit when creating referenced comment * Update modules/repofiles/action.go * Display first line only on feeds too Co-authored-by: techknowlogick <[email protected]> Co-authored-by: zeripath <[email protected]>

…-gitea#11971)

Fixes a wrong 302 redirect to the login page, see go-gitea#11989. Also made it so the reserved username list is extended with those known entries so we avoid code duplication. Should be backported to 1.12.

Webpack outputs to this directory so it should be removed during cleanup. No backport needed. Co-authored-by: zeripath <[email protected]>

* Handle multiple merges in gitgraph.js There is a bug in web_src/js/vendor/gitgraph.js whereby it fails to handle multiple merges in a single commit correctly. This PR adds changes to make this work. Fix go-gitea#11981 Signed-off-by: Andrew Thornton <[email protected]> * Update web_src/js/vendor/gitgraph.js

…abase (go-gitea#11145) * begin work * import fmt * more work * empty commit Co-authored-by: Lauris BH <[email protected]>

Closes go-gitea#11210 Co-authored-by: Lauris BH <[email protected]>

* Use octicons for all repo header buttons * ensure margin isn't set on any other svg outside repo buttons Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: Lauris BH <[email protected]>

* Fix missing styling for dropdown icon on review button * Remove unnecessary span element Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: Lauris BH <[email protected]>

* Changelog for v1.12.1 (go-gitea#12006) * Update gitea version to latest release

* Fix typo of MSSQL * Fix typo: validates * Fix typo * fix comment with space Co-authored-by: techknowlogick <[email protected]>

* Make tabs smaller Fomantic's tabs are excessively wide and with another tab added on the repo tabbar (go-gitea#8346) it would break the layout on the english language. Globally reduce tab bar padding to around half of the previous values. * disable no-duplicate-selectors linter rule * more tab bar tweaks * more tweaks * merge rules and nesting * remove arc-green weird hover color * few more arc-green tweaks * restore to 12px * tweaks * use half width height padding * final tweak * 10px * remove min-height * 11px * remve new-menu background on light theme too * background fixes for new-menu Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]>

…at new swagger section settings (go-gitea#11854) * move Setting function into its own package * swagger add&use new section "settings" * move api AllowedReactions into general UI-Settings endpoint * prepare TEST * lint

* Fix sticky diff stats container * Use pure CSS sticky instead of Fomantic's JS * add border color to arc-green * add slight padding on sides * make linter happy Co-authored-by: techknowlogick <[email protected]>

* Use label instead of icon to describe repository type when repo avatar is set * header_icon is not longer duplicated; move out of separate template * handle archived case too * use everywhere * public template -> template * bring back separate icon in better form * definitely was overthinking this * 32 Co-authored-by: techknowlogick <[email protected]>

Dropzone 4.4 introduced a 30s XHR timeout that will kill any upload still in progress. This disable that timeout again. Ref: https://www.dropzonejs.com/#config-timeout Ref: go-gitea#10645 Ref: https://xhr.spec.whatwg.org/#the-timeout-attribute Fixes: go-gitea#12022 Fixes: go-gitea#11906 Co-authored-by: Lunny Xiao <[email protected]>

Don't change font smoothing via CSS. Linked issue has more details, but this seems fowned upon in general and a was also removed from standards track. Hopefully this will be a part of reverting to a native font stack for Gitea. Fixes go-gitea#11931 Co-authored-by: techknowlogick <[email protected]>

* fix bug about can't skip commits base on base branch Signed-off-by: a1012112796 <[email protected]> * Update modules/git/commit.go Co-authored-by: Lauris BH <[email protected]> * Update models/issue_comment.go Co-authored-by: Lauris BH <[email protected]> * fix lint Co-authored-by: Lauris BH <[email protected]>

@silverwind

* [UI] Sortable Tables Header By Click * get rid of padding above header * restart CI * fix lint * convert getArrow JS to SortArrow go func * addopt SortArrow funct * suggestions from @silverwind - tablesort.js Co-authored-by: silverwind <[email protected]> * Update web_src/js/features/tablesort.js Co-authored-by: silverwind <[email protected]> * Update web_src/js/features/tablesort.js Co-authored-by: silverwind <[email protected]> Co-authored-by: silverwind <[email protected]>

* Fix webhook comment handling type cast panic * Handle HookIssueReviewed action in webhook Co-authored-by: Lunny Xiao <[email protected]>

* Fix gitgraph branch continues after merge After fixing the initial problem in go-gitea#11981 another problem has come to light... Fix go-gitea#11981 (part 2) Signed-off-by: Andrew Thornton <[email protected]> * Update web_src/js/vendor/gitgraph.js * Apply suggestions from code review Co-authored-by: silverwind <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: techknowlogick <[email protected]>

Co-authored-by: techknowlogick <[email protected]>

* Add org avatar on top of internal repo icon * add color for arc-green * use wrapper div to avoid negative margins * rename class and move div * move div to icon tmpl * remove unnecessary margin for lock octicon * fix label align together with go-gitea#11891 Co-authored-by: techknowlogick <[email protected]>

Fixes go-gitea#12043 Co-authored-by: Lauris BH <[email protected]>

This changes the links on headings like '# Usage' in markdown from `https://host/user/repo#user-content-usage` to just `https://host/user/repo#usage` matching GitHub and GitLab. The linked id elements still have the prefix and this behaviour matches GitHub and GitLab too, so JS is needed to scroll to the active anchor. I suspect it's like that to avoid namespace collission between user-generated content and other page content. Compatibilty for old links is included so they will continue to work. Also included are some enhancements to make the clickable area for the link icon larger and fix its color on arc-green. Fixes: go-gitea#11896 Fixes: go-gitea#12062

Prevent `go get` from touching `go.mod` and `go.sum` when executing global binaries during the build process. Once golang/go#30515 is fixed, we should is whatever solution is provided there. Fixes: go-gitea#12010 Co-authored-by: techknowlogick <[email protected]>

Co-authored-by: Lauris BH <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: techknowlogick <[email protected]>

This saves around 3 MB binary size by not including useless fomantic files in the build. Also, this allows us to move jQuery into the main bundle as well which eliminates a few HTTP requests. Also included are webpack config changes: - split less and css loaders to speed up compliation - enable css sourcemaps - switch css minfier plugin to cssnano-webpack-plugin which works better for sourcemaps than the previous plugin Co-authored-by: techknowlogick <[email protected]>

* Use custom SVGs for commit signing lock icon * missing spans * editorconfig * xmlns and remove aria-hidden Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: techknowlogick <[email protected]>

This prevents a potential make errors like "No rule to make sticky.js" that happens when a file is present from a previous build but is not generated in the current build. We don't use these module files from fomantic so it's safe to not depend on them. Related to: go-gitea@7761245

@silverwind

* Server-side syntax hilighting for all code This PR does a few things: * Remove all traces of highlight.js * Use chroma library to provide fast syntax hilighting directly on the server * Provide syntax hilighting for diffs * Re-style both unified and split diffs views * Add custom syntax hilighting styling for both regular and arc-green Fixes go-gitea#7729 Fixes go-gitea#10157 Fixes go-gitea#11825 Fixes go-gitea#7728 Fixes go-gitea#3872 Fixes go-gitea#3682 And perhaps gets closer to go-gitea#9553 * fix line marker * fix repo search * Fix single line select * properly load settings * npm uninstall highlight.js * review suggestion * code review * forgot to call function * fix test * Apply suggestions from code review suggestions from @silverwind thanks Co-authored-by: silverwind <[email protected]> * code review * copy/paste error * Use const for highlight size limit * Update web_src/less/_repository.less Co-authored-by: Lauris BH <[email protected]> * update size limit to 1MB and other styling tweaks * fix highlighting for certain diff sections * fix test * add worker back as suggested Co-authored-by: silverwind <[email protected]> Co-authored-by: Lauris BH <[email protected]>

* Fix merge section in dark theme * Fix lint

go-gitea#11716 reports multiple git blame processes hanging around this was thought to be due to timeouts, however on closer look this appears to be due to the Close() function of the BlameReader hanging with a blocked stdout pipe. This PR fixes this Close function to: * Cancel the context of the cmd * Close the StdoutReader - ensuring that the output pipe is closed Further it makes the context of the `git blame` command a child of the request context - ensuring that even if Close() is not called, on cancellation of the Request the blame is command will also be cancelled. Fixes go-gitea#11716 Closes go-gitea#11727 Signed-off-by: Andrew Thornton <[email protected]>

* Improve arc-green code colors This should fix all previous colors that had too few contrast on the background. I took solarized-dark as a baseline and did various improvments. I removed bold/italic flags because I don't think they fit and generally other tools also don't use those font flags. * diff tweak

The filter was wrongly excluding the gitGraph.css file. Need to clean this up later so that imports are always relative to the source file (which is not the case for fonts right now). Regressed by: go-gitea#11997 Co-authored-by: zeripath <[email protected]>

@CirnoT

* Provide option to unlink a fork Fix go-gitea#4566 Signed-off-by: Andrew Thornton <[email protected]> * Apply suggestions from code review Co-authored-by: techknowlogick <[email protected]> * Add check that user can create repo Signed-off-by: Andrew Thornton <[email protected]> * as per @CirnoT Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>

Repo listings are paginated in the API now. Unfortunately, they are ORDER BY updated_unix which only has second resolution. This means that if you do a listing when multiple projects were created at the same time you can unstable ordering. If that unstable ordering happens at a page boundary you may fail to get a complete repo listing. To make things worse sorting by updated_unix means that we may never get a complete listing because udpated_unix can change independent of our API calls. Fix this by making the API repo listing order by id instead.

* Fix ui bug in wiki commit page TODO: Maybe we should allow wiki to have its own ``.editorconfig`` file. Signed-off-by: a1012112796 <[email protected]> * fix a small nit Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: zeripath <[email protected]>

Move EventSource to use a SharedWorker. This prevents issues with HTTP/1.1 open browser connections from preventing gitea from opening multiple tabs. Also allow setting EVENT_SOURCE_UPDATE_TIME to disable EventSource updating Fix go-gitea#11978 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: techknowlogick <[email protected]>

Co-authored-by: codeberg <[email protected]>

For some reason our eslint configuration is not working correctly and a bug has become apparent when trying to backport this to 1.12. Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>

Unfortunately some of the suggested changes to go-gitea#12095 introduced bugs which due to caching behaviour of sharedworkers were not caught on simple tests. These are as follows: * Changing from simple for loop to use includes here: ```js register(port) { if (!this.clients.includes(port)) return; this.clients.push(port); port.postMessage({ type: 'status', message: `registered to ${this.url}`, }); } ``` The additional `!` prevents any clients from being added and should read: ```js if (this.clients.includes(port)) return; ``` * Dropping the use of jQuery `$(...)` selection and using DOM `querySelector` here: ```js async function receiveUpdateCount(event) { try { const data = JSON.parse(event.data); const notificationCount = document.querySelector('.notification_count'); if (data.Count > 0) { notificationCount.classList.remove('hidden'); } else { notificationCount.classList.add('hidden'); } notificationCount.text() = `${data.Count}`; await updateNotificationTable(); } catch (error) { console.error(error, event); } } ``` Requires that `notificationCount.text()` be changed to use `textContent` instead. Signed-off-by: Andrew Thornton <[email protected]>

@silverwind

The current vendored gitgraph.js is no longer maintained and is difficult to understand, fix and maintain. This PR completely rewrites its logic - hopefully in a clearer fashion and easier to maintain. It also includes @silverwind's improvements of coloring the commit dots and preventing the flash of incorrect content. Further changes to contemplate in future will be abstracting out of the flows to an object, storing the involved commit references on the flows etc. However, this is probably a required step for this. Replaces go-gitea#12131 Fixes go-gitea#11981 (part 3) Signed-off-by: Andrew Thornton <[email protected]>

Unfortunately go-gitea#10745 merged a spurious logging message. This PR removes this. Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Lauris BH <[email protected]>

This gets the config closer to what 1.12 had. Related: go-gitea#12129

…er default branch (go-gitea#12135) This fixes an issue I noticed with go-gitea#10803: when you create a repo with a non-master default branch, gitea doesn't change the remote ref HEAD, so it still points at refs/heads/master. As a result, cloning my repos gives me error messages and doesn't check out the desired default branch, so I need to manually check it out after cloning.

Co-authored-by: zeripath <[email protected]>

* Remove spurious spacing between Maintenance Operations and its table on dashboard * Prevent (EXTRA string) comments in Task headers * Redirect tasks started from monitor page back to monitor * Fix go-gitea#12107 - redirects from process cancel should use AppSubUrl * When wrapping queues set the name correctly Signed-off-by: Andrew Thornton <[email protected]>

…ne (go-gitea#11777) * Make LogDescriptions race safe * Add manager commands for pausing, resuming, adding and removing loggers Signed-off-by: Andrew Thornton <[email protected]> * Placate lint * Ensure that file logger is run! * Add support for smtp and conn Signed-off-by: Andrew Thornton <[email protected]> * Add release-and-reopen Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: Lauris BH <[email protected]>

…sitory's Clone From URL (go-gitea#12053) * update the wiki repository remote origin go-gitea#12050 * wikiRemoteURL is under repo_module * export WikiRemoteURL func * remove redundant space and empty line Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]>

- Use system fonts only for text to avoid FOUT - Move font-awesome to npm/webpack - Move NotoColorEmoji to web_src - Remove presumably unneccesary 'PT Sans Narrow' - Simplify webpack import exclusions Fixes: go-gitea#11818 Fixes: go-gitea#11814 Co-authored-by: zeripath <[email protected]> Co-authored-by: Lauris BH <[email protected]>

Co-authored-by: Lunny Xiao <[email protected]>

Co-authored-by: techknowlogick <[email protected]>

When attempting to verify subkeys the email address verification step requires checking the emails however, these emails are not stored on subkeys but instead on the primary key. This PR will obtain the primaryKey and check against these emails too. Fix go-gitea#12128 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: techknowlogick <[email protected]>

Previously this used a USB icon which required a separate font file used nowhere else so replace it with a octicon and fix the background color on arc-green too.

* Decrease the num_stars when deleting a repo fix go-gitea#11949 Signed-off-by: a1012112796 <[email protected]> * Add migration * use batch * Apply suggestions from code review Co-authored-by: Lauris BH <[email protected]> * fix lint * fix lint * fix ci * fix ci2 * add doctor * duplicate code * fix migration * fix some nits * add start Co-authored-by: Lauris BH <[email protected]> Co-authored-by: zeripath <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>

* Trim to 255 runes instead of bytes Prevents invalid UTF-8 encoding for Description and Website. Refs go-gitea#7905 * Apply suggestions from code review Co-authored-by: zeripath <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: zeripath <[email protected]> Co-authored-by: Lauris BH <[email protected]>

* Remove newline when highlighting random chunks of code Somewhere when tokenizing a newline gets added to code formatted by chroma. This breaks the case of 'added-code' inside of an 'added-line' in a diff. Just remove any newline when processing chunks of code since we don't need it. Fixes go-gitea#12172 * don't process empty lines * This is the proper way to fix this by telling chroma not to add the newline in the first place

* Enable Git Wire Protocol v2 over HTTP * use RunInDirTimeoutEnv * pass $HOME environment variable to git upload-pack

- Update all dependencies excluding octicons - Configure new eslint 7.3.0 rules Co-authored-by: techknowlogick <[email protected]>

… full messages (go-gitea#12186) Closes go-gitea#12185

… CLI_users

This reverts commit 97d6fc6.

Commits on Oct 16, 2020

Merge branch 'master' into CLI_users

techknowlogick authored Oct 16, 2020

Configuration menu

View commit details

Copy full SHA for 1f47e3d

Browse repository at this point

Copy the full SHA

1f47e3d View commit details

Browse the repository at this point in the history

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve users management through the CLI (#6001) #10492

Improve users management through the CLI (#6001) #10492

Commits on Jul 31, 2020

Commits on Oct 16, 2020