-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync with upstream #22
Commits on Jan 7, 2021
-
Upgrade Treelite module(#3316)
Depends on dmlc/treelite#235, dmlc/treelite#236, dmlc/treelite#237, dmlc/treelite#240, dmlc/treelite#241, dmlc/treelite#242, dmlc/treelite#243 Depends on rapidsai/integration#201 Closes #2160 Closes #2795 Closes #2817 TODOs - [x] Get code review for dmlc/treelite#235 and dmlc/treelite#236 and merge them - [x] Get code review for dmlc/treelite#237 and merge them - [x] Merge dmlc/treelite#240, dmlc/treelite#241, dmlc/treelite#242, dmlc/treelite#243 - [x] Run tests locally - [x] Tag a new version of Treelite - [x] Release a new Conda package with the new version tag - [x] Update `meta.yml` and the integration package to use the new Treelite - [x] Run tests (this time build with new Conda package) Authors: - Hyunsu Cho <[email protected]> Approvers: - AJ Schmidt (@ajschmidt8) - William Hicks (@wphicks) - John Zedlewski (@JohnZed) URL: #3316
Configuration menu - View commit details
-
Copy full SHA for b8e71ca - Browse repository at this point
Copy the full SHA b8e71caView commit details -
This PR allows TSNE to accept sparse inputs. It also removes long-standing warnings ```ptxas warning : Value of threads per SM for entry _ZN2ML4TSNE17IntegrationKernelEfffPfS1_PKfS3_S3_S3_S1_S1_S1_S1_S3_i is out of range. .minnctapersm will be ignored ptxas warning : Value of threads per SM for entry _ZN2ML4TSNE15RepulsionKernelEffPKiS2_PKfS4_S4_PfS5_S5_fiiiS4_S2_ is out of range. .minnctapersm will be ignored ptxas warning : Value of threads per SM for entry _ZN2ML4TSNE18TreeBuildingKernelEPiPKfS3_iiS1_S1_S3_ is out of range. .minnctapersm will be ignored ptxas warning : Value of threads per SM for entry _ZN2ML4TSNE17BoundingBoxKernelEPiS1_PfS2_S2_S2_S2_S2_S2_iiiPjS2_ is out of range. .minnctapersm will be ignored``` from cuml builds which were caused by invalid parameters to `__launch_bounds__` in TSNE kernels. Furthermore, I also created a class `TSNE_runner` to handle running separate components of the algorithm as well as to ensure the proper use of RAII buffers and their de-allocation once their use is done, without explicitly deleting those buffers. closes #2751 Authors: - divyegala <[email protected]> Approvers: - Corey J. Nolet (@cjnolet) URL: #3293
Configuration menu - View commit details
-
Copy full SHA for 4d2de05 - Browse repository at this point
Copy the full SHA 4d2de05View commit details -
Rename print_summary() of Dask RF to get_summary_text(); it now retur…
…ns string to the client(#3341) Closes #3280. In order to obtain outputs in MNMG setting, cuML should not print to stdout. Authors: - Hyunsu Cho <[email protected]> Approvers: - John Zedlewski (@JohnZed) URL: #3341
Configuration menu - View commit details
-
Copy full SHA for b69d19a - Browse repository at this point
Copy the full SHA b69d19aView commit details -
Updating PyTests to Stay Below 4 Gb Limit(#3306)
Closes #3120 Current WIP. Changed the lone test >4Gb in testing to be a stress param. Added a rmm.mr.PoolMemoryResource to limit the max memory that can be allocated. Only using the MR for testing in CI. Would be removed once PR is complete. Authors: - Michael Demoret <[email protected]> Approvers: - John Zedlewski (@JohnZed) URL: #3306
Configuration menu - View commit details
-
Copy full SHA for 89318f6 - Browse repository at this point
Copy the full SHA 89318f6View commit details -
Remove outdated references to changelog in CONTRIBUTING.md(#3328)
Eliminate reference to manually updating the changelog in accordance with new system for automated changelog generation Authors: - William Hicks <[email protected]> Approvers: - John Zedlewski (@JohnZed) URL: #3328
Configuration menu - View commit details
-
Copy full SHA for 416e85d - Browse repository at this point
Copy the full SHA 416e85dView commit details
Commits on Jan 9, 2021
-
Updating dense pairwise distance enum names(#3352)
Authors: - Corey J. Nolet <[email protected]> Approvers: - John Zedlewski (@JohnZed) URL: #3352
Configuration menu - View commit details
-
Copy full SHA for 3a137f8 - Browse repository at this point
Copy the full SHA 3a137f8View commit details
Commits on Jan 10, 2021
-
Promote IncrementalPCA from experimental in 0.18 release(#3327)
This PR aims at promoting IncrementalPCA from experimental, and closes #2703. Authors: - Mickael Ide <[email protected]> Approvers: - John Zedlewski (@JohnZed) - John Zedlewski (@JohnZed) URL: #3327
Configuration menu - View commit details
-
Copy full SHA for c021dec - Browse repository at this point
Copy the full SHA c021decView commit details
Commits on Jan 11, 2021
-
Rename dump_as_json() -> get_json(); expose it from Dask RF(#3340)
Follow-up to #2677. Rename `dump_as_json()` to `get_json()`, and make it available from the Dask RF interface. Authors: - Hyunsu Cho <[email protected]> Approvers: - John Zedlewski (@JohnZed) URL: #3340
Configuration menu - View commit details
-
Copy full SHA for bef75cd - Browse repository at this point
Copy the full SHA bef75cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20c83ff - Browse repository at this point
Copy the full SHA 20c83ffView commit details -
Fixing
make_blobs
to Respect the Global Output Type(#3339)Closes #3334 This was missed in the large CumlDescriptor and Decorators update. Changing the decorator to correctly respect the output type and adding a test to check the functionality. Authors: - Michael Demoret <[email protected]> Approvers: - John Zedlewski (@JohnZed) URL: #3339
Configuration menu - View commit details
-
Copy full SHA for 9ad71f0 - Browse repository at this point
Copy the full SHA 9ad71f0View commit details -
[REVIEW] k-means bug fix in debug build (#3321)
* [kmeans] bug fix * update changelog * Revert "update changelog" This reverts commit 4bb39c3.
Configuration menu - View commit details
-
Copy full SHA for 2a3b354 - Browse repository at this point
Copy the full SHA 2a3b354View commit details -
* Create labeler.yml * Create labeler.yml * update globs to minimatch globs * Update labeler.yml
Configuration menu - View commit details
-
Copy full SHA for efdb230 - Browse repository at this point
Copy the full SHA efdb230View commit details
Commits on Jan 12, 2021
-
[REVIEW] Multiclass meta estimator wrappers and multiclass SVC (#3092)
* FEA Add wrappers for scikit-learn multiclass * FEA Multiclass SVM * DOC Update changelog * Rebased to use CumlArrayDestcriptor, intercept_ property fixed * Move multiclass wrappers into a single source file * TST Multiclass SVC pickle test * ENH Use a multiclass wrapper, add test * Fix style * DOC Add description of D2H H2D copies to docstring * Remove n_jobs arg, improve docstring * TST Skip unfit pickle and unfit clone tests for multiclass wrappers * DOC Improve doc format * Skip subclass doc test for multiclass wrappers * Fix get_parma_names * Apply suggestions from code review Co-authored-by: Michael Demoret <[email protected]> * Improve doc, style and other smaller issues * Add link to multiclass into the API doc * Correct python style errors * Fix param names * Update example format Co-authored-by: Michael Demoret <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 639357e - Browse repository at this point
Copy the full SHA 639357eView commit details
Commits on Jan 13, 2021
-
Exposing model_selection in a similar way to scikit-learn(#3329)
Resolving #3267. It seems that model_selection is already properly exposed through `cuml.preprocessing.model_selection` A small test suite for `train_test_split` is included in this PR to demonstrate that it works as desired. Authors: - Patrick Liu <[email protected]> Approvers: - William Hicks (@wphicks) - John Zedlewski (@JohnZed) URL: #3329
Configuration menu - View commit details
-
Copy full SHA for ecd508c - Browse repository at this point
Copy the full SHA ecd508cView commit details
Commits on Jan 16, 2021
-
Preparing sparse primitives for movement to RAFT(#3157)
This PR contains the initial steps to move many of the sparse prims API over to raft, including: - [x] Adjusting `MLCommon::Sparse` namespaces to `raft::sparse` - [x] Breaking csr/coo prims into multiple files (e.g. linalg, components, matrix, etc...) - [x] Using RAFT namespaces for raft componentry used within the sparse prims, such as `device_buffer` and `deviceAllocator`. - [x] Use RAFT handle in public API Closes #3106 Authors: - Corey J. Nolet <[email protected]> - Ray Douglass <[email protected]> Approvers: - Divye Gala (@divyegala) - Divye Gala (@divyegala) - John Zedlewski (@JohnZed) URL: #3157
Configuration menu - View commit details
-
Copy full SHA for d72c54a - Browse repository at this point
Copy the full SHA d72c54aView commit details
Commits on Jan 20, 2021
-
XFail Holt Winters test where statsmodels has known issues with gcc 9…
Configuration menu - View commit details
-
Copy full SHA for 816bb65 - Browse repository at this point
Copy the full SHA 816bb65View commit details
Commits on Jan 21, 2021
-
re-enable cuML's copyright checker script (#3363)
This PR ports the corresponding fixes by @rlratzel for the cugraph [here](rapidsai/cugraph#1325) in order to re-enable copyright year checks in the CI scripts, over to cuML too. In the process I also took the liberty to port other changes that had been done on cugraph's copyright.py over to cuML too. ~~Just like the above PR, I'm leaving the copyright years unmodified to verify that the CI really works.~~ [Verified] Authors: - Thejaswi. N. S (@teju85) Approvers: - William Hicks (@wphicks) - AJ Schmidt (@ajschmidt8) - Dante Gama Dessavre (@dantegd) - Rick Ratzel (@rlratzel) URL: #3363
Configuration menu - View commit details
-
Copy full SHA for c48f35a - Browse repository at this point
Copy the full SHA c48f35aView commit details -
Fix for ANN memory release bug (#3391)
Answers #3318 This may fix the error observed in CI. Before the change, the memory manager handler was released first, then the FAISS index. After the change, the FAISS index is released first, then the memory manager handler is released. Authors: - Victor Lafargue (@viclafargue) Approvers: - John Zedlewski (@JohnZed) URL: #3391
Configuration menu - View commit details
-
Copy full SHA for e8d1610 - Browse repository at this point
Copy the full SHA e8d1610View commit details
Commits on Jan 22, 2021
-
Also xfail zlib errors when downloading newsgroups data (#3393)
Configuration menu - View commit details
-
Copy full SHA for 29f7d08 - Browse repository at this point
Copy the full SHA 29f7d08View commit details -
Parallelize RF to Treelite conversion over trees (#3395)
Perform construction of Treelite trees in parallel when converting from a cuML RF model Improve speed of initial prediction for a model with 300 trees of approximately 4M nodes by an average of 2.04x on a system with 12 Intel Xeon Gold 6128 CPUs available Authors: - William Hicks (@wphicks) Approvers: - Andy Adinets (@canonizer) - Philip Hyunsu Cho (@hcho3) - John Zedlewski (@JohnZed) URL: #3395
Configuration menu - View commit details
-
Copy full SHA for 4ce2380 - Browse repository at this point
Copy the full SHA 4ce2380View commit details
Commits on Jan 24, 2021
-
[REVIEW] API update to match RAFT PR #120 (#3386)
* API update to match RAFT PR #120 * Update raft git tag * Update copyrights * Copyright update Co-authored-by: Devin Robison <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6b5e7ff - Browse repository at this point
Copy the full SHA 6b5e7ffView commit details
Commits on Jan 26, 2021
-
[REVIEW] Add slow high-precision mode to KNN (#3304)
* Add slow high-precision mode to KNN Provide mode to perform a second high-precision pass over results returned from brute-force KNN searches which make use of L2-derived metrics. This provides a workaround for issues with numerical instability in L2 distance calculations in FAISS when a query vector is quite close to multiple retrieved samples relative to the typical inter-sample distance. * Correct axes selection and variable name * Fix style * Clarify documentation and use input_to_cupy_array * Fix style * Use expanded L2 directly in high-precision mode * Update copyright headers
Configuration menu - View commit details
-
Copy full SHA for 546abad - Browse repository at this point
Copy the full SHA 546abadView commit details -
Parallelize Treelite to FIL conversion over trees (#3396)
Convert Treelite trees to FIL in parallel Improve speed of initial prediction for a model with 300 trees of approximately 4M nodes by an average of 5.9% on a system with 12 Intel Xeon Gold 6128 CPUs available Authors: - William Hicks (@wphicks) Approvers: - Andy Adinets (@canonizer) - Philip Hyunsu Cho (@hcho3) - John Zedlewski (@JohnZed) URL: #3396
Configuration menu - View commit details
-
Copy full SHA for 9ff478f - Browse repository at this point
Copy the full SHA 9ff478fView commit details
Commits on Jan 27, 2021
-
Fix vectorizer tests by restoring sort behavior in groupby (#3416)
Configuration menu - View commit details
-
Copy full SHA for c403f83 - Browse repository at this point
Copy the full SHA c403f83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84d308f - Browse repository at this point
Copy the full SHA 84d308fView commit details
Commits on Jan 28, 2021
-
Fix array_equal in tests (#3400)
Answers #1970 This PR fixes the `array_equal` function. More specifically, the calculation of the percentage of correct element in the array. This had as an effect a release in testing (necessary changes harder to detect). After verification, it appeared that the `total_tol` parameter was (explicitly or implicitly) set at default value everywhere. No change in pytests was necessary. Authors: - Victor Lafargue (@viclafargue) Approvers: - John Zedlewski (@JohnZed) URL: #3400
Configuration menu - View commit details
-
Copy full SHA for e0f6a80 - Browse repository at this point
Copy the full SHA e0f6a80View commit details -
Merge pull request #3418 from rapidsai/branch-0.18
[gpuCI] Auto-merge branch-0.18 to branch-0.19 [skip ci]
Configuration menu - View commit details
-
Copy full SHA for 2602e8d - Browse repository at this point
Copy the full SHA 2602e8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 624555f - Browse repository at this point
Copy the full SHA 624555fView commit details -
Merge pull request #3424 from rapidsai/branch-0.18
[gpuCI] Auto-merge branch-0.18 to branch-0.19 [skip ci]
Configuration menu - View commit details
-
Copy full SHA for d397887 - Browse repository at this point
Copy the full SHA d397887View commit details
Commits on Jan 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 62af4bf - Browse repository at this point
Copy the full SHA 62af4bfView commit details -
Merge pull request #3430 from rapidsai/branch-0.18
[gpuCI] Auto-merge branch-0.18 to branch-0.19 [skip ci]
Configuration menu - View commit details
-
Copy full SHA for f6759b1 - Browse repository at this point
Copy the full SHA f6759b1View commit details -
Temporary skipping IVFPQ tests. Authors: - Victor Lafargue (@viclafargue) Approvers: - Micka (@lowener) - Dante Gama Dessavre (@dantegd) URL: #3429
Configuration menu - View commit details
-
Copy full SHA for d413fe6 - Browse repository at this point
Copy the full SHA d413fe6View commit details -
Merge pull request #3432 from rapidsai/branch-0.18
[gpuCI] Auto-merge branch-0.18 to branch-0.19 [skip ci]
Configuration menu - View commit details
-
Copy full SHA for dc56845 - Browse repository at this point
Copy the full SHA dc56845View commit details -
Improving Copyright Check When Not Running in CI (#3398)
This PR fixes some a few issues that were encountered recently with the new copyright check. Currently, if you get a copyright error in the style check, you get an error message that states: ``` You can run ci/checks/copyright.py --update-current-year to fix 1 of these errors. ``` This unfortunately wouldn't work if you tried to run it locally for a few reasons: 1. If you run `ci/checks/copyright.py --update-current-year`, it wont work since you are missing `python` 2. The script `copyright.py` imports `gitutils` which is not on the `PYTHONPATH` 3. The script would determine which files to fix by looking for uncommited changes in your repo and fixing these files. If you have already gotten the error message in CI, all of your files have been committed already so it will report nothing to fix. This PR fixes the above issues by printing the correct code to run to fix the error, appending `sys.path` with the location of `gitutils` and modifying the copyright.py script to more intelligently determine the PR target branch, even when running locally. Authors: - Michael Demoret (@mdemoret-nv) Approvers: - Thejaswi. N. S (@teju85) - AJ Schmidt (@ajschmidt8) URL: #3398
Configuration menu - View commit details
-
Copy full SHA for 2dff06f - Browse repository at this point
Copy the full SHA 2dff06fView commit details -
Fixing Python Documentation Errors and Warnings (#3428)
Closes #3268 General cleanup of sphinx documentation to eliminate all warnings and fix issue #3268. Main change was using `autofunction::` instead of `automethod::` (which is designed for class methods) Authors: - Michael Demoret (@mdemoret-nv) Approvers: - Dante Gama Dessavre (@dantegd) - John Zedlewski (@JohnZed) URL: #3428
Configuration menu - View commit details
-
Copy full SHA for 58ed101 - Browse repository at this point
Copy the full SHA 58ed101View commit details -
Merge pull request #3434 from rapidsai/branch-0.18
[gpuCI] Auto-merge branch-0.18 to branch-0.19 [skip ci]
Configuration menu - View commit details
-
Copy full SHA for e82b454 - Browse repository at this point
Copy the full SHA e82b454View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2b5825 - Browse repository at this point
Copy the full SHA e2b5825View commit details -
Merge pull request #3436 from rapidsai/branch-0.18
[gpuCI] Auto-merge branch-0.18 to branch-0.19 [skip ci]
Configuration menu - View commit details
-
Copy full SHA for 02eece9 - Browse repository at this point
Copy the full SHA 02eece9View commit details
Commits on Jan 30, 2021
-
Sparse Generalized SPMV (semiring) Primitive (#3146)
Closes #1448 I'm not sure why/how the original PR for this was closed but I'm opening up a new PR for this. Please refer to original PR for more info: #2861 If reviewing this prim, you can start with `cpp/src_prims/sparse/distance/coo_spmv.cuh` and `cpp/src_prims/sparse/csr_spmv.cuh` and associated Gtest. cc @teju85 As mentioned in comments throughout this PR, there are a few tasks which will be pushed off to the next PR. Here are a few tasks that remain in this PR to prep for release 0.18: - [x] Add explicit distance gtests for coo_spmv and csr_spmv - [x] Add gtest case for Hellinger distance in distance prim tests - [x] Add a pytest for very wide but very sparse input (to test switch to csr kernel) Authors: - Corey J. Nolet (@cjnolet) - Ray Douglass (@raydouglass) Approvers: - Tamas Bela Feher (@tfeher) - John Zedlewski (@JohnZed) URL: #3146
Configuration menu - View commit details
-
Copy full SHA for 95ec78c - Browse repository at this point
Copy the full SHA 95ec78cView commit details -
Merge pull request #3437 from rapidsai/branch-0.18
[gpuCI] Auto-merge branch-0.18 to branch-0.19 [skip ci]
Configuration menu - View commit details
-
Copy full SHA for 9aeebf1 - Browse repository at this point
Copy the full SHA 9aeebf1View commit details -
Improve runtime performance of RF to Treelite conversion (#3410)
Speed up prediction time by an additional factor of 4.82 Build Treelite Trees directly to avoid deletion and `CommitModel` call for TreeBuilder (PoC by @canonizer) Avoid use of stdlib queues where the growth of those queues is bounded and can be optimized via indexing into a vector of the appropriate size Authors: - William Hicks (@wphicks) Approvers: - Andy Adinets (@canonizer) - Philip Hyunsu Cho (@hcho3) - John Zedlewski (@JohnZed) URL: #3410
Configuration menu - View commit details
-
Copy full SHA for dfcea4e - Browse repository at this point
Copy the full SHA dfcea4eView commit details -
Merge pull request #3438 from rapidsai/branch-0.18
[gpuCI] Auto-merge branch-0.18 to branch-0.19 [skip ci]
Configuration menu - View commit details
-
Copy full SHA for 45cf131 - Browse repository at this point
Copy the full SHA 45cf131View commit details -
Use stable 1.0.0 version of Treelite (#3394)
The stable 1.0.0 version of Treelite is [virtually identical to the 1.0.0 RC1 version](dmlc/treelite#246). Using `1.0.0rc1|1.0.0` so that the CI doesn't break until rapidsai/integration#210 is merged. Authors: - Philip Hyunsu Cho (@hcho3) Approvers: - AJ Schmidt (@ajschmidt8) URL: #3394
Configuration menu - View commit details
-
Copy full SHA for a22681c - Browse repository at this point
Copy the full SHA a22681cView commit details -
Merge pull request #3439 from rapidsai/branch-0.18
[gpuCI] Auto-merge branch-0.18 to branch-0.19 [skip ci]
Configuration menu - View commit details
-
Copy full SHA for fe3c62a - Browse repository at this point
Copy the full SHA fe3c62aView commit details
Commits on Feb 1, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1f693ab - Browse repository at this point
Copy the full SHA 1f693abView commit details -
Merge pull request #3441 from rapidsai/branch-0.18
[gpuCI] Auto-merge branch-0.18 to branch-0.19 [skip ci]
Configuration menu - View commit details
-
Copy full SHA for f0bcbcd - Browse repository at this point
Copy the full SHA f0bcbcdView commit details -
Batched Silhouette Score (#3362)
closes #3255 Local tests show that batched SilhouetteScore implementation does as well or better than the full SilhouetteScore implementation when chunksize is equal to the number of rows in input matrix. Hence, I have removed the full SilhouetteScore from Cython for now. I have also created #3368 to investigate the improvement of perf using shared memory. The timeline for this is TBD. Authors: - Divye Gala (@divyegala) Approvers: - Corey J. Nolet (@cjnolet) URL: #3362
Configuration menu - View commit details
-
Copy full SHA for fb1c810 - Browse repository at this point
Copy the full SHA fb1c810View commit details -
Merge pull request #3443 from rapidsai/branch-0.18
[gpuCI] Auto-merge branch-0.18 to branch-0.19 [skip ci]
Configuration menu - View commit details
-
Copy full SHA for d37b63a - Browse repository at this point
Copy the full SHA d37b63aView commit details -
Prepare Changelog for Automation (#3442)
This PR prepares the changelog to be automatically updated during releases. Authors: - AJ Schmidt (@ajschmidt8) Approvers: - Dante Gama Dessavre (@dantegd) URL: #3442
Configuration menu - View commit details
-
Copy full SHA for da87257 - Browse repository at this point
Copy the full SHA da87257View commit details -
Allow saving Dask RandomForest models immediately after training (fixes
#3331) (#3388) This attempts to fix #3331. See that issue for a lot more details. Today, `.get_combined_model()` for the Dask RandomForest model objects returns `None` if it's called immediately after training. That pattern is recommended in ["Distributed Model Pickling"](https://docs.rapids.ai/api/cuml/stable/pickling_cuml_models.html#Distributed-Model-Pickling). Without this support, there is not a way to save a Dask RandomForest model using only public methods / attributes on those classes. Per #3331 (comment), this PR proposes populating the internal model object whenever `get_combined_model()` is called. ## Notes for Reviewers * I have not tested this locally. I spent about 3 hours trying to build `cuml` from source following https://github.com/rapidsai/cuml/blob/main/BUILD.md, and was not successful. If there is a containerized setup for developing `cuml`, I'd greatly appreciate it and would be happy to try it out. I've added a unit test for this change, so I hope that will be enough to confirm that this works and that CI will catch any mistakes I've made. Thanks for your time and consideration. Authors: - James Lamb (@jameslamb) - John Zedlewski (@JohnZed) Approvers: - John Zedlewski (@JohnZed) URL: #3388
Configuration menu - View commit details
-
Copy full SHA for df67553 - Browse repository at this point
Copy the full SHA df67553View commit details
Commits on Feb 2, 2021
-
Enable feature sampling for the experimental backend of Random Forest (…
…#3364) Feature sampling was not supported for experimental backend of Random Forest (RF). This PR implements feature sampling without needing any auxiliary memory storage. Thus the `colids` array is also removed. Authors: - Vinay Deshpande (@vinaydes) Approvers: - Thejaswi. N. S (@teju85) - Philip Hyunsu Cho (@hcho3) - John Zedlewski (@JohnZed) URL: #3364
Configuration menu - View commit details
-
Copy full SHA for fa9edbc - Browse repository at this point
Copy the full SHA fa9edbcView commit details -
Improve Python Docs with Default Role (#3445)
This PR sets the default type of "interpolated text" in sphinx to `:py:obj:`. This is very useful for us since we frequently use a single backtick in our python documentation to refer to another python object. Currently, the docstring: ``` `cuml.datasets.make_blobs` ``` Would generate (italicized, variable spaced): ![image](https://user-images.githubusercontent.com/42954918/106529509-dd4c1900-64a7-11eb-9977-49a2594c7c3e.png) This PR changes it to (bold, mono spaced): ![image](https://user-images.githubusercontent.com/42954918/106529282-77f82800-64a7-11eb-86e2-a38e37ccea0d.png) The added benefit here is if the interpolated text is found in the index, it will link to that section. So in the above example, clicking on `cuml.datasets.make_blobs` will take you to the function documentation. Finally, this PR adds a new type of interpolated text role: `:py:` . This should be used for inline python code. For example, the following code: ``` * `cuml.cuml.datasets.make_blobs` for references do objects (functions, classes, modules, etc.) * :py:`import cupy as cp` for inline python code * ``import cupy as cp`` for literal code ``` will generate: ![image](https://user-images.githubusercontent.com/42954918/106530276-3f594e00-64a9-11eb-8edf-569fc9dd829e.png) I also looked for a few examples to replace to help seed usage of these new options. Updating every location would be very time consuming and is best done over time. Authors: - Michael Demoret (@mdemoret-nv) Approvers: - Dante Gama Dessavre (@dantegd) URL: #3445
Configuration menu - View commit details
-
Copy full SHA for 28953ab - Browse repository at this point
Copy the full SHA 28953abView commit details -
This Pull Request adds initial support for multi-node multi-GPU DBSCAN, and fixes the bugs identified in #3094. It works by copying the dataset on all the workers and giving ownership of a subset of points to each one. The workers compute a partial clustering with the knowledge of the relationships between their points and the rest of the dataset, and the partial clusterings are merged to form the final labeling. This merging algorithm is also used to accumulate the results in case a batch-wise approach is used on a worker to limit the memory consumption. The multi-GPU implementation gives great speedups for large datasets, while for small datasets the performance is dominated by the Dask launch overhead, as shown in the figure below: ![mnmg_dbscan_perf](https://user-images.githubusercontent.com/17441062/104958437-55a6da80-59d0-11eb-8a18-fcca0d69c41b.png) Notes: - I have renamed variables in the DBSCAN implementation to match our style conventions (snake case). Sorry for the noise that it adds to this PR. - I refactored some CSR tests to accept multiple test cases instead of hardcoded ones, in order to add corner cases to weak CC. PR #3157 by @cjnolet changed the location of these tests, so I moved those that I had already refactored accordingly. At the moment only the tests that were in `cpp/test/prims/csr.cu` previously have been refactored. I was thinking that the others can be refactored later, I'd like @cjnolet's opinion on this refactoring. - Regarding testing, the MNMG tests are mostly a copy of the single-GPU ones, though I removed a few tests with very small datasets to avoid problems with MNMG (it doesn't really support the edge case where a worker owns 0 sample, as I think it's a fair assumption that MNMG DBSCAN isn't used with such a tiny dataset). - Also regarding tests, I changed the comparison function to account for the fact that border points are ambiguous. It assumes that the labeling of core points is minimal in both our implementation and the reference, so if this assumption changes we will need to update the tests accordingly. If you want to access a pseudo-code description and proof of the new algorithm, feel free to contact me. Tagging people to whom this PR is relevant: @teju85 @tfeher @MatthiasKohl @canonizer Authors: - Louis Sugy (@Nyrio) Approvers: - Tamas Bela Feher (@tfeher) - Corey J. Nolet (@cjnolet) URL: #3382
Configuration menu - View commit details
-
Copy full SHA for 8201a33 - Browse repository at this point
Copy the full SHA 8201a33View commit details -
MNMG KNN consolidation (#3307)
Answers #3197 Currently, MNMG KNN and MNMG KNN Cl&Re use separate code. This PR intends to refactor the code on both the Python and C++ sides to use common code as much as possible. In addition, the functions in the C++ code currently have a very large number of arguments, making them unreadable to newcomers. This PR will work on reducing their number with the use of parameter structures like it's done elsewhere in cuML's codebase. Authors: - Victor Lafargue (@viclafargue) Approvers: - Corey J. Nolet (@cjnolet) - Dante Gama Dessavre (@dantegd) URL: #3307
Configuration menu - View commit details
-
Copy full SHA for fa2371a - Browse repository at this point
Copy the full SHA fa2371aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3c62b1 - Browse repository at this point
Copy the full SHA a3c62b1View commit details
Commits on Feb 3, 2021
-
genetic programming initial structures (#3387)
This PR introduces/proposes some of the basic and core (gpu-friendly!) data structures for implementing gplearn in cuML in order to address the issue #2121 . Tagging all who will be involved in this development: @vinaydes @venkywonka @vimarsh6739. PS: It also contains an experimental register-based stack implementation that will be useful while implementing CUDA-based AST evaluation, which is needed for organizing tournaments. Authors: - Thejaswi. N. S (@teju85) Approvers: - Corey J. Nolet (@cjnolet) URL: #3387
Configuration menu - View commit details
-
Copy full SHA for 9196252 - Browse repository at this point
Copy the full SHA 9196252View commit details -
Relaxing Batched SilhouetteScore Test Constraint (#3452)
Authors: - Divye Gala (@divyegala) Approvers: - John Zedlewski (@JohnZed) URL: #3452
Configuration menu - View commit details
-
Copy full SHA for d5bb758 - Browse repository at this point
Copy the full SHA d5bb758View commit details -
Fix failing sparse NN test in CI by allowing small number of index di…
Configuration menu - View commit details
-
Copy full SHA for d69f08c - Browse repository at this point
Copy the full SHA d69f08cView commit details
Commits on Feb 4, 2021
-
FIL to use L1 cache when input columns don't fit into shared memory (#…
…3370) currently, the new tests take 4s each to run, despite the bare minimum size. We might be able to accelerate FIL for this usecase somwhat (later), so might make sense to merge the slow tests in once they all pass. Authors: - @levsnv Approvers: - Andy Adinets (@canonizer) - John Zedlewski (@JohnZed) URL: #3370
Configuration menu - View commit details
-
Copy full SHA for b90142f - Browse repository at this point
Copy the full SHA b90142fView commit details -
Mark kbinsdiscretizer quantile tests as xfail (#3450)
Mark kbinsdiscretizer quantile tests as xfail to avoid cupy/cupy#4607 Authors: - William Hicks (@wphicks) Approvers: - John Zedlewski (@JohnZed) - Michael Demoret (@mdemoret-nv) URL: #3450
Configuration menu - View commit details
-
Copy full SHA for a01a55d - Browse repository at this point
Copy the full SHA a01a55dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6e6450 - Browse repository at this point
Copy the full SHA b6e6450View commit details -
Exempting thirdparty code from copyright checks (#3453)
This PR will exclude all files from `_thirdparty` from the copyright check, since these files are under different licenses. Authors: - Micka (@lowener) Approvers: - AJ Schmidt (@ajschmidt8) - John Zedlewski (@JohnZed) URL: #3453
Configuration menu - View commit details
-
Copy full SHA for 6844932 - Browse repository at this point
Copy the full SHA 6844932View commit details -
Fix naive bayes inputs (#3448)
Opening a new PR for these changes because I don't seem to be able to have push access to John Z's branch. Authors: - Corey J. Nolet (@cjnolet) - John Zedlewski (@JohnZed) Approvers: - Michael Demoret (@mdemoret-nv) URL: #3448
Configuration menu - View commit details
-
Copy full SHA for 4f47fd0 - Browse repository at this point
Copy the full SHA 4f47fd0View commit details -
In CI, the test_nearest_neighbors tests can take up to 21 min - about 5x longer than any other test. They cover a lot of functionality, so some time is expected, but there is also a lot of redundancy in parameters. This change reduces the combinatorial explosion significantly in tests and removes a number of superfluous "quality" test options we rarely use that add thousands of always-skipped tests. Locally, this reduces test time from 278s to 50s. Hopefully doesn't cause *too* many conflicts with @lowener's other knn test improvements. Authors: - John Zedlewski (@JohnZed) Approvers: - Victor Lafargue (@viclafargue) - Micka (@lowener) - Dante Gama Dessavre (@dantegd) URL: #3411
Configuration menu - View commit details
-
Copy full SHA for bb1f8dd - Browse repository at this point
Copy the full SHA bb1f8ddView commit details -
Fix for default arguments of PCA (#3320)
When using default arguments on PCA I faced an error on the following line `PCA().fit(X).transform(X)`. `transform` was failing because n_components was `None` so I introduced `n_components_` to store the number of components used by the fit function without overwriting the user' `n_components`. I added some tests on this feature too. Authors: - Micka (@lowener) Approvers: - Dante Gama Dessavre (@dantegd) URL: #3320
Configuration menu - View commit details
-
Copy full SHA for 0955096 - Browse repository at this point
Copy the full SHA 0955096View commit details -
FIX Update cupy to >= 7.8 and remove unused build.sh script (#3378)
closes #3366 Also removes an older build.sh script that to my knowledge we don't use anymore cc @beckernick who pointed out we need to bump it due to using cupy.full order parameter Authors: - Dante Gama Dessavre (@dantegd) Approvers: - John Zedlewski (@JohnZed) - Dillon Cullinan (@dillon-cullinan) - AJ Schmidt (@ajschmidt8) URL: #3378
Configuration menu - View commit details
-
Copy full SHA for 39c7262 - Browse repository at this point
Copy the full SHA 39c7262View commit details
Commits on Feb 5, 2021
-
Replacing sklearn functions with cuml in RF MNMG notebook (#3408)
Configuration menu - View commit details
-
Copy full SHA for dec134a - Browse repository at this point
Copy the full SHA dec134aView commit details -
Clean Up
#include
Dependencies (#3402)Closes #3376 This PR moves a few header files around to fix bad dependencies from `include` -> `src`. Moving forward, the only allowed `#include` direction will be: - `src` -> `include` - `src` -> `src_prims` - `src_prims` -> `include` To facilitate this, a few changes needed to be made: 1. Functions for the C-API have been separated into their own `*_api.cpp` file (some were combined with C++ files) 2. `host_buffer`, `device_buffer`, `hostAllocator` and `deviceAllocator` were moved from `src_prims` to `include` 3. `#include <common/cumlHandle.hpp>` has been removed from all C++ files. This PR includes some additional improvements: - Updated the `include_checker.py` script: - Added functionality to check for badly placed `#pragma once` - Added functionality to fix some of the existing warnings - General refactor to support more checks - Fixed all incorrect uses of `#pragma once` - Fixed incorrect uses of `using namespace ...` in header files outside of a namespace - Removed some unnecessary `#include` While this touches a lot of files, the actual number of changes is relatively small. Below is a before/after comparison of the include graphs: **`src/include`:** Before: ![image](https://user-images.githubusercontent.com/42954918/105561661-ab32fe00-5cd4-11eb-8850-bfeaffaba60f.png) After: ![image](https://user-images.githubusercontent.com/42954918/105561673-b4bc6600-5cd4-11eb-8bb7-04be91f902b6.png) **`src/src_prims`:** Before: ![image](https://user-images.githubusercontent.com/42954918/105561616-79ba3280-5cd4-11eb-8a49-1d0c030df7c1.png) After: ![image](https://user-images.githubusercontent.com/42954918/105561633-89397b80-5cd4-11eb-9702-27b2a809834b.png) Authors: - Michael Demoret (@mdemoret-nv) Approvers: - Dante Gama Dessavre (@dantegd) - John Zedlewski (@JohnZed) - Thejaswi. N. S (@teju85) URL: #3402
Configuration menu - View commit details
-
Copy full SHA for d49dd1a - Browse repository at this point
Copy the full SHA d49dd1aView commit details -
Fixing documentation on SimpleImputer (#3447)
This solve partially #3435 by fixing the documentation of `SimpleImputer`. The next step will be to allow usage of lists for this algorithm. Authors: - Micka (@lowener) Approvers: - Michael Demoret (@mdemoret-nv) URL: #3447
Configuration menu - View commit details
-
Copy full SHA for c9c8619 - Browse repository at this point
Copy the full SHA c9c8619View commit details
Commits on Feb 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 58c30b2 - Browse repository at this point
Copy the full SHA 58c30b2View commit details -
Update failing MNMG tests (#3348)
Partially answers #3354. The PR updates some of the failing MNMG tests so that nightly testing finally pass. This PR addresses MNMG RF and MNMG KNN tests failures. Authors: - Victor Lafargue (@viclafargue) Approvers: - John Zedlewski (@JohnZed) URL: #3348
Configuration menu - View commit details
-
Copy full SHA for c1a7447 - Browse repository at this point
Copy the full SHA c1a7447View commit details
Commits on Feb 9, 2021
-
Update call to dask client persist (#3474)
Fixes the current CI issue dask/distributed#4492 Authors: - Dante Gama Dessavre (@dantegd) - Michael Demoret (@mdemoret-nv) Approvers: - John Zedlewski (@JohnZed) - William Hicks (@wphicks) - @jakirkham - Corey J. Nolet (@cjnolet) URL: #3474
Configuration menu - View commit details
-
Copy full SHA for ec462e7 - Browse repository at this point
Copy the full SHA ec462e7View commit details
Commits on Feb 10, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8082f3b - Browse repository at this point
Copy the full SHA 8082f3bView commit details -
Adding warning for IVFPQ (#3472)
Following observations in #3318 Authors: - Victor Lafargue (@viclafargue) Approvers: - John Zedlewski (@JohnZed) URL: #3472
Configuration menu - View commit details
-
Copy full SHA for ae2aeda - Browse repository at this point
Copy the full SHA ae2aedaView commit details -
Minor doc updates for 0.18 (#3475)
Just small readme and api.rst updates for new algos. Authors: - John Zedlewski (@JohnZed) Approvers: - Michael Demoret (@mdemoret-nv) URL: #3475
Configuration menu - View commit details
-
Copy full SHA for f1abbeb - Browse repository at this point
Copy the full SHA f1abbebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 04780be - Browse repository at this point
Copy the full SHA 04780beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b23821 - Browse repository at this point
Copy the full SHA 7b23821View commit details -
Fix illegal memory accesses when NITEMS > 1, and nrows % NITEMS != 0. (…
Configuration menu - View commit details
-
Copy full SHA for 1d486c7 - Browse repository at this point
Copy the full SHA 1d486c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50897aa - Browse repository at this point
Copy the full SHA 50897aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1aac6b2 - Browse repository at this point
Copy the full SHA 1aac6b2View commit details -
Merge branch 'branch-0.19-merge-0.18' of https://github.com/ajschmidt…
…8/cuml into branch-0.19-merge-0.18
Configuration menu - View commit details
-
Copy full SHA for 844a831 - Browse repository at this point
Copy the full SHA 844a831View commit details -
Configuration menu - View commit details
-
Copy full SHA for 676b68f - Browse repository at this point
Copy the full SHA 676b68fView commit details
Commits on Feb 11, 2021
-
Merge pull request #3455 from ajschmidt8/branch-0.19-merge-0.18
Fix forward-merger conflicts in #3444
Configuration menu - View commit details
-
Copy full SHA for 099f103 - Browse repository at this point
Copy the full SHA 099f103View commit details -
Correct import path in docs for experimental preprocessing features (#…
Configuration menu - View commit details
-
Copy full SHA for 3fc458f - Browse repository at this point
Copy the full SHA 3fc458fView commit details -
Merge pull request #3490 from rapidsai/branch-0.18
[gpuCI] Auto-merge branch-0.18 to branch-0.19 [skip ci]
Configuration menu - View commit details
-
Copy full SHA for de69ead - Browse repository at this point
Copy the full SHA de69eadView commit details -
Use cmake --build in build.sh to facilitate switching build tools (#3487
) Use `cmake --build` in build.sh rather than invoking `make` directly. This should not affect existing usage at all but will allow developers to build with e.g. Ninja simply by setting `CUML_EXTRA_CMAKE_ARGS='-GNinja'` when building. Authors: - William Hicks (@wphicks) Approvers: - Dante Gama Dessavre (@dantegd) URL: #3487
Configuration menu - View commit details
-
Copy full SHA for 001b9ed - Browse repository at this point
Copy the full SHA 001b9edView commit details
Commits on Feb 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b88d39b - Browse repository at this point
Copy the full SHA b88d39bView commit details -
Merge pull request #3499 from rapidsai/branch-0.18
[gpuCI] Auto-merge branch-0.18 to branch-0.19 [skip ci]
Configuration menu - View commit details
-
Copy full SHA for 632b938 - Browse repository at this point
Copy the full SHA 632b938View commit details -
List as input for SimpleImputer (#3489)
Partially answers #3435 Authors: - Victor Lafargue (@viclafargue) Approvers: - Micka (@lowener) - Dante Gama Dessavre (@dantegd) URL: #3489
Configuration menu - View commit details
-
Copy full SHA for f457471 - Browse repository at this point
Copy the full SHA f457471View commit details
Commits on Feb 17, 2021
-
Fix forward-merger conflicts in #3502 (#3506)
This PR fixes the conflicts in #3502 Authors: - Dante Gama Dessavre (@dantegd) - Jordan Jacobelli (@Ethyling) - Joseph (@jolorunyomi) Approvers: - AJ Schmidt (@ajschmidt8) URL: #3506
Configuration menu - View commit details
-
Copy full SHA for d5687ea - Browse repository at this point
Copy the full SHA d5687eaView commit details
Commits on Feb 18, 2021
-
Adding CodeCov Info for Dask Tests (#3338)
Closes #3171 This PR adjusts the CI build script to generate code coverage output for the dask tests that are run separately from the rest of the cuML tests. Ideally, the `codecov` CLI will detect this additional output and automatically upload it. Still a WIP. Testing alternative upload methods for Codecov.io. Authors: - Michael Demoret (@mdemoret-nv) - John Zedlewski (@JohnZed) Approvers: - AJ Schmidt (@ajschmidt8) - Dillon Cullinan (@dillon-cullinan) - John Zedlewski (@JohnZed) URL: #3338
Configuration menu - View commit details
-
Copy full SHA for 9845e26 - Browse repository at this point
Copy the full SHA 9845e26View commit details